[GitHub] jihoonson commented on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
jihoonson commented on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425618705 Ah, now I really get it. I thought you want to set a specific date for dropRule. It makes sense. Probably it's

[GitHub] jihoonson edited a comment on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
jihoonson edited a comment on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425618705 Ah, now I really get it. I thought you want to set a specific date for dropRule. Your idea makes sense to

[GitHub] QiuMM edited a comment on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
QiuMM edited a comment on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425617187 @jihoonson I'm not sure why you think people need to update the date? If I just want to keep last 1 day data,

[GitHub] QiuMM edited a comment on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
QiuMM edited a comment on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425617187 @jihoonson I'm not sure why you think people need to update the date? If I just want to keep last 1 day data,

[GitHub] QiuMM commented on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
QiuMM commented on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425617187 @jihoonson I'm not sure why you think people need to update the date? If I just want to keep last 1 day data, then set

[GitHub] QiuMM closed pull request #6342: Add support for Graylog

2018-09-28 Thread GitBox
QiuMM closed pull request #6342: Add support for Graylog URL: https://github.com/apache/incubator-druid/pull/6342 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] QiuMM commented on issue #6342: Add support for Graylog

2018-09-28 Thread GitBox
QiuMM commented on issue #6342: Add support for Graylog URL: https://github.com/apache/incubator-druid/pull/6342#issuecomment-425613386 @gianm Reasonable. I am going to close it. Thanks for your review. BTW, I think this pr's info would be useful if people want to use `Graylog`, they'll

[GitHub] surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r221410555 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java

[GitHub] surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API backwards compatible with 0.12 (#6333) URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r221410391 ## File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java

[GitHub] jihoonson opened a new issue #6401: Missing doc for numMaxThreads configuration

2018-09-28 Thread GitBox
jihoonson opened a new issue #6401: Missing doc for numMaxThreads configuration URL: https://github.com/apache/incubator-druid/issues/6401 `druid.broker.http.numMaxThreads` and `druid.global.http.numMaxThreads` are missing.

[GitHub] clintropolis commented on issue #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
clintropolis commented on issue #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#issuecomment-425601154 Neat idea! I'm just getting started to review, but was wondering if there is any reason for this be a part of the balancer (which is

[GitHub] clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints.

2018-09-28 Thread GitBox
clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints. URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r221375129 ## File path:

[GitHub] clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints.

2018-09-28 Thread GitBox
clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints. URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r221384075 ## File path:

[GitHub] clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints.

2018-09-28 Thread GitBox
clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints. URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r221383521 ## File path:

[GitHub] clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints.

2018-09-28 Thread GitBox
clintropolis commented on a change in pull request #6272: Add suspend|resume|terminate all supervisors endpoints. URL: https://github.com/apache/incubator-druid/pull/6272#discussion_r221407316 ## File path: docs/content/development/extensions-core/kafka-ingestion.md ## @@

[GitHub] clintropolis commented on issue #5787: Adding additional datatypes support for Parquet extension

2018-09-28 Thread GitBox
clintropolis commented on issue #5787: Adding additional datatypes support for Parquet extension URL: https://github.com/apache/incubator-druid/pull/5787#issuecomment-425599467 Hi @sathishsri88, I have a related PR open, #6360, which in addition to introducing an alternate way to

[GitHub] jihoonson closed pull request #6308: overlord check task whether is present before get lock

2018-09-28 Thread GitBox
jihoonson closed pull request #6308: overlord check task whether is present before get lock URL: https://github.com/apache/incubator-druid/pull/6308 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-druid] branch master updated: overlord check task whether is present before get lock (#6308)

2018-09-28 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 63ba7f7 overlord check task

[GitHub] robertervin commented on issue #6330: Fix Empty InDimFilter Failure

2018-09-28 Thread GitBox
robertervin commented on issue #6330: Fix Empty InDimFilter Failure URL: https://github.com/apache/incubator-druid/pull/6330#issuecomment-425595646 @gianm Yep I'll add a test this weekend, thanks This is an automated message

[GitHub] gianm commented on issue #6330: Fix Empty InDimFilter Failure

2018-09-28 Thread GitBox
gianm commented on issue #6330: Fix Empty InDimFilter Failure URL: https://github.com/apache/incubator-druid/pull/6330#issuecomment-425589759 Hi @robertervin, is this patch still interesting to you? Could you please add a test?

[GitHub] gianm commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-09-28 Thread GitBox
gianm commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-425589038 Is this still "Incompatible"?

[GitHub] gianm commented on issue #6327: Druid based on OakIncrementalIndex

2018-09-28 Thread GitBox
gianm commented on issue #6327: Druid based on OakIncrementalIndex URL: https://github.com/apache/incubator-druid/pull/6327#issuecomment-425586851 Hi @sanastas, Does this code run -- and if so how can it be activated? I am thinking we can start helping to review / test by deploying

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221392310 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,101 @@ SELECT * FROM

[GitHub] jihoonson commented on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask

2018-09-28 Thread GitBox
jihoonson commented on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask URL: https://github.com/apache/incubator-druid/pull/6393#issuecomment-425578777 I realized the teamcity failure legit. Fixed it.

[GitHub] jihoonson edited a comment on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask

2018-09-28 Thread GitBox
jihoonson edited a comment on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask URL: https://github.com/apache/incubator-druid/pull/6393#issuecomment-425578777 I realized the teamcity failure is legit. Fixed it.

[GitHub] jihoonson edited a comment on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
jihoonson edited a comment on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425578518 @QiuMM thank you for the explanation. Now I get it. But, I'm afraid that it can introduce another

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221391895 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/SqlBenchmark.java ##

[GitHub] jihoonson commented on issue #5869: Period load rules should include the future by default

2018-09-28 Thread GitBox
jihoonson commented on issue #5869: Period load rules should include the future by default URL: https://github.com/apache/incubator-druid/issues/5869#issuecomment-425578518 @QiuMM thank you for the explanation. Now I got it. But, I'm afraid that it can introduce another issue. The

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221383921 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221383921 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] jihoonson commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-09-28 Thread GitBox
jihoonson commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#issuecomment-425561151 @jaihind213 sorry for the delayed review. The PR

[GitHub] churrodog commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-09-28 Thread GitBox
churrodog commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#issuecomment-425559751 any plan on getting this in? This would be very

[GitHub] niketh commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-09-28 Thread GitBox
niketh commented on issue #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#issuecomment-425559252 @jaihind213 Are you planning to finish this up?

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221368670 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221372783 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221365849 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ## @@ -103,9

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221371431 ## File path: server/src/main/java/org/apache/druid/client/BrokerServerView.java ## @@ -322,4

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221373401 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221350548 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221353193 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221368622 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221365114 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataHolder.java ##

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221372496 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221366851 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221356186 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221367718 ## File path: server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java ## @@ -133,6

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221353249 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221366807 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221372115 ## File path: server/src/main/java/org/apache/druid/server/http/MetadataResource.java ## @@

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221371837 ## File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java ## @@ -36,6

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221371456 ## File path: sql/src/main/java/io/druid/sql/calcite/schema/SystemSchema.java ## @@ -0,0 +1,537

[GitHub] gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221371033 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ## @@ -320,25

[GitHub] gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221370122 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,101 @@ SELECT * FROM

[GitHub] surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
surekhasaharan commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221369753 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221369584 ## File path: docs/content/querying/sql.md ## @@ -481,6 +486,88 @@ SELECT * FROM

[GitHub] gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989)

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221369004 ## File path: docs/content/querying/sql.md ## @@ -519,6 +524,101 @@ SELECT * FROM

[GitHub] leventov commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
leventov commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221367120 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] gianm commented on issue #6400: Optimize data structures in SelectResultValueBuilder

2018-09-28 Thread GitBox
gianm commented on issue #6400: Optimize data structures in SelectResultValueBuilder URL: https://github.com/apache/incubator-druid/pull/6400#issuecomment-425550755 I'm not super familiar with how the pagingIdentifiers work exactly, but I think the idea is they represent cursors into

[GitHub] leventov commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
leventov commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r220495765 ## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ## @@

[GitHub] leventov commented on issue #6400: Optimize data structures in SelectResultValueBuilder

2018-09-28 Thread GitBox
leventov commented on issue #6400: Optimize data structures in SelectResultValueBuilder URL: https://github.com/apache/incubator-druid/pull/6400#issuecomment-425550207 @gianm no, we don't - I was just passing by this code. However still curious about `pagingIdentifiers`

[GitHub] gianm commented on issue #6400: Optimize data structures in SelectResultValueBuilder

2018-09-28 Thread GitBox
gianm commented on issue #6400: Optimize data structures in SelectResultValueBuilder URL: https://github.com/apache/incubator-druid/pull/6400#issuecomment-425548573 @leventov are you using the Select query today? In general it is worse than the Scan query, except in one way - it supports

[GitHub] gianm commented on issue #6302: Add SQL id, request logs, and metrics

2018-09-28 Thread GitBox
gianm commented on issue #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-425539501 What do you think? This is an automated message from the Apache Git

[GitHub] gianm commented on issue #6302: Add SQL id, request logs, and metrics

2018-09-28 Thread GitBox
gianm commented on issue #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-425539467 @gaodayue @jon-wei re: https://github.com/apache/incubator-druid/pull/6302#discussion_r221352359, I am thinking it will be best to

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r221352359 ## File path: server/src/main/java/org/apache/druid/server/log/AbstractFileRequestLogger.java ## @@

[incubator-druid] branch master updated: Add support targetCompactionSizeBytes for compactionTask (#6203)

2018-09-28 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 122caec Add support

[GitHub] jihoonson closed pull request #6203: Add support targetCompactionSizeBytes for compactionTask

2018-09-28 Thread GitBox
jihoonson closed pull request #6203: Add support targetCompactionSizeBytes for compactionTask URL: https://github.com/apache/incubator-druid/pull/6203 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jihoonson commented on issue #6396: Implement MapVirtualColumn.makeDimensionSelector properly

2018-09-28 Thread GitBox
jihoonson commented on issue #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#issuecomment-425522713 @nishantmonu51 thanks. Addressed your comments.

[GitHub] jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221339164 ## File path:

[GitHub] jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221338797 ## File path:

[GitHub] jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221338768 ## File path:

[GitHub] jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221338751 ## File path:

[GitHub] jihoonson commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor

2018-09-28 Thread GitBox
jihoonson commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor URL: https://github.com/apache/incubator-druid/issues/6006#issuecomment-425516823 Hi @frcake, what issue are you seeing exactly? If you mean it takes some time for a

[GitHub] jihoonson commented on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask

2018-09-28 Thread GitBox
jihoonson commented on issue #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask URL: https://github.com/apache/incubator-druid/pull/6393#issuecomment-425514797 @nishantmonu51 can we use reindexing (`IndexTask` + `IngestSegmentFirehose` or

[GitHub] jihoonson commented on a change in pull request #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask

2018-09-28 Thread GitBox
jihoonson commented on a change in pull request #6393: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask URL: https://github.com/apache/incubator-druid/pull/6393#discussion_r221330881 ## File path: docs/content/ingestion/misc-tasks.md

[GitHub] jihoonson commented on issue #6350: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask

2018-09-28 Thread GitBox
jihoonson commented on issue #6350: Remove ConvertSegmentTask, HadoopConverterTask, and ConvertSegmentBackwardsCompatibleTask URL: https://github.com/apache/incubator-druid/issues/6350#issuecomment-425512935 I want to add this to 0.13. if possible because this is an incompatible change

[incubator-druid] branch master updated: Add missing comma (#6399)

2018-09-28 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 6f44e56 Add missing comma (#6399)

[GitHub] fjy commented on issue #6399: Add missing comma

2018-09-28 Thread GitBox
fjy commented on issue #6399: Add missing comma URL: https://github.com/apache/incubator-druid/pull/6399#issuecomment-425483925 @adursun thanks for the fix This is an automated message from the Apache Git Service. To respond

[GitHub] fjy closed pull request #6399: Add missing comma

2018-09-28 Thread GitBox
fjy closed pull request #6399: Add missing comma URL: https://github.com/apache/incubator-druid/pull/6399 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221291652 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221277398 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221276758 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221276758 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274743 ## File path: server/src/test/java/org/apache/druid/server/http/CoordinatorDynamicConfigTest.java ##

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274626 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274451 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274524 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274488 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221274236 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @@

[GitHub] QiuMM commented on issue #6302: Add SQL id, request logs, and metrics

2018-09-28 Thread GitBox
QiuMM commented on issue #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#issuecomment-425421548 @gaodayue maybe you can merge the master branch, it works for me. This is

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228846 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTester.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228815 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228776 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228735 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228691 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228510 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228554 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228486 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228625 ## File path: server/src/main/java/org/apache/druid/server/coordinator/rules/LoadRule.java ## @@

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228590 ## File path: server/src/main/java/org/apache/druid/server/coordinator/rules/BroadcastDistributionRule.java

[GitHub] egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical

2018-09-28 Thread GitBox
egor-ryashin commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221228420 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

  1   2   >