[GitHub] [incubator-druid] blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r286864575 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/

[GitHub] [incubator-druid] blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r286865186 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/

[GitHub] [incubator-druid] blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
blugowski commented on a change in pull request #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#discussion_r286864976 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/

[GitHub] [incubator-druid] blugowski commented on issue #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
blugowski commented on issue #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#issuecomment-495151132 @himanshug, @surekhasaharan thanks for code review! @jihoonson I think it's not related. --

[GitHub] [incubator-druid] Mikulash opened a new issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore

2019-05-23 Thread GitBox
Mikulash opened a new issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore URL: https://github.com/apache/incubator-druid/issues/7736 Druid keep using segment data from segment cache in queries meanwhile it was disabled and kill job was (

[GitHub] [incubator-druid] leventov opened a new issue #7737: Dead code in IndexTask.collectIntervalsAndShardSpecs()

2019-05-23 Thread GitBox
leventov opened a new issue #7737: Dead code in IndexTask.collectIntervalsAndShardSpecs() URL: https://github.com/apache/incubator-druid/issues/7737 `thrownAway` and `unparseable` variables are never updated, the logic that depends on these variables to be positive is dead. @jihoons

[GitHub] [incubator-druid] leventov commented on a change in pull request #4238: Early publishing segments in the middle of data ingestion

2019-05-23 Thread GitBox
leventov commented on a change in pull request #4238: Early publishing segments in the middle of data ingestion URL: https://github.com/apache/incubator-druid/pull/4238#discussion_r286899300 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #5418: More error reporting and stats for ingestion tasks

2019-05-23 Thread GitBox
leventov commented on a change in pull request #5418: More error reporting and stats for ingestion tasks URL: https://github.com/apache/incubator-druid/pull/5418#discussion_r286899660 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java ###

[GitHub] [incubator-druid] leventov commented on a change in pull request #7138: 'core' ORC extension

2019-05-23 Thread GitBox
leventov commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r286900651 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java ## @

[GitHub] [incubator-druid] leventov opened a new pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
leventov opened a new pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738 Mostly cosmetics and unused code, no real bugs here. This is an automated message fro

[GitHub] [incubator-druid] sashidhar commented on issue #7609: Local variable names shouldn't start with capital

2019-05-23 Thread GitBox
sashidhar commented on issue #7609: Local variable names shouldn't start with capital URL: https://github.com/apache/incubator-druid/issues/7609#issuecomment-495244946 How do I create a pull request ? I've made changes in a local branch and unable to commit the local branch to remote. I w

[GitHub] [incubator-druid] leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-23 Thread GitBox
leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495288920 @jihoonson > This sounds like going back to feature-based release instead of time-based one.

[GitHub] [incubator-druid] fjy merged pull request #7734: reorganizing the ToC

2019-05-23 Thread GitBox
fjy merged pull request #7734: reorganizing the ToC URL: https://github.com/apache/incubator-druid/pull/7734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[incubator-druid] branch master updated: reorganizing the ToC (#7734)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 3dec5cd reorganizing the ToC (#7734) 3dec

[GitHub] [incubator-druid] fjy commented on issue #7734: reorganizing the ToC

2019-05-23 Thread GitBox
fjy commented on issue #7734: reorganizing the ToC URL: https://github.com/apache/incubator-druid/pull/7734#issuecomment-495289289 @jihoonson do you mind helping me backport this to 0.15? This is an automated message from the

[incubator-druid] branch toc-fix deleted (was afd80e0)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch toc-fix in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. was afd80e0 reorganizing the ToC The revisions that were on this branch are still contained in other references;

[incubator-druid] branch master updated: Remove LegacyKafkaIndexTaskRunner (#7735)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new eff2be4 Remove LegacyKafkaIndexTaskRunner

[GitHub] [incubator-druid] fjy merged pull request #7735: Remove LegacyKafkaIndexTaskRunner

2019-05-23 Thread GitBox
fjy merged pull request #7735: Remove LegacyKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7735 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-druid] leventov edited a comment on issue #7681: Add checkstyle for "Local variable names shouldn't start with capital"

2019-05-23 Thread GitBox
leventov edited a comment on issue #7681: Add checkstyle for "Local variable names shouldn't start with capital" URL: https://github.com/apache/incubator-druid/pull/7681#issuecomment-495294723 @lml2468 thanks for the contribution! ---

[GitHub] [incubator-druid] leventov closed issue #7609: Local variable names shouldn't start with capital

2019-05-23 Thread GitBox
leventov closed issue #7609: Local variable names shouldn't start with capital URL: https://github.com/apache/incubator-druid/issues/7609 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-druid] leventov merged pull request #7681: Add checkstyle for "Local variable names shouldn't start with capital"

2019-05-23 Thread GitBox
leventov merged pull request #7681: Add checkstyle for "Local variable names shouldn't start with capital" URL: https://github.com/apache/incubator-druid/pull/7681 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] leventov commented on issue #7681: Add checkstyle for "Local variable names shouldn't start with capital"

2019-05-23 Thread GitBox
leventov commented on issue #7681: Add checkstyle for "Local variable names shouldn't start with capital" URL: https://github.com/apache/incubator-druid/pull/7681#issuecomment-495294723 @lml2468 thanks for contribution! This

[incubator-druid] branch master updated: Add checkstyle for "Local variable names shouldn't start with capital" (#7681)

2019-05-23 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 26fad7e Add checkstyle for "Local va

[GitHub] [incubator-druid] leventov commented on issue #7609: Local variable names shouldn't start with capital

2019-05-23 Thread GitBox
leventov commented on issue #7609: Local variable names shouldn't start with capital URL: https://github.com/apache/incubator-druid/issues/7609#issuecomment-495295982 @sashidhar it looks like there is a collision and @lml2468 has already solved this problem. In general, please consult to

[GitHub] [incubator-druid] jihoonson opened a new pull request #7739: [Backport] reorganizing the ToC

2019-05-23 Thread GitBox
jihoonson opened a new pull request #7739: [Backport] reorganizing the ToC URL: https://github.com/apache/incubator-druid/pull/7739 Backport of #7734 to 0.15.0-incubating. This is an automated message from the Apache Git Servi

[GitHub] [incubator-druid] jihoonson commented on issue #7734: reorganizing the ToC

2019-05-23 Thread GitBox
jihoonson commented on issue #7734: reorganizing the ToC URL: https://github.com/apache/incubator-druid/pull/7734#issuecomment-495302516 Sure, raised https://github.com/apache/incubator-druid/pull/7739. This is an automated me

[GitHub] [incubator-druid] leventov commented on a change in pull request #7138: 'core' ORC extension

2019-05-23 Thread GitBox
leventov commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r287044764 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java ## @

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #7628: 0.14.2-incubating release notes

2019-05-23 Thread GitBox
AlexanderSaydakov commented on issue #7628: 0.14.2-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7628#issuecomment-495314738 What is stopping this release? It has been two weeks since release candidate. --

[GitHub] [incubator-druid] fjy commented on issue #7628: 0.14.2-incubating release notes

2019-05-23 Thread GitBox
fjy commented on issue #7628: 0.14.2-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7628#issuecomment-495314956 We still need 2 more +1 votes: https://lists.apache.org/list.html?gene...@incubator.apache.org --

[GitHub] [incubator-druid] fjy merged pull request #7739: [Backport] reorganizing the ToC

2019-05-23 Thread GitBox
fjy merged pull request #7739: [Backport] reorganizing the ToC URL: https://github.com/apache/incubator-druid/pull/7739 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[incubator-druid] branch 0.15.0-incubating updated: reorganizing the ToC (#7734) (#7739)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.15.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.15.0-incubating by this push: new 8bd5170 reorganizin

[GitHub] [incubator-druid] himanshug merged pull request #7717: Adding influxdb emitter as a contrib extension

2019-05-23 Thread GitBox
himanshug merged pull request #7717: Adding influxdb emitter as a contrib extension URL: https://github.com/apache/incubator-druid/pull/7717 This is an automated message from the Apache Git Service. To respond to the message

[incubator-druid] branch master updated: Adding influxdb emitter as a contrib extension (#7717)

2019-05-23 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 6964ac2 Adding influxdb emitter as

[incubator-druid] branch master updated: allow quantiles merge aggregator to also accept doubles (#7718)

2019-05-23 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 23e96d1 allow quantiles merge aggre

[GitHub] [incubator-druid] himanshug closed issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns

2019-05-23 Thread GitBox
himanshug closed issue #7660: Quantiles sketch agg fails on inner query numeric post-agg columns URL: https://github.com/apache/incubator-druid/issues/7660 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-druid] himanshug merged pull request #7718: allow quantiles merge aggregator to also accept doubles

2019-05-23 Thread GitBox
himanshug merged pull request #7718: allow quantiles merge aggregator to also accept doubles URL: https://github.com/apache/incubator-druid/pull/7718 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-druid] jihoonson commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-23 Thread GitBox
jihoonson commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495331651 > Note that I unblocked #7425 only on the condition that people agree with the proposed approach and

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7716: AggregatorUtil should cache parsed expression to avoid memory problem (OOM/FGC) when Expression is used in metricsSpec

2019-05-23 Thread GitBox
himanshug commented on a change in pull request #7716: AggregatorUtil should cache parsed expression to avoid memory problem (OOM/FGC) when Expression is used in metricsSpec URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r287079210 ## File path: processing/src

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7729: SeekableStreamIndexTaskRunner: Lazy init of runner.

2019-05-23 Thread GitBox
himanshug commented on a change in pull request #7729: SeekableStreamIndexTaskRunner: Lazy init of runner. URL: https://github.com/apache/incubator-druid/pull/7729#discussion_r287083036 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableSt

[GitHub] [incubator-druid] himanshug opened a new pull request #7740: use memoized supplier for lazy singleton in SeekableStreamIndexTask.java

2019-05-23 Thread GitBox
himanshug opened a new pull request #7740: use memoized supplier for lazy singleton in SeekableStreamIndexTask.java URL: https://github.com/apache/incubator-druid/pull/7740 https://github.com/apache/incubator-druid/pull/7729#discussion_r286661510 ---

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7729: SeekableStreamIndexTaskRunner: Lazy init of runner.

2019-05-23 Thread GitBox
himanshug commented on a change in pull request #7729: SeekableStreamIndexTaskRunner: Lazy init of runner. URL: https://github.com/apache/incubator-druid/pull/7729#discussion_r287083342 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableSt

[GitHub] [incubator-druid] gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r287071863 ## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateH

[GitHub] [incubator-druid] gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r287071695 ## File path: extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegment

[GitHub] [incubator-druid] gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r287070364 ## File path: extensions-contrib/kafka-eight-simpleConsumer/src/main/java/org/apache/druid/firehose/kafka/Kafka

[GitHub] [incubator-druid] gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r287079179 ## File path: integration-tests/src/main/java/org/apache/druid/testing/clients/CoordinatorResourceTestClient.ja

[GitHub] [incubator-druid] gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-23 Thread GitBox
gianm commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r287071606 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication

[GitHub] [incubator-druid] himanshug commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore

2019-05-23 Thread GitBox
himanshug commented on issue #7736: Druid keep using segment from the segment-cache the one not exists on deep storage anymore URL: https://github.com/apache/incubator-druid/issues/7736#issuecomment-495353746 sounds like expected behavior: it takes time for coordinator to notice removal o

[GitHub] [incubator-druid] surekhasaharan commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-23 Thread GitBox
surekhasaharan commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-495357873 @leventov @jihoonson @gianm thanks for the discussion, I will work on this PR tomorrow and hope

[GitHub] [incubator-druid] a2l007 opened a new issue #7741: Reindexing tasks containing thetaSketches resulting in incorrect sketch values

2019-05-23 Thread GitBox
a2l007 opened a new issue #7741: Reindexing tasks containing thetaSketches resulting in incorrect sketch values URL: https://github.com/apache/incubator-druid/issues/7741 ### Affected Version 0.13.0-incubating ### Description One of our clusters running on 0.13.0 is see

[GitHub] [incubator-druid] jihoonson commented on issue #7741: Reindexing tasks containing thetaSketches resulting in incorrect sketch values

2019-05-23 Thread GitBox
jihoonson commented on issue #7741: Reindexing tasks containing thetaSketches resulting in incorrect sketch values URL: https://github.com/apache/incubator-druid/issues/7741#issuecomment-495364906 I see some differences between two specs in the size of thetaSketch and partitionSpec. The t

[GitHub] [incubator-druid] jihoonson commented on issue #7729: SeekableStreamIndexTaskRunner: Lazy init of runner.

2019-05-23 Thread GitBox
jihoonson commented on issue #7729: SeekableStreamIndexTaskRunner: Lazy init of runner. URL: https://github.com/apache/incubator-druid/pull/7729#issuecomment-495367228 To me, this bug doesn't look critical enough to backport to 0.15.0. -

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator

2019-05-23 Thread GitBox
jon-wei commented on a change in pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator URL: https://github.com/apache/incubator-druid/pull/7685#discussion_r287115003 ## File path: extensions-core/druid-kerberos/src/main/java/org/apache/druid/security/ke

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator

2019-05-23 Thread GitBox
jon-wei commented on a change in pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator URL: https://github.com/apache/incubator-druid/pull/7685#discussion_r287116248 ## File path: extensions-core/druid-kerberos/src/main/java/org/apache/druid/security/ke

[GitHub] [incubator-druid] jon-wei merged pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator

2019-05-23 Thread GitBox
jon-wei merged pull request #7685: Remove unnecessary principal handling in KerberosAuthenticator URL: https://github.com/apache/incubator-druid/pull/7685 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-druid] jon-wei closed issue #7527: druid-kerberos module uses internal Java APIs removed in Java 9 and above

2019-05-23 Thread GitBox
jon-wei closed issue #7527: druid-kerberos module uses internal Java APIs removed in Java 9 and above URL: https://github.com/apache/incubator-druid/issues/7527 This is an automated message from the Apache Git Service. To re

[incubator-druid] branch master updated: Remove unnecessary principal handling in KerberosAuthenticator (#7685)

2019-05-23 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 54b3f36 Remove unnecessary principal h

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7138: 'core' ORC extension

2019-05-23 Thread GitBox
clintropolis commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r287124475 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java #

[incubator-druid] branch clintropolis-patch-1 created (now 3100c61)

2019-05-23 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at 3100c61 [Backport] OrcStructConvert fix This branch includes the following new commits:

[incubator-druid] 01/01: [Backport] OrcStructConvert fix

2019-05-23 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git commit 3100c61f1220f6593d160818719a416e6ca53064 Author: Clint Wylie AuthorDate: Thu May 23 13:40:59 2019

[GitHub] [incubator-druid] clintropolis opened a new pull request #7742: [Backport] OrcStructConvert fix

2019-05-23 Thread GitBox
clintropolis opened a new pull request #7742: [Backport] OrcStructConvert fix URL: https://github.com/apache/incubator-druid/pull/7742 from #7738, this is a performance issue This is an automated message from the Apache Git Se

[GitHub] [incubator-druid] clintropolis opened a new pull request #7743: [Backport] allow quantiles merge aggregator to also accept doubles

2019-05-23 Thread GitBox
clintropolis opened a new pull request #7743: [Backport] allow quantiles merge aggregator to also accept doubles URL: https://github.com/apache/incubator-druid/pull/7743 Backport of #7718 to 0.15.0-incubating. This is an auto

[GitHub] [incubator-druid] vogievetsky commented on issue #7723: Web-console: add resizable split screen layout to tasks and servers views

2019-05-23 Thread GitBox
vogievetsky commented on issue #7723: Web-console: add resizable split screen layout to tasks and servers views URL: https://github.com/apache/incubator-druid/pull/7723#issuecomment-495380923 Could you please make the splitter match the style that it had prior to this PR? ---

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287133661 ## File path: web-console/src/views/load-data-view/load-data-view.tsx #

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287132688 ## File path: web-console/src/components/header-bar/header-bar.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287134431 ## File path: web-console/src/views/load-data-view/load-data-view.tsx #

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287132991 ## File path: web-console/src/console-application.tsx ## @@ -101,6 +10

[GitHub] [incubator-druid] clintropolis opened a new pull request #7744: [Backport] fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs

2019-05-23 Thread GitBox
clintropolis opened a new pull request #7744: [Backport] fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs URL: https://github.com/apache/incubator-druid/pull/7744 Backport of #7731 to 0.15.0-incubating.

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287133909 ## File path: web-console/src/views/load-data-view/load-data-view.tsx #

[GitHub] [incubator-druid] jon-wei opened a new pull request #7745: Remove obsolete isExcluded config from Kerberos authenticator

2019-05-23 Thread GitBox
jon-wei opened a new pull request #7745: Remove obsolete isExcluded config from Kerberos authenticator URL: https://github.com/apache/incubator-druid/pull/7745 `druid.auth.authenticator.kerberos.excludedPaths` is a configuration on the Kerberos authenticator that allowed the user to specif

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7703: Web console: add log tailing to task log view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7703: Web console: add log tailing to task log view URL: https://github.com/apache/incubator-druid/pull/7703#discussion_r287138069 ## File path: web-console/src/components/show-log/show-log.tsx ## @@ -71,12 +74,39 @@ expo

[GitHub] [incubator-druid] jon-wei opened a new pull request #7746: Fix dead code in IndexTask.collectIntervalsAndShardSpecs()

2019-05-23 Thread GitBox
jon-wei opened a new pull request #7746: Fix dead code in IndexTask.collectIntervalsAndShardSpecs() URL: https://github.com/apache/incubator-druid/pull/7746 Fixes #7737 PR #5418 added meters for ingestion row counts, the logs adjusted in this PR referred to the old row ingestion co

[GitHub] [incubator-druid] jihoonson opened a new pull request #7747: Remove keepSegmentGranularity option from compaction

2019-05-23 Thread GitBox
jihoonson opened a new pull request #7747: Remove keepSegmentGranularity option from compaction URL: https://github.com/apache/incubator-druid/pull/7747 `keepSegmentGranularity` option ignores the interval boundary of segments before compaction. This option is not much useful and was depre

[GitHub] [incubator-druid] jihoonson commented on issue #7742: [Backport] OrcStructConverter fix

2019-05-23 Thread GitBox
jihoonson commented on issue #7742: [Backport] OrcStructConverter fix URL: https://github.com/apache/incubator-druid/pull/7742#issuecomment-495405097 Please remove the branch once this PR is merged. This is an automated messag

[incubator-druid] branch master updated: use memoized supplier for lazy singleton in SeekableStreamIndexTask.java (#7740)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new daf20b4 use memoized supplier for lazy si

[GitHub] [incubator-druid] fjy merged pull request #7740: use memoized supplier for lazy singleton in SeekableStreamIndexTask.java

2019-05-23 Thread GitBox
fjy merged pull request #7740: use memoized supplier for lazy singleton in SeekableStreamIndexTask.java URL: https://github.com/apache/incubator-druid/pull/7740 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-druid] fjy merged pull request #7745: Remove obsolete isExcluded config from Kerberos authenticator

2019-05-23 Thread GitBox
fjy merged pull request #7745: Remove obsolete isExcluded config from Kerberos authenticator URL: https://github.com/apache/incubator-druid/pull/7745 This is an automated message from the Apache Git Service. To respond to th

[incubator-druid] branch master updated: Remove obsolete isExcluded config from Kerberos authenticator (#7745)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new ec4d09a Remove obsolete isExcluded config

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287163630 ## File path: web-console/src/views/servers-view/servers-view.tsx #

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287164070 ## File path: web-console/src/views/task-view/tasks-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287164040 ## File path: web-console/src/views/task-view/tasks-view.tsx ##

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287161036 ## File path: web-console/src/views/servers-view/servers-view.tsx #

[GitHub] [incubator-druid] jihoonson commented on issue #7735: Remove LegacyKafkaIndexTaskRunner

2019-05-23 Thread GitBox
jihoonson commented on issue #7735: Remove LegacyKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7735#issuecomment-495419811 @gianm thanks for reminding me. I think I have to do some tests before adding the draft for release notes. I'm especially not sure about what

[GitHub] [incubator-druid] fjy merged pull request #7742: [Backport] OrcStructConverter fix

2019-05-23 Thread GitBox
fjy merged pull request #7742: [Backport] OrcStructConverter fix URL: https://github.com/apache/incubator-druid/pull/7742 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[incubator-druid] branch clintropolis-patch-1 deleted (was 3100c61)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch clintropolis-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. was 3100c61 [Backport] OrcStructConvert fix The revisions that were on this branch are still contai

[incubator-druid] branch 0.15.0-incubating updated: [Backport] OrcStructConvert fix (#7742)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.15.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.15.0-incubating by this push: new 2441394 [Backport]

[GitHub] [incubator-druid] rae89 closed issue #7467: Historical node issue with segments being loaded when running locally.

2019-05-23 Thread GitBox
rae89 closed issue #7467: Historical node issue with segments being loaded when running locally. URL: https://github.com/apache/incubator-druid/issues/7467 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287170320 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -50

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287170132 ## File path: web-console/src/views/load-data-view/load-data-view.tsx #

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287170096 ## File path: web-console/src/views/load-data-view/load-data-view.tsx #

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287170242 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -27

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7705: Web-Console: add go to editor button to tasks and supervisors view URL: https://github.com/apache/incubator-druid/pull/7705#discussion_r287170344 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -50

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287172048 ## File path: web-console/src/views/lookups-view/lookups-view.tsx ## @@ -54,9 +56,11 @@ export i

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups

2019-05-23 Thread GitBox
vogievetsky commented on a change in pull request #7725: Web-Console: add actions icon to lookups URL: https://github.com/apache/incubator-druid/pull/7725#discussion_r287171719 ## File path: web-console/src/dialogs/table-action-dialog/table-action-dialog.scss ## @@ -36,6 +

[GitHub] [incubator-druid] clintropolis merged pull request #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
clintropolis merged pull request #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642 This is an automated message from the Apache Git Service. T

[incubator-druid] branch master updated: Web console - add enable/disable actions for middle manager workers (#7642)

2019-05-23 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new cbdac49 Web console - add enable/disab

[GitHub] [incubator-druid] vogievetsky commented on issue #7642: Web console - add enable/disable actions for middle manager workers

2019-05-23 Thread GitBox
vogievetsky commented on issue #7642: Web console - add enable/disable actions for middle manager workers URL: https://github.com/apache/incubator-druid/pull/7642#issuecomment-495423632 Thank you for updating the web console / typescript parts so promptly to reflect the new spec tests! --

[GitHub] [incubator-druid] clintropolis commented on issue #6214: Add [disable] button to overlord console for remote workers

2019-05-23 Thread GitBox
clintropolis commented on issue #6214: Add [disable] button to overlord console for remote workers URL: https://github.com/apache/incubator-druid/issues/6214#issuecomment-495423914 Resolved by #7642 This is an automated mes

[GitHub] [incubator-druid] clintropolis closed issue #6214: Add [disable] button to overlord console for remote workers

2019-05-23 Thread GitBox
clintropolis closed issue #6214: Add [disable] button to overlord console for remote workers URL: https://github.com/apache/incubator-druid/issues/6214 This is an automated message from the Apache Git Service. To respond to

[incubator-druid] branch 0.15.0-incubating updated: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs (#7731) (#7744)

2019-05-23 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.15.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.15.0-incubating by this push: new 8f4a690 fix Aggrega

[GitHub] [incubator-druid] fjy merged pull request #7744: [Backport] fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs

2019-05-23 Thread GitBox
fjy merged pull request #7744: [Backport] fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs URL: https://github.com/apache/incubator-druid/pull/7744 This is an automated message from the Apa

  1   2   >