[GitHub] [druid] suneet-s commented on pull request #10027: fix query memory leak

2020-06-24 Thread GitBox
suneet-s commented on pull request #10027: URL: https://github.com/apache/druid/pull/10027#issuecomment-648663220 > According to the job log, it seems the test of `DruidCoordinatorTest.testComputeUnderReplicationCountsPerDataSourcePerTierForSegmentsWithBroadcastRule` doesn't pass.

[GitHub] [druid] clintropolis commented on a change in pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
clintropolis commented on a change in pull request #10033: URL: https://github.com/apache/druid/pull/10033#discussion_r444696192 ## File path: core/src/test/java/org/apache/druid/timeline/partition/HashBasedNumberedPartialShardSpecTest.java ## @@ -73,5 +73,21 @@ public void te

[GitHub] [druid] clintropolis commented on a change in pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
clintropolis commented on a change in pull request #10033: URL: https://github.com/apache/druid/pull/10033#discussion_r444696192 ## File path: core/src/test/java/org/apache/druid/timeline/partition/HashBasedNumberedPartialShardSpecTest.java ## @@ -73,5 +73,21 @@ public void te

[GitHub] [druid] chenyuzhi459 commented on pull request #10027: fix query memory leak

2020-06-24 Thread GitBox
chenyuzhi459 commented on pull request #10027: URL: https://github.com/apache/druid/pull/10027#issuecomment-648684719 > Actually, the logs indicate that the failing test is `JettyTest.testNumConnectionsMetricHttp` - this is a known flaky test. I've re-triggered the build so hopefully it wi

[GitHub] [druid] clintropolis commented on a change in pull request #9999: Optimize protobuf parsing for flatten data

2020-06-24 Thread GitBox
clintropolis commented on a change in pull request #: URL: https://github.com/apache/druid/pull/#discussion_r444740588 ## File path: extensions-core/protobuf-extensions/src/test/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParserTest.java ## @@ -177,6 +191

[GitHub] [druid] liran-funaro commented on a change in pull request #9999: Optimize protobuf parsing for flatten data

2020-06-24 Thread GitBox
liran-funaro commented on a change in pull request #: URL: https://github.com/apache/druid/pull/#discussion_r444750976 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/ProtobufParserBenchmark.java ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Sof

[GitHub] [druid] xhl0726 commented on a change in pull request #9999: Optimize protobuf parsing for flatten data

2020-06-24 Thread GitBox
xhl0726 commented on a change in pull request #: URL: https://github.com/apache/druid/pull/#discussion_r444792520 ## File path: extensions-core/protobuf-extensions/src/test/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParserTest.java ## @@ -76,6 +77,19 @@

[GitHub] [druid] xhl0726 commented on a change in pull request #9999: Optimize protobuf parsing for flatten data

2020-06-24 Thread GitBox
xhl0726 commented on a change in pull request #: URL: https://github.com/apache/druid/pull/#discussion_r444796917 ## File path: extensions-core/protobuf-extensions/src/test/java/org/apache/druid/data/input/protobuf/ProtobufInputRowParserTest.java ## @@ -177,6 +191,45 @

[GitHub] [druid] tonytjo commented on issue #6872: druid-0.13.0-incubating | Druid broker and Druid History is failing to start in Docker

2020-06-24 Thread GitBox
tonytjo commented on issue #6872: URL: https://github.com/apache/druid/issues/6872#issuecomment-648742092 Dear @havannavar Sorry for my ignorance. How could I update the druid.zk.service.host config? I'm using helm to deploy druid in kubernetes cluster: https://hub.helm.sh/c

[GitHub] [druid] sjx782392329 commented on issue #9829: Druid start-micro-quickstart, Unrecognized VM option 'ExitOnOutOfMemoryError'

2020-06-24 Thread GitBox
sjx782392329 commented on issue #9829: URL: https://github.com/apache/druid/issues/9829#issuecomment-648785827 I start this service successful, my machine's RAM is so slow. I use nano start, that costs about 3G RAM. thank you very much.

[GitHub] [druid] sjx782392329 closed issue #9829: Druid start-micro-quickstart, Unrecognized VM option 'ExitOnOutOfMemoryError'

2020-06-24 Thread GitBox
sjx782392329 closed issue #9829: URL: https://github.com/apache/druid/issues/9829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [druid] AndyLin0128 opened a new issue #10066: web interface ingesting function module tasks use standard UTC time

2020-06-24 Thread GitBox
AndyLin0128 opened a new issue #10066: URL: https://github.com/apache/druid/issues/10066 Why does the creation time of tasks in Druid management web interface ingesting function module tasks use standard UTC time, because it has been set in the JVM configuration file- Duser.timezone=UTC +8

[GitHub] [druid] morrifeldman commented on a change in pull request #10046: Fix missing temp dir for native single_dim

2020-06-24 Thread GitBox
morrifeldman commented on a change in pull request #10046: URL: https://github.com/apache/druid/pull/10046#discussion_r444986289 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java ## @@ -200,6

[GitHub] [druid] AlexanderSaydakov commented on issue #10042: com.yahoo.sketches.SketchesArgumentException: Incompatible Seed Hashes. 0, -27700

2020-06-24 Thread GitBox
AlexanderSaydakov commented on issue #10042: URL: https://github.com/apache/druid/issues/10042#issuecomment-648994943 Is this fragment of the log from an upgraded node? I doubt that. Version 0.18.0 must depend on Apache datasketches-java 1.2.0-incubating, and therefore class names must beg

[GitHub] [druid] jihoonson commented on issue #10042: com.yahoo.sketches.SketchesArgumentException: Incompatible Seed Hashes. 0, -27700

2020-06-24 Thread GitBox
jihoonson commented on issue #10042: URL: https://github.com/apache/druid/issues/10042#issuecomment-648997614 @AlexanderSaydakov it looks like he ran a query in the middle of rolling upgrade (when there were historials of mixed versions running) and the query failed in a historical of an o

[GitHub] [druid] pjain1 opened a new issue #10068: RandomBalancerStrategy gets stuck into loop

2020-06-24 Thread GitBox
pjain1 opened a new issue #10068: URL: https://github.com/apache/druid/issues/10068 Found while investigating https://github.com/apache/druid/issues/10067. RandomBalancerStrategy gets stuck into loop when the number of replicants is more than the number of nodes. ### Affected Versio

[GitHub] [druid] pjain1 opened a new issue #10067: CostBalancerStrategy over assigns segments to historicals over their max size

2020-06-24 Thread GitBox
pjain1 opened a new issue #10067: URL: https://github.com/apache/druid/issues/10067 ### Affected Version All ### Description Was hitting this issue in production cluster, so tried to reproduce it locally. Setup - I have one empty historical with server size -

[GitHub] [druid] pjain1 opened a new issue #10069: RandomBalancerStrategy does not assign segments if there is only one historical

2020-06-24 Thread GitBox
pjain1 opened a new issue #10069: URL: https://github.com/apache/druid/issues/10069 Found while investigating https://github.com/apache/druid/issues/10067. RandomBalancerStrategy does not assign segments if there is only one historical. ### Affected Version All ### Desc

[GitHub] [druid] pjain1 opened a new pull request #10070: Fix balancer strategy

2020-06-24 Thread GitBox
pjain1 opened a new pull request #10070: URL: https://github.com/apache/druid/pull/10070 Fixes https://github.com/apache/druid/issues/10067, https://github.com/apache/druid/issues/10068 and https://github.com/apache/druid/issues/10069 ### Description Found multiple bugs in ba

[GitHub] [druid] clintropolis merged pull request #10065: Enable query vectorization by default

2020-06-24 Thread GitBox
clintropolis merged pull request #10065: URL: https://github.com/apache/druid/pull/10065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (f80c02d -> 9be5039)

2020-06-24 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f80c02d Fix HyperUniquesAggregatorFactory.estimateCardinality null handling to respect output type (#10063) add

[GitHub] [druid] xvrl opened a new pull request #10071: statsd-emitter: fix dimension names for jvm monitor metrics

2020-06-24 Thread GitBox
xvrl opened a new pull request #10071: URL: https://github.com/apache/druid/pull/10071 the default set of dimensions were incorrect for some of the jvm-level metrics This is an automated message from the Apache Git Service.

[GitHub] [druid] nishantmonu51 commented on a change in pull request #10070: Fix balancer strategy

2020-06-24 Thread GitBox
nishantmonu51 commented on a change in pull request #10070: URL: https://github.com/apache/druid/pull/10070#discussion_r445155089 ## File path: server/src/main/java/org/apache/druid/server/coordinator/RandomBalancerStrategy.java ## @@ -28,20 +28,22 @@ import java.util.Navigab

[GitHub] [druid] leerho commented on issue #10042: com.yahoo.sketches.SketchesArgumentException: Incompatible Seed Hashes. 0, -27700

2020-06-24 Thread GitBox
leerho commented on issue #10042: URL: https://github.com/apache/druid/issues/10042#issuecomment-649071281 The error output "Incompatible Seed Hashes. 0, -27700" means the sketch that is being wrapped has no seed hash (=0) and the aggregator is looking for the default seed (=27700). This

[GitHub] [druid] maytasm commented on a change in pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
maytasm commented on a change in pull request #10033: URL: https://github.com/apache/druid/pull/10033#discussion_r445196039 ## File path: core/src/main/java/org/apache/druid/timeline/partition/ShardSpec.java ## @@ -125,8 +125,13 @@ default short getAtomicUpdateGroupSize() bo

[GitHub] [druid] damnMeddlingKid opened a new issue #10072: Average aggregate does not ignore nulls in numeric column when druid.generic.useDefaultValueForNull=false

2020-06-24 Thread GitBox
damnMeddlingKid opened a new issue #10072: URL: https://github.com/apache/druid/issues/10072 ### Affected Version Tested in version 0.18.1 ### Description While investigating the correctness of druid's null handling by setting `druid.generic.useDefaultValueForNull=false

[GitHub] [druid] damnMeddlingKid opened a new issue #10073: "is null" returns null for row with null instead of true for numeric column with druid.generic.useDefaultValueForNull=false

2020-06-24 Thread GitBox
damnMeddlingKid opened a new issue #10073: URL: https://github.com/apache/druid/issues/10073 ### Affected Version Tested in version 0.18.1 ### Description While investigating the correctness of druid's null handling by setting `druid.generic.useDefaultValueForNull=false

[GitHub] [druid] clintropolis opened a new pull request #10074: update avatica to handle additional character sets over jdbc

2020-06-24 Thread GitBox
clintropolis opened a new pull request #10074: URL: https://github.com/apache/druid/pull/10074 Fixes #10064. ### Description The test added to `DruidAvaticaHandlerTest` fails prior to bumping Avatica dependency version. The test added to `SqlResourceTest` was just for fun, and pa

[GitHub] [druid] maytasm commented on a change in pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
maytasm commented on a change in pull request #10033: URL: https://github.com/apache/druid/pull/10033#discussion_r445218905 ## File path: core/src/main/java/org/apache/druid/timeline/partition/ShardSpec.java ## @@ -125,8 +125,13 @@ default short getAtomicUpdateGroupSize() bo

[GitHub] [druid] surekhasaharan commented on pull request #10010: Remove JODA Time Dependency from Avro Extensions

2020-06-24 Thread GitBox
surekhasaharan commented on pull request #10010: URL: https://github.com/apache/druid/pull/10010#issuecomment-649119090 @belugabehr thank you for your contribution, do you want to remove Joda Time dependency from rest of the project as #8225 is about removing all Joda Time dependencies IMO

[GitHub] [druid] ccaominh commented on pull request #10074: update avatica to handle additional character sets over jdbc

2020-06-24 Thread GitBox
ccaominh commented on pull request #10074: URL: https://github.com/apache/druid/pull/10074#issuecomment-649143249 `CalciteQueryTest.testSelectLimitWrappingAgainAkaIDontReallyQuiteUnderstandCalciteQueryPlanning` failure looks related to change: https://travis-ci.org/github/apache/druid/j

[GitHub] [druid] clintropolis merged pull request #9999: Optimize protobuf parsing for flatten data

2020-06-24 Thread GitBox
clintropolis merged pull request #: URL: https://github.com/apache/druid/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] clintropolis closed issue #9984: Low efficiency in parsing Protobuf and a possible optimization

2020-06-24 Thread GitBox
clintropolis closed issue #9984: URL: https://github.com/apache/druid/issues/9984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[druid] branch master updated (9be5039 -> 1596b3e)

2020-06-24 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 9be5039 Enable query vectorization by default (#10065) add 1596b3e Optimize protobuf parsing for flatten data (

[GitHub] [druid] clintropolis commented on a change in pull request #10060: More prominent instructions on code coverage failure

2020-06-24 Thread GitBox
clintropolis commented on a change in pull request #10060: URL: https://github.com/apache/druid/pull/10060#discussion_r445252568 ## File path: .travis.yml ## @@ -183,7 +183,7 @@ jobs: --log-template "totals-complete" --log-template "errors" -- -

[GitHub] [druid] clintropolis commented on pull request #10071: statsd-emitter: fix dimension names for jvm monitor metrics

2020-06-24 Thread GitBox
clintropolis commented on pull request #10071: URL: https://github.com/apache/druid/pull/10071#issuecomment-649156501 It looks like the dropwizard emitter has this issue too, https://github.com/apache/druid/blob/master/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDi

[GitHub] [druid] clintropolis opened a new pull request #10075: fix dropwizard emitter jvm bufferpoolName metric

2020-06-24 Thread GitBox
clintropolis opened a new pull request #10075: URL: https://github.com/apache/druid/pull/10075 Related to #10071, fixed a few other places using `bufferPoolName` instead of `bufferpoolName` This is an automated message from

[GitHub] [druid] clintropolis commented on pull request #10071: statsd-emitter: fix dimension names for jvm monitor metrics

2020-06-24 Thread GitBox
clintropolis commented on pull request #10071: URL: https://github.com/apache/druid/pull/10071#issuecomment-649183824 >It looks like the dropwizard emitter has this issue too, https://github.com/apache/druid/blob/master/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricD

[GitHub] [druid] clintropolis merged pull request #10071: statsd-emitter: fix dimension names for jvm monitor metrics

2020-06-24 Thread GitBox
clintropolis merged pull request #10071: URL: https://github.com/apache/druid/pull/10071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (1596b3e -> 572cd16)

2020-06-24 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 1596b3e Optimize protobuf parsing for flatten data (#) add 572cd16 fix dimension names for jvm monitor metr

[GitHub] [druid] clintropolis merged pull request #10074: update avatica to handle additional character sets over jdbc

2020-06-24 Thread GitBox
clintropolis merged pull request #10074: URL: https://github.com/apache/druid/pull/10074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [druid] clintropolis closed issue #10064: Druid SQL multi-lingual decoded problem

2020-06-24 Thread GitBox
clintropolis closed issue #10064: URL: https://github.com/apache/druid/issues/10064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (572cd16 -> ec1f443)

2020-06-24 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 572cd16 fix dimension names for jvm monitor metrics (#10071) add ec1f443 update avatica to handle additional ch

[GitHub] [druid] clintropolis commented on issue #10064: Druid SQL multi-lingual decoded problem

2020-06-24 Thread GitBox
clintropolis commented on issue #10064: URL: https://github.com/apache/druid/issues/10064#issuecomment-649184447 Thanks for the report and suggested fix @leedohyun. I've opened #10074 and added a test which appears to show the updated Avatica dependency resolve the issue. ---

[GitHub] [druid] pjain1 commented on a change in pull request #10070: Fix balancer strategy

2020-06-24 Thread GitBox
pjain1 commented on a change in pull request #10070: URL: https://github.com/apache/druid/pull/10070#discussion_r445302030 ## File path: server/src/main/java/org/apache/druid/server/coordinator/RandomBalancerStrategy.java ## @@ -28,20 +28,22 @@ import java.util.NavigableSet;

[GitHub] [druid] jihoonson commented on a change in pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
jihoonson commented on a change in pull request #10033: URL: https://github.com/apache/druid/pull/10033#discussion_r445310128 ## File path: core/src/test/java/org/apache/druid/timeline/partition/HashBasedNumberedPartialShardSpecTest.java ## @@ -73,5 +73,21 @@ public void testJ

[GitHub] [druid] jihoonson commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-24 Thread GitBox
jihoonson commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649222738 ``` 133 F default boolean sharePartitionSpace(PartialShardSpec partialShardSpec) 134 F { 135 F | L | B(0/2)return !partialShardSpec.us

[GitHub] [druid] clintropolis opened a new pull request #10076: Parallel merge combining sequence close yielders

2020-06-24 Thread GitBox
clintropolis opened a new pull request #10076: URL: https://github.com/apache/druid/pull/10076 ### Description #9934 but for `ParallelMergeCombiningSequence`. Also spotted a place where we weren't closing a non-exploding `BatchedResultCursor` so fixes more leaks than I was anticipat

[GitHub] [druid] clintropolis commented on a change in pull request #10076: ensure ParallelMergeCombiningSequence closes it's closeables

2020-06-24 Thread GitBox
clintropolis commented on a change in pull request #10076: URL: https://github.com/apache/druid/pull/10076#discussion_r445326768 ## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ## @@ -1036,11 +1047,13 @@ public boole