[jira] [Created] (HUDI-4864) Fix AWSDmsAvroPayload during delete operations with MOR snapshot query

2022-09-16 Thread Rahil Chertara (Jira)
Rahil Chertara created HUDI-4864: Summary: Fix AWSDmsAvroPayload during delete operations with MOR snapshot query Key: HUDI-4864 URL: https://issues.apache.org/jira/browse/HUDI-4864 Project: Apache Hu

[GitHub] [hudi] parisni commented on pull request #6580: [HUDI-4792] Batch clean files to delete

2022-09-16 Thread GitBox
parisni commented on PR #6580: URL: https://github.com/apache/hudi/pull/6580#issuecomment-1249917468 @nsivabalan I applied your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] rahil-c commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations

2022-09-16 Thread GitBox
rahil-c commented on PR #6688: URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249916684 @yihua Was able to add test which exposed the constructor issue as well as the same `combineAndGetValue` issue that aws customer saw ``` Caused by: java.util.NoSuchElementExceptio

[GitHub] [hudi] tarunguptanit closed issue #6174: Hudi Read Performance : Partition pruning not happening when reading Hudi table

2022-09-16 Thread GitBox
tarunguptanit closed issue #6174: Hudi Read Performance : Partition pruning not happening when reading Hudi table URL: https://github.com/apache/hudi/issues/6174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [hudi] hudi-bot commented on pull request #6580: [HUDI-4792] Batch clean files to delete

2022-09-16 Thread GitBox
hudi-bot commented on PR #6580: URL: https://github.com/apache/hudi/pull/6580#issuecomment-1249906693 ## CI report: * ff98ae0dda69ee611e4814fbae9c8ddc0a93a4f1 UNKNOWN * c292838205bb8eb57c529808c6b6da98635ac17d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] parisni commented on a diff in pull request #6580: [HUDI-4792] Batch clean files to delete

2022-09-16 Thread GitBox
parisni commented on code in PR #6580: URL: https://github.com/apache/hudi/pull/6580#discussion_r973465697 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java: ## @@ -735,6 +735,34 @@ public final Stream getAllFileGroups(String partit

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249889804 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 7300c9eb17c30e11aaeb9cd768b15585536ab5f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #6693: [HUDI-4856] Missing option for HoodieCatalogFactory

2022-09-16 Thread GitBox
hudi-bot commented on PR #6693: URL: https://github.com/apache/hudi/pull/6693#issuecomment-1249869868 ## CI report: * d543dcbb0210ad1e798af374efe7bae79065bbde Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1142

[GitHub] [hudi] hudi-bot commented on pull request #6694: [DO NOT MERGE][HUDI-4855] Add missing table configs for bootstrap in Deltastreamer

2022-09-16 Thread GitBox
hudi-bot commented on PR #6694: URL: https://github.com/apache/hudi/pull/6694#issuecomment-1249869916 ## CI report: * 5a6eed936fc08b943370db12c258ea6e75430912 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1142

[GitHub] [hudi] parisni commented on a diff in pull request #6580: [HUDI-4792] Batch clean files to delete

2022-09-16 Thread GitBox
parisni commented on code in PR #6580: URL: https://github.com/apache/hudi/pull/6580#discussion_r973441831 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java: ## @@ -110,9 +112,15 @@ HoodieCleanerPlan requestClean(Hood

[GitHub] [hudi] parisni commented on a diff in pull request #6580: [HUDI-4792] Batch clean files to delete

2022-09-16 Thread GitBox
parisni commented on code in PR #6580: URL: https://github.com/apache/hudi/pull/6580#discussion_r973439309 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java: ## @@ -110,9 +112,15 @@ HoodieCleanerPlan requestClean(Hood

[GitHub] [hudi] CTTY commented on a diff in pull request #5113: [HUDI-3625] [RFC-60] Optimized storage layout for Cloud Object Stores

2022-09-16 Thread GitBox
CTTY commented on code in PR #5113: URL: https://github.com/apache/hudi/pull/5113#discussion_r973438573 ## rfc/rfc-56/rfc-56.md: ## @@ -0,0 +1,226 @@ + + +# RFC-56: Federated Storage Layer + +## Proposers +- @umehrot2 + +## Approvers +- @vinoth +- @shivnarayan + +## Status + +JI

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6361: [WIP][HUDI-4690][HUDI-4503][Stacked on 6550] Cleaning up Hudi custom Spark `Rule`s

2022-09-16 Thread GitBox
alexeykudinkin commented on code in PR #6361: URL: https://github.com/apache/hudi/pull/6361#discussion_r971019994 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala: ## @@ -65,35 +68,33 @@ object HoodieSparkUtils extends SparkAdapterSupport wi

[GitHub] [hudi] parisni closed pull request #6537: [HUDI-4762] Avoid update metastore schema if only missing column in input

2022-09-16 Thread GitBox
parisni closed pull request #6537: [HUDI-4762] Avoid update metastore schema if only missing column in input URL: https://github.com/apache/hudi/pull/6537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hudi] parisni commented on pull request #6537: [HUDI-4762] Avoid update metastore schema if only missing column in input

2022-09-16 Thread GitBox
parisni commented on PR #6537: URL: https://github.com/apache/hudi/pull/6537#issuecomment-1249828151 Agreed, I will close this On Thu, 2022-09-15 at 22:47 -0700, Shiyan Xu wrote: > @xushiyan commented on this pull request. > > > > > @@ -286,7 +286,11 @@ private boolea

[jira] [Created] (HUDI-4863) Deprecate `hoodie.compaction.payload.class` and re-use hoodie.datasource.write.payload.class

2022-09-16 Thread sivabalan narayanan (Jira)
sivabalan narayanan created HUDI-4863: - Summary: Deprecate `hoodie.compaction.payload.class` and re-use hoodie.datasource.write.payload.class Key: HUDI-4863 URL: https://issues.apache.org/jira/browse/HUDI-4863

[GitHub] [hudi] hudi-bot commented on pull request #6630: [HUDI-4808] Fix HoodieSimpleBucketIndex not consider bucket num in lo…

2022-09-16 Thread GitBox
hudi-bot commented on PR #6630: URL: https://github.com/apache/hudi/pull/6630#issuecomment-1249800719 ## CI report: * 8746849f96d764a6203009df3f856ef564ff0931 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1142

[jira] [Updated] (HUDI-4862) Add an option leverage RDDCustomColumnsSortPartitioner in bulk-insert

2022-09-16 Thread Alexey Kudinkin (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kudinkin updated HUDI-4862: -- Component/s: deltastreamer > Add an option leverage RDDCustomColumnsSortPartitioner in bulk-inse

[jira] [Created] (HUDI-4862) Add an option leverage RDDCustomColumnsSortPartitioner in bulk-insert

2022-09-16 Thread Alexey Kudinkin (Jira)
Alexey Kudinkin created HUDI-4862: - Summary: Add an option leverage RDDCustomColumnsSortPartitioner in bulk-insert Key: HUDI-4862 URL: https://issues.apache.org/jira/browse/HUDI-4862 Project: Apache H

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6516: [HUDI-4729] Fix fq can not be queried in pending compaction when query ro table with spark

2022-09-16 Thread GitBox
alexeykudinkin commented on code in PR #6516: URL: https://github.com/apache/hudi/pull/6516#discussion_r973345568 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java: ## @@ -665,13 +665,25 @@ public final Stream getLatestFileSlicesBef

[jira] [Updated] (HUDI-4861) Relax MERGE INTO restrictions to permit casting of the matching condition

2022-09-16 Thread Alexey Kudinkin (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kudinkin updated HUDI-4861: -- Fix Version/s: 0.12.1 (was: 0.13.0) > Relax MERGE INTO restrictions to pe

[jira] [Created] (HUDI-4861) Relax MERGE INTO restrictions to permit casting of the matching condition

2022-09-16 Thread Alexey Kudinkin (Jira)
Alexey Kudinkin created HUDI-4861: - Summary: Relax MERGE INTO restrictions to permit casting of the matching condition Key: HUDI-4861 URL: https://issues.apache.org/jira/browse/HUDI-4861 Project: Apac

[GitHub] [hudi] alexeykudinkin commented on issue #6626: [SUPPORT] HUDI merge into via spark sql not working

2022-09-16 Thread GitBox
alexeykudinkin commented on issue #6626: URL: https://github.com/apache/hudi/issues/6626#issuecomment-1249744358 Filed HUDI-4861, we can close this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hudi] hudi-bot commented on pull request #6561: [HUDI-4760] Fixing repeated trigger of data file creations w/ clustering

2022-09-16 Thread GitBox
hudi-bot commented on PR #6561: URL: https://github.com/apache/hudi/pull/6561#issuecomment-1249736183 ## CI report: * 7163ee63648dc1e4957e71a73452d652e6ee9235 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1141

[GitHub] [hudi] hudi-bot commented on pull request #6516: [HUDI-4729] Fix fq can not be queried in pending compaction when query ro table with spark

2022-09-16 Thread GitBox
hudi-bot commented on PR #6516: URL: https://github.com/apache/hudi/pull/6516#issuecomment-1249729529 ## CI report: * 52bcb16f2611c4476ede864cadd79a32fb6e94fa Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1141

[jira] [Closed] (HUDI-4851) Fix CSI not supporting InSet operator

2022-09-16 Thread Alexey Kudinkin (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kudinkin closed HUDI-4851. - Resolution: Fixed > Fix CSI not supporting InSet operator > -

[jira] [Resolved] (HUDI-4851) Fix CSI not supporting InSet operator

2022-09-16 Thread Alexey Kudinkin (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kudinkin resolved HUDI-4851. --- > Fix CSI not supporting InSet operator > - > >

[GitHub] [hudi] hudi-bot commented on pull request #6349: [HUDI-4433] Hudi-CLI repair deduplicate not working with non-partitio…

2022-09-16 Thread GitBox
hudi-bot commented on PR #6349: URL: https://github.com/apache/hudi/pull/6349#issuecomment-1249680267 ## CI report: * 0e3df9a761552d5893706084eb60331308a71b42 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1129

[GitHub] [hudi] hudi-bot commented on pull request #6349: [HUDI-4433] Hudi-CLI repair deduplicate not working with non-partitio…

2022-09-16 Thread GitBox
hudi-bot commented on PR #6349: URL: https://github.com/apache/hudi/pull/6349#issuecomment-1249674873 ## CI report: * 0e3df9a761552d5893706084eb60331308a71b42 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1129

[GitHub] [hudi] hudi-bot commented on pull request #6669: [HUDI-4841] Fix BlockLocation array sorting idempotency issue

2022-09-16 Thread GitBox
hudi-bot commented on PR #6669: URL: https://github.com/apache/hudi/pull/6669#issuecomment-1249670410 ## CI report: * c9221a1b17c255166f9562bd850390384f9d0fa2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1141

[jira] [Updated] (HUDI-4193) Fail to compile in osx aarch_64 environment

2022-09-16 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan updated HUDI-4193: -- Fix Version/s: 0.12.1 > Fail to compile in osx aarch_64 environment > --

[jira] [Closed] (HUDI-4193) Fail to compile in osx aarch_64 environment

2022-09-16 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan closed HUDI-4193. - Resolution: Fixed > Fail to compile in osx aarch_64 environment >

[jira] [Updated] (HUDI-4193) Fail to compile in osx aarch_64 environment

2022-09-16 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan updated HUDI-4193: -- Status: Open (was: In Progress) > Fail to compile in osx aarch_64 environment > ---

[GitHub] [hudi] KeltonKarboviak opened a new pull request, #6701: Fix typo in File Sizing docs

2022-09-16 Thread GitBox
KeltonKarboviak opened a new pull request, #6701: URL: https://github.com/apache/hudi/pull/6701 ### Change Logs Fixes typo in docs ### Impact N/A **Risk level: none** ### Contributor's checklist - [x] Read through [contributor's guide](https://hu

[GitHub] [hudi] rahil-c commented on a diff in pull request #6684: [DOCS] Add Documentation for running unit tests/debugger with spark3

2022-09-16 Thread GitBox
rahil-c commented on code in PR #6684: URL: https://github.com/apache/hudi/pull/6684#discussion_r973264735 ## website/contribute/developer-setup.md: ## @@ -275,6 +275,18 @@ Discussion about contributing code to Hudi happens on the [dev@ mailing list](/c This Quick Video will

[GitHub] [hudi] rahil-c commented on a diff in pull request #6684: [DOCS] Add Documentation for running unit tests/debugger with spark3

2022-09-16 Thread GitBox
rahil-c commented on code in PR #6684: URL: https://github.com/apache/hudi/pull/6684#discussion_r973242929 ## website/contribute/developer-setup.md: ## @@ -275,6 +275,18 @@ Discussion about contributing code to Hudi happens on the [dev@ mailing list](/c This Quick Video will

[GitHub] [hudi] rahil-c commented on a diff in pull request #6489: [HUDI-4485] [cli] Bumped spring shell to 2.1.1. Updated the default …

2022-09-16 Thread GitBox
rahil-c commented on code in PR #6489: URL: https://github.com/apache/hudi/pull/6489#discussion_r973239535 ## hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java: ## @@ -86,7 +87,7 @@ */ public class SparkMain { - private static final Logger LOG = Logger.get

[GitHub] [hudi] hudi-bot commented on pull request #6672: [HUDI-4757] Create pyspark examples

2022-09-16 Thread GitBox
hudi-bot commented on PR #6672: URL: https://github.com/apache/hudi/pull/6672#issuecomment-1249600106 ## CI report: * 25fad9af64012f22e0bb00d1a454026de0902f92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1136

[GitHub] [hudi] hudi-bot commented on pull request #6672: [HUDI-4757] Create pyspark examples

2022-09-16 Thread GitBox
hudi-bot commented on PR #6672: URL: https://github.com/apache/hudi/pull/6672#issuecomment-1249595330 ## CI report: * 25fad9af64012f22e0bb00d1a454026de0902f92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1136

[GitHub] [hudi] hudi-bot commented on pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
hudi-bot commented on PR #4676: URL: https://github.com/apache/hudi/pull/4676#issuecomment-1249593450 ## CI report: * 5944f5cbe9ce73fe6b7e27a0d381eaeb80dead38 UNKNOWN * 4ef7b451c3dd795906f3f68571256baeb330a59f UNKNOWN * 6aeb3d0d8f09aeab2a5766cf9d25ecb30537 UNKNOWN * e3

[GitHub] [hudi] hudi-bot commented on pull request #6672: [HUDI-4757] Create pyspark examples

2022-09-16 Thread GitBox
hudi-bot commented on PR #6672: URL: https://github.com/apache/hudi/pull/6672#issuecomment-1249590783 ## CI report: * 25fad9af64012f22e0bb00d1a454026de0902f92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1136

[GitHub] [hudi] hudi-bot commented on pull request #6079: [HUDI-3287] Remove hudi-spark dependencies from hudi-kafka-connect-bundle

2022-09-16 Thread GitBox
hudi-bot commented on PR #6079: URL: https://github.com/apache/hudi/pull/6079#issuecomment-1249589782 ## CI report: * a77b30d0c5576b6a1e364fe15d473ca0e9310847 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1141

[GitHub] [hudi] yihua commented on pull request #6700: [HUDI-4851] Handle UTF8String when match InSet for dataskipping

2022-09-16 Thread GitBox
yihua commented on PR #6700: URL: https://github.com/apache/hudi/pull/6700#issuecomment-1249553496 @alexeykudinkin could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] yihua commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations

2022-09-16 Thread GitBox
yihua commented on PR #6688: URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249550520 @rahil-c I'll wait for you to add a test before merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249538850 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249533624 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[jira] [Updated] (HUDI-4760) Clustering results in repeated triggers of clustering execution

2022-09-16 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-4760: - Status: Patch Available (was: In Progress) > Clustering results in repeated triggers of clustering execut

[jira] [Updated] (HUDI-4749) PartitionsForFullCleaning in CleanPlanner is using FileSystemBasedListing

2022-09-16 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-4749: - Status: In Progress (was: Open) > PartitionsForFullCleaning in CleanPlanner is using FileSystemBasedListi

[jira] [Updated] (HUDI-4749) PartitionsForFullCleaning in CleanPlanner is using FileSystemBasedListing

2022-09-16 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-4749: - Status: Open (was: Patch Available) > PartitionsForFullCleaning in CleanPlanner is using FileSystemBasedL

[GitHub] [hudi] codope commented on pull request #6349: [HUDI-4433] Hudi-CLI repair deduplicate not working with non-partitio…

2022-09-16 Thread GitBox
codope commented on PR #6349: URL: https://github.com/apache/hudi/pull/6349#issuecomment-1249516314 @brightwon Can you please rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (HUDI-4860) Presto/Trino Cannot parse partition value '\N' of type 'integer' for partition column

2022-09-16 Thread Sagar Sumit (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Sumit updated HUDI-4860: -- Sprint: 2022/09/19 > Presto/Trino Cannot parse partition value '\N' of type 'integer' for > partition c

[jira] [Created] (HUDI-4860) Presto/Trino Cannot parse partition value '\N' of type 'integer' for partition column

2022-09-16 Thread Sagar Sumit (Jira)
Sagar Sumit created HUDI-4860: - Summary: Presto/Trino Cannot parse partition value '\N' of type 'integer' for partition column Key: HUDI-4860 URL: https://issues.apache.org/jira/browse/HUDI-4860 Project:

[jira] [Updated] (HUDI-4759) Fix website Quick start guide to add validations

2022-09-16 Thread Jonathan Vexler (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Vexler updated HUDI-4759: -- Status: Patch Available (was: In Progress) > Fix website Quick start guide to add validations >

[GitHub] [hudi] xushiyan commented on issue #6696: [SUPPORT][Consistent bucket index]NoClassDefFoundError: org/apache/logging/log4j/LogManager

2022-09-16 Thread GitBox
xushiyan commented on issue #6696: URL: https://github.com/apache/hudi/issues/6696#issuecomment-1249505357 @eric9204 can you share how you ran the spark job with what jars please? so we can try to reproduce -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hudi] xushiyan commented on issue #6686: Apache Hudi Consistency issues with glue and marketplace connector

2022-09-16 Thread GitBox
xushiyan commented on issue #6686: URL: https://github.com/apache/hudi/issues/6686#issuecomment-1249499536 @asankadarshana007 have you filed aws support case? this is aws-managed env and app. Not sure why you have to set 'hoodie.consistency.check.enabled': 'true'. this is not needed as s3 h

[GitHub] [hudi] gtwuser commented on issue #6463: [SUPPORT]Caused by: java.lang.IllegalArgumentException at org.apache.hudi.common.util.ValidationUtils.checkArgument(ValidationUtils.java:31)

2022-09-16 Thread GitBox
gtwuser commented on issue #6463: URL: https://github.com/apache/hudi/issues/6463#issuecomment-1249488123 I will be trying it soon, got busy in other tasks and update you back, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hudi] gtwuser commented on issue #6463: [SUPPORT]Caused by: java.lang.IllegalArgumentException at org.apache.hudi.common.util.ValidationUtils.checkArgument(ValidationUtils.java:31)

2022-09-16 Thread GitBox
gtwuser commented on issue #6463: URL: https://github.com/apache/hudi/issues/6463#issuecomment-1249487584 Thanks for sharing this info, please correct me here, but AFAIU in case when we are writing in a multi-threaded environment, we should(mandatorily) use locks you shared right ? And that

[GitHub] [hudi] hudi-bot commented on pull request #6700: [HUDI-4851] Handle UTF8String when match InSet for dataskipping

2022-09-16 Thread GitBox
hudi-bot commented on PR #6700: URL: https://github.com/apache/hudi/pull/6700#issuecomment-1249465021 ## CI report: * fbbe63e493acf95b9d74f1a1bc9133646cd64812 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1143

[GitHub] [hudi] hudi-bot commented on pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
hudi-bot commented on PR #4676: URL: https://github.com/apache/hudi/pull/4676#issuecomment-1249462580 ## CI report: * 5944f5cbe9ce73fe6b7e27a0d381eaeb80dead38 UNKNOWN * 4ef7b451c3dd795906f3f68571256baeb330a59f UNKNOWN * 6aeb3d0d8f09aeab2a5766cf9d25ecb30537 UNKNOWN * e3

[GitHub] [hudi] hudi-bot commented on pull request #6700: [HUDI-4851] Handle UTF8String when match InSet for dataskipping

2022-09-16 Thread GitBox
hudi-bot commented on PR #6700: URL: https://github.com/apache/hudi/pull/6700#issuecomment-1249458968 ## CI report: * fbbe63e493acf95b9d74f1a1bc9133646cd64812 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
hudi-bot commented on PR #4676: URL: https://github.com/apache/hudi/pull/4676#issuecomment-1249456348 ## CI report: * 5944f5cbe9ce73fe6b7e27a0d381eaeb80dead38 UNKNOWN * 4ef7b451c3dd795906f3f68571256baeb330a59f UNKNOWN * 6aeb3d0d8f09aeab2a5766cf9d25ecb30537 UNKNOWN * e3

[GitHub] [hudi] xushiyan opened a new pull request, #6700: [HUDI-4851] Handle UTF8String when match InSet for dataskipping

2022-09-16 Thread GitBox
xushiyan opened a new pull request, #6700: URL: https://github.com/apache/hudi/pull/6700 ### Change Logs Handle UTF8String case when InSet ### Impact **Risk level: none** ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apac

[GitHub] [hudi] xushiyan commented on pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-16 Thread GitBox
xushiyan commented on PR #6662: URL: https://github.com/apache/hudi/pull/6662#issuecomment-1249388775 cc @fengjian428 does this solve your problem with [HUDI-4538](https://issues.apache.org/jira/browse/HUDI-4538)? PTAL -- This is an automated message from the Apache Git Service. To respon

[GitHub] [hudi] xushiyan closed pull request #6303: [HUDI-4538] fall back to full path scan if last commit time synced i…

2022-09-16 Thread GitBox
xushiyan closed pull request #6303: [HUDI-4538] fall back to full path scan if last commit time synced i… URL: https://github.com/apache/hudi/pull/6303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hudi] xushiyan commented on pull request #6303: [HUDI-4538] fall back to full path scan if last commit time synced i…

2022-09-16 Thread GitBox
xushiyan commented on PR #6303: URL: https://github.com/apache/hudi/pull/6303#issuecomment-1249386930 @fengjian428 closing this in favor of https://github.com/apache/hudi/pull/6662 which could solve the problem in [HUDI-4538](https://issues.apache.org/jira/browse/HUDI-4538). please review t

[GitHub] [hudi] fengjian428 commented on a diff in pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
fengjian428 commented on code in PR #4676: URL: https://github.com/apache/hudi/pull/4676#discussion_r973032219 ## hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteNonDefaultsWithLatestAvroPayload.java: ## @@ -58,19 +58,32 @@ public Option combineAndGetUpdateValue

[GitHub] [hudi] xushiyan commented on pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-16 Thread GitBox
xushiyan commented on PR #6662: URL: https://github.com/apache/hudi/pull/6662#issuecomment-1249370360 cc @liujinhui1994 does this solve your problem with [HUDI-4451](https://issues.apache.org/jira/browse/HUDI-4451) ? PTAL -- This is an automated message from the Apache Git Service. To res

[GitHub] [hudi] hudi-bot commented on pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
hudi-bot commented on PR #4676: URL: https://github.com/apache/hudi/pull/4676#issuecomment-1249369178 ## CI report: * 5944f5cbe9ce73fe6b7e27a0d381eaeb80dead38 UNKNOWN * 4ef7b451c3dd795906f3f68571256baeb330a59f UNKNOWN * 6aeb3d0d8f09aeab2a5766cf9d25ecb30537 UNKNOWN * e3

[GitHub] [hudi] xushiyan closed pull request #6187: [HUDI-4451] Multiple writer using loses some hive partitions

2022-09-16 Thread GitBox
xushiyan closed pull request #6187: [HUDI-4451] Multiple writer using loses some hive partitions URL: https://github.com/apache/hudi/pull/6187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hudi] xushiyan commented on pull request #6187: [HUDI-4451] Multiple writer using loses some hive partitions

2022-09-16 Thread GitBox
xushiyan commented on PR #6187: URL: https://github.com/apache/hudi/pull/6187#issuecomment-1249368542 @liujinhui1994 https://github.com/apache/hudi/pull/6662 should cover this patch. closing this. please review the PR too, see if it solves your problem. thanks. -- This is an automated me

[GitHub] [hudi] hudi-bot commented on pull request #6358: [HUDI-4588][HUDI-4472] Fixing `HoodieParquetReader` to properly specify projected schema when reading Parquet file

2022-09-16 Thread GitBox
hudi-bot commented on PR #6358: URL: https://github.com/apache/hudi/pull/6358#issuecomment-1249364205 ## CI report: * 288d166c49602a4593b1e97763a467811903737d UNKNOWN * a0ebc2afda58895b220ef520d58cf2187a4edd1b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[jira] [Commented] (HUDI-4859) Adding a blog on how to run Hudi on Serverless Platforms (AWS Glue)

2022-09-16 Thread Angel Conde (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605810#comment-17605810 ] Angel Conde commented on HUDI-4859: Started to work on this. > Adding a blog on how

[jira] [Updated] (HUDI-4859) Adding a blog on how to run Hudi on Serverless Platforms (AWS Glue)

2022-09-16 Thread Angel Conde (Jira)
[ https://issues.apache.org/jira/browse/HUDI-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angel Conde updated HUDI-4859: --- Status: In Progress (was: Open) > Adding a blog on how to run Hudi on Serverless Platforms (AWS Glue)

[jira] [Created] (HUDI-4859) Adding a blog on how to run Hudi on Serverless Platforms (AWS Glue)

2022-09-16 Thread Angel Conde (Jira)
Angel Conde created HUDI-4859: -- Summary: Adding a blog on how to run Hudi on Serverless Platforms (AWS Glue) Key: HUDI-4859 URL: https://issues.apache.org/jira/browse/HUDI-4859 Project: Apache Hudi

[GitHub] [hudi] pintusoliya opened a new pull request, #6699: [DO NOT MERGE] feat: landing page redesign

2022-09-16 Thread GitBox
pintusoliya opened a new pull request, #6699: URL: https://github.com/apache/hudi/pull/6699 ### Change Logs _Describe context and summary for this change. Highlight if any code was copied._ ### Impact _Describe any public API or user-facing feature change or any performa

[GitHub] [hudi] codope commented on a diff in pull request #6516: [HUDI-4729] Fix fq can not be queried in pending compaction when query ro table with spark

2022-09-16 Thread GitBox
codope commented on code in PR #6516: URL: https://github.com/apache/hudi/pull/6516#discussion_r972973080 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java: ## @@ -665,13 +665,25 @@ public final Stream getLatestFileSlicesBeforeOrOn(

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249297603 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249292500 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #3985: [HUDI-2754] Performance improvement for IncrementalRelation

2022-09-16 Thread GitBox
hudi-bot commented on PR #3985: URL: https://github.com/apache/hudi/pull/3985#issuecomment-1249290985 ## CI report: * ccd1d89352a2f72feb381962718cc0c80920c041 UNKNOWN * 6eaade5cab40d7eed0d67f06c820628c97b47528 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #6670: [HUDI-4842] Support compression strategy based on delte file length

2022-09-16 Thread GitBox
hudi-bot commented on PR #6670: URL: https://github.com/apache/hudi/pull/6670#issuecomment-1249287949 ## CI report: * 9d0a67996db91ad90808ddb83aa281ad04e91a76 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] hudi-bot commented on pull request #6358: [HUDI-4588][HUDI-4472] Fixing `HoodieParquetReader` to properly specify projected schema when reading Parquet file

2022-09-16 Thread GitBox
hudi-bot commented on PR #6358: URL: https://github.com/apache/hudi/pull/6358#issuecomment-1249287346 ## CI report: * 288d166c49602a4593b1e97763a467811903737d UNKNOWN * 0f8adc10d644da86c1b070d4cdecfb28cd016e79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] boneanxs commented on a diff in pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
boneanxs commented on code in PR #6046: URL: https://github.com/apache/hudi/pull/6046#discussion_r972929585 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -160,9 +160,6 @@ class BaseFileOnlyRelation(sqlContext: SQLCont

[GitHub] [hudi] boneanxs commented on a diff in pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
boneanxs commented on code in PR #6046: URL: https://github.com/apache/hudi/pull/6046#discussion_r972820986 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -160,9 +160,6 @@ class BaseFileOnlyRelation(sqlContext: SQLCont

[GitHub] [hudi] hudi-bot commented on pull request #6697: [HUDI-3478] Spark CDC Write

2022-09-16 Thread GitBox
hudi-bot commented on PR #6697: URL: https://github.com/apache/hudi/pull/6697#issuecomment-1249236406 ## CI report: * 60b5ed8092b288f8ef11887ca5e438ebf60669b8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1142

[GitHub] [hudi] hudi-bot commented on pull request #6677: [HUDI-4294][Stacked on 4293] Introduce build action to actually perform index data generation

2022-09-16 Thread GitBox
hudi-bot commented on PR #6677: URL: https://github.com/apache/hudi/pull/6677#issuecomment-1249236335 ## CI report: * 5e4be0aff69d72a934a6b3e7f31a5be41d7d9ead Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249235392 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #5933: [HUDI-4293] Implement Create/Drop/Show/Refresh Index Command for Secondary Index

2022-09-16 Thread GitBox
hudi-bot commented on PR #5933: URL: https://github.com/apache/hudi/pull/5933#issuecomment-1249235283 ## CI report: * 7e66a3b8fb65f6e0a73c4f10c74d80034d0e888d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] hudi-bot commented on pull request #6697: [HUDI-3478] Spark CDC Write

2022-09-16 Thread GitBox
hudi-bot commented on PR #6697: URL: https://github.com/apache/hudi/pull/6697#issuecomment-1249231602 ## CI report: * 60b5ed8092b288f8ef11887ca5e438ebf60669b8 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] koochiswathiTR commented on issue #6606: Observing data duplication with Single Writer

2022-09-16 Thread GitBox
koochiswathiTR commented on issue #6606: URL: https://github.com/apache/hudi/issues/6606#issuecomment-1249231599 with Locking mechanism we expect only one writer writes at a time by acquiring lock. and other writer waits for the lock. There should not be any concurrent writers. We do

[GitHub] [hudi] hudi-bot commented on pull request #6677: [HUDI-4294][Stacked on 4293] Introduce build action to actually perform index data generation

2022-09-16 Thread GitBox
hudi-bot commented on PR #6677: URL: https://github.com/apache/hudi/pull/6677#issuecomment-1249231526 ## CI report: * 5e4be0aff69d72a934a6b3e7f31a5be41d7d9ead Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] danny0405 commented on a diff in pull request #4676: [HUDI-3304] Support partial update payload

2022-09-16 Thread GitBox
danny0405 commented on code in PR #4676: URL: https://github.com/apache/hudi/pull/4676#discussion_r972909463 ## hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteNonDefaultsWithLatestAvroPayload.java: ## @@ -58,19 +58,32 @@ public Option combineAndGetUpdateValue(I

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249230524 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #5933: [HUDI-4293] Implement Create/Drop/Show/Refresh Index Command for Secondary Index

2022-09-16 Thread GitBox
hudi-bot commented on PR #5933: URL: https://github.com/apache/hudi/pull/5933#issuecomment-1249230377 ## CI report: * 7e66a3b8fb65f6e0a73c4f10c74d80034d0e888d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] hudi-bot commented on pull request #6489: [HUDI-4485] [cli] Bumped spring shell to 2.1.1. Updated the default …

2022-09-16 Thread GitBox
hudi-bot commented on PR #6489: URL: https://github.com/apache/hudi/pull/6489#issuecomment-1249226465 ## CI report: * 7f4ac87702ec40ed706e7bdf1dd5ce74ce752846 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] hudi-bot commented on pull request #5933: [HUDI-4293] Implement Create/Drop/Show/Refresh Index Command for Secondary Index

2022-09-16 Thread GitBox
hudi-bot commented on PR #5933: URL: https://github.com/apache/hudi/pull/5933#issuecomment-1249225654 ## CI report: * 7e66a3b8fb65f6e0a73c4f10c74d80034d0e888d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1140

[GitHub] [hudi] eric9204 opened a new issue, #6698: [SUPPORT] [Consistent bucket index] NPE SparkConsistentBucketClusteringPlanStrategy buildMergeClusteringGroup

2022-09-16 Thread GitBox
eric9204 opened a new issue, #6698: URL: https://github.com/apache/hudi/issues/6698 **_Tips before filing an issue_** - Have you gone through our [FAQs](https://hudi.apache.org/learn/faq/)? - Join the mailing list to engage in conversations and get faster support at dev-subscr.

[GitHub] [hudi] YannByron opened a new pull request, #6697: [HUDI-3478] Spark CDC Write

2022-09-16 Thread GitBox
YannByron opened a new pull request, #6697: URL: https://github.com/apache/hudi/pull/6697 ### Change Logs This PR is going to support CDC on Spark. The changes are listed: 1. add a new field named `cdcPath` in `HoodieWriteStat` to hold the cdc file. 2. upgrade `HooideMergeHand

[GitHub] [hudi] Zouxxyy commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir

2022-09-16 Thread GitBox
Zouxxyy commented on code in PR #6652: URL: https://github.com/apache/hudi/pull/6652#discussion_r972869009 ## hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java: ## @@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() { EN

[GitHub] [hudi] hudi-bot commented on pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-16 Thread GitBox
hudi-bot commented on PR #6662: URL: https://github.com/apache/hudi/pull/6662#issuecomment-1249168943 ## CI report: * 25f03c88cb4d0d18529746053b9575f0574dcfc0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1138

[GitHub] [hudi] hudi-bot commented on pull request #6046: [HUDI-4363] Support Clustering row writer to improve performance

2022-09-16 Thread GitBox
hudi-bot commented on PR #6046: URL: https://github.com/apache/hudi/pull/6046#issuecomment-1249167991 ## CI report: * 5a16d35ec42bf86e5759ebb155cad40e83aba9f9 UNKNOWN * 60ef51484364c4a7e8a0aa64817e96b4f5a277cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

<    1   2   3   >