[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232205220 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -344,17 +346,18 @@ protected void preCommit(HoodieInstant

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232157917 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -432,6 +468,7 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232196123 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -430,53 +395,212 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232194607 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -557,32 +558,33 @@ private HoodieData

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232193731 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -734,6 +736,7 @@ private void

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232192328 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java: ## @@ -193,121 +190,126 @@ public HoodieData> getRecordsByKeyPrefixes(L

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232181133 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -1620,4 +1620,72 @@ public static String createIndexInitTimestamp(String

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232166856 ## hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java: ## @@ -143,46 +126,33 @@ public List getAllPartitionPaths() throws IOException { *

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232168973 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java: ## @@ -163,16 +160,16 @@ public List getPartitionPathWithPathPrefixes(List

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232166856 ## hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java: ## @@ -143,46 +126,33 @@ public List getAllPartitionPaths() throws IOException { *

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232160434 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java: ## @@ -135,8 +138,13 @@ protected byte[] serializeRecords(List records)

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232157917 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -432,6 +468,7 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232152667 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -408,18 +365,32 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232153798 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -474,14 +511,80 @@ private Pair>

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232152667 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -408,18 +365,32 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232151200 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java: ## @@ -123,6 +124,9 @@ public static HoodieWriteConfig

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1232142078 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java: ## @@ -694,17 +695,80 @@ private Long getTableChecksum() { return

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231913717 ## hudi-client/hudi-client-common/src/test/java/org/apache/hudi/common/testutils/HoodieMetadataTestTable.java: ## @@ -77,7 +79,8 @@ public HoodieCommitMetadata

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231909053 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java: ## @@ -170,6 +171,17 @@ public static HoodieWriteConfig

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231907972 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java: ## @@ -99,7 +90,25 @@ public interface HoodieTableMetadataWriter

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231893906 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -430,53 +395,212 @@ private boolean

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231876855 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -111,18 +111,27 @@ public abstract class

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231876855 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -111,18 +111,27 @@ public abstract class

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1231819563 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -147,84 +156,55 @@ protected

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1227025649 ## hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java: ## @@ -143,46 +126,33 @@ public List getAllPartitionPaths() throws IOException { *

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1226046920 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataLogRecordReader.java: ## @@ -106,10 +107,10 @@ public Map> getRecordsByKeys(List allRecords =

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1213269335 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java: ## @@ -99,7 +90,25 @@ public interface HoodieTableMetadataWriter

[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

codope commented on code in PR #8758: URL: https://github.com/apache/hudi/pull/8758#discussion_r1199078692 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedTableMetadata.java: ## @@ -254,9 +253,9 @@ public void