codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1232205220
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -344,17 +346,18 @@ protected void preCommit(HoodieInstant inflightInstant,
HoodieCommitMetadata met
/**
* Write the HoodieCommitMetadata to metadata table if available.
- * @param table {@link HoodieTable} of interest.
+ *
+ * @param table {@link HoodieTable} of interest.
* @param instantTime instant time of the commit.
- * @param actionType action type of the commit.
- * @param metadata instance of {@link HoodieCommitMetadata}.
+ * @param actionType action type of the commit.
+ * @param metadata instance of {@link HoodieCommitMetadata}.
*/
- protected void writeTableMetadata(HoodieTable table, String instantTime,
String actionType, HoodieCommitMetadata metadata) {
+ protected void writeTableMetadata(HoodieTable table, String instantTime,
String actionType, HoodieCommitMetadata metadata, HoodieData<WriteStatus>
writeStatuses) {
if (table.isTableServiceAction(actionType, instantTime)) {
- tableServiceClient.writeTableMetadata(table, instantTime, actionType,
metadata);
+ tableServiceClient.writeTableMetadata(table, instantTime, actionType,
metadata, writeStatuses);
} else {
context.setJobStatus(this.getClass().getSimpleName(), "Committing to
metadata table: " + config.getTableName());
- table.getMetadataWriter(instantTime).ifPresent(w ->
((HoodieTableMetadataWriter) w).update(metadata, instantTime));
+ table.getMetadataWriter(instantTime).ifPresent(w ->
((HoodieTableMetadataWriter) w).update(metadata, writeStatuses, instantTime));
Review Comment:
We need not refactor in this PR but I think we need a better abstraction
that only encapsulates the key and record location, something like
https://github.com/apache/hudi/pull/7336/files#diff-fde1e56ecf64ce9a748f23f6d9009ff1dd33098c5f795523e3432a645d26803c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
