codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1232194607
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -557,32 +558,33 @@ private HoodieData<HoodieRecord>
readRecordKeysFromBaseFiles(HoodieEngineContext
final String fileId = FSUtils.getFileId(filename);
final String instantTime = FSUtils.getCommitTime(filename);
- HoodieFileReader reader =
HoodieFileReaderFactory.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO).getFileReader(hadoopConf.get(),
dataFilePath);
- Iterator<String> recordKeyIterator = reader.getRecordKeyIterator();
+ try (HoodieFileReader reader =
HoodieFileReaderFactory.getReaderFactory(HoodieRecord.HoodieRecordType.AVRO).getFileReader(hadoopConf.get(),
dataFilePath)) {
Review Comment:
Got you. Thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
