codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1232166856
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -143,46 +126,33 @@ public List<String> getAllPartitionPaths() throws
IOException {
* @param partitionPath The absolute path of the partition to list
*/
@Override
- public FileStatus[] getAllFilesInPartition(Path partitionPath)
- throws IOException {
- if (isMetadataTableEnabled) {
- try {
- return fetchAllFilesInPartition(partitionPath);
- } catch (Exception e) {
- throw new HoodieMetadataException("Failed to retrieve files in
partition " + partitionPath + " from metadata", e);
- }
+ public FileStatus[] getAllFilesInPartition(Path partitionPath) throws
IOException {
+ ValidationUtils.checkArgument(isMetadataTableInitialized);
+ try {
+ return fetchAllFilesInPartition(partitionPath);
+ } catch (Exception e) {
+ throw new HoodieMetadataException("Failed to retrieve files in partition
" + partitionPath + " from metadata", e);
}
-
- FileSystemBackedTableMetadata fileSystemBackedTableMetadata =
Review Comment:
Agree, but this behavior change (not falling back to FS backed metadata)
caused many tests to fail. I'm fully aligned with the change but it could have
been done in a separate PR and checked in before RLI. Now, we're pretty close
to fixing all the tests. But, something to note for all future big
needle-moving PRs. If there is a breaking change then it's even easier to
revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
