[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-27 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r318200332 ## File path: tests/python/unittest/test_operator.py ## @@ -1559,15 +1559,23 @@

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-27 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r318199733 ## File path: src/operator/nn/upsampling.cc ## @@ -58,17 +61,19 @@ static bool U

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-27 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r318198645 ## File path: src/operator/nn/upsampling.cc ## @@ -37,13 +37,16 @@ static bool U

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-27 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317811212 ## File path: 3rdparty/mshadow/mshadow/extension/spatial_upsampling_nearest.h ##

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-26 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317811965 ## File path: src/operator/nn/upsampling-inl.h ## @@ -84,6 +86,21 @@ struct UpSa

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-26 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317811212 ## File path: 3rdparty/mshadow/mshadow/extension/spatial_upsampling_nearest.h ##

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-23 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317295616 ## File path: tests/python/unittest/test_operator.py ## @@ -1599,14 +1607,21 @@

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-23 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317295370 ## File path: src/operator/nn/upsampling-inl.h ## @@ -84,6 +86,23 @@ struct UpSa

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

2019-08-23 Thread GitBox
apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317290135 ## File path: src/operator/nn/upsampling-inl.h ## @@ -48,16 +48,18 @@ enum UpSam