Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]

2025-04-24 Thread via GitHub
roskuttan closed pull request #16212: CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico URL: https://github.com/apache/nuttx/pull/16212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] arch/esp32_partition.c: fix the incorrect boot sequence when switching from Factory to OTA_1 [nuttx]

2025-04-24 Thread via GitHub
nuttxs opened a new pull request, #16260: URL: https://github.com/apache/nuttx/pull/16260 ## Summary arch/esp32_partition.c: There are eight possible sequence arrangements for switching the boot sequence of the three partitions (factory/ota_0/ota_1) through the ota_set_bootseq() and o

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059578589 ## sched/semaphore/sem_wait.c: ## @@ -218,6 +271,16 @@ int nxsem_wait_slow(FAR sem_t *sem) #endif } + /* If this now holds the mutex, set the holder TID and t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059591043 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable va

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059578589 ## sched/semaphore/sem_wait.c: ## @@ -218,6 +271,16 @@ int nxsem_wait_slow(FAR sem_t *sem) #endif } + /* If this now holds the mutex, set the holder TID and t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059569009 ## libs/libc/semaphore/sem_init.c: ## @@ -62,15 +62,15 @@ * / -int nxsem_init(FAR sem

Re: [I] [HELP] disassemble output of xtensa gdb is not understandable [nuttx]

2025-04-24 Thread via GitHub
chirping78 commented on issue #16235: URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2829258858 > [@chirping78](https://github.com/chirping78) , regarding [#16255 (comment)](https://github.com/apache/nuttx/pull/16255#issuecomment-2826294591), can you please share which ESP-I

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
XuNeo commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2829174531 You can try locally `git show | tools/checkpatch.sh -`, then `git status`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: 8832136b69865d54124c9a48d3a87c29ecca152c

2025-04-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new e9517135c Publishing web: 16e1777

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
lupyuen commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2829087353 @TimJTi Could you fix this Python Formatting? Thanks! https://github.com/apache/nuttx/actions/runs/14650017368/job/41125074665?pr=16257#step:5:226 ``` 2025-04-24 23:47:29 [INFO]

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
TimJTi commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2829013114 > @TimJTi please include a basic Documentation/ explaining about this feature and how to use the pythong script to convert the PNG image and use it. Yeah, I said I'd do that. Ito has

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059313697 ## libs/libc/semaphore/sem_init.c: ## @@ -62,15 +62,15 @@ * / -int nxsem_init(FAR sem_t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059164152 ## sched/semaphore/sem_wait.c: ## @@ -71,9 +71,12 @@ int nxsem_wait_slow(FAR sem_t *sem) { - FAR struct tcb_s *rtcb; + FAR struct tcb_s *rtcb = this_task(); Revie

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
acassis commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2828859340 @lupyuen what does it mean by reformat the python file? ``` would reformat /home/runner/work/nuttx/nuttx/nuttx/tools/splashscreen_converter.py Oh no! 💥 💔 💥 1 file would

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
acassis commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2828856740 @TimJTi please include a basic Documentation/ explaining about this feature and how to use the pythong script to convert the PNG image and use it. -- This is an automated message from t

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
acassis commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2059226883 ## drivers/video/Kconfig: ## @@ -56,6 +56,87 @@ config VIDEO_FB_NPOLLWAITERS depends on VIDEO_FB default 2 +config VIDEO_FB_SPLASHSCREEN + bool

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059196216 ## libs/libc/misc/lib_mutex.c: ## @@ -389,22 +249,17 @@ int nxmutex_clocklock(FAR mutex_t *mutex, clockid_t clockid, /* Wait until we get the lock or until the t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059185945 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059178306 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059169103 ## sched/semaphore/sem_trywait.c: ## @@ -74,29 +77,57 @@ int nxsem_trywait_slow(FAR sem_t *sem) /* If the semaphore is available, give it to the requesting task */

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059162378 ## sched/semaphore/sem_wait.c: ## @@ -218,6 +271,16 @@ int nxsem_wait_slow(FAR sem_t *sem) #endif } + /* If this now holds the mutex, set the holder TID and the

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059160520 ## sched/semaphore/sem_wait.c: ## @@ -86,19 +89,62 @@ int nxsem_wait_slow(FAR sem_t *sem) /* Check if the lock is available */ - if (atomic_fetch_sub(NXSEM_COU

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059065297 ## sched/semaphore/sem_trywait.c: ## @@ -74,29 +77,57 @@ int nxsem_trywait_slow(FAR sem_t *sem) /* If the semaphore is available, give it to the requesting task *

[I] [HELP] Use cases for different sleep/delay functions [nuttx]

2025-04-24 Thread via GitHub
stbenn opened a new issue, #16259: URL: https://github.com/apache/nuttx/issues/16259 ### Description I am hoping to get some clarification on when it is appropriate to use each of the sleep/delay functions provided in NuttX. - `up_delay`, `up_udelay` and `up_mdelay` - `nxsig_sle

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
TimJTi commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2828672709 Python sucks - what a HORRID language. Ugh! And, worse, checkpatch.sh reports not problems, but CI reports random cryptic errors that I am struggling to resolve. Whoever devis

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059092838 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059085409 ## sched/semaphore/sem_wait.c: ## @@ -218,6 +271,16 @@ int nxsem_wait_slow(FAR sem_t *sem) #endif } + /* If this now holds the mutex, set the holder TID and t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059067704 ## sched/semaphore/sem_wait.c: ## @@ -110,7 +156,6 @@ int nxsem_wait_slow(FAR sem_t *sem) #ifdef CONFIG_PRIORITY_INHERITANCE uint8_t prioinherit = sem->flags &

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059066634 ## sched/semaphore/sem_wait.c: ## @@ -71,9 +71,12 @@ int nxsem_wait_slow(FAR sem_t *sem) { - FAR struct tcb_s *rtcb; + FAR struct tcb_s *rtcb = this_task(); Rev

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059065297 ## sched/semaphore/sem_trywait.c: ## @@ -74,29 +77,57 @@ int nxsem_trywait_slow(FAR sem_t *sem) /* If the semaphore is available, give it to the requesting task *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059041794 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable valu

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059041052 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count i

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059041723 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count i

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059038702 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count i

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059037996 ## sched/semaphore/sem_recover.c: ## @@ -100,7 +101,39 @@ void nxsem_recover(FAR struct tcb_s *tcb) * place. */ - atomic_fetch_add(NXSEM_COUNT(s

Re: [PR] build(deps): bump h11 from 0.14.0 to 0.16.0 in /Documentation [nuttx]

2025-04-24 Thread via GitHub
nuttxpr commented on PR #16258: URL: https://github.com/apache/nuttx/pull/16258#issuecomment-2828531880 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** meet NuttX requirements. It's a d

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059032291 ## libs/libc/misc/lib_mutex.c: ## @@ -389,22 +249,17 @@ int nxmutex_clocklock(FAR mutex_t *mutex, clockid_t clockid, /* Wait until we get the lock or until the tim

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059027512 ## sched/semaphore/sem_recover.c: ## @@ -86,7 +86,8 @@ void nxsem_recover(FAR struct tcb_s *tcb) if (tcb->task_state == TSTATE_WAIT_SEM) { FAR sem_t *se

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059016085 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable va

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059013892 ## libs/libc/misc/lib_mutex.c: ## @@ -389,22 +249,17 @@ int nxmutex_clocklock(FAR mutex_t *mutex, clockid_t clockid, /* Wait until we get the lock or until the t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059013419 ## include/nuttx/mutex.h: ## @@ -754,6 +571,273 @@ int nxrmutex_restorelock(FAR rmutex_t *rmutex, unsigned int count); #define nxrmutex_setprioceiling(rmutex, prioceil

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059012531 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059012302 ## sched/semaphore/sem_post.c: ## @@ -73,10 +73,12 @@ int nxsem_post_slow(FAR sem_t *sem) { FAR struct tcb_s *stcb = NULL; irqstate_t flags; - int32_t sem_count;

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059011887 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059009780 ## sched/semaphore/sem_destroy.c: ## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + const bool mutex = NXSEM_IS_MUTEX(sem); + FAR atomic_t *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059008335 ## include/nuttx/mutex.h: ## @@ -754,6 +571,273 @@ int nxrmutex_restorelock(FAR rmutex_t *rmutex, unsigned int count); #define nxrmutex_setprioceiling(rmutex, prioce

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059004988 ## sched/semaphore/sem_post.c: ## @@ -73,10 +73,12 @@ int nxsem_post_slow(FAR sem_t *sem) { FAR struct tcb_s *stcb = NULL; irqstate_t flags; - int32_t sem_coun

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059003761 ## sched/semaphore/sem_destroy.c: ## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + const bool mutex = NXSEM_IS_MUTEX(sem); + FAR atomic_t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059002944 ## sched/misc/deadlock.c: ## @@ -100,8 +100,8 @@ static void collect_deadlock(FAR struct tcb_s *tcb, FAR void *arg) pid_t holder; size_t i; - hol

[PR] build(deps): bump h11 from 0.14.0 to 0.16.0 in /Documentation [nuttx]

2025-04-24 Thread via GitHub
dependabot[bot] opened a new pull request, #16258: URL: https://github.com/apache/nuttx/pull/16258 Bumps [h11](https://github.com/python-hyper/h11) from 0.14.0 to 0.16.0. Commits https://github.com/python-hyper/h11/commit/1c5b07581f058886c8bdd87adababd7d959dc7ca";>1c5b075 this

(nuttx) branch dependabot/pip/Documentation/h11-0.16.0 created (now 40968bc645)

2025-04-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/Documentation/h11-0.16.0 in repository https://gitbox.apache.org/repos/asf/nuttx.git at 40968bc645 build(deps): bump h11 from 0.14.0 to 0.16.0 in /Documentation No new

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058999733 ## libs/libc/semaphore/sem_init.c: ## @@ -62,15 +62,15 @@ * / -int nxsem_init(FAR sem

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058998349 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -65,7 +69,23 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { if (sem != NULL && sval != NULL) { - *s

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058996029 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058838555 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058865683 ## include/nuttx/mutex.h: ## @@ -754,6 +571,273 @@ int nxrmutex_restorelock(FAR rmutex_t *rmutex, unsigned int count); #define nxrmutex_setprioceiling(rmutex, prioceil

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058973167 ## sched/semaphore/sem_wait.c: ## @@ -110,7 +156,6 @@ int nxsem_wait_slow(FAR sem_t *sem) #ifdef CONFIG_PRIORITY_INHERITANCE uint8_t prioinherit = sem->flags & S

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058972929 ## sched/semaphore/sem_wait.c: ## @@ -126,11 +171,19 @@ int nxsem_wait_slow(FAR sem_t *sem) rtcb->waitobj = sem; + /* In case of a mutex, store the previ

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058968249 ## sched/semaphore/sem_waitirq.c: ## @@ -72,30 +72,54 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode) { FAR struct tcb_s *rtcb = this_task(); FAR sem_

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058968249 ## sched/semaphore/sem_waitirq.c: ## @@ -72,30 +72,54 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode) { FAR struct tcb_s *rtcb = this_task(); FAR sem_

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058960582 ## sched/semaphore/sem_wait.c: ## @@ -218,6 +271,16 @@ int nxsem_wait_slow(FAR sem_t *sem) #endif } + /* If this now holds the mutex, set the holder TID and the

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058957556 ## sched/semaphore/sem_wait.c: ## @@ -71,9 +71,12 @@ int nxsem_wait_slow(FAR sem_t *sem) { - FAR struct tcb_s *rtcb; + FAR struct tcb_s *rtcb = this_task(); Revie

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
nuttxpr commented on PR #16257: URL: https://github.com/apache/nuttx/pull/16257#issuecomment-2828419635 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does a good job of outlining the changes and th

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058953336 ## sched/semaphore/sem_wait.c: ## @@ -86,19 +89,62 @@ int nxsem_wait_slow(FAR sem_t *sem) /* Check if the lock is available */ - if (atomic_fetch_sub(NXSEM_COUNT

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058950673 ## sched/semaphore/sem_trywait.c: ## @@ -74,29 +77,57 @@ int nxsem_trywait_slow(FAR sem_t *sem) /* If the semaphore is available, give it to the requesting task */

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058937456 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count ind

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058945664 ## sched/semaphore/sem_trywait.c: ## @@ -63,8 +63,11 @@ int nxsem_trywait_slow(FAR sem_t *sem) { irqstate_t flags; - int32_t semcount; - int ret; + int ret = -EA

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058943758 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count ind

[PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-24 Thread via GitHub
TimJTi opened a new pull request, #16257: URL: https://github.com/apache/nuttx/pull/16257 ## Summary This PR adds Kconfig-selected splashscreen options used when the driver is first registered * Includes a new Python script in ./tools to create RLE bitmap files * Includes de

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058937456 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count ind

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058938082 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count ind

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058936809 ## sched/semaphore/sem_reset.c: ## @@ -76,38 +81,63 @@ int nxsem_reset(FAR sem_t *sem, int16_t count) flags = enter_critical_section(); - /* A negative count ind

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058935926 ## sched/semaphore/sem_recover.c: ## @@ -100,7 +101,39 @@ void nxsem_recover(FAR struct tcb_s *tcb) * place. */ - atomic_fetch_add(NXSEM_COUNT(sem

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058921148 ## sched/semaphore/sem_recover.c: ## @@ -86,7 +86,8 @@ void nxsem_recover(FAR struct tcb_s *tcb) if (tcb->task_state == TSTATE_WAIT_SEM) { FAR sem_t *sem

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058918144 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable valu

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058894333 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -65,7 +69,23 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { if (sem != NULL && sval != NULL) { - *sva

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058865683 ## include/nuttx/mutex.h: ## @@ -754,6 +571,273 @@ int nxrmutex_restorelock(FAR rmutex_t *rmutex, unsigned int count); #define nxrmutex_setprioceiling(rmutex, prioceil

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058901926 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable valu

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058901926 ## sched/semaphore/sem_post.c: ## @@ -85,19 +87,54 @@ int nxsem_post_slow(FAR sem_t *sem) flags = enter_critical_section(); - /* Check the maximum allowable valu

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058891202 ## libs/libc/misc/lib_mutex.c: ## @@ -389,22 +249,17 @@ int nxmutex_clocklock(FAR mutex_t *mutex, clockid_t clockid, /* Wait until we get the lock or until the tim

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r205521 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058865683 ## include/nuttx/mutex.h: ## @@ -754,6 +571,273 @@ int nxrmutex_restorelock(FAR rmutex_t *rmutex, unsigned int count); #define nxrmutex_setprioceiling(rmutex, prioceil

Re: [I] [BUG] STM32H7 43zi unstable, USB master, ps command and syslog crashes/hangs [nuttx]

2025-04-24 Thread via GitHub
keever50 commented on issue #16256: URL: https://github.com/apache/nuttx/issues/16256#issuecomment-2828264648 ![Image](https://github.com/user-attachments/assets/1d6c174d-70e6-43e6-ad05-62cd744c5bc9) It also randomly just hangs here. Its completely random. Happens sometimes after a r

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058856591 ## sched/semaphore/sem_post.c: ## @@ -73,10 +73,12 @@ int nxsem_post_slow(FAR sem_t *sem) { FAR struct tcb_s *stcb = NULL; irqstate_t flags; - int32_t sem_count;

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058851774 ## sched/semaphore/sem_destroy.c: ## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + const bool mutex = NXSEM_IS_MUTEX(sem); + FAR atomic_t *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058850944 ## sched/misc/deadlock.c: ## @@ -100,8 +100,8 @@ static void collect_deadlock(FAR struct tcb_s *tcb, FAR void *arg) pid_t holder; size_t i; - holde

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058843256 ## libs/libc/semaphore/sem_init.c: ## @@ -62,15 +62,15 @@ * / -int nxsem_init(FAR sem_t

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058841530 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -65,7 +69,23 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { if (sem != NULL && sval != NULL) { - *sva

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058841530 ## libs/libc/semaphore/sem_getvalue.c: ## @@ -65,7 +69,23 @@ int nxsem_get_value(FAR sem_t *sem, FAR int *sval) { if (sem != NULL && sval != NULL) { - *sva

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058838555 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-24 Thread via GitHub
pussuw commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058830559 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_INI

[I] [BUG] STM32H7 43zi unstable, USB master, ps command and syslog crashes/hangs [nuttx]

2025-04-24 Thread via GitHub
keever50 opened a new issue, #16256: URL: https://github.com/apache/nuttx/issues/16256 ### Description / Steps to reproduce the issue I am using the STMH743ZI nucleo dev board and nuttx with default usb otg fs configuration. **Reproduce USB crash at startup:** I enabled sysl

Re: [I] [HELP] disassemble output of xtensa gdb is not understandable [nuttx]

2025-04-24 Thread via GitHub
tmedicci commented on issue #16235: URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2827603273 @chirping78 , regarding https://github.com/apache/nuttx/pull/16255#issuecomment-2826294591, can you please share which ESP-IDF version you are using? I couldn't reproduce the

Re: [I] [HELP] disassemble output of xtensa gdb is not understandable [nuttx]

2025-04-24 Thread via GitHub
tmedicci commented on issue #16235: URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2827597867 Reopening the issue because the issue is still valid for gdb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

(nuttx) branch master updated (da74a5e368 -> 4a8af202c6)

2025-04-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from da74a5e368 net/tcp/tcp_conn.c: optimize the port conflict detection rules for tcp_listener(). fixed potential conflic

Re: [PR] drivers/ioexpander/icjx: add option to set filters during initialization [nuttx]

2025-04-24 Thread via GitHub
acassis merged PR #16254: URL: https://github.com/apache/nuttx/pull/16254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (4a8af202c6 -> 8832136b69)

2025-04-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4a8af202c6 boards/xtensa/esp32[|s2|s3]: Fix unknown disassembling instructions add 8832136b69 drivers/ioexpander

Re: [I] [HELP] disassemble output of xtensa gdb is not understandable [nuttx]

2025-04-24 Thread via GitHub
acassis closed issue #16235: [HELP] disassemble output of xtensa gdb is not understandable URL: https://github.com/apache/nuttx/issues/16235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] boards/xtensa/esp32[|s2|s3]: Fix unknown disassembling instructions [nuttx]

2025-04-24 Thread via GitHub
acassis merged PR #16255: URL: https://github.com/apache/nuttx/pull/16255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] boards/xtensa/esp32[|s2|s3]: Fix unknown disassembling instructions [nuttx]

2025-04-24 Thread via GitHub
tmedicci commented on PR #16255: URL: https://github.com/apache/nuttx/pull/16255#issuecomment-2827451906 > @tmedicci Your fix points out the right direction. Since the `objdump` is right, find `byte 00` in it's output, it's easy to find out where the disassemble is problematic now. >

  1   2   >