Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
itschrispeck commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558836542 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableIndex.java: ## @@ -60,4 +60,12 @@ public interface MutableIndex extends

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
itschrispeck commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558835084 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java: ## @@ -90,14 +102,17 @@ public static

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
itschrispeck commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558833921 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -181,6 +181,17 @@ private

Re: [I] Upgrade Lucene from 9.8.0 to 9.10.0 [pinot]

2024-04-09 Thread via GitHub
deepthi912 commented on issue #12860: URL: https://github.com/apache/pinot/issues/12860#issuecomment-2046526106 I think failures are due to Lucene95Codec, Lucene95HnswVectorsFormat which are currently not in 9.10.0 version. -- This is an automated message from the Apache Git Service. To

Re: [PR] (WIP ...) Using local copy of segment instead of downloading from remote [pinot]

2024-04-09 Thread via GitHub
codecov-commenter commented on PR #12863: URL: https://github.com/apache/pinot/pull/12863#issuecomment-2046499970 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12863?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish commented on code in PR #12812: URL: https://github.com/apache/pinot/pull/12812#discussion_r1558784988 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java: ## @@ -45,93

[PR] (WIP ...) Using local copy of segment instead of downloading from remote [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish opened a new pull request, #12863: URL: https://github.com/apache/pinot/pull/12863 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5.

Re: [PR] ban easymock library [pinot]

2024-04-09 Thread via GitHub
codecov-commenter commented on PR #12862: URL: https://github.com/apache/pinot/pull/12862#issuecomment-2046460827 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12862?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] ban easymock library [pinot]

2024-04-09 Thread via GitHub
sullis opened a new pull request, #12862: URL: https://github.com/apache/pinot/pull/12862 This project uses Mockito for mock objects. Therefore, we will ban EasyMock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Custom configuration property reader for segment metadata files [pinot]

2024-04-09 Thread via GitHub
abhioncbr commented on PR #12440: URL: https://github.com/apache/pinot/pull/12440#issuecomment-2046294955 @Jackie-Jiang / @klsince, please review it once more. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Support ORC 2.0+ [pinot]

2024-04-09 Thread via GitHub
abhioncbr commented on issue #12858: URL: https://github.com/apache/pinot/issues/12858#issuecomment-2046251639 I will look into it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Upgrade Lucene from 9.8.0 to 9.10.0 [pinot]

2024-04-09 Thread via GitHub
abhioncbr commented on issue #12860: URL: https://github.com/apache/pinot/issues/12860#issuecomment-2046251450 I can take a look. Assign it to me. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Upgrade com.dynatrace.hash4j:hash4j from 0.13.0 to 0.17.0 [pinot]

2024-04-09 Thread via GitHub
abhioncbr commented on issue #12861: URL: https://github.com/apache/pinot/issues/12861#issuecomment-2046250619 Assign it to me please thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish commented on code in PR #12812: URL: https://github.com/apache/pinot/pull/12812#discussion_r1558500972 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java: ## @@ -45,93

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
jackjlli commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046224113 I did test out the cases when forward index is disabled for the realtime table. And here is the exception messages: ``` 2024/04/09 16:31:42.220 INFO

(pinot) branch master updated: Add SchemaConformingTransformerV2 to enhance text search abilities (#12788)

2024-04-09 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 13673f1150 Add SchemaConformingTransformerV2

Re: [PR] Add SchemaConformingTransformerV2 to enhance text search abilities [pinot]

2024-04-09 Thread via GitHub
chenboat merged PR #12788: URL: https://github.com/apache/pinot/pull/12788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046124115 My point is that forward index cannot be disabled for consuming segment anyway, regardless of whether `columnMajorSegmentBuilderEnabled` is enabled or not. Have you tried disabling

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
jackjlli commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046113187 Right, I was about to paste you the same

Re: [PR] remove easymock library [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12859: URL: https://github.com/apache/pinot/pull/12859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on PR #12812: URL: https://github.com/apache/pinot/pull/12812#issuecomment-2046102481 > Thanks Jackie. From the code, it does not look like there are any changes in behavior except that its done in a different way without the executor. Just wanted to confirm.

(pinot) branch master updated (425eea9e80 -> c93de37765)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 425eea9e80 Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.2.0 to 3.6.3 (#12852) add c93de37765 remove

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12812: URL: https://github.com/apache/pinot/pull/12812#discussion_r1558332571 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java: ## @@ -45,93 +40,66 @@

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12812: URL: https://github.com/apache/pinot/pull/12812#discussion_r1558333101 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java: ## @@ -45,93 +40,66 @@

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046098039 I don't think forward index can be disabled for mutable segment (see this

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046090959 What I was asking is when we disable forward index, will the config be picked up for consuming segment? Will the consuming segment only create inverted index, but not forward index?

Re: [PR] Add validation check for forward index disabled when enabling columnar segment creation [pinot]

2024-04-09 Thread via GitHub
jackjlli commented on PR #12838: URL: https://github.com/apache/pinot/pull/12838#issuecomment-2046083662 > Do we allow disabling forward index for consuming segment? Can we add a test to verify if it works? With the change in this current PR no we won't allow disabling forward index

Re: [PR] Enhance Pulsar consumer [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish commented on code in PR #12812: URL: https://github.com/apache/pinot/pull/12812#discussion_r1558308899 ## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java: ## @@ -45,93

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-javadoc-plugin-3.6.3 deleted (was 1c37415bab)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-javadoc-plugin-3.6.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1c37415bab Bump

Re: [PR] Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.2.0 to 3.6.3 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12852: URL: https://github.com/apache/pinot/pull/12852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch master updated (7e4ea06b99 -> 425eea9e80)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7e4ea06b99 use static TypeReference object (#12776) add 425eea9e80 Bump

Re: [PR] Improves in unsafe memory [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12808: URL: https://github.com/apache/pinot/pull/12808#discussion_r1558289310 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/unsafe/DirectMemory.java: ## @@ -56,8 +56,12 @@ public void flush() { @Override

Re: [PR] use static TypeReference object [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12776: URL: https://github.com/apache/pinot/pull/12776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch master updated (07682d24f8 -> 7e4ea06b99)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 07682d24f8 Bump com.azure:azure-identity from 1.11.3 to 1.12.0 (#12855) add 7e4ea06b99 use static TypeReference

Re: [I] Scheduled data load into Dimensional table [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on issue #12801: URL: https://github.com/apache/pinot/issues/12801#issuecomment-2046039885 cc @snleee @swaminathanmanish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add schema as input to the decoder. [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12813: URL: https://github.com/apache/pinot/pull/12813#discussion_r1558283670 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageDecoder.java: ## @@ -44,9 +45,10 @@ public interface StreamMessageDecoder { * @param

Re: [PR] Bump com.azure:azure-identity from 1.11.3 to 1.12.0 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12855: URL: https://github.com/apache/pinot/pull/12855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/com.azure-azure-identity-1.12.0 deleted (was 64fa753f38)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.azure-azure-identity-1.12.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 64fa753f38 Bump com.azure:azure-identity from 1.11.3 to 1.12.0 The

(pinot) branch master updated (3a7cef3155 -> 07682d24f8)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3a7cef3155 Bump net.openhft:chronicle-core from 2.25ea10 to 2.25ea13 (#12854) add 07682d24f8 Bump

(pinot) branch master updated (d9b1f040bf -> 3a7cef3155)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from d9b1f040bf Bump com.microsoft.azure:msal4j from 1.14.3 to 1.15.0 (#12853) add 3a7cef3155 Bump

(pinot) branch dependabot/maven/net.openhft-chronicle-core-2.25ea13 deleted (was 22ef79e8e5)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/net.openhft-chronicle-core-2.25ea13 in repository https://gitbox.apache.org/repos/asf/pinot.git was 22ef79e8e5 Bump net.openhft:chronicle-core from 2.25ea10 to 2.25ea13

Re: [PR] Bump net.openhft:chronicle-core from 2.25ea10 to 2.25ea13 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12854: URL: https://github.com/apache/pinot/pull/12854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.15.0 deleted (was cd6fee632f)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.15.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was cd6fee632f Bump com.microsoft.azure:msal4j from 1.14.3 to 1.15.0 The

(pinot) branch master updated: Bump com.microsoft.azure:msal4j from 1.14.3 to 1.15.0 (#12853)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d9b1f040bf Bump com.microsoft.azure:msal4j from

Re: [PR] Bump com.microsoft.azure:msal4j from 1.14.3 to 1.15.0 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12853: URL: https://github.com/apache/pinot/pull/12853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch master updated: Bump com.gradle:common-custom-user-data-maven-extension from 1.13 to 2 (#12850)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e001a884e4 Bump

(pinot) branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2 deleted (was f203e8b4b5)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.gradle-common-custom-user-data-maven-extension-2 in repository https://gitbox.apache.org/repos/asf/pinot.git was f203e8b4b5 Bump

Re: [PR] Bump com.gradle:common-custom-user-data-maven-extension from 1.13 to 2 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12850: URL: https://github.com/apache/pinot/pull/12850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/com.google.apis-google-api-services-storage-v1-rev20240319-2.0.0 deleted (was c5bcdf0f1b)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.apis-google-api-services-storage-v1-rev20240319-2.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was c5bcdf0f1b Bump

(pinot) branch master updated (abf45fc6e0 -> df5fcb7b0f)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from abf45fc6e0 Bump com.google.errorprone:error_prone_annotations from 2.25.0 to 2.26.1 (#12847) add df5fcb7b0f Bump

Re: [PR] Bump com.google.apis:google-api-services-storage from v1-rev20240209-2.0.0 to v1-rev20240319-2.0.0 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12848: URL: https://github.com/apache/pinot/pull/12848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.26.1 deleted (was 5b17efc281)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.errorprone-error_prone_annotations-2.26.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5b17efc281 Bump

(pinot) branch master updated (73ef57b3af -> abf45fc6e0)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 73ef57b3af Bump org.apache:apache from 21 to 31 (#12846) add abf45fc6e0 Bump

Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.25.0 to 2.26.1 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12847: URL: https://github.com/apache/pinot/pull/12847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/org.apache-apache-31 deleted (was 5685a2da34)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache-apache-31 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5685a2da34 Bump org.apache:apache from 21 to 31 The revisions that were on this branch

(pinot) branch dependabot/maven/pulsar.version-3.2.2 deleted (was 986277bdc5)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/pulsar.version-3.2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 986277bdc5 Bump pulsar.version from 2.11.4 to 3.2.2 The revisions that were on

(pinot) branch master updated (c722607743 -> 73ef57b3af)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c722607743 Bump aws.sdk.version from 2.25.17 to 2.25.27 (#12843) add 73ef57b3af Bump org.apache:apache from 21 to

Re: [PR] Bump org.apache:apache from 21 to 31 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12846: URL: https://github.com/apache/pinot/pull/12846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump pulsar.version from 2.11.4 to 3.2.2 [pinot]

2024-04-09 Thread via GitHub
dependabot[bot] commented on PR #12845: URL: https://github.com/apache/pinot/pull/12845#issuecomment-2046007646 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

Re: [PR] Bump pulsar.version from 2.11.4 to 3.2.2 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on PR #12845: URL: https://github.com/apache/pinot/pull/12845#issuecomment-2046007590 Tracked in #12713, need some manual fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump pulsar.version from 2.11.4 to 3.2.2 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang closed pull request #12845: Bump pulsar.version from 2.11.4 to 3.2.2 URL: https://github.com/apache/pinot/pull/12845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pinot) branch dependabot/maven/org.codehaus.woodstox-stax2-api-4.2.2 updated (e2311b8272 -> 026fcae76f)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.woodstox-stax2-api-4.2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git discard e2311b8272 Bump org.codehaus.woodstox:stax2-api from 4.1 to 4.2.2

(pinot) branch master updated (101af7c583 -> b5148ebfeb)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 101af7c583 add SegmentContext to collect validDocIds bitmaps for many segments together (#12694) add b5148ebfeb

Re: [PR] Bump aws.sdk.version from 2.25.17 to 2.25.27 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12843: URL: https://github.com/apache/pinot/pull/12843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump cloud.localstack:localstack-utils from 0.2.19 to 0.2.23 [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang merged PR #12842: URL: https://github.com/apache/pinot/pull/12842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(pinot) branch dependabot/maven/aws.sdk.version-2.25.27 deleted (was ff444303fe)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/aws.sdk.version-2.25.27 in repository https://gitbox.apache.org/repos/asf/pinot.git was ff444303fe Bump aws.sdk.version from 2.25.17 to 2.25.27 The revisions that were on

(pinot) branch master updated (b5148ebfeb -> c722607743)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from b5148ebfeb Bump cloud.localstack:localstack-utils from 0.2.19 to 0.2.23 (#12842) add c722607743 Bump

(pinot) branch dependabot/maven/cloud.localstack-localstack-utils-0.2.23 deleted (was 5250ac04c3)

2024-04-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/cloud.localstack-localstack-utils-0.2.23 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5250ac04c3 Bump cloud.localstack:localstack-utils from 0.2.19 to

(pinot) branch master updated (620c46acd3 -> 101af7c583)

2024-04-09 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 620c46acd3 Move package org.apache.calcite to org.apache.pinot.calcite (#12837) add 101af7c583 add SegmentContext

Re: [PR] add SegmentContext to collect validDocIds bitmaps for many segments together [pinot]

2024-04-09 Thread via GitHub
klsince merged PR #12694: URL: https://github.com/apache/pinot/pull/12694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Support ORC 2.0+ [pinot]

2024-04-09 Thread via GitHub
hpvd commented on issue #12858: URL: https://github.com/apache/pinot/issues/12858#issuecomment-2045910970 notable changes: https://orc.apache.org/releases/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558152978 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableIndex.java: ## @@ -60,4 +60,12 @@ public interface MutableIndex extends

Re: [PR] remove easymock library [pinot]

2024-04-09 Thread via GitHub
codecov-commenter commented on PR #12859: URL: https://github.com/apache/pinot/pull/12859#issuecomment-2045873576 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12859?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558146827 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java: ## @@ -90,14 +102,17 @@ public static

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558134729 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -181,6 +181,17 @@ private

Re: [PR] Add SchemaConformingTransformerV2 to enhance text search abilities [pinot]

2024-04-09 Thread via GitHub
lnbest0707-uber commented on PR #12788: URL: https://github.com/apache/pinot/pull/12788#issuecomment-2045820585 Some extreme column name corner case checks would be taken care in future patch, e.g., column name with `a.`, input data with `{"a": {"b":1}, "a.b":2, "a.":3, "a.b.":4}` --

Re: [PR] Add SchemaConformingTransformerV2 to enhance text search abilities [pinot]

2024-04-09 Thread via GitHub
lnbest0707-uber commented on code in PR #12788: URL: https://github.com/apache/pinot/pull/12788#discussion_r1558107343 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/SchemaConformingTransformerV2Config.java: ## @@ -0,0 +1,253 @@ +/** + * Licensed to the

[PR] remove easymock library [pinot]

2024-04-09 Thread via GitHub
sullis opened a new pull request, #12859: URL: https://github.com/apache/pinot/pull/12859 This project uses Mockito for mock objects. We don't need to use EasyMock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558089422 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java: ## @@ -118,6 +118,9 @@ public void

Re: [PR] Fix metric rule pattern regex [pinot]

2024-04-09 Thread via GitHub
Jackie-Jiang commented on code in PR #12856: URL: https://github.com/apache/pinot/pull/12856#discussion_r1558089252 ## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ## @@ -1,173 +1,173 @@ rules: -- pattern: "\"org.apache.pinot.common.metrics\"<>(\\w+)"

Re: [PR] Improved segment build time for Lucene text index realtime to offline conversion [pinot]

2024-04-09 Thread via GitHub
chenboat commented on code in PR #12744: URL: https://github.com/apache/pinot/pull/12744#discussion_r1558086670 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -932,6 +932,19 @@ public Object getValue(int

Re: [PR] Fix metric rule pattern regex [pinot]

2024-04-09 Thread via GitHub
zhtaoxiang commented on PR #12856: URL: https://github.com/apache/pinot/pull/12856#issuecomment-2045767927 > It also replaces *? with * for custom metric rules as the surrounding pattern matching is well defined. Can you please elaborate more on this? Maybe you can use an example to

Re: [I] [Flaky test] CaseTransformFunctionTest. testCaseTransformFunctionWithIntResults() [pinot]

2024-04-09 Thread via GitHub
aditya0811 commented on issue #12367: URL: https://github.com/apache/pinot/issues/12367#issuecomment-2045759962 Hello Jackie, I was able to reproduce the error by changing `protected static final int NUM_ROWS = 1` and below in `setUp()` in `BaseTransformFunctionTest.java`. ```

(pinot) branch add-validation-check-for-forward-index-disabled-when-enabling-columnar-segment-creation updated (4c2fca142d -> c7f5887d55)

2024-04-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-validation-check-for-forward-index-disabled-when-enabling-columnar-segment-creation in repository https://gitbox.apache.org/repos/asf/pinot.git discard 4c2fca142d Add validation check for

Re: [I] GeoServer Compatibility [pinot]

2024-04-09 Thread via GitHub
robertzych commented on issue #12805: URL: https://github.com/apache/pinot/issues/12805#issuecomment-2045708477 GeoServer doesn't strictly require the missing functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[I] Support maxNumRowsPerTask in RealtimeToOfflineSegmentsTask [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish opened a new issue, #12857: URL: https://github.com/apache/pinot/issues/12857 **Problem**: Currently [RealtimeToOfflineSegmentsTask that is used to move real time segments to offline

Re: [I] Support maxNumRowsPerTask in RealtimeToOfflineSegmentsTask [pinot]

2024-04-09 Thread via GitHub
swaminathanmanish commented on issue #12857: URL: https://github.com/apache/pinot/issues/12857#issuecomment-2045650083 cc @aishikbh - Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Fix video placeholder. Fix logos [pinot-site]

2024-04-09 Thread via GitHub
gio-startree opened a new pull request, #112: URL: https://github.com/apache/pinot-site/pull/112 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add base class for merging and accumulating custom objects [pinot]

2024-04-09 Thread via GitHub
davecromberge commented on PR #12685: URL: https://github.com/apache/pinot/pull/12685#issuecomment-2045245091 > Can you please help update the Pinot doc about this function? @Jackie-Jiang here is the accompanying pull request to the documentation site:

(pinot-site) branch new-site-dev updated: Wb 280 add webex (#111)

2024-04-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch new-site-dev in repository https://gitbox.apache.org/repos/asf/pinot-site.git The following commit(s) were added to refs/heads/new-site-dev by this push: new 278bf8c9 Wb 280 add webex

Re: [PR] Wb 280 add webex [pinot-site]

2024-04-09 Thread via GitHub
xiangfu0 merged PR #111: URL: https://github.com/apache/pinot-site/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Inconsistent segment file extension for TarGzPush and MetadataPush [pinot]

2024-04-09 Thread via GitHub
deepthi912 commented on issue #10375: URL: https://github.com/apache/pinot/issues/10375#issuecomment-2045045145 Is anyone still working on this issue? I can take a look if not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] More accurate consumption metrics in presence of server restarts and replication [pinot]

2024-04-09 Thread via GitHub
hpvd commented on issue #11441: URL: https://github.com/apache/pinot/issues/11441#issuecomment-2045052419 Perhaps this is something to keep in mind when futher refining the metrics: https://github.com/apache/pinot/issues/12840 -- This is an automated message from the Apache Git

[PR] Fix metric rule pattern regex [pinot]

2024-04-09 Thread via GitHub
shounakmk219 opened a new pull request, #12856: URL: https://github.com/apache/pinot/pull/12856 # Description The `.` requires escaping throughout the pattern string if it is intended to represent a `.` literal. The only reason its working right now is because its surrounded by specific

(pinot) branch dependabot/maven/com.azure-azure-identity-1.12.0 created (now 64fa753f38)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-identity-1.12.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 64fa753f38 Bump com.azure:azure-identity from 1.11.3 to 1.12.0 No new

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-javadoc-plugin-3.6.3 created (now 1c37415bab)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-javadoc-plugin-3.6.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1c37415bab Bump

(pinot) branch dependabot/maven/net.openhft-chronicle-core-2.25ea13 created (now 22ef79e8e5)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/net.openhft-chronicle-core-2.25ea13 in repository https://gitbox.apache.org/repos/asf/pinot.git at 22ef79e8e5 Bump net.openhft:chronicle-core from 2.25ea10 to

[PR] Bump com.azure:azure-identity from 1.11.3 to 1.12.0 [pinot]

2024-04-09 Thread via GitHub
dependabot[bot] opened a new pull request, #12855: URL: https://github.com/apache/pinot/pull/12855 Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.11.3 to 1.12.0. Release notes Sourced from

(pinot) branch dependabot/maven/com.microsoft.azure-msal4j-1.15.0 created (now cd6fee632f)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.microsoft.azure-msal4j-1.15.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at cd6fee632f Bump com.microsoft.azure:msal4j from 1.14.3 to 1.15.0 No

(pinot) branch dependabot/maven/org.codehaus.woodstox-stax2-api-4.2.2 created (now e2311b8272)

2024-04-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.woodstox-stax2-api-4.2.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at e2311b8272 Bump org.codehaus.woodstox:stax2-api from 4.1 to 4.2.2

  1   2   >