[GitHub] [pulsar] sijie commented on issue #3977: Provide a mechanism to disable uploading distribution packages

2019-04-08 Thread GitBox
sijie commented on issue #3977: Provide a mechanism to disable uploading distribution packages URL: https://github.com/apache/pulsar/pull/3977#issuecomment-480741840 run java8 tests This is an automated message from the Apach

[pulsar] branch asf-site updated: Updated site at revision c706d45

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 3ae8405 Updated site at revision c706d45 3a

[pulsar.wiki] branch master updated: Updated PIP 34: Add new subscribe type Key_Failover (markdown)

2019-04-08 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 1758841 Updated PIP 34: Add new subscribe

[GitHub] [pulsar] massakam opened a new pull request #4003: [broker] Fix deadlock during GC of non-persistent topic

2019-04-08 Thread GitBox
massakam opened a new pull request #4003: [broker] Fix deadlock during GC of non-persistent topic URL: https://github.com/apache/pulsar/pull/4003 ### Motivation A deadlock can occur when non-persistent topics are deleted by GC. The cause is that thread `pulsar-inactivity-monitor-x`

[GitHub] [pulsar] eolivelli commented on a change in pull request #3997: Issue 3655: Kerberos authentication for proxy

2019-04-08 Thread GitBox
eolivelli commented on a change in pull request #3997: Issue 3655: Kerberos authentication for proxy URL: https://github.com/apache/pulsar/pull/3997#discussion_r273002218 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ## @@ -1

[pulsar] branch master updated: [Kubernetes] Added ingress resource to dashboard (#3996)

2019-04-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new de24ad7 [Kubernetes] Added ingress resource to d

[GitHub] [pulsar] sijie merged pull request #3996: [Kubernetes] Added ingress resource to dashboard

2019-04-08 Thread GitBox
sijie merged pull request #3996: [Kubernetes] Added ingress resource to dashboard URL: https://github.com/apache/pulsar/pull/3996 This is an automated message from the Apache Git Service. To respond to the message, please lo

[pulsar] branch master updated: Provide a mechanism to disable uploading distribution packages (#3977)

2019-04-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8365808 Provide a mechanism to disable uploading

[GitHub] [pulsar] sijie merged pull request #3977: Provide a mechanism to disable uploading distribution packages

2019-04-08 Thread GitBox
sijie merged pull request #3977: Provide a mechanism to disable uploading distribution packages URL: https://github.com/apache/pulsar/pull/3977 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] massakam commented on issue #4003: [broker] Fix deadlock during GC of non-persistent topic

2019-04-08 Thread GitBox
massakam commented on issue #4003: [broker] Fix deadlock during GC of non-persistent topic URL: https://github.com/apache/pulsar/pull/4003#issuecomment-480853474 rerun cpp tests This is an automated message from the Apache Gi

[GitHub] [pulsar] jerrypeng commented on issue #3999: Don't pass any auth parameters when authentication is disabled

2019-04-08 Thread GitBox
jerrypeng commented on issue #3999: Don't pass any auth parameters when authentication is disabled URL: https://github.com/apache/pulsar/pull/3999#issuecomment-480908984 rerun cpp tests This is an automated message from the A

[GitHub] [pulsar] srkukarni opened a new pull request #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
srkukarni opened a new pull request #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004 ### Motivation Currently Json parsing fails if there are unquoted field names. This is too restrictive. This pr allows unquoted filed names.

[GitHub] [pulsar] grantwwu commented on issue #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
grantwwu commented on issue #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004#issuecomment-480975005 Porting some comments I had from the Slack here: I personally do not think Pulsar should allow unquoted property names in the J

[GitHub] [pulsar] jerrypeng opened a new pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng opened a new pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005 ### Motivation In java functions, when a user calls publish, the outgoing message does not have a key set even though in the input message h

[GitHub] [pulsar] kenandalley-gm commented on issue #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
kenandalley-gm commented on issue #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004#issuecomment-480978245 I also agree that it should be tunable rather than set to the default for Pulsar. Also, there needs to be some additional

[GitHub] [pulsar] jerrypeng commented on issue #3984: Fixed issue in backoff builder configuration

2019-04-08 Thread GitBox
jerrypeng commented on issue #3984: Fixed issue in backoff builder configuration URL: https://github.com/apache/pulsar/pull/3984#issuecomment-480978699 rerun java8 tests rerun integration tests This is an automated message

[GitHub] [pulsar] merlimat opened a new pull request #4006: Fixed concurrent modification exception on function worker stop

2019-04-08 Thread GitBox
merlimat opened a new pull request #4006: Fixed concurrent modification exception on function worker stop URL: https://github.com/apache/pulsar/pull/4006 ### Motivation During function worker shutdown there's concurrent modification exception since the stop function is removing from

[GitHub] [pulsar] jerrypeng commented on issue #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
jerrypeng commented on issue #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004#issuecomment-480987269 @srkukarni I don't think we should do this. I think we should keep as much of the behavior default as possible

[GitHub] [pulsar] merlimat commented on issue #4006: Fixed concurrent modification exception on function worker stop

2019-04-08 Thread GitBox
merlimat commented on issue #4006: Fixed concurrent modification exception on function worker stop URL: https://github.com/apache/pulsar/pull/4006#issuecomment-481010520 run integration tests This is an automated message from

[pulsar] branch master updated: Fix deadlock during GC of non-persistent topic (#4003)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c9f444e Fix deadlock during GC of non-persisten

[GitHub] [pulsar] merlimat merged pull request #4003: [broker] Fix deadlock during GC of non-persistent topic

2019-04-08 Thread GitBox
merlimat merged pull request #4003: [broker] Fix deadlock during GC of non-persistent topic URL: https://github.com/apache/pulsar/pull/4003 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] merlimat commented on issue #3988: [issue #3975] Bugfix NPE on non durable consumer

2019-04-08 Thread GitBox
merlimat commented on issue #3988: [issue #3975] Bugfix NPE on non durable consumer URL: https://github.com/apache/pulsar/pull/3988#issuecomment-481012962 run integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] srkukarni commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
srkukarni commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273245375 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[pulsar] branch master updated: Fixed concurrent modification exception on function worker stop (#4006)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 247a608 Fixed concurrent modification exception

[GitHub] [pulsar] merlimat merged pull request #4006: Fixed concurrent modification exception on function worker stop

2019-04-08 Thread GitBox
merlimat merged pull request #4006: Fixed concurrent modification exception on function worker stop URL: https://github.com/apache/pulsar/pull/4006 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch branch-2.3 updated (78125b0 -> 0fc17cc)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch branch-2.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 78125b0 Release 2.3.1 new 5eeef74 Fix integration tests by pinning the version of python package (#4000)

[GitHub] [pulsar] merlimat commented on issue #4000: Fix integration tests by pinning the version of python package

2019-04-08 Thread GitBox
merlimat commented on issue #4000: Fix integration tests by pinning the version of python package URL: https://github.com/apache/pulsar/pull/4000#issuecomment-481020373 merged in 2.3.1 at 5eeef74 This is an automated mess

[pulsar] branch branch-2.3 updated: Fix deadlock during GC of non-persistent topic (#4003)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.3 by this push: new 7a6f2cc Fix deadlock during GC of non-p

[GitHub] [pulsar] srkukarni commented on a change in pull request #3854: [issue #3767] support go function for pulsar

2019-04-08 Thread GitBox
srkukarni commented on a change in pull request #3854: [issue #3767] support go function for pulsar URL: https://github.com/apache/pulsar/pull/3854#discussion_r273259522 ## File path: pulsar-function-go/pf/instance.go ## @@ -0,0 +1,272 @@ +// +// Licensed to the Apache Sof

[GitHub] [pulsar] srkukarni commented on issue #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
srkukarni commented on issue #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004#issuecomment-481028761 Withdrawing since there seems to be consensus on keeping the parsing logic as conforming to the standard as possible ---

[GitHub] [pulsar] srkukarni closed pull request #4004: Allow for a more lenient decoder for json schemas

2019-04-08 Thread GitBox
srkukarni closed pull request #4004: Allow for a more lenient decoder for json schemas URL: https://github.com/apache/pulsar/pull/4004 This is an automated message from the Apache Git Service. To respond to the message, plea

svn commit: r33521 [2/2] - in /dev/pulsar: pulsar-2.3.1-candidate-1/ pulsar-2.3.1-candidate-2/ pulsar-2.3.1-candidate-2/DEB/ pulsar-2.3.1-candidate-2/RPMS/ pulsar-2.3.1-candidate-2/RPMS/repodata/ puls

2019-04-08 Thread mmerli
Added: dev/pulsar/pulsar-2.3.1-candidate-2/connectors/pulsar-io-netty-2.3.1.nar.asc == --- dev/pulsar/pulsar-2.3.1-candidate-2/connectors/pulsar-io-netty-2.3.1.nar.asc (added) +++ dev/pulsar/pulsar-2.3.1-candidate-2/con

svn commit: r33521 [1/2] - in /dev/pulsar: pulsar-2.3.1-candidate-1/ pulsar-2.3.1-candidate-2/ pulsar-2.3.1-candidate-2/DEB/ pulsar-2.3.1-candidate-2/RPMS/ pulsar-2.3.1-candidate-2/RPMS/repodata/ puls

2019-04-08 Thread mmerli
Author: mmerli Date: Mon Apr 8 22:33:08 2019 New Revision: 33521 Log: Staging artifacts and signature for Pulsar release 2.3.1 candidate 2 Added: dev/pulsar/pulsar-2.3.1-candidate-2/ dev/pulsar/pulsar-2.3.1-candidate-2/DEB/ dev/pulsar/pulsar-2.3.1-candidate-2/DEB/Packages.gz (with

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273264655 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] jerrypeng merged pull request #3999: Don't pass any auth parameters when authentication is disabled

2019-04-08 Thread GitBox
jerrypeng merged pull request #3999: Don't pass any auth parameters when authentication is disabled URL: https://github.com/apache/pulsar/pull/3999 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated: Don't pass any auth parameters when authentication is disabled (#3999)

2019-04-08 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 14a5ee0 Don't pass any auth parameters when

[GitHub] [pulsar] srkukarni commented on issue #3992: Add exclusion for windows c++ compiler

2019-04-08 Thread GitBox
srkukarni commented on issue #3992: Add exclusion for windows c++ compiler URL: https://github.com/apache/pulsar/pull/3992#issuecomment-481040156 @aahmed-se can you rebase with master? This is an automated message from the Apa

[GitHub] [pulsar] ConcurrencyPractitioner commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config for ReaderImpl

2019-04-08 Thread GitBox
ConcurrencyPractitioner commented on a change in pull request #3983: [Issue#3976] [component/client] Adding config for ReaderImpl URL: https://github.com/apache/pulsar/pull/3983#discussion_r273272433 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReader

[pulsar] annotated tag v2.3.1-candidate-2 updated (7a6f2cc -> c329b5b)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to annotated tag v2.3.1-candidate-2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. *** WARNING: tag v2.3.1-candidate-2 was modified! *** from 7a6f2cc (commit) to c329b5b (tag)

[GitHub] [pulsar] merlimat commented on issue #3984: Fixed issue in backoff builder configuration

2019-04-08 Thread GitBox
merlimat commented on issue #3984: Fixed issue in backoff builder configuration URL: https://github.com/apache/pulsar/pull/3984#issuecomment-481045586 run integration tests This is an automated message from the Apache Git Serv

[GitHub] [pulsar] merlimat commented on issue #3991: [pulsar-storm] Fix NPE while emitting next tuple

2019-04-08 Thread GitBox
merlimat commented on issue #3991: [pulsar-storm] Fix NPE while emitting next tuple URL: https://github.com/apache/pulsar/pull/3991#issuecomment-481045507 run integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
sijie commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273283165 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record_met

[GitHub] [pulsar] sijie commented on issue #3958: [Doc] Update "load distribution" as "load balance"

2019-04-08 Thread GitBox
sijie commented on issue #3958: [Doc] Update "load distribution" as "load balance" URL: https://github.com/apache/pulsar/pull/3958#issuecomment-481053558 run java8 tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] aahmed-se commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default

2019-04-08 Thread GitBox
aahmed-se commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default URL: https://github.com/apache/pulsar/pull/3982#issuecomment-481055514 jdk8 and python are EOL, so this pr is to start preparing for moving to lte versions for both. --

[GitHub] [pulsar] sijie commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default

2019-04-08 Thread GitBox
sijie commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default URL: https://github.com/apache/pulsar/pull/3982#issuecomment-481056196 @aahmed-se this will change the user behavior using pulsar docker images. this change will directly impact users. I would prefer h

[GitHub] [pulsar] sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler URL: https://github.com/apache/pulsar/pull/3992#discussion_r273287483 ## File path: pulsar-client-cpp/lib/LogUtils.h ## @@ -27,7 +27,11 @@ namespace pulsar { +#if defined _WIN32

[GitHub] [pulsar] aahmed-se commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default

2019-04-08 Thread GitBox
aahmed-se commented on issue #3982: [WIP] Move Docker images to jdk11 and python3 as default URL: https://github.com/apache/pulsar/pull/3982#issuecomment-481058189 ok will create a pip the runtime target will still java 8 , no plans to change that. -

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273289025 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273289025 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273288979 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaProvider.java ## @@ -31,6

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289033 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaProvider.java ## @@ -31,6

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273291454 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericAvroReader.java ## @

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273290029 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ## @@ -57,6 +57,7 @@ im

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273291755 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericSchemaImpl.java ## @

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289838 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBase.java ## @@ -41,6 +44,12 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273294405 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaProvider.java ## @@ -31,6

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289802 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBase.java ## @@ -41,6 +44,12 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289771 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -153,17 +157,22 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273290279 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoProduceBytesSchema.java ## @@ -

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289364 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -153,17 +157,22 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273292976 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/writer/AvroWriter.java ## @@ -0,0 +

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273293068 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/ProtobufSchemaTest.java ## @@ -89,7

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289994 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBase.java ## @@ -41,6 +44,12 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273293372 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericJsonReader.java ## @

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273293315 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericJsonRecord.java ## @

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273289635 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -153,17 +157,22 @@

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273291187 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StructSchema.java ## @@ -38,26 +50,

[GitHub] [pulsar] sijie commented on a change in pull request #3876: Add the multi version schema support

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r273291315 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StructSchema.java ## @@ -38,26 +50,

[GitHub] [pulsar] sijie merged pull request #3984: Fixed issue in backoff builder configuration

2019-04-08 Thread GitBox
sijie merged pull request #3984: Fixed issue in backoff builder configuration URL: https://github.com/apache/pulsar/pull/3984 This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch master updated: Fixed issue in backoff builder configuration (#3984)

2019-04-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6bce00b Fixed issue in backoff builder configura

[GitHub] [pulsar] sijie commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
sijie commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273295700 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record_met

[GitHub] [pulsar] merlimat merged pull request #3988: [issue #3975] Bugfix NPE on non durable consumer

2019-04-08 Thread GitBox
merlimat merged pull request #3988: [issue #3975] Bugfix NPE on non durable consumer URL: https://github.com/apache/pulsar/pull/3988 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] merlimat closed issue #3975: Failed to reset subscription: Message id was not present

2019-04-08 Thread GitBox
merlimat closed issue #3975: Failed to reset subscription: Message id was not present URL: https://github.com/apache/pulsar/issues/3975 This is an automated message from the Apache Git Service. To respond to the message, ple

[pulsar] branch master updated: [issue #3975] Bugfix NPE on non durable consumer (#3988)

2019-04-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 372575a [issue #3975] Bugfix NPE on non durable

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3854: [issue #3767] support go function for pulsar

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3854: [issue #3767] support go function for pulsar URL: https://github.com/apache/pulsar/pull/3854#discussion_r273301121 ## File path: pulsar-function-go/pf/instance.go ## @@ -0,0 +1,272 @@ +// +// Licensed to the Apache Sof

[GitHub] [pulsar] sijie merged pull request #3991: [pulsar-storm] Fix NPE while emitting next tuple

2019-04-08 Thread GitBox
sijie merged pull request #3991: [pulsar-storm] Fix NPE while emitting next tuple URL: https://github.com/apache/pulsar/pull/3991 This is an automated message from the Apache Git Service. To respond to the message, please lo

[pulsar] branch master updated: [pulsar-storm] Fix NPE while emitting next tuple (#3991)

2019-04-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 12de91f [pulsar-storm] Fix NPE while emitting ne

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273302868 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -108,6 +108,14 @@ func createProducerAsy

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273304065 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273303793 ## File path: pulsar-client-go/pulsar/producer.go ## @@ -125,6 +125,12 @@ type ProducerOptions str

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273302845 ## File path: pulsar-client-go/pulsar/producer.go ## @@ -125,6 +125,12 @@ type ProducerOptions str

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273306686 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273307241 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273307241 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record

[GitHub] [pulsar] skyrocknroll commented on issue #3945: [#3944][dashboard]Dashboard authentication support for JWT token

2019-04-08 Thread GitBox
skyrocknroll commented on issue #3945: [#3944][dashboard]Dashboard authentication support for JWT token URL: https://github.com/apache/pulsar/pull/3945#issuecomment-481083147 run java8 tests This is an automated message from

[GitHub] [pulsar] sijie commented on a change in pull request #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
sijie commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273310264 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -126,7 +126,8 @@ def record_met

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273311107 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -108,6 +108,14 @@ func createProducerAs

[GitHub] [pulsar] foreversunyao commented on issue #3915: (WIP) [PIP28][PROXY] Pulsar Proxy Gateway Improvement

2019-04-08 Thread GitBox
foreversunyao commented on issue #3915: (WIP) [PIP28][PROXY] Pulsar Proxy Gateway Improvement URL: https://github.com/apache/pulsar/pull/3915#issuecomment-481085571 run cpp tests This is an automated message from the Apache

[GitHub] [pulsar] jerrypeng commented on issue #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
jerrypeng commented on issue #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#issuecomment-481085772 @sijie in my previous comment, I already said I was going to add the tests. Please read my responses in their entirety before respond

[GitHub] [pulsar] sijie commented on issue #4005: Set key for message when using function publish

2019-04-08 Thread GitBox
sijie commented on issue #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#issuecomment-481085977 @jerrypeng got it now. thank you This is an automated message from the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318170 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318725 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318725 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273320217 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the Apa

[GitHub] [pulsar] sijie commented on issue #3854: [issue #3767] support go function for pulsar

2019-04-08 Thread GitBox
sijie commented on issue #3854: [issue #3767] support go function for pulsar URL: https://github.com/apache/pulsar/pull/3854#issuecomment-481109155 run cpp tests This is an automated message from the Apache Git Service. To res