[GitHub] [pulsar] Jennifer88huang opened a new pull request #9972: [docs] Fix package REST API command issues

Jennifer88huang opened a new pull request #9972: URL: https://github.com/apache/pulsar/pull/9972 Fixes https://github.com/apache/pulsar/issues/9971 ### Motivation The REST admin API commands for packages are not displayed well. ### Modifications Fix the format of

[GitHub] [pulsar] michaeljmarshall commented on issue #9916: Flaky-test: DeadLetterTopicTest.testDeadLetterTopic

michaeljmarshall commented on issue #9916: URL: https://github.com/apache/pulsar/issues/9916#issuecomment-802590723 Quick note: it does seem rather intentional that we send to the DLQ first and only acknowledge the message on the original topic upon successful delivery to the DLQ. This ord

[GitHub] [pulsar] jerrypeng commented on pull request #9895: Implement Schema#OBJECT - support for Consumer

jerrypeng commented on pull request #9895: URL: https://github.com/apache/pulsar/pull/9895#issuecomment-802587065 Having a Schema of Object type does not make sense to me. The point of a schema is to provide boundaries on what the structure of the data can be. However, having a schema th

[GitHub] [pulsar] Jennifer88huang commented on pull request #8816: Implement the packages management administration opeartions.

Jennifer88huang commented on pull request #8816: URL: https://github.com/apache/pulsar/pull/8816#issuecomment-802584409 @zymap we've added related content in #9071, shall we enable those `pulsar-admin` commands on the [CLI page](http://pulsar.apache.org/tools/pulsar-admin/2.8.0-SNAPSHOT/)?

[GitHub] [pulsar] michaeljmarshall commented on issue #9916: Flaky-test: DeadLetterTopicTest.testDeadLetterTopic

michaeljmarshall commented on issue #9916: URL: https://github.com/apache/pulsar/issues/9916#issuecomment-802583964 I made some solid progress running through this test with a debugger. It does indeed look like there is a race condition based on the design of the test and the way that we s

[GitHub] [pulsar] Jennifer88huang commented on pull request #8418: support broker-level consume rate limiter

Jennifer88huang commented on pull request #8418: URL: https://github.com/apache/pulsar/pull/8418#issuecomment-802581810 @Anonymitaet this PR is closed. Double confirmed with the author, no need to add doc. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] linlinnn commented on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802580510 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] linlinnn removed a comment on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn removed a comment on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802570291 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] jerrypeng commented on issue #9966: Fail immediately on ErrorNotifierRecord inside BatchPushSource

jerrypeng commented on issue #9966: URL: https://github.com/apache/pulsar/issues/9966#issuecomment-802579670 Perhaps there should be two modes of notifying a fatal error. One is to restart without flushing the internal queue of records. The other one is to restart after flushing the inte

[GitHub] [pulsar] jerrypeng commented on issue #9966: Fail immediately on ErrorNotifierRecord inside BatchPushSource

jerrypeng commented on issue #9966: URL: https://github.com/apache/pulsar/issues/9966#issuecomment-802578589 > When an IO connector that implements the BatchPushSource interface wants to fail a task, it publishes a ErrorNotifierRecord to the internal queue. However, the exception isn't thr

[GitHub] [pulsar] linlinnn commented on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802570291 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Jennifer88huang commented on issue #9971: [website] The REST API commands do not display correctly

Jennifer88huang commented on issue #9971: URL: https://github.com/apache/pulsar/issues/9971#issuecomment-802521717 @tuteng @zymap could you please give some guidance on it? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Jennifer88huang commented on issue #9971: [website] The REST API commands do not display correctly

Jennifer88huang commented on issue #9971: URL: https://github.com/apache/pulsar/issues/9971#issuecomment-802521476 Related to #8896 #9071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] Jennifer88huang opened a new issue #9971: [website] The REST API commands do not display correctly

Jennifer88huang opened a new issue #9971: URL: https://github.com/apache/pulsar/issues/9971 **Describe the bug** On [admin api package](http://pulsar.apache.org/docs/en/next/admin-api-namespaces/#create-namespaces) page, the REST APIs are not displayed correctly. **To Reproduce**

[GitHub] [pulsar] congbobo184 opened a new pull request #9970: [Schema] Fix autoConsumeSchema deadLetter problem.

congbobo184 opened a new pull request #9970: URL: https://github.com/apache/pulsar/pull/9970 ## Motivation in order to fix autoConsumeSchema deadLetter problem. fix https://github.com/apache/pulsar/issues/9935 ## implement Add AutoProduceSchema to fix it ### Verifying this

[GitHub] [pulsar] david-streamlio commented on pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

david-streamlio commented on pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#issuecomment-802515276 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] michaeljmarshall commented on pull request #9948: Cleanup PrometheusMetricsTest

michaeljmarshall commented on pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#issuecomment-802496056 > If tests run in particular sequence or a module does a retry the static variables resolve to incorrect values. @aahmed-se - thanks for the explanation. I hadn't

[GitHub] [pulsar] michaeljmarshall commented on issue #3804: ManagedLedger should streamline the read requests

michaeljmarshall commented on issue #3804: URL: https://github.com/apache/pulsar/issues/3804#issuecomment-802493258 @eolivelli - thanks, I'll do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597366868 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -26,6 +26,9 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DIR=

[GitHub] [pulsar] zymap commented on pull request #9963: [Build] Run PR builds for merge commit

zymap commented on pull request #9963: URL: https://github.com/apache/pulsar/pull/9963#issuecomment-802491388 Can we get a copy of the `dorny/paths-filter@ca8fa4002c226cbab8b50cc157d3f47899a49762` in the [pulsar-test-infra](https://github.com/apache/pulsar-test-infra)? Because we still te

[GitHub] [pulsar] zymap commented on a change in pull request #9963: [Build] Run PR builds for merge commit

zymap commented on a change in pull request #9963: URL: https://github.com/apache/pulsar/pull/9963#discussion_r597364899 ## File path: .github/workflows/ci-cpp.yaml ## @@ -39,18 +39,18 @@ jobs: steps: - name: checkout uses: actions/checkout@v2 -with

[GitHub] [pulsar] linlinnn removed a comment on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn removed a comment on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802434930 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] zymap commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

zymap commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597360890 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -26,6 +26,9 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DIR=$(di

[GitHub] [pulsar] tuteng opened a new issue #9969: Add the version command for the command pulsar, pulsar-admin, pulsar-client etc

tuteng opened a new issue #9969: URL: https://github.com/apache/pulsar/issues/9969 **Is your feature request related to a problem? Please describe.** Add the `version` command for the command ./bin/pulsar, ./bin/pulsar-admin, ./bin/pulsar-client etc **Describe the solution you'd l

[GitHub] [pulsar] linlinnn commented on a change in pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on a change in pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#discussion_r597356277 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -131,11 +132,25 @@ public PulsarClientImpl(ClientConf

[GitHub] [pulsar] yitian108 commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

yitian108 commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-802454825 hi BewareMyPower, I've sent the email to you, please check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar] aahmed-se commented on pull request #9948: Cleanup PrometheusMetricsTest

aahmed-se commented on pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#issuecomment-802452506 Wrong origin repo will rebuild the pull request here https://github.com/apache/pulsar/pull/9968 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] aahmed-se closed pull request #9948: Cleanup PrometheusMetricsTest

aahmed-se closed pull request #9948: URL: https://github.com/apache/pulsar/pull/9948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] aahmed-se opened a new pull request #9968: Prometheus mtestmaster

aahmed-se opened a new pull request #9968: URL: https://github.com/apache/pulsar/pull/9968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[pulsar] branch master updated: Harden RawReaderTest with Awaitility (#9965)

This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 23a7346 Harden RawReaderTest with Awaitility (#

[GitHub] [pulsar] aahmed-se merged pull request #9965: Harden RawReaderTest with Awaitility

aahmed-se merged pull request #9965: URL: https://github.com/apache/pulsar/pull/9965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] merlimat commented on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

merlimat commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802436424 @linlinnn Can you take a look at my last comment (https://github.com/apache/pulsar/pull/9802/files#r597025305) We should only add 1 new constructor instead of 3. -- This is

[GitHub] [pulsar] linlinnn commented on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802434930 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r597338047 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaSinkTaskContext.java ## @@ -0,0 +1,212 @@ +/** + *

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r597335899 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaConnectSinkConfig.java ## @@ -0,0 +1,100 @@ +/** +

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597335499 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DI

[GitHub] [pulsar] merlimat commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

merlimat commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597333531 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DIR

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597331408 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DI

[GitHub] [pulsar] merlimat commented on issue #9950: client-cpp checksum failure on big endian

merlimat commented on issue #9950: URL: https://github.com/apache/pulsar/issues/9950#issuecomment-802404428 If you have a patch, please submit :) One other way, would be to use instead https://github.com/google/crc32c, although it would be preferable not to add additional compile de

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r597323899 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java ## @@ -0,0 +1,277 @@ +/** + * Licensed

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r597269231 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java ## @@ -0,0 +1,277 @@ +/** + * Licensed

[GitHub] [pulsar] Anonymitaet commented on pull request #9903: [docs] Add description about enable-subscription-types

Anonymitaet commented on pull request #9903: URL: https://github.com/apache/pulsar/pull/9903#issuecomment-802389191 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Anonymitaet commented on pull request #9951: [Doc] Support DLQ in key_shared subscription mode

Anonymitaet commented on pull request #9951: URL: https://github.com/apache/pulsar/pull/9951#issuecomment-802384342 > @codelipenghui thanks! How about adding the consequence of using DQL for ordered subscription type (as below)? > > > **Note** > > Using the dead letter topic on th

[GitHub] [pulsar] gmethvin commented on pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#issuecomment-802384279 @codelipenghui @315157973 responded to your comments. I get that the implementation for this is a little weird, so let me know if you have any other suggestions to achieve

[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r597308379 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java ## @@ -18,17 +18,11 @@ */ package org.apache.pulsar.cl

[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r597305928 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@ -27,15 +27,22 @@ import io.netty.util.concurrent.FastTh

[GitHub] [pulsar] rdhabalia opened a new pull request #9967: [pulsar-discovery] Replace MetadataStore with ZooKeeper in discoveryservice

rdhabalia opened a new pull request #9967: URL: https://github.com/apache/pulsar/pull/9967 ### Motivation one of the Implementations of #9646 . Remove direct ZooKeeper dependency from discovery-service and replace with metadata-store. Rename `ZookeeperCacheLoader` to `MetadataStoreCach

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r597289828 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] david-streamlio opened a new issue #9966: Fail immediately on ErrorNotifierRecord inside BatchPushSource

david-streamlio opened a new issue #9966: URL: https://github.com/apache/pulsar/issues/9966 **Is your enhancement request related to a problem? Please describe.** When an IO connector that implements the BatchPushSource interface wants to fail a task, it publishes a `ErrorNotifierRecord`

[pulsar] branch master updated: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig (#9907)" (#9945)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a4ca8f4 Revert "[fix #9851] Add forwardSourc

[GitHub] [pulsar] jerrypeng merged pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

jerrypeng merged pull request #9945: URL: https://github.com/apache/pulsar/pull/9945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r597269231 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java ## @@ -0,0 +1,277 @@ +/** + * Licensed

[GitHub] [pulsar] eolivelli commented on pull request #9965: Harden RawReaderTest with Awaitility

eolivelli commented on pull request #9965: URL: https://github.com/apache/pulsar/pull/9965#issuecomment-802290435 We can merge as soon as CI is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] david-streamlio commented on pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

david-streamlio commented on pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#issuecomment-802258216 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-802244383 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] aahmed-se commented on a change in pull request #9965: Harden RawReaderTest with Awaitility

aahmed-se commented on a change in pull request #9965: URL: https://github.com/apache/pulsar/pull/9965#discussion_r597197327 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java ## @@ -357,14 +359,14 @@ public void testAcknowledgeWithPrope

[GitHub] [pulsar] lhotari commented on a change in pull request #9965: Harden RawReaderTest with Awaitility

lhotari commented on a change in pull request #9965: URL: https://github.com/apache/pulsar/pull/9965#discussion_r597187494 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java ## @@ -357,14 +359,14 @@ public void testAcknowledgeWithPropert

[GitHub] [pulsar] jerrypeng edited a comment on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

jerrypeng edited a comment on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802166287 @freeznet first of all thank you for looking into a solution for an existing issue. There definitely was a bug in the framework involving setting messaging properties.

[GitHub] [pulsar] sijia-w commented on pull request #9903: [docs] Add description about enable-subscription-types

sijia-w commented on pull request #9903: URL: https://github.com/apache/pulsar/pull/9903#issuecomment-802218574 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] aahmed-se opened a new pull request #9965: Harden RawReaderTest with Awaitility

aahmed-se opened a new pull request #9965: URL: https://github.com/apache/pulsar/pull/9965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] jianyun8023 opened a new issue #9964: [BUG] SchemaInfo toString occurs NPE

jianyun8023 opened a new issue #9964: URL: https://github.com/apache/pulsar/issues/9964 **Describe the bug** Writing`schemaInfo#properties` may cause the client not to consume it when it is a Pulsar native type. **To Reproduce** Write `key` to `SchemaInfo#properties` has va

[GitHub] [pulsar] lhotari removed a comment on pull request #9934: [CI] Fix Transaction flaky test.

lhotari removed a comment on pull request #9934: URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [pulsar] lhotari commented on pull request #9934: [CI] Fix Transaction flaky test.

lhotari commented on pull request #9934: URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182861 Good work @congbobo184 . Thanks for addressing the flaky tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] lhotari commented on pull request #9934: [CI] Fix Transaction flaky test.

lhotari commented on pull request #9934: URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [pulsar] jerrypeng commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

jerrypeng commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802166287 @freeznet first of all thank you for looking into a solution for an existing issue. There definitely was a bug in the framework involving setting messaging properties.

[GitHub] [pulsar] lhotari commented on pull request #9963: [Build] Run PR builds for merge commit

lhotari commented on pull request #9963: URL: https://github.com/apache/pulsar/pull/9963#issuecomment-802153303 For this solution it is necessary to get `dorny/paths-filter@ca8fa4002c226cbab8b50cc157d3f47899a49762` whitelisted in the Apache GitHub Actions solution by opening an ASF INFRA t

[GitHub] [pulsar] lhotari opened a new pull request #9963: [Build] Run PR builds for merge commit

lhotari opened a new pull request #9963: URL: https://github.com/apache/pulsar/pull/9963 ### Motivation [Mailing list discussion](https://lists.apache.org/thread.html/r8a72efa166bbb2dad660d958e138139c0cd25041eddfd52705f0de11%40%3Cdev.pulsar.apache.org%3E) In GitHub Actions, th

[GitHub] [pulsar] dlg99 commented on a change in pull request #9947: add partitionNumber() to the Record<>

dlg99 commented on a change in pull request #9947: URL: https://github.com/apache/pulsar/pull/9947#discussion_r597091861 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarRecord.java ## @@ -61,6 +61,11 @@ return Optional.of

[GitHub] [pulsar] dlg99 commented on a change in pull request #9947: add partitionNumber() to the Record<>

dlg99 commented on a change in pull request #9947: URL: https://github.com/apache/pulsar/pull/9947#discussion_r597091399 ## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java ## @@ -178,6 +178,11 @@ public KafkaRecord(ConsumerRecord re

[GitHub] [pulsar] lhotari commented on pull request #9957: [Performance] Omit call to log.debug in hot code path ManagedLedgerImpl.doCacheEviction

lhotari commented on pull request #9957: URL: https://github.com/apache/pulsar/pull/9957#issuecomment-802143914 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch prometheusMtest updated (8e34089 -> bbcd036)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch prometheusMtest in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8e34089 Cleanup up PromethuesMetricsTest add bbcd036 Apply suggestions from code review No new revis

[GitHub] [pulsar] merlimat commented on a change in pull request #9948: Cleanup PrometheusMetricsTest

merlimat commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r597045208 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java ## @@ -77,6 +77,7 @@ @Override protected vo

[GitHub] [pulsar] merlimat commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

merlimat commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597027909 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DIR

[GitHub] [pulsar] david-streamlio commented on issue #9926: Message properties don't get passed from Pulsar Sources

david-streamlio commented on issue #9926: URL: https://github.com/apache/pulsar/issues/9926#issuecomment-802056281 > Looks like a duplicate of #9851 You are correct. However, there is an on going discussion w.r.t to the solution to this issue so I will keep this open for now for trac

[GitHub] [pulsar] merlimat commented on a change in pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

merlimat commented on a change in pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#discussion_r597025305 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -131,11 +132,25 @@ public PulsarClientImpl(ClientConf

[GitHub] [pulsar] lhotari commented on pull request #9957: [Performance] Omit call to log.debug in hot code path ManagedLedgerImpl.doCacheEviction

lhotari commented on pull request #9957: URL: https://github.com/apache/pulsar/pull/9957#issuecomment-802053510 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] merlimat commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

merlimat commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802049890 @freeznet > if a source connector is maintained by another orgs or devs, and it passes Record with properties that user doesn't need, I think it would be less painful t

[GitHub] [pulsar] adg25 commented on issue #9922: Create c++ producer/consumer with protobuf schema

adg25 commented on issue #9922: URL: https://github.com/apache/pulsar/issues/9922#issuecomment-802037396 Yes that worked for me as well! MessageToJsonString will not work for what I need here -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] david-streamlio commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

david-streamlio commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802024987 > I do think the tests written as part of > > https://github.com/apache/pulsar/pull/9907/files > > we should still keep. FYI, I have ad

[GitHub] [pulsar] michaeljmarshall opened a new issue #9962: [Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

michaeljmarshall opened a new issue #9962: URL: https://github.com/apache/pulsar/issues/9962 **Problem** From my testing and reading through of the code, when a topic with segments in tiered storage and on bookies is deleted, the data on the bookies eventually gets deleted (because the

[GitHub] [pulsar] eolivelli merged pull request #9954: [Doc]--Add metrics for producer throttling

eolivelli merged pull request #9954: URL: https://github.com/apache/pulsar/pull/9954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] thesquiff edited a comment on issue #9926: Message properties don't get passed from Pulsar Sources

thesquiff edited a comment on issue #9926: URL: https://github.com/apache/pulsar/issues/9926#issuecomment-801981042 Looks like a duplicate of #9851 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] thesquiff commented on issue #9926: Message properties don't get passed from Pulsar Sources

thesquiff commented on issue #9926: URL: https://github.com/apache/pulsar/issues/9926#issuecomment-801981042 Looks like a duplicate of [https://github.com/apache/pulsar/issues/9851] This is an automated message from the Apach

[GitHub] [pulsar] linlinnn commented on pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801976838 @codelipenghui @eolivelli @merlimat many thanks for your comments. This is an automated message from the Apac

[GitHub] [pulsar] linlinnn commented on a change in pull request #9802: [ISSUE 9783][pulsar-client] Allow pulsar client receive external timer

linlinnn commented on a change in pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#discussion_r596926653 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -152,7 +167,12 @@ public PulsarClientImpl(ClientConfi

[GitHub] [pulsar] timmyyuan opened a new pull request #9961: [Build] Python-client build script use wrong path for root dir

timmyyuan opened a new pull request #9961: URL: https://github.com/apache/pulsar/pull/9961 Motivation The current build process is broken by the wrong root dir. The same mistake that occurred in RPM build has been fixed by #9890 but it hasn't been fixed in python-client build. ---

[pulsar] branch master updated (7d3317e -> ac1a03c)

This is an automated email from the ASF dual-hosted git repository. hjf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7d3317e [CI] Fix Transaction flaky test. (#9934) add ac1a03c Support DLQ in key_shared sub mode (#9951) No new r

[GitHub] [pulsar] Jennifer88huang merged pull request #9951: [Doc] Support DLQ in key_shared subscription mode

Jennifer88huang merged pull request #9951: URL: https://github.com/apache/pulsar/pull/9951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Jennifer88huang commented on pull request #9951: [Doc] Support DLQ in key_shared subscription mode

Jennifer88huang commented on pull request #9951: URL: https://github.com/apache/pulsar/pull/9951#issuecomment-801941615 @Huanli-Meng when you submit a PR, could you please add the labels accordingly? Thank you. This is an au

[GitHub] [pulsar-client-go] GPrabhudas opened a new issue #489: Ability to set ServerName in TLS Config

GPrabhudas opened a new issue #489: URL: https://github.com/apache/pulsar-client-go/issues/489 ### Description: Failing to connect to broker because cert verification fails with error: `x509: cannot validate certificate for xxx.xxx.xxx.xxx because it doesn't contain any IP SANs`

[GitHub] [pulsar] frankjkelly opened a new issue #9960: Pulsar 2.6.1: Bookie GarbageCollectorThread does not execute major or minor compaction as scheduled

frankjkelly opened a new issue #9960: URL: https://github.com/apache/pulsar/issues/9960 **Describe the bug** Monitoring the GarbageCollectorThread in the Bookie it is running but although configured to run Major compaction every 2 hours and Minor compaction every 20 minutes neither has

[GitHub] [pulsar] thesquiff commented on issue #9959: Getting function status for function on another broker fails when TLS HTTP endpoints are configured

thesquiff commented on issue #9959: URL: https://github.com/apache/pulsar/issues/9959#issuecomment-801909979 Note, I've also observed the same problem when deleting a function - the delete command must be run from the broker that a function is running on when TLS is enabled.

[GitHub] [pulsar] thesquiff opened a new issue #9959: Getting function status for function on another broker fails when TLS HTTP endpoints are configured

thesquiff opened a new issue #9959: URL: https://github.com/apache/pulsar/issues/9959 Let's say we have a cluster of three brokers, A, B & C. Broker A&B are also configured as functions workers. All brokers are TLS enabled for both https:// and pulsar://. The https endpoint is configured o

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-801891017 rebased This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] Huanli-Meng commented on pull request #9954: [Doc]--Add metrics for producer throttling

Huanli-Meng commented on pull request #9954: URL: https://github.com/apache/pulsar/pull/9954#issuecomment-801875702 @Anonymitaet Thanks for your comments. Updated. PTAL This is an automated message from the Apache Git Service

[GitHub] [pulsar] lhotari commented on issue #9958: [Performance] Optimize allocations in ManagedLedgerImpl.getEarlierReadPositionForActiveCursors()/ManagedCursorContainer.iterator()

lhotari commented on issue #9958: URL: https://github.com/apache/pulsar/issues/9958#issuecomment-801874506 @merlimat would you mind taking a look at this issue? In the stack trace it shows that ConcurrentSkipListMap is used in ManagedCursorContainer. Would there be a benefit to switch over

[GitHub] [pulsar] lhotari opened a new issue #9958: [Performance] Optimize allocations in ManagedLedgerImpl.getEarlierReadPositionForActiveCursors()/ManagedCursorContainer.iterator()

lhotari opened a new issue #9958: URL: https://github.com/apache/pulsar/issues/9958 ### Problem In profiling, I can see that a lot of allocations in TLAB are made for this kind of stack trace: ``` Iterator java.util.concurrent.ConcurrentSkipListMap.entryIterator() Iterator j

[GitHub] [pulsar] lhotari opened a new pull request #9957: [Performance] Omit call to log.debug in hot code path ManagedLedgerImpl.doCacheEviction

lhotari opened a new pull request #9957: URL: https://github.com/apache/pulsar/pull/9957 ### Motivation `log.debug` calls should be omitted on hot code paths. There was a `log.debug` call on the frequently called `ManagedLedgerImpl.doCacheEviction` code path ### Modificatio

[GitHub] [pulsar] codelipenghui commented on a change in pull request #9802: [ISSUE 9783][pulsar-client] avoid create too many HashedWheelTimer instances

codelipenghui commented on a change in pull request #9802: URL: https://github.com/apache/pulsar/pull/9802#discussion_r596734204 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -152,7 +167,12 @@ public PulsarClientImpl(Client

[GitHub] [pulsar] eolivelli commented on issue #9944: Still get red in IntelliJ...

eolivelli commented on issue #9944: URL: https://github.com/apache/pulsar/issues/9944#issuecomment-801796636 sometimes I right-click in the module (in this case is pulsar-common) that I click "rebuild module" in this case "Rebuild module pulsar-common" ---

  1   2   >