jerrypeng commented on issue #9966:
URL: https://github.com/apache/pulsar/issues/9966#issuecomment-802578589
> When an IO connector that implements the BatchPushSource interface wants
to fail a task, it publishes a ErrorNotifierRecord to the internal queue.
However, the exception isn't
linlinnn commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802570291
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jennifer88huang commented on issue #9971:
URL: https://github.com/apache/pulsar/issues/9971#issuecomment-802521717
@tuteng @zymap could you please give some guidance on it? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Jennifer88huang commented on issue #9971:
URL: https://github.com/apache/pulsar/issues/9971#issuecomment-802521476
Related to #8896 #9071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Jennifer88huang opened a new issue #9971:
URL: https://github.com/apache/pulsar/issues/9971
**Describe the bug**
On [admin api
package](http://pulsar.apache.org/docs/en/next/admin-api-namespaces/#create-namespaces)
page, the REST APIs are not displayed correctly.
**To
congbobo184 opened a new pull request #9970:
URL: https://github.com/apache/pulsar/pull/9970
## Motivation
in order to fix autoConsumeSchema deadLetter problem.
fix https://github.com/apache/pulsar/issues/9935
## implement
Add AutoProduceSchema to fix it
### Verifying
david-streamlio commented on pull request #9943:
URL: https://github.com/apache/pulsar/pull/9943#issuecomment-802515276
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
michaeljmarshall commented on pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948#issuecomment-802496056
> If tests run in particular sequence or a module does a retry the static
variables resolve to incorrect values.
@aahmed-se - thanks for the explanation. I hadn't
michaeljmarshall commented on issue #3804:
URL: https://github.com/apache/pulsar/issues/3804#issuecomment-802493258
@eolivelli - thanks, I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
timmyyuan commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597366868
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -26,6 +26,9 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
zymap commented on pull request #9963:
URL: https://github.com/apache/pulsar/pull/9963#issuecomment-802491388
Can we get a copy of the
`dorny/paths-filter@ca8fa4002c226cbab8b50cc157d3f47899a49762` in the
[pulsar-test-infra](https://github.com/apache/pulsar-test-infra)? Because we
still
zymap commented on a change in pull request #9963:
URL: https://github.com/apache/pulsar/pull/9963#discussion_r597364899
##
File path: .github/workflows/ci-cpp.yaml
##
@@ -39,18 +39,18 @@ jobs:
steps:
- name: checkout
uses: actions/checkout@v2
-
linlinnn removed a comment on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802434930
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zymap commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597360890
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -26,6 +26,9 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
tuteng opened a new issue #9969:
URL: https://github.com/apache/pulsar/issues/9969
**Is your feature request related to a problem? Please describe.**
Add the `version` command for the command ./bin/pulsar, ./bin/pulsar-admin,
./bin/pulsar-client etc
**Describe the solution you'd
linlinnn commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r597356277
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##
@@ -131,11 +132,25 @@ public
yitian108 commented on issue #9796:
URL: https://github.com/apache/pulsar/issues/9796#issuecomment-802454825
hi BewareMyPower, I've sent the email to you, please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aahmed-se commented on pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948#issuecomment-802452506
Wrong origin repo will rebuild the pull request here
https://github.com/apache/pulsar/pull/9968
--
This is an automated message from the Apache Git Service.
To respond to
aahmed-se closed pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
aahmed-se opened a new pull request #9968:
URL: https://github.com/apache/pulsar/pull/9968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
aahmed pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 23a7346 Harden RawReaderTest with Awaitility
aahmed-se merged pull request #9965:
URL: https://github.com/apache/pulsar/pull/9965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
merlimat commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802436424
@linlinnn Can you take a look at my last comment
(https://github.com/apache/pulsar/pull/9802/files#r597025305) We should only
add 1 new constructor instead of 3.
--
This is
linlinnn commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-802434930
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dlg99 commented on a change in pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#discussion_r597338047
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaSinkTaskContext.java
##
@@ -0,0 +1,212 @@
+/**
+
dlg99 commented on a change in pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#discussion_r597335899
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaConnectSinkConfig.java
##
@@ -0,0 +1,100 @@
+/**
timmyyuan commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597335499
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -25,6 +25,7 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
merlimat commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597333531
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -25,6 +25,7 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
timmyyuan commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597331408
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -25,6 +25,7 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
merlimat commented on issue #9950:
URL: https://github.com/apache/pulsar/issues/9950#issuecomment-802404428
If you have a patch, please submit :)
One other way, would be to use instead https://github.com/google/crc32c,
although it would be preferable not to add additional compile
dlg99 commented on a change in pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#discussion_r597323899
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java
##
@@ -0,0 +1,277 @@
+/**
+ * Licensed
dlg99 commented on a change in pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#discussion_r597269231
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java
##
@@ -0,0 +1,277 @@
+/**
+ * Licensed
Anonymitaet commented on pull request #9903:
URL: https://github.com/apache/pulsar/pull/9903#issuecomment-802389191
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Anonymitaet commented on pull request #9951:
URL: https://github.com/apache/pulsar/pull/9951#issuecomment-802384342
> @codelipenghui thanks! How about adding the consequence of using DQL for
ordered subscription type (as below)?
>
> > **Note**
> > Using the dead letter topic on
gmethvin commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-802384279
@codelipenghui @315157973 responded to your comments.
I get that the implementation for this is a little weird, so let me know if
you have any other suggestions to
gmethvin commented on a change in pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#discussion_r597308379
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java
##
@@ -18,17 +18,11 @@
*/
package
gmethvin commented on a change in pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#discussion_r597305928
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java
##
@@ -27,15 +27,22 @@
import
rdhabalia opened a new pull request #9967:
URL: https://github.com/apache/pulsar/pull/9967
### Motivation
one of the Implementations of #9646 . Remove direct ZooKeeper dependency
from discovery-service and replace with metadata-store. Rename
`ZookeeperCacheLoader` to
david-streamlio commented on a change in pull request #9943:
URL: https://github.com/apache/pulsar/pull/9943#discussion_r597289828
##
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##
@@ -736,8 +737,14 @@
david-streamlio opened a new issue #9966:
URL: https://github.com/apache/pulsar/issues/9966
**Is your enhancement request related to a problem? Please describe.**
When an IO connector that implements the BatchPushSource interface wants to
fail a task, it publishes a
This is an automated email from the ASF dual-hosted git repository.
jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new a4ca8f4 Revert "[fix #9851] Add
jerrypeng merged pull request #9945:
URL: https://github.com/apache/pulsar/pull/9945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
dlg99 commented on a change in pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#discussion_r597269231
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java
##
@@ -0,0 +1,277 @@
+/**
+ * Licensed
eolivelli commented on pull request #9965:
URL: https://github.com/apache/pulsar/pull/9965#issuecomment-802290435
We can merge as soon as CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
david-streamlio commented on pull request #9943:
URL: https://github.com/apache/pulsar/pull/9943#issuecomment-802258216
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
KannarFr commented on pull request #7523:
URL: https://github.com/apache/pulsar/pull/7523#issuecomment-802244383
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aahmed-se commented on a change in pull request #9965:
URL: https://github.com/apache/pulsar/pull/9965#discussion_r597197327
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java
##
@@ -357,14 +359,14 @@ public void
lhotari commented on a change in pull request #9965:
URL: https://github.com/apache/pulsar/pull/9965#discussion_r597187494
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java
##
@@ -357,14 +359,14 @@ public void
jerrypeng edited a comment on pull request #9945:
URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802166287
@freeznet first of all thank you for looking into a solution for an existing
issue. There definitely was a bug in the framework involving setting messaging
properties.
sijia-w commented on pull request #9903:
URL: https://github.com/apache/pulsar/pull/9903#issuecomment-802218574
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aahmed-se opened a new pull request #9965:
URL: https://github.com/apache/pulsar/pull/9965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
jianyun8023 opened a new issue #9964:
URL: https://github.com/apache/pulsar/issues/9964
**Describe the bug**
Writing`schemaInfo#properties` may cause the client not to consume it when
it is a Pulsar native type.
**To Reproduce**
Write `key` to `SchemaInfo#properties` has
lhotari removed a comment on pull request #9934:
URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
lhotari commented on pull request #9934:
URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182861
Good work @congbobo184 . Thanks for addressing the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lhotari commented on pull request #9934:
URL: https://github.com/apache/pulsar/pull/9934#issuecomment-802182626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
jerrypeng commented on pull request #9945:
URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802166287
@freeznet first of all thank you for looking into a solution for an existing
issue. There definitely was a bug in the framework involving setting messaging
properties.
lhotari commented on pull request #9963:
URL: https://github.com/apache/pulsar/pull/9963#issuecomment-802153303
For this solution it is necessary to get
`dorny/paths-filter@ca8fa4002c226cbab8b50cc157d3f47899a49762` whitelisted in
the Apache GitHub Actions solution by opening an ASF INFRA
lhotari opened a new pull request #9963:
URL: https://github.com/apache/pulsar/pull/9963
### Motivation
[Mailing list
discussion](https://lists.apache.org/thread.html/r8a72efa166bbb2dad660d958e138139c0cd25041eddfd52705f0de11%40%3Cdev.pulsar.apache.org%3E)
In GitHub Actions,
dlg99 commented on a change in pull request #9947:
URL: https://github.com/apache/pulsar/pull/9947#discussion_r597091861
##
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarRecord.java
##
@@ -61,6 +61,11 @@
return
dlg99 commented on a change in pull request #9947:
URL: https://github.com/apache/pulsar/pull/9947#discussion_r597091399
##
File path:
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java
##
@@ -178,6 +178,11 @@ public KafkaRecord(ConsumerRecord
lhotari commented on pull request #9957:
URL: https://github.com/apache/pulsar/pull/9957#issuecomment-802143914
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch prometheusMtest
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 8e34089 Cleanup up PromethuesMetricsTest
add bbcd036 Apply suggestions from code review
No new
merlimat commented on a change in pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948#discussion_r597045208
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
##
@@ -77,6 +77,7 @@
@Override
protected
merlimat commented on a change in pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961#discussion_r597027909
##
File path: pulsar-client-cpp/docker/build-wheels.sh
##
@@ -25,6 +25,7 @@
BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"
david-streamlio commented on issue #9926:
URL: https://github.com/apache/pulsar/issues/9926#issuecomment-802056281
> Looks like a duplicate of #9851
You are correct. However, there is an on going discussion w.r.t to the
solution to this issue so I will keep this open for now for
merlimat commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r597025305
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##
@@ -131,11 +132,25 @@ public
lhotari commented on pull request #9957:
URL: https://github.com/apache/pulsar/pull/9957#issuecomment-802053510
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
merlimat commented on pull request #9945:
URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802049890
@freeznet
> if a source connector is maintained by another orgs or devs, and it
passes Record with properties that user doesn't need, I think it would be less
painful
adg25 commented on issue #9922:
URL: https://github.com/apache/pulsar/issues/9922#issuecomment-802037396
Yes that worked for me as well! MessageToJsonString will not work for what I
need here
--
This is an automated message from the Apache Git Service.
To respond to the message, please
david-streamlio commented on pull request #9945:
URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802024987
> I do think the tests written as part of
>
> https://github.com/apache/pulsar/pull/9907/files
>
> we should still keep.
FYI, I have
michaeljmarshall opened a new issue #9962:
URL: https://github.com/apache/pulsar/issues/9962
**Problem**
From my testing and reading through of the code, when a topic with segments
in tiered storage and on bookies is deleted, the data on the bookies eventually
gets deleted (because the
eolivelli merged pull request #9954:
URL: https://github.com/apache/pulsar/pull/9954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
thesquiff edited a comment on issue #9926:
URL: https://github.com/apache/pulsar/issues/9926#issuecomment-801981042
Looks like a duplicate of #9851
This is an automated message from the Apache Git Service.
To respond to the
thesquiff commented on issue #9926:
URL: https://github.com/apache/pulsar/issues/9926#issuecomment-801981042
Looks like a duplicate of [https://github.com/apache/pulsar/issues/9851]
This is an automated message from the
linlinnn commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801976838
@codelipenghui @eolivelli @merlimat many thanks for your comments.
This is an automated message from the
linlinnn commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r596926653
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##
@@ -152,7 +167,12 @@ public
timmyyuan opened a new pull request #9961:
URL: https://github.com/apache/pulsar/pull/9961
Motivation
The current build process is broken by the wrong root dir. The same mistake
that occurred in RPM build has been fixed by #9890 but it hasn't been fixed in
python-client build.
This is an automated email from the ASF dual-hosted git repository.
hjf pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 7d3317e [CI] Fix Transaction flaky test. (#9934)
add ac1a03c Support DLQ in key_shared sub mode (#9951)
No new
Jennifer88huang merged pull request #9951:
URL: https://github.com/apache/pulsar/pull/9951
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jennifer88huang commented on pull request #9951:
URL: https://github.com/apache/pulsar/pull/9951#issuecomment-801941615
@Huanli-Meng when you submit a PR, could you please add the labels
accordingly? Thank you.
This is an
GPrabhudas opened a new issue #489:
URL: https://github.com/apache/pulsar-client-go/issues/489
### Description:
Failing to connect to broker because cert verification fails with error:
`x509: cannot validate certificate for xxx.xxx.xxx.xxx because it doesn't
contain any IP SANs`
frankjkelly opened a new issue #9960:
URL: https://github.com/apache/pulsar/issues/9960
**Describe the bug**
Monitoring the GarbageCollectorThread in the Bookie it is running but
although configured to run Major compaction every 2 hours and Minor compaction
every 20 minutes neither has
thesquiff commented on issue #9959:
URL: https://github.com/apache/pulsar/issues/9959#issuecomment-801909979
Note, I've also observed the same problem when deleting a function - the
delete command must be run from the broker that a function is running on when
TLS is enabled.
thesquiff opened a new issue #9959:
URL: https://github.com/apache/pulsar/issues/9959
Let's say we have a cluster of three brokers, A, B & C. Broker A are also
configured as functions workers. All brokers are TLS enabled for both https://
and pulsar://. The https endpoint is configured on
KannarFr commented on pull request #7523:
URL: https://github.com/apache/pulsar/pull/7523#issuecomment-801891017
rebased
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Huanli-Meng commented on pull request #9954:
URL: https://github.com/apache/pulsar/pull/9954#issuecomment-801875702
@Anonymitaet Thanks for your comments. Updated. PTAL
This is an automated message from the Apache Git
lhotari commented on issue #9958:
URL: https://github.com/apache/pulsar/issues/9958#issuecomment-801874506
@merlimat would you mind taking a look at this issue? In the stack trace it
shows that ConcurrentSkipListMap is used in ManagedCursorContainer. Would there
be a benefit to switch
lhotari opened a new issue #9958:
URL: https://github.com/apache/pulsar/issues/9958
### Problem
In profiling, I can see that a lot of allocations in TLAB are made for this
kind of stack trace:
```
Iterator java.util.concurrent.ConcurrentSkipListMap.entryIterator()
Iterator
lhotari opened a new pull request #9957:
URL: https://github.com/apache/pulsar/pull/9957
### Motivation
`log.debug` calls should be omitted on hot code paths. There was a
`log.debug` call on the frequently called
`ManagedLedgerImpl.doCacheEviction` code path
###
codelipenghui commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r596734204
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##
@@ -152,7 +167,12 @@ public
eolivelli commented on issue #9944:
URL: https://github.com/apache/pulsar/issues/9944#issuecomment-801796636
sometimes I right-click in the module (in this case is pulsar-common) that I
click "rebuild module"
in this case "Rebuild module pulsar-common"
eolivelli commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801794367
@codelipenghui I agree!
we can merge this patch as soon as CI passes
thank you @linlinnn
This
codelipenghui commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801790866
@eolivelli We should consider the author’s feelings in the community, this
PR is opened 14 days ago, @linlinnn is a very new contributor in the community,
we can narrow
eolivelli commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801786495
IMHO we can make the change to the PulsarProxy in this patch.
it won't be a big addition and the patch will stay enough little to be
reviewed carefully.
but it is a
codelipenghui commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801782209
@eolivelli Yes, so this PR is trying to allow pass the external timer to the
client, we can fix the proxy side in a separate PR? @linlinnn I think we can
update the
eolivelli commented on a change in pull request #9947:
URL: https://github.com/apache/pulsar/pull/9947#discussion_r596686252
##
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/AbstractKafkaConnectSource.java
##
@@ -183,13 +183,16 @@
pointearth commented on issue #6930:
URL: https://github.com/apache/pulsar/issues/6930#issuecomment-801764807
Can we store it in bookKeeper? and it may be able to start when the presto
enhancement switching is open.
This is
pointearth commented on issue #6930:
URL: https://github.com/apache/pulsar/issues/6930#issuecomment-801761819
I know querying with timestamp is very fast, because data in bookKeeper save
timestamp as key.
My suggestion is to create a non-clustered index, based on the key in
bookKeeper,
eolivelli commented on pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#issuecomment-801760737
@codelipenghui @linlinnn
@merlimat comment is
> Instead, we could take a Timer instance from the PulsarClientImpl
constructor and have the Pulsar proxy to pass it there.
Anonymitaet commented on pull request #9903:
URL: https://github.com/apache/pulsar/pull/9903#issuecomment-801759547
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 128 matches
Mail list logo
