liangyepianzhou commented on code in PR #21406:
URL: https://github.com/apache/pulsar/pull/21406#discussion_r1690902221
##
pulsar-broker/pom.xml:
##
@@ -507,6 +507,12 @@
pulsar-package-filesystem-storage
${project.version}
+
+ org.powermock
+
crossoverJie commented on code in PR #1255:
URL: https://github.com/apache/pulsar-client-go/pull/1255#discussion_r1690889316
##
pulsar/client_impl.go:
##
@@ -66,8 +66,10 @@ func newClient(options ClientOptions) (Client, error) {
if connectionMaxIdleTime == 0 {
crossoverJie closed pull request #1255: fix: Connection use minConnMaxIdleTime
URL: https://github.com/apache/pulsar-client-go/pull/1255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
BewareMyPower commented on code in PR #21406:
URL: https://github.com/apache/pulsar/pull/21406#discussion_r1690841326
##
pulsar-broker/pom.xml:
##
@@ -507,6 +507,12 @@
pulsar-package-filesystem-storage
${project.version}
+
+ org.powermock
+
nodece opened a new pull request, #1256:
URL: https://github.com/apache/pulsar-client-go/pull/1256
### Motivation
We are using `time.Sleep` and `for` to execute the retry, which cannot be
interrupted, this PR will use context and timer to improve this behavior.
The next
gaoran10 commented on code in PR #23072:
URL: https://github.com/apache/pulsar/pull/23072#discussion_r1690830218
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##
@@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck
ack) {
gaoran10 commented on code in PR #23074:
URL: https://github.com/apache/pulsar/pull/23074#discussion_r1690767523
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##
@@ -1320,6 +1320,13 @@ protected void handleSubscribe(final CommandSubscribe
RobertIndie commented on PR #1254:
URL:
https://github.com/apache/pulsar-client-go/pull/1254#issuecomment-2249342477
There are still some lint issues. If you are using macos or linux, you can
run [`make
RobertIndie commented on code in PR #1255:
URL: https://github.com/apache/pulsar-client-go/pull/1255#discussion_r1690764848
##
pulsar/client_impl.go:
##
@@ -66,8 +66,10 @@ func newClient(options ClientOptions) (Client, error) {
if connectionMaxIdleTime == 0 {
BewareMyPower commented on code in PR #23075:
URL: https://github.com/apache/pulsar/pull/23075#discussion_r1690756510
##
pip/pip-368.md:
##
@@ -0,0 +1,148 @@
+# PIP-368: Support client properties for the lookup
+
+# Background knowledge
+
+## How Pulsar Lookup Works
+
+Before
RobertIndie opened a new pull request, #23075:
URL: https://github.com/apache/pulsar/pull/23075
### Motivation
Currently, the lookup process uses only the topic name as its parameter.
However, to enhance this process, it's
beneficial for clients to provide additional
github-actions[bot] commented on PR #23075:
URL: https://github.com/apache/pulsar/pull/23075#issuecomment-2249273364
@RobertIndie Please add the following content to your PR description and
select a checkbox:
```
- [ ] `doc`
- [ ] `doc-required`
- [ ] `doc-not-needed`
- [
hangc0276 merged PR #23044:
URL: https://github.com/apache/pulsar/pull/23044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
poorbarcode commented on code in PR #23033:
URL: https://github.com/apache/pulsar/pull/23033#discussion_r1690627466
##
pip/pip-366.md:
##
@@ -0,0 +1,70 @@
+# PIP-366: Support to specify different config for Configuration and Local
Metadata Store
+
+# Background knowledge
+
GitHub user adparts edited a discussion: How to enable server publish time on
messages?
Hi all,
The Message class, has the following method:
`Optional getBrokerPublishTime()`
Get broker publish time from broker entry metadata.
**Note that only if the feature is enabled in the broker then
heesung-sn merged PR #23064:
URL: https://github.com/apache/pulsar/pull/23064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
heesung-sn commented on code in PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#discussion_r1690153125
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -2250,6 +2250,15 @@ private CompletableFuture
heesung-sn closed pull request #23064: [fix][broker] Do not try to clean owned
bundles from inactive source brokers (ExtensibleLoadManagerImpl only)
URL: https://github.com/apache/pulsar/pull/23064
--
This is an automated message from the Apache Git Service.
To respond to the message, please
AuroraTwinkle commented on issue #23067:
URL: https://github.com/apache/pulsar/issues/23067#issuecomment-2248260663
> solved already. check https://github.com/apache/pulsar/pull/21623
This is just a readme doc comment, but do nothing about pip 307.
--
This is an automated message
codecov-commenter commented on PR #23072:
URL: https://github.com/apache/pulsar/pull/23072#issuecomment-2248244409
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23072?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
geniusjoe commented on issue #1238:
URL:
https://github.com/apache/pulsar-client-go/issues/1238#issuecomment-2248220725
> Currently, Pulsar clients only support the client_credentials
authentication type. The authentication type determines how to obtain an access
token through an OAuth
hechen0 commented on issue #23067:
URL: https://github.com/apache/pulsar/issues/23067#issuecomment-2248165784
solved already. check https://github.com/apache/pulsar/pull/21623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shibd opened a new pull request, #23072:
URL: https://github.com/apache/pulsar/pull/23072
### Motivation
If a subscription has many consumers and each consumer individually
acknowledges messages from other consumers, this scenario is very CPU
resource-intensive.
Refer this:
robertdumitrescu opened a new issue, #512:
URL: https://github.com/apache/pulsar-helm-chart/issues/512
**Describe the bug**
The Pulsar Helm chart fails to initialize the pulsar-manager-init pod when
the existingSecret feature is used. The initialization process gets stuck,
preventing
dao-jun merged PR #23070:
URL: https://github.com/apache/pulsar/pull/23070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dao-jun commented on PR #23070:
URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247627792
merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
RobertIndie commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247617825
> @RobertIndie
>
> So the linting succeeded this time.
>
> Do you know what the process is when this is merged in on how the updated
go package is applied to
RobertIndie merged PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #23070:
URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247557250
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23070?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
thetumbled opened a new pull request, #23071:
URL: https://github.com/apache/pulsar/pull/23071
### Motivation
Message deduplication feature has been introduced into Pulsar long time ago,
but the concrete problem it solve is vague.
The info i can get from the official document is
Jeff-Tian commented on issue #101:
URL:
https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-2247502760
Never mind, I can use the following instead:
```csharp
await using var client = PulsarClient.Builder()
.Authentication(AuthenticationFactory.Token(
Jeff-Tian commented on issue #101:
URL:
https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-2247466922
I used 3.3.1 and still can't see that method, see:
https://github.com/user-attachments/assets/4d6eae81-ecca-4f1a-b3bd-ad93b48e97d5;>
--
This is an automated
nodece merged PR #1249:
URL: https://github.com/apache/pulsar-client-go/pull/1249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nodece closed issue #1190: [BUG] The process will block if close client or
producer when pulsar server is down.
URL: https://github.com/apache/pulsar-client-go/issues/1190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gunli commented on PR #1249:
URL:
https://github.com/apache/pulsar-client-go/pull/1249#issuecomment-2247365823
This PR may be related to issue #1190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nodece commented on PR #23070:
URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247325654
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Demogorgon314 commented on code in PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#discussion_r1689368480
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -2250,6 +2250,15 @@ private CompletableFuture
github-actions[bot] commented on PR #23070:
URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247188920
@dao-jun Please add the following content to your PR description and select
a checkbox:
```
- [ ] `doc`
- [ ] `doc-required`
- [ ] `doc-not-needed`
- [ ]
dao-jun closed pull request #23070: [fix] Fix compile failing
URL: https://github.com/apache/pulsar/pull/23070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dao-jun opened a new pull request, #23070:
URL: https://github.com/apache/pulsar/pull/23070
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
### Motivation
### Modifications
### Verifying this change
- [
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247116184
@RobertIndie
So the linting succeeded this time.
Do you know what the process is when this is merged in on how the updated go
package is applied to the
hangc0276 commented on code in PR #23044:
URL: https://github.com/apache/pulsar/pull/23044#discussion_r1689281963
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java:
##
@@ -263,33 +273,42 @@ public void testBrokerMetrics() throws Exception
nodece commented on code in PR #1249:
URL: https://github.com/apache/pulsar-client-go/pull/1249#discussion_r1689235363
##
pulsar/producer_partition.go:
##
@@ -464,77 +469,82 @@ func (p *partitionProducer)
reconnectToBroker(connectionClosed *connectionClosed
)
dao-jun merged PR #22735:
URL: https://github.com/apache/pulsar/pull/22735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #23068:
URL: https://github.com/apache/pulsar/pull/23068#issuecomment-2246988214
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23068?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
heesung-sn commented on PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#issuecomment-2246801022
It would be great if the community starts testing/improving
ExtensibleLoadManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
liyinxin commented on issue #19568:
URL: https://github.com/apache/pulsar/issues/19568#issuecomment-2246775094
ok, thanks, we will try it to avoid resending message in exception block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
thetumbled commented on PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#issuecomment-2246765218
> > I prefer to introduce AvgShedder into new load manager first, WDYT?
>
> You meant the modular load manager here?
>
> Yes, AvgShedder is improvement in modular load
heesung-sn commented on PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#issuecomment-2246756366
> I prefer to introduce AvgShedder into new load manager first, WDYT?
You meant the modular load manager here?
Yes, AvgShedder is improvement in modular load manager,
thetumbled commented on PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#issuecomment-2246741963
> > And i notice that TransferShedder use historical weight algorithm too,
which may introduce the same problem as i analyze in the doc.
>
> I assume you refer to this part.
thetumbled commented on issue #19568:
URL: https://github.com/apache/pulsar/issues/19568#issuecomment-2246725793
> Hello, I've also encountered this issue recently. May I ask if you have
resolved it?
We don't solve this problem, but avoid resending message in exception block.
--
thetumbled commented on issue #19568:
URL: https://github.com/apache/pulsar/issues/19568#issuecomment-2246724291
> Hello, I've also encountered this issue recently. May I ask if you have
resolved it?
Refer to https://github.com/apache/bookkeeper/issues/4457
crossoverJie commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1689015955
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -284,10 +285,11 @@ public class BrokerService implements Closeable {
crossoverJie commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1689016137
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##
@@ -133,10 +135,17 @@ public
dao-jun commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1689014112
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -284,10 +285,11 @@ public class BrokerService implements Closeable {
dao-jun commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1689010471
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##
@@ -133,10 +135,17 @@ public
dave2wave commented on PR #23061:
URL: https://github.com/apache/pulsar/pull/23061#issuecomment-2246472836
Using a website building repository template as the basis for this effort is
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rdhabalia opened a new pull request, #23068:
URL: https://github.com/apache/pulsar/pull/23068
### Motivation
Currently if Pulsar-client fails to decrypt batch-message and if
CrypotFailureAction is configured as `Discard` then after a while consumer at
client side runs out of permit
heesung-sn merged PR #23035:
URL: https://github.com/apache/pulsar/pull/23035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
heesung-sn commented on PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#issuecomment-2245922133
> And i notice that TransferShedder use historical weight algorithm too,
which may introduce the same problem as i analyze in the doc.
I assume you refer to this part.
heesung-sn commented on code in PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#discussion_r1688439130
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##
@@ -993,5 +997,26 @@ public void disableBroker()
dragosvictor commented on code in PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#discussion_r1688435826
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##
@@ -993,5 +997,26 @@ public void
heesung-sn commented on PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#issuecomment-2245786747
> Should this not be cherry-picked to 3.1 too?
Sure. I can push it there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dragosvictor commented on PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#issuecomment-2245774979
Should this not be cherry-picked to 3.1 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gunli commented on code in PR #1249:
URL: https://github.com/apache/pulsar-client-go/pull/1249#discussion_r1688357401
##
pulsar/producer_partition.go:
##
@@ -464,77 +469,82 @@ func (p *partitionProducer)
reconnectToBroker(connectionClosed *connectionClosed
)
klevy-toast commented on PR #1254:
URL:
https://github.com/apache/pulsar-client-go/pull/1254#issuecomment-2245615912
Thanks, fixed @RobertIndie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gunli commented on PR #1249:
URL:
https://github.com/apache/pulsar-client-go/pull/1249#issuecomment-2245565450
Good job, but I think it can be better, my idea is:
1. add mutex and cancelfunc to producer
```go
type partitionProducer struct {
reconnectMutex sync.Mutex
nodece commented on PR #1249:
URL:
https://github.com/apache/pulsar-client-go/pull/1249#issuecomment-2245447407
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
crossoverJie opened a new pull request, #1255:
URL: https://github.com/apache/pulsar-client-go/pull/1255
### Motivation
Keep consistent with [Java
liyinxin commented on issue #19568:
URL: https://github.com/apache/pulsar/issues/19568#issuecomment-2245363794
Hello, I've also encountered this issue recently. May I ask if you have
resolved it?
--
This is an automated message from the Apache Git Service.
To respond to the message,
BewareMyPower closed pull request #21272: [improve][txn] Apply table view in
the transaction buffer snapshot
URL: https://github.com/apache/pulsar/pull/21272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
BewareMyPower commented on PR #21272:
URL: https://github.com/apache/pulsar/pull/21272#issuecomment-2245338491
Close this PR by https://github.com/apache/pulsar/pull/23062, which applies
the similar solution.
--
This is an automated message from the Apache Git Service.
To respond to the
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2245162447
> > @RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
>
> @Nikolajls There are still lint issues. BTW, you can run `make lint` to
RobertIndie commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2245151605
> @RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
@Nikolajls There are still lint issues. BTW, you can run `make lint` to
check
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2244988150
@RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message,
Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687509325
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret
RobertIndie commented on PR #1254:
URL:
https://github.com/apache/pulsar-client-go/pull/1254#issuecomment-2244957135
Please take a look at this compilation error:
https://github.com/apache/pulsar-client-go/actions/runs/10045685387/job/27779892242?pr=1254#step:5:30
```
Error:
RobertIndie commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687870287
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
BewareMyPower commented on PR #23062:
URL: https://github.com/apache/pulsar/pull/23062#issuecomment-2244798112
Mark it as draft to avoid repeated creation of reader. It's better to
maintain a long live reader.
--
This is an automated message from the Apache Git Service.
To respond to the
GitHub user antliu2012 edited a comment on the discussion: Environmental
variables loss
你的意思是说pulsar worker是这样运行nar文件的对吗？那我怎么在``bin/pulsar source create``的时候指定环境变量呢？
You mean this is how pulsar worker runs nar files right? And how do I specify
the environment variables in ``bin/pulsar source
GitHub user antliu2012 closed the discussion with a comment: Environmental
variables loss
你的意思是说pulsar worker是这样运行nar文件的对吗？那我怎么在``source create``的时候指定环境变量呢？
You mean this is how pulsar worker runs nar files right? And how do I specify
the environment variables in ``source create``?
GitHub
BewareMyPower commented on PR #23062:
URL: https://github.com/apache/pulsar/pull/23062#issuecomment-2244764499
This improvement for the reader side can be verified by the following
example.
```java
public class LoadTopicTest extends ProducerConsumerBase {
@BeforeClass
GitHub user crossoverJie added a comment to the discussion: I am getting
following error w.r.t. opentelemetery(current version is 1.26) after updating
the pulsar version to 3.3.0. Please suggest which version of opentelemetery
should i update as i have tried for 1.28 but it is still not
GitHub user shoothzj closed the discussion with a comment: Environmental
variables loss
`export XX=YY; java -jar xxx.jar`
GitHub link:
https://github.com/apache/pulsar/discussions/23066#discussioncomment-10124354
This is an automatically sent email for commits@pulsar.apache.org.
To
GitHub user antliu2012 closed a discussion: Environmental variables loss
Hi , all
I’ve wrote a source connector and a sink connector (both of them has packaged
into nar file) ,
when I run these 2 connectors on pulsar standalone mode (bin/pulsar
standalone), the connectors works fine ,
But
thetumbled commented on code in PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#discussion_r1687745021
##
pip/pip-364.md:
##
@@ -0,0 +1,476 @@
+
+# PIP-364: Introduce a new load balance algorithm AvgShedder
+
+# Background knowledge
+
+Pulsar has two load balance
GitHub user antliu2012 added a comment to the discussion: Environmental
variables loss
Yes, you're right. I've checked the /proc/$pid/environ file just now , these is
no Environmental variables I need .
So, how can I setting/enable these environmental variables when I commit
function?
GitHub user shoothzj added a comment to the discussion: Environmental variables
loss
hello, @antliu2012 I think `/etc/profile` only works in bash conversation
instead of running programs. Would you mind check it from `/proc/$pid/environ`
GitHub link:
AuroraTwinkle opened a new issue, #23067:
URL: https://github.com/apache/pulsar/issues/23067
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### What issue do you find in Pulsar docs?
I
liangyepianzhou commented on PR #21406:
URL: https://github.com/apache/pulsar/pull/21406#issuecomment-2244589450
@codelipenghui @poorbarcode Could you please take a look when you have time?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
crossoverJie commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1687642455
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##
@@ -133,10 +135,17 @@ public
hangc0276 commented on code in PR #22946:
URL: https://github.com/apache/pulsar/pull/22946#discussion_r1687515313
##
pip/pip-364.md:
##
@@ -0,0 +1,476 @@
+
+# PIP-364: Introduce a new load balance algorithm AvgShedder
+
+# Background knowledge
+
+Pulsar has two load balance
Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687509325
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret
horizonzy commented on code in PR #23044:
URL: https://github.com/apache/pulsar/pull/23044#discussion_r1687413352
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java:
##
@@ -263,33 +273,42 @@ public void testBrokerMetrics() throws Exception
horizonzy commented on code in PR #23044:
URL: https://github.com/apache/pulsar/pull/23044#discussion_r1687413352
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java:
##
@@ -263,33 +273,42 @@ public void testBrokerMetrics() throws Exception
BewareMyPower commented on PR #23062:
URL: https://github.com/apache/pulsar/pull/23062#issuecomment-2244239245
Let me fix the failed tests first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov-commenter commented on PR #23060:
URL: https://github.com/apache/pulsar/pull/23060#issuecomment-2244194181
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23060?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
hangc0276 commented on PR #23044:
URL: https://github.com/apache/pulsar/pull/23044#issuecomment-2244192013
> LGTM, do we need a PIP for this ?
@Technoboy- It doesn't change any interface or configurations, and I think
we do not need a PIP
--
This is an automated message from the
Demogorgon314 commented on code in PR #23033:
URL: https://github.com/apache/pulsar/pull/23033#discussion_r1687378476
##
pip/pip-366.md:
##
@@ -0,0 +1,70 @@
+# PIP-366: Support to specify different config for Configuration and Local
Metadata Store
+
+# Background knowledge
+
nodece commented on code in PR #23038:
URL: https://github.com/apache/pulsar/pull/23038#discussion_r1687368123
##
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java:
##
@@ -130,6 +134,50 @@ public void testClientVersion() throws Exception {
}
201 - 300 of 32918 matches
Mail list logo
