[GitHub] [incubator-tvm] liangfu commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

liangfu commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-574013028 This is a favorable feature, since there could be more than one operator with the given

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra

zhiics commented on a change in pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra URL: https://github.com/apache/incubator-tvm/pull/4702#discussion_r366149219 ## File path: include/tvm/relay/transform.h ## @@ -19,320 +19,32 @@ /*! * \file

[GitHub] [incubator-tvm] tqchen commented on issue #4701: [REFACTOR][IR] Move error.h into ir

tqchen commented on issue #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#issuecomment-573991951 thanks @zhiics This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] yzhliu edited a comment on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

yzhliu edited a comment on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-573985733 @tqchen updated per comments. do you think there could be a better name than `shape_var`?

[GitHub] [incubator-tvm] yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-573985733 @tqchen updated per comments. do you think there could be a better name than `shape_var`? @icemelon9

[GitHub] [incubator-tvm] rumusan commented on issue #1204: Getting a crash on a MacBook Pro 13' with Intel GPU

rumusan commented on issue #1204: Getting a crash on a MacBook Pro 13' with Intel GPU URL: https://github.com/apache/incubator-tvm/issues/1204#issuecomment-573985454 hi @acostin1 can u give some tips how to install tvm in macbook? thanks.

[GitHub] [incubator-tvm] zhiics commented on issue #4570: [relay] Relay annotation and partitioning for external compilers

zhiics commented on issue #4570: [relay] Relay annotation and partitioning for external compilers URL: https://github.com/apache/incubator-tvm/pull/4570#issuecomment-573980033 @tqchen We removed the annotation part, any other outstanding concerns?

[GitHub] [incubator-tvm] zhiics closed issue #4697: [Relay] VM prunes global functions with no direct calls.

zhiics closed issue #4697: [Relay] VM prunes global functions with no direct calls. URL: https://github.com/apache/incubator-tvm/issues/4697 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] wweic merged pull request #4700: [Fix] Fix RemoveUnusedFunctions pass

wweic merged pull request #4700: [Fix] Fix RemoveUnusedFunctions pass URL: https://github.com/apache/incubator-tvm/pull/4700 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-tvm] branch master updated (c69092a -> 5699637)

This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from c69092a [REFACTOR][IR] Unified IR IRModule structure. (#4699) add 5699637 [VTA] Fix an issue in

[GitHub] [incubator-tvm] tmoreau89 merged pull request #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module

tmoreau89 merged pull request #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module URL: https://github.com/apache/incubator-tvm/pull/4694 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] liangfu commented on issue #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module

liangfu commented on issue #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module URL: https://github.com/apache/incubator-tvm/pull/4694#issuecomment-573967105 > Can you explain why m.run() must be used instead of time_evaluator to generate the correct prediction result?

[GitHub] [incubator-tvm] huajsj commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

huajsj commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-573966672 @tmoreau89 could you help for a review? Thanks.

[GitHub] [incubator-tvm] huajsj opened a new pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

huajsj opened a new pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703 [Issue] Current vta use 'start' and 'stop' name to define the pack start point and end point, but

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir

tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#discussion_r366118128 ## File path: include/tvm/ir/error.h ## @@ -18,62 +18,79 @@ */ /*! - * \file error.h - * \brief The

[GitHub] [incubator-tvm] tqchen opened a new pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra

tqchen opened a new pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra URL: https://github.com/apache/incubator-tvm/pull/4702 Move the relay's pass Infra to ir. Keep FunctionPass in relay as it is local to the dialect. depends on

[GitHub] [incubator-tvm] tqchen commented on issue #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra

tqchen commented on issue #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra URL: https://github.com/apache/incubator-tvm/pull/4702#issuecomment-573960469 cc @zhiics @yzhliu @jroesch This is an automated message from the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir

tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#discussion_r366118128 ## File path: include/tvm/ir/error.h ## @@ -18,62 +18,79 @@ */ /*! - * \file error.h - * \brief The

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir

tqchen commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#discussion_r366118128 ## File path: include/tvm/ir/error.h ## @@ -18,62 +18,79 @@ */ /*! - * \file error.h - * \brief The

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r366114637 ## File path: src/arithmetic/bound_deducer.cc ## @@ -297,6 +331,18

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir

zhiics commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#discussion_r366109844 ## File path: include/tvm/ir/error.h ## @@ -18,62 +18,79 @@ */ /*! - * \file error.h - * \brief The

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir

zhiics commented on a change in pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701#discussion_r366109844 ## File path: include/tvm/ir/error.h ## @@ -18,62 +18,79 @@ */ /*! - * \file error.h - * \brief The

[GitHub] [incubator-tvm] tqchen opened a new pull request #4701: [REFACTOR][IR] Move error.h into ir

tqchen opened a new pull request #4701: [REFACTOR][IR] Move error.h into ir URL: https://github.com/apache/incubator-tvm/pull/4701 We will use a single ErrorReporter to report errors during program transformations. cc @ZihengJiang @jroesch @zhiics @yzhliu

[incubator-tvm] branch master updated (bd17baa -> c69092a)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bd17baa GitHub Action lint Python code for syntax errors (#4688) add c69092a [REFACTOR][IR] Unified IR

[GitHub] [incubator-tvm] tqchen merged pull request #4699: [REFACTOR][IR] Unified IR IRModule structure.

tqchen merged pull request #4699: [REFACTOR][IR] Unified IR IRModule structure. URL: https://github.com/apache/incubator-tvm/pull/4699 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] zhiics commented on issue #4697: [Relay] VM prunes global functions with no direct calls.

zhiics commented on issue #4697: [Relay] VM prunes global functions with no direct calls. URL: https://github.com/apache/incubator-tvm/issues/4697#issuecomment-573909502 @abergeron #4700 fixes this. This is an automated

[GitHub] [incubator-tvm] zhiics opened a new pull request #4700: [Fix] Fix RemoveUnusedFunctions pass

zhiics opened a new pull request #4700: [Fix] Fix RemoveUnusedFunctions pass URL: https://github.com/apache/incubator-tvm/pull/4700 #4697 cc @abergeron @wweic @icemelon9 This is an automated message from the

[GitHub] [incubator-tvm] tqchen closed issue #4599: [Refactor] Replace relay.vm.Tensor with NDArray

tqchen closed issue #4599: [Refactor] Replace relay.vm.Tensor with NDArray URL: https://github.com/apache/incubator-tvm/issues/4599 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen commented on issue #4599: [Refactor] Replace relay.vm.Tensor with NDArray

tqchen commented on issue #4599: [Refactor] Replace relay.vm.Tensor with NDArray URL: https://github.com/apache/incubator-tvm/issues/4599#issuecomment-573878329 #4643 This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tqchen commented on issue #4699: [REFACTOR][IR] Unified IR IRModule structure.

tqchen commented on issue #4699: [REFACTOR][IR] Unified IR IRModule structure. URL: https://github.com/apache/incubator-tvm/pull/4699#issuecomment-573861736 cc @jroesch @wweic @zhiics @yzhliu @merrymercy This is an automated

[GitHub] [incubator-tvm] ZihengJiang commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards

ZihengJiang commented on issue #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#issuecomment-573861790 for allocate, does tflite runtime removed the `AllocateTensors` API or just EdgeTPU does not need it?

[GitHub] [incubator-tvm] tqchen opened a new pull request #4699: [REFACTOR][IR] Unified IR IRModule structure.

tqchen opened a new pull request #4699: [REFACTOR][IR] Unified IR IRModule structure. URL: https://github.com/apache/incubator-tvm/pull/4699 This PR brings relay::Module as the unified IRModule structure. IRModule will be used as the basic unit for transformations through out the

[GitHub] [incubator-tvm] ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r366016395 ## File path: python/tvm/contrib/tflite_runtime.py ## @@ -50,20 +59,19 @@ class

[GitHub] [incubator-tvm] ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r366016395 ## File path: python/tvm/contrib/tflite_runtime.py ## @@ -50,20 +59,19 @@ class

[GitHub] [incubator-tvm] ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r366016186 ## File path: python/tvm/contrib/tflite_runtime.py ## @@ -18,7 +18,7 @@ from .._ffi.function

[GitHub] [incubator-tvm] tmoreau89 opened a new pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards

tmoreau89 opened a new pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698 This PR extends the TFLite runtime to support edgeTPU-equipped Coral boards in order to measure inference time of models on edgeTPU with TVM RPC.

[GitHub] [incubator-tvm] zhiics commented on issue #4697: [Relay] VM prunes global functions with no direct calls.

zhiics commented on issue #4697: [Relay] VM prunes global functions with no direct calls. URL: https://github.com/apache/incubator-tvm/issues/4697#issuecomment-573835864 @abergeron Thanks for reporting this. There is pass in VM that removes the "unused" global functions. It probably

[GitHub] [incubator-tvm] abergeron opened a new issue #4697: VM prunes global functions with no direct calls.

abergeron opened a new issue #4697: VM prunes global functions with no direct calls. URL: https://github.com/apache/incubator-tvm/issues/4697 It seems there is a problem in the VM compiler for indirect calls to global functions that aren't used elsewhere. I have a simple code block

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365970269 ## File path: src/arithmetic/int_set.cc ## @@ -529,6 +554,22 @@

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365970115 ## File path: src/arithmetic/bound_deducer.cc ## @@ -297,6 +331,18

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365928309 ## File path: src/arithmetic/int_set.cc ## @@ -529,6 +554,22 @@

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365928309 ## File path: src/arithmetic/int_set.cc ## @@ -529,6 +554,22 @@

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365928076 ## File path: src/arithmetic/bound_deducer.cc ## @@ -297,6 +331,18

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

inadob commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695#discussion_r365927427 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -616,6 +621,36 @@ def

[GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

wyc-ruiker commented on a change in pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695#discussion_r365897665 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -616,6 +621,36 @@

[GitHub] [incubator-tvm] inadob opened a new pull request #4696: [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

inadob opened a new pull request #4696: [Relay][Frontend][TFlite] Add support for quantized LOGISTIC URL: https://github.com/apache/incubator-tvm/pull/4696 * add qnn implementation in the parser * add test case for qnn logistic

[GitHub] [incubator-tvm] kevinyuan commented on issue #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module

kevinyuan commented on issue #4694: [VTA] Fix an issue in updating uop_idx in the TensorGemm module URL: https://github.com/apache/incubator-tvm/pull/4694#issuecomment-573733217 Hi @liangfu, With your recommended changes, **tsim** produced the same prediction results as **fsim**.

[GitHub] [incubator-tvm] inadob edited a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators

inadob edited a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573727010 @u99127 @yzhliuso previously, the tests for **logical_and** and **logical_or** were failing because

[GitHub] [incubator-tvm] inadob removed a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators

inadob removed a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573731291 @u99127 This is an automated message

[GitHub] [incubator-tvm] inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators

inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573731291 @u99127 This is an automated message from the

[GitHub] [incubator-tvm] inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators

inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573727010 @yzhliuso previously, the tests for **logical_and** and **logical_or** were failing because of the CI

[GitHub] [incubator-tvm] inadob commented on issue #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

inadob commented on issue #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695#issuecomment-573719645 @anijain2305 @FrozenGene, can you please review this PR

[GitHub] [incubator-tvm] inadob opened a new pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops

inadob opened a new pull request #4695: [Relay][Frontend][TFlite] Add parser support for relational ops URL: https://github.com/apache/incubator-tvm/pull/4695 - Add support for: greater_equal, less, less_equal, equal, not_equal - Add tests for the elemwise relational ops

[GitHub] [incubator-tvm] inadob commented on a change in pull request #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE

inadob commented on a change in pull request #4518: [Bugfix][Frontend][TF] Fix incorrect calculations in tf SLICE URL: https://github.com/apache/incubator-tvm/pull/4518#discussion_r365863059 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -639,7 +639,7 @@ def

[GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference

wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference URL: https://github.com/apache/incubator-tvm/pull/4652#discussion_r365700016 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -628,6 +629,15

[GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference

wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference URL: https://github.com/apache/incubator-tvm/pull/4652#discussion_r365699977 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -723,6

[GitHub] [incubator-tvm] wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference

wyc-ruiker commented on a change in pull request #4652: [Relay][Frontend][TFLite] Add parser support for squared difference URL: https://github.com/apache/incubator-tvm/pull/4652#discussion_r365700077 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -628,6 +629,15