[GitHub] [hadoop] zhengzhuobinzzb commented on pull request #3415: HDFS-16216. RBF: Wrong path when get mount point status

2021-09-14 Thread GitBox
zhengzhuobinzzb commented on pull request #3415: URL: https://github.com/apache/hadoop/pull/3415#issuecomment-919751635 Hi @brahmareddybattula , could you help for review this path in your free time? Thank you -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] tomscut commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-14 Thread GitBox
tomscut commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-919701384 > @tomscut Thanks. > Is Related UT fixed? If it's been fixed, this PR looks good to me. Yes, this related failed UT ```TestRouterRPCClientRetries#testNamenodeMetrics

[GitHub] [hadoop] ferhui commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-14 Thread GitBox
ferhui commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-919696025 @tomscut Thanks. Is Related UT fixed? If it's been fixed, this PR looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Comment Edited] (HADOOP-16254) Add proxy address in IPC connection

2021-09-14 Thread Janus Chow (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415313#comment-17415313 ] Janus Chow edited comment on HADOOP-16254 at 9/15/21, 4:25 AM: --

[jira] [Comment Edited] (HADOOP-16254) Add proxy address in IPC connection

2021-09-14 Thread Janus Chow (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415313#comment-17415313 ] Janus Chow edited comment on HADOOP-16254 at 9/15/21, 4:25 AM: --

[jira] [Commented] (HADOOP-16254) Add proxy address in IPC connection

2021-09-14 Thread Janus Chow (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415313#comment-17415313 ] Janus Chow commented on HADOOP-16254: - [~hexiaoqiao] [~daryn] For the safe concert,

[GitHub] [hadoop] wzhallright edited a comment on pull request #3317: HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN

2021-09-14 Thread GitBox
wzhallright edited a comment on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919656426 > Can you address the checkstyle issue? > > ``` > ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:5

[GitHub] [hadoop] wzhallright commented on pull request #3317: HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN

2021-09-14 Thread GitBox
wzhallright commented on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919656426 > Can you address the checkstyle issue? > > ``` > ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:54: Mu

[jira] [Work logged] (HADOOP-17907) FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17907?focusedWorklogId=650926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650926 ] ASF GitHub Bot logged work on HADOOP-17907: --- Author: ASF GitHub B

[GitHub] [hadoop] FrankinRUC commented on pull request #3431: HADOOP-17907. FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread GitBox
FrankinRUC commented on pull request #3431: URL: https://github.com/apache/hadoop/pull/3431#issuecomment-919656045 > LGTM Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

common-issues@hadoop.apache.org

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3417: URL: https://github.com/apache/hadoop/pull/3417#issuecomment-919655135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Commented] (HADOOP-17907) FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread Weihao Zheng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415294#comment-17415294 ] Weihao Zheng commented on HADOOP-17907: --- Hi, [~ayushsaxena], could you please rev

[GitHub] [hadoop] hadoop-yetus commented on pull request #3425: HDFS-16224. testBalancerWithObserverWithFailedNode times out

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3425: URL: https://github.com/apache/hadoop/pull/3425#issuecomment-919614344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3427: HDFS-10648. Expose Balancer metrics through Metrics2

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3427: URL: https://github.com/apache/hadoop/pull/3427#issuecomment-919602488 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Commented] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread L. C. Hsieh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415261#comment-17415261 ] L. C. Hsieh commented on HADOOP-17891: -- Yea, I also verified it locally. It also p

[GitHub] [hadoop] hadoop-yetus commented on pull request #3422: HDFS-16222. Fix ViewDFS with mount points for HDFS only API.

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3422: URL: https://github.com/apache/hadoop/pull/3422#issuecomment-919596441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Commented] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415252#comment-17415252 ] Chao Sun commented on HADOOP-17891: --- Could you share your build command? I just did {

[jira] [Commented] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415246#comment-17415246 ] Eric Badger commented on HADOOP-17891: -- Yea, I'm not sure what happened. Might be

[jira] [Commented] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415245#comment-17415245 ] Chao Sun commented on HADOOP-17891: --- Hmm interesting, I checked the yetus result and

[jira] [Commented] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Eric Badger (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415242#comment-17415242 ] Eric Badger commented on HADOOP-17891: -- {noformat} [ERROR] Failed to execute goal

[GitHub] [hadoop] hadoop-yetus commented on pull request #3419: YARN-10911. AbstractCSQueue: Create a separate class for usernames and weights that are travelling in a Map

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3419: URL: https://github.com/apache/hadoop/pull/3419#issuecomment-919570914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

common-issues@hadoop.apache.org

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3417: URL: https://github.com/apache/hadoop/pull/3417#issuecomment-919560294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

common-issues@hadoop.apache.org

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3417: URL: https://github.com/apache/hadoop/pull/3417#issuecomment-919513045 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3430: YARN-10942. Move AbstractCSQueue fields to separate objects that are tracking usage

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3430: URL: https://github.com/apache/hadoop/pull/3430#issuecomment-919502118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3427: HDFS-10648. Expose Balancer metrics through Metrics2

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3427: URL: https://github.com/apache/hadoop/pull/3427#issuecomment-919495695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17873) ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17873?focusedWorklogId=650756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650756 ] ASF GitHub Bot logged work on HADOOP-17873: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3341: HADOOP-17873. ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3341: URL: https://github.com/apache/hadoop/pull/3341#issuecomment-919455929 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Updated] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun updated HADOOP-17891: -- Fix Version/s: 3.3.2 > lz4-java and snappy-java should be excluded from relocation in shaded Hadoop

[jira] [Work logged] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?focusedWorklogId=650752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650752 ] ASF GitHub Bot logged work on HADOOP-17891: --- Author: ASF GitHub B

[GitHub] [hadoop] viirya commented on pull request #3385: HADOOP-17891. Exclude snappy-java and lz4-java from relocation in shaded hadoop client libraries

2021-09-14 Thread GitBox
viirya commented on pull request #3385: URL: https://github.com/apache/hadoop/pull/3385#issuecomment-919437178 Thanks @sunchao @dbtsai ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=650743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650743 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] goiri commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-14 Thread GitBox
goiri commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r708538792 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -301,9 +305,18 @@ public void clear() { */ priva

[GitHub] [hadoop] hadoop-yetus commented on pull request #3427: HDFS-10648. Expose Balancer metrics through Metrics2

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3427: URL: https://github.com/apache/hadoop/pull/3427#issuecomment-919419020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Updated] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun updated HADOOP-17891: -- Affects Version/s: 3.3.1 > lz4-java and snappy-java should be excluded from relocation in shaded Hado

[jira] [Work logged] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?focusedWorklogId=650736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650736 ] ASF GitHub Bot logged work on HADOOP-17891: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?focusedWorklogId=650735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650735 ] ASF GitHub Bot logged work on HADOOP-17891: --- Author: ASF GitHub B

[jira] [Resolved] (HADOOP-17891) lz4-java and snappy-java should be excluded from relocation in shaded Hadoop libraries

2021-09-14 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun resolved HADOOP-17891. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Assignee: L. C. Hsieh Resolution: F

[GitHub] [hadoop] sunchao merged pull request #3385: HADOOP-17891. Exclude snappy-java and lz4-java from relocation in shaded hadoop client libraries

2021-09-14 Thread GitBox
sunchao merged pull request #3385: URL: https://github.com/apache/hadoop/pull/3385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-u

[GitHub] [hadoop] sunchao commented on pull request #3385: HADOOP-17891. Exclude snappy-java and lz4-java from relocation in shaded hadoop client libraries

2021-09-14 Thread GitBox
sunchao commented on pull request #3385: URL: https://github.com/apache/hadoop/pull/3385#issuecomment-919400732 Merged to trunk. Thanks @viirya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] hadoop-yetus commented on pull request #3427: HDFS-10648. Expose Balancer metrics through Metrics2

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3427: URL: https://github.com/apache/hadoop/pull/3427#issuecomment-919394398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

common-issues@hadoop.apache.org

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3417: URL: https://github.com/apache/hadoop/pull/3417#issuecomment-919391771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] szilard-nemeth edited a comment on pull request #3430: YARN-10942. Move AbstractCSQueue fields to separate objects that are tracking usage

2021-09-14 Thread GitBox
szilard-nemeth edited a comment on pull request #3430: URL: https://github.com/apache/hadoop/pull/3430#issuecomment-919383259 I don't get what the Spotbugs issue is about for the "VO_VOLATILE_INCREMENT" bug, as I'm updating the volatile field from synchroinzed methods only, which is enough

[GitHub] [hadoop] szilard-nemeth commented on pull request #3430: YARN-10942. Move AbstractCSQueue fields to separate objects that are tracking usage

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3430: URL: https://github.com/apache/hadoop/pull/3430#issuecomment-919383259 I don't get what the Spotbugs issue is about for the "VO_VOLATILE_INCREMENT" bug, as I'm updating the volatile field from synchroinzed methods only, which is enough to kee

[GitHub] [hadoop] virajjasani commented on pull request #3434: HDFS-16217. RBF: Set default value of hdfs.fedbalance.procedure.scheduler.journal.uri by adding appropriate config resources

2021-09-14 Thread GitBox
virajjasani commented on pull request #3434: URL: https://github.com/apache/hadoop/pull/3434#issuecomment-919376781 Jenkins QA failure for `TestRouterDistCpProcedure` doesn't seem relevant. I have run the test locally multiple times and all tests are passing: ``` [INFO] Running or

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3420: YARN-10913. AbstractCSQueue: Group preemption methods and fields into a separate class

2021-09-14 Thread GitBox
szilard-nemeth commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r708495101 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] hadoop-yetus commented on pull request #3418: YARN-10915. AbstractCSQueue: Simplify complex logic in methods: deriveCapacityFromAbsoluteConfigurations and updateEffectiveResources

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3418: URL: https://github.com/apache/hadoop/pull/3418#issuecomment-919368453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3420: YARN-10913. AbstractCSQueue: Group preemption methods and fields into a separate class

2021-09-14 Thread GitBox
szilard-nemeth commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r708488331 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3420: YARN-10913. AbstractCSQueue: Group preemption methods and fields into a separate class

2021-09-14 Thread GitBox
szilard-nemeth commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r708487312 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3420: YARN-10913. AbstractCSQueue: Group preemption methods and fields into a separate class

2021-09-14 Thread GitBox
szilard-nemeth commented on a change in pull request #3420: URL: https://github.com/apache/hadoop/pull/3420#discussion_r708487150 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[jira] [Work logged] (HADOOP-17880) build hadoop 2.10.0 with docker machine failed

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17880?focusedWorklogId=650710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650710 ] ASF GitHub Bot logged work on HADOOP-17880: --- Author: ASF GitHub B

[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #3349: HADOOP-17880. build 2.10.x with docker only.

2021-09-14 Thread GitBox
GauthamBanasandra commented on a change in pull request #3349: URL: https://github.com/apache/hadoop/pull/3349#discussion_r708481994 ## File path: BUILDING.txt ## @@ -21,38 +21,15 @@ The easiest way to get an environment with all the appropriate tools is by means of the provi

[jira] [Work logged] (HADOOP-17195) Intermittent OutOfMemory error while performing hdfs CopyFromLocal to abfs

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17195?focusedWorklogId=650705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650705 ] ASF GitHub Bot logged work on HADOOP-17195: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on a change in pull request #3406: HADOOP-17195. OutOfMemory error while performing hdfs CopyFromLocal to ABFS

2021-09-14 Thread GitBox
steveloughran commented on a change in pull request #3406: URL: https://github.com/apache/hadoop/pull/3406#discussion_r708375778 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/store/DataBlocks.java ## @@ -0,0 +1,1064 @@ +/* + * Licensed to

[GitHub] [hadoop] hadoop-yetus commented on pull request #3434: HDFS-16217. RBF: Set default value of hdfs.fedbalance.procedure.scheduler.journal.uri by adding appropriate config resources

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3434: URL: https://github.com/apache/hadoop/pull/3434#issuecomment-919345579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] xkrogen edited a comment on pull request #3317: HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN

2021-09-14 Thread GitBox
xkrogen edited a comment on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919332797 Can you address the checkstyle issue? ``` ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:54: MutableStat

[GitHub] [hadoop] xkrogen commented on pull request #3317: HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN

2021-09-14 Thread GitBox
xkrogen commented on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919332797 Can you address the checkstyle issue? ``` ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:54: MutableStat rpcReq

[GitHub] [hadoop] szilard-nemeth merged pull request #3418: YARN-10915. AbstractCSQueue: Simplify complex logic in methods: deriveCapacityFromAbsoluteConfigurations and updateEffectiveResources

2021-09-14 Thread GitBox
szilard-nemeth merged pull request #3418: URL: https://github.com/apache/hadoop/pull/3418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-i

[GitHub] [hadoop] szilard-nemeth commented on pull request #3418: YARN-10915. AbstractCSQueue: Simplify complex logic in methods: deriveCapacityFromAbsoluteConfigurations and updateEffectiveResources

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3418: URL: https://github.com/apache/hadoop/pull/3418#issuecomment-919294455 Thanks @brumi1024 for working on this. Latest state LGTM, committed to trunk. Thanks @tomicooler for the review. -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-17892) Add Hadoop code formatter in dev-support

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17892?focusedWorklogId=650658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650658 ] ASF GitHub Bot logged work on HADOOP-17892: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3387: HADOOP-17892. Add Hadoop code formatter in dev-support

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-919292123 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] szilard-nemeth merged pull request #3403: YARN-10917. Investigate and simplify CapacitySchedulerConfigValidator…

2021-09-14 Thread GitBox
szilard-nemeth merged pull request #3403: URL: https://github.com/apache/hadoop/pull/3403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-i

[GitHub] [hadoop] szilard-nemeth edited a comment on pull request #3403: YARN-10917. Investigate and simplify CapacitySchedulerConfigValidator…

2021-09-14 Thread GitBox
szilard-nemeth edited a comment on pull request #3403: URL: https://github.com/apache/hadoop/pull/3403#issuecomment-919283755 Thanks @tomicooler for working on this. Latest state LGTM, committed to trunk. Thanks @9uapaw for the review. -- This is an automated message from the Apache

[GitHub] [hadoop] szilard-nemeth commented on pull request #3403: YARN-10917. Investigate and simplify CapacitySchedulerConfigValidator…

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3403: URL: https://github.com/apache/hadoop/pull/3403#issuecomment-919283755 Thanks @tomicooler for working on this. Latest state LGTM, committed to trunk. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] szilard-nemeth merged pull request #3410: YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir

2021-09-14 Thread GitBox
szilard-nemeth merged pull request #3410: URL: https://github.com/apache/hadoop/pull/3410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-i

[GitHub] [hadoop] szilard-nemeth commented on pull request #3410: YARN-10901. Permission checking error on an existing directory in Log…

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3410: URL: https://github.com/apache/hadoop/pull/3410#issuecomment-919267287 @tomicooler Thanks for working on this backport. Latest patch LGTM, committed to branch-3.2. Thanks @brumi1024 for the review. -- This is an automated message from

[GitHub] [hadoop] szilard-nemeth merged pull request #3409: YARN-10901. Permission checking error on an existing directory in LogAggregationFileController#verifyAndCreateRemoteLogDir

2021-09-14 Thread GitBox
szilard-nemeth merged pull request #3409: URL: https://github.com/apache/hadoop/pull/3409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-i

[GitHub] [hadoop] szilard-nemeth commented on pull request #3409: YARN-10901. Permission checking error on an existing directory in Log…

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3409: URL: https://github.com/apache/hadoop/pull/3409#issuecomment-919266624 @tomicooler Thanks for working on this backport. Latest patch LGTM, committed to branch-3.3. Thanks @brumi1024 for the review. -- This is an automated message from

[GitHub] [hadoop] szilard-nemeth merged pull request #3390: YARN-10912. Refactor AbstractCSQueue#updateConfigurableResourceRequir…

2021-09-14 Thread GitBox
szilard-nemeth merged pull request #3390: URL: https://github.com/apache/hadoop/pull/3390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-i

[GitHub] [hadoop] szilard-nemeth commented on pull request #3390: YARN-10912. Refactor AbstractCSQueue#updateConfigurableResourceRequir…

2021-09-14 Thread GitBox
szilard-nemeth commented on pull request #3390: URL: https://github.com/apache/hadoop/pull/3390#issuecomment-919263224 Thanks @tomicooler for working on this. Latest state LGTM, committed to trunk. Thanks @brumi1024 for the review. -- This is an automated message from the Apache Git

[GitHub] [hadoop] brumi1024 commented on a change in pull request #3418: YARN-10915. AbstractCSQueue: Simplify complex logic in methods: deriveCapacityFromAbsoluteConfigurations and updateEffectiveRes

2021-09-14 Thread GitBox
brumi1024 commented on a change in pull request #3418: URL: https://github.com/apache/hadoop/pull/3418#discussion_r708384043 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/

[GitHub] [hadoop] hadoop-yetus commented on pull request #3434: HDFS-16217. RBF: Set default value of hdfs.fedbalance.procedure.scheduler.journal.uri by adding appropriate config resources

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3434: URL: https://github.com/apache/hadoop/pull/3434#issuecomment-919237791 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=650618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650618 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-14 Thread GitBox
steveloughran commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-919231375 LGTM, though someone who does docker work needs to review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Work logged] (HADOOP-17871) S3A CSE: minor tuning

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17871?focusedWorklogId=650615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650615 ] ASF GitHub Bot logged work on HADOOP-17871: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3412: HADOOP-17871. S3A CSE: minor tuning

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3412: URL: https://github.com/apache/hadoop/pull/3412#issuecomment-919228696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17892) Add Hadoop code formatter in dev-support

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17892?focusedWorklogId=650609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650609 ] ASF GitHub Bot logged work on HADOOP-17892: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3387: HADOOP-17892. Add Hadoop code formatter in dev-support

2021-09-14 Thread GitBox
steveloughran commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-919218567 order is ``` java.* javax.* -- o.a.h.thirdparty all non-org.apache -- org.apache.* -- all statics, in order. -- ``` all but th

[jira] [Work logged] (HADOOP-17908) Add missing RELEASENOTES and CHANGELOG to upstream

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17908?focusedWorklogId=650583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650583 ] ASF GitHub Bot logged work on HADOOP-17908: --- Author: ASF GitHub B

[GitHub] [hadoop] iwasakims commented on pull request #3433: HADOOP-17908. Add missing RELEASENOTES and CHANGELOG to upstream.

2021-09-14 Thread GitBox
iwasakims commented on pull request #3433: URL: https://github.com/apache/hadoop/pull/3433#issuecomment-919183324 > The patch has 1 line(s) that end in blanks. The relevant file (RELEASENOTES.3.3.0.md) are part of [already published release artifacts](https://archive.apache.org/dist

[GitHub] [hadoop] hadoop-yetus commented on pull request #3422: HDFS-16222. Fix ViewDFS with mount points for HDFS only API.

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3422: URL: https://github.com/apache/hadoop/pull/3422#issuecomment-919172071 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] virajjasani opened a new pull request #3434: HDFS-16217. RBF: Set default value of hdfs.fedbalance.procedure.scheduler.journal.uri by adding appropriate config resources

2021-09-14 Thread GitBox
virajjasani opened a new pull request #3434: URL: https://github.com/apache/hadoop/pull/3434 ### Description of PR When dfs.federation.router.federation.rename.option is set to DISTCP and hdfs.fedbalance.procedure.scheduler.journal.uri is not set, DFSRouter fails to launch. ``` 20

[GitHub] [hadoop] tomscut commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-14 Thread GitBox
tomscut commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-919112684 > > Overall it looks good. > > DataNode Info shows on namenode UI and Router UI, It is reasonable to add this into router UI. > > Maybe it is like namenode, just lines code

[GitHub] [hadoop] tomscut commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-14 Thread GitBox
tomscut commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-919110352 Those failed unit tests are unrelated to the change and they work fine locally. @tasanuma @ferhui Could you please help review this PR again. Thank you very much. -- Th

[GitHub] [hadoop] hadoop-yetus commented on pull request #3317: HDFS-16181. [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when tailEditLog form JN

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919067139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3427: HDFS-10648. Expose Balancer metrics through Metrics2

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3427: URL: https://github.com/apache/hadoop/pull/3427#issuecomment-919055376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17907) FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17907?focusedWorklogId=650511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650511 ] ASF GitHub Bot logged work on HADOOP-17907: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3431: HADOOP-17907. FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3431: URL: https://github.com/apache/hadoop/pull/3431#issuecomment-919049692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3432: Revert " HDFS-15160. branch-3.2. ReplicaMap, Disk Balancer, Directory Scanner and various FsDatasetImpl methods should use datanode read

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3432: URL: https://github.com/apache/hadoop/pull/3432#issuecomment-919046179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Updated] (HADOOP-17895) RawLocalFileSystem cannot mkdir/chmod paths with emojis. ☹️

2021-09-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17895: Summary: RawLocalFileSystem cannot mkdir/chmod paths with emojis. ☹️ (was: RawLocalFileS

[jira] [Commented] (HADOOP-17895) RawLocalFileSystem cannot mkdir/chmod paths with emojis

2021-09-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414855#comment-17414855 ] Steve Loughran commented on HADOOP-17895: - Updated title based on Chris N's com

[jira] [Updated] (HADOOP-17895) RawLocalFileSystem cannot mkdir/chmod paths with emojis

2021-09-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17895: Summary: RawLocalFileSystem cannot mkdir/chmod paths with emojis (was: RawLocalFileSyste

[GitHub] [hadoop] hadoop-yetus commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-14 Thread GitBox
hadoop-yetus commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-918983134 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] ayushtkn commented on pull request #3428: HDFS-16225. Fix typo for FederationTestUtils

2021-09-14 Thread GitBox
ayushtkn commented on pull request #3428: URL: https://github.com/apache/hadoop/pull/3428#issuecomment-918954743 Thanx @tomscut for the contribution and @goiri and @virajjasani for the reviews!!! -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] ayushtkn merged pull request #3428: HDFS-16225. Fix typo for FederationTestUtils

2021-09-14 Thread GitBox
ayushtkn merged pull request #3428: URL: https://github.com/apache/hadoop/pull/3428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[GitHub] [hadoop] ayushtkn merged pull request #2831: HDFS-15920.Solve the problem that the value of SafeModeMonitor#RECHECK_INTERVAL can be configured.

2021-09-14 Thread GitBox
ayushtkn merged pull request #2831: URL: https://github.com/apache/hadoop/pull/2831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[jira] [Work logged] (HADOOP-17907) FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17907?focusedWorklogId=650423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650423 ] ASF GitHub Bot logged work on HADOOP-17907: --- Author: ASF GitHub B

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3431: HADOOP-17907. FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs f

2021-09-14 Thread GitBox
ayushtkn commented on a change in pull request #3431: URL: https://github.com/apache/hadoop/pull/3431#discussion_r708054750 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java ## @@ -182,7 +183,7 @@ public static boolean fullyDele

[jira] [Work logged] (HADOOP-17907) FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs fault

2021-09-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17907?focusedWorklogId=650422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650422 ] ASF GitHub Bot logged work on HADOOP-17907: --- Author: ASF GitHub B

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3431: HADOOP-17907. FileUtil#fullyDelete deletes contents of sym-linked directory when symlink cannot be deleted because of local fs f

2021-09-14 Thread GitBox
ayushtkn commented on a change in pull request #3431: URL: https://github.com/apache/hadoop/pull/3431#discussion_r708054511 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java ## @@ -182,7 +183,7 @@ public static boolean fullyDele

[jira] [Created] (HADOOP-17909) cleanupTempFiles in CopyCommitter can work with directWrite option

2021-09-14 Thread yinan zhan (Jira)
yinan zhan created HADOOP-17909: --- Summary: cleanupTempFiles in CopyCommitter can work with directWrite option Key: HADOOP-17909 URL: https://issues.apache.org/jira/browse/HADOOP-17909 Project: Hadoop Co

  1   2   >