[jira] [Commented] (HADOOP-18498) [ABFS]: Error introduced when SAS Token containing '?' prefix is passed

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640432#comment-17640432 ] ASF GitHub Bot commented on HADOOP-18498: - sreeb-msft commented on PR #5136: URL:

[GitHub] [hadoop] sreeb-msft commented on pull request #5136: HADOOP-18498. ABFS: Removing unwanted ? prefix from SAS Tokens

2022-11-28 Thread GitBox
sreeb-msft commented on PR #5136: URL: https://github.com/apache/hadoop/pull/5136#issuecomment-1330177057 > +1, approving. > > i do like the end of a file to have a newline, the unix convention, but not enough for it to be a blocker here and to lose a day Will keep this in

[GitHub] [hadoop] susheel-gupta commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2022-11-28 Thread GitBox
susheel-gupta commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1330105691 Hi @ashutoshcipher , for this PR the tests are passing locally but failing at jenkin. So I tried it to fix using this

[GitHub] [hadoop] hadoop-yetus commented on pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1330082726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1330060886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5146: YARN-11373. [Federation] Support refreshQueues refreshNodes API's for Federation.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5146: URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1330052524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5104: YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5104: URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1330005970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomscut commented on pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
tomscut commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1329975976 Thanks @xkrogen for your thoughtful advice. It makes perfect sense to me. I updated the code. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] tasanuma commented on pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-28 Thread GitBox
tasanuma commented on PR #5143: URL: https://github.com/apache/hadoop/pull/5143#issuecomment-1329970821 Merged it. Thanks for your contribution and fixing this issue, @lfxy! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] tasanuma merged pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-28 Thread GitBox
tasanuma merged PR #5143: URL: https://github.com/apache/hadoop/pull/5143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] cainbit commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2022-11-28 Thread GitBox
cainbit commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1329946107 > @slfan1989 @dineshchitlangia @brumi1024 @9uapaw @ashutoshcipher Could you please to help review the code? This issue makes version 3.3.4 unable to run directly on the production

[GitHub] [hadoop] cainbit commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2022-11-28 Thread GitBox
cainbit commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1329936324 > > @slfan1989 > > I'm using Hadoop 3.3.4 with kerberos, and the issue is happened, the DelegationTokenRenewer use 100% CPU. > > I use jstack to check threads and find the

[GitHub] [hadoop] omalley merged pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

2022-11-28 Thread GitBox
omalley merged PR #5142: URL: https://github.com/apache/hadoop/pull/5142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] omalley merged pull request #5145: HDFS-16847: RBF: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

2022-11-28 Thread GitBox
omalley merged PR #5145: URL: https://github.com/apache/hadoop/pull/5145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] tomscut commented on a diff in pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
tomscut commented on code in PR #4209: URL: https://github.com/apache/hadoop/pull/4209#discussion_r1034187735 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournaledEditsCache.java: ## @@ -221,6 +224,24 @@ public void

[GitHub] [hadoop] tomscut commented on a diff in pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
tomscut commented on code in PR #4209: URL: https://github.com/apache/hadoop/pull/4209#discussion_r1034183546 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -4955,6 +4955,19 @@ Review Comment: Thanks for your thoughtful advice. -- This

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
xkrogen commented on code in PR #4209: URL: https://github.com/apache/hadoop/pull/4209#discussion_r1034168326 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournaledEditsCache.java: ## @@ -221,6 +224,24 @@ public void

[GitHub] [hadoop] tomscut commented on a diff in pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
tomscut commented on code in PR #4209: URL: https://github.com/apache/hadoop/pull/4209#discussion_r1034167277 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournaledEditsCache.java: ## @@ -221,6 +224,24 @@ public void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5143: URL: https://github.com/apache/hadoop/pull/5143#issuecomment-1329817462 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5170: HDFS-16855. Remove the redundant write lock in addBlockPool.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5170: URL: https://github.com/apache/hadoop/pull/5170#issuecomment-1329816617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640241#comment-17640241 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #5163: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1329719849 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addB

2022-11-28 Thread GitBox
xkrogen commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1033981920 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3095,12 +3095,12 @@ LocatedBlock

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-28 Thread GitBox
xkrogen commented on code in PR #4209: URL: https://github.com/apache/hadoop/pull/4209#discussion_r1033958544 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournaledEditsCache.java: ## @@ -277,11 +279,10 @@ void storeEdits(byte[]

[GitHub] [hadoop] omalley commented on a diff in pull request #5155: HDFS-16851: RBF: Add a utility to dump the StateStore.

2022-11-28 Thread GitBox
omalley commented on code in PR #5155: URL: https://github.com/apache/hadoop/pull/5155#discussion_r1033968329 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -97,6 +106,7 @@ public class RouterAdmin extends

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640195#comment-17640195 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1329588076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5171: YARN-11383. lowercasing workflowid in workflow priority mappings

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5171: URL: https://github.com/apache/hadoop/pull/5171#issuecomment-1329555084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18544) S3A: add option to disable probe for dir marker recreation on delete/rename.

2022-11-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640168#comment-17640168 ] Steve Loughran commented on HADOOP-18544: - [~harshit.gupta] assigning to you this'll need a

[jira] [Created] (HADOOP-18544) S3A: add option to disable probe for dir marker recreation on delete/rename.

2022-11-28 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18544: --- Summary: S3A: add option to disable probe for dir marker recreation on delete/rename. Key: HADOOP-18544 URL: https://issues.apache.org/jira/browse/HADOOP-18544

[jira] [Commented] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640161#comment-17640161 ] ASF GitHub Bot commented on HADOOP-18543: - hadoop-yetus commented on PR #5172: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5172: HADOOP-18543. AliyunOSSFileSystem#open(Path path, int bufferSize) use buffer size as its downloadPartSize

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5172: URL: https://github.com/apache/hadoop/pull/5172#issuecomment-1329502962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1329497060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-11-28 Thread GitBox
xkrogen commented on code in PR #4744: URL: https://github.com/apache/hadoop/pull/4744#discussion_r1033837986 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java: ## @@ -1666,6 +1670,9 @@ synchronized void

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640155#comment-17640155 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in PR #5117: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
steveloughran commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033835902 ## hadoop-tools/hadoop-azure/src/test/resources/log4j.properties: ## @@ -26,6 +26,8 @@

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640153#comment-17640153 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in PR #5117: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
steveloughran commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033833635 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -555,7 +579,7 @@ int readRemote(long position,

[jira] [Commented] (HADOOP-18541) Upgrade grizzly version to 2.4.4

2022-11-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640151#comment-17640151 ] Steve Loughran commented on HADOOP-18541: - can you tag version and modules affected here, plus

[jira] [Commented] (HADOOP-18541) Upgrade grizzly version to 2.4.4

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640149#comment-17640149 ] ASF GitHub Bot commented on HADOOP-18541: - steveloughran commented on PR #5167: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5167: HADOOP-18541. Upgrade grizzly version to 2.4.4

2022-11-28 Thread GitBox
steveloughran commented on PR #5167: URL: https://github.com/apache/hadoop/pull/5167#issuecomment-1329463338 AFAIK, grizzly is only used in test, so this isn't something we should be distributing. how fussy is grizzly about jersey versions -as if it expects any changes there or

[jira] [Commented] (HADOOP-18540) Upgrade Bouncy Castle to 1.70

2022-11-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640142#comment-17640142 ] Steve Loughran commented on HADOOP-18540: - what are the CVE numbers, *not some sonatype thing*

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640138#comment-17640138 ] ASF GitHub Bot commented on HADOOP-18542: - steveloughran commented on PR #4262: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2022-11-28 Thread GitBox
steveloughran commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1329440077 ITestAzureBlobFileSystemCheckAccess.testCheckAccessForAccountWithoutNS looks related...what is the full stack? it may be a different exception came back from the azure call, or it

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640136#comment-17640136 ] Steve Loughran commented on HADOOP-18542: - what is the stack trace with the error? > Azure

[GitHub] [hadoop] hadoop-yetus commented on pull request #5146: YARN-11373. [Federation] Support refreshQueues refreshNodes API's for Federation.

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5146: URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1329378044 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18543: Labels: pull-request-available (was: ) > AliyunOSS: AliyunOSSFileSystem#open(Path path,

[jira] [Commented] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640117#comment-17640117 ] ASF GitHub Bot commented on HADOOP-18543: - masteryhx opened a new pull request, #5172: URL:

[GitHub] [hadoop] masteryhx opened a new pull request, #5172: HADOOP-18543. AliyunOSSFileSystem#open(Path path, int bufferSize) use buffer size as its downloadPartSize

2022-11-28 Thread GitBox
masteryhx opened a new pull request, #5172: URL: https://github.com/apache/hadoop/pull/5172 ### Description of PR In our application, different components have their own suitable buffer size to download. But currently, AliyunOSSFileSystem#open(Path path, int

[jira] [Commented] (HADOOP-18457) ABFS: Support for account level throttling

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640106#comment-17640106 ] ASF GitHub Bot commented on HADOOP-18457: - hadoop-yetus commented on PR #5034: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5034: HADOOP-18457. ABFS: Support for account level throttling

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5034: URL: https://github.com/apache/hadoop/pull/5034#issuecomment-1329308547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] aparchoudhary opened a new pull request, #5171: YARN-11383. lowercasing workflowid in workflow priority mappings

2022-11-28 Thread GitBox
aparchoudhary opened a new pull request, #5171: URL: https://github.com/apache/hadoop/pull/5171 ### Description of PR Jira: [YARN-11383](https://issues.apache.org/jira/browse/YARN-11383) Lowercasing workflowId in workflow priority mappings as yarn lowercases application tags.

[jira] [Commented] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

2022-11-28 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640053#comment-17640053 ] Hangxiang Yu commented on HADOOP-18543: --- [~wujinhu] WDYT? If right, I'd like to create a pr to

[jira] [Created] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

2022-11-28 Thread Hangxiang Yu (Jira)
Hangxiang Yu created HADOOP-18543: - Summary: AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize Key: HADOOP-18543 URL:

[GitHub] [hadoop] lfxy commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-28 Thread GitBox
lfxy commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1033554982 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeManager.java: ## @@ -1040,28 +1054,28 @@ private void

[GitHub] [hadoop] lfxy commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-28 Thread GitBox
lfxy commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1033551972 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeManager.java: ## @@ -1009,13 +1011,25 @@ private void

[GitHub] [hadoop] dingshun3016 opened a new pull request, #5170: HDFS-16855. Remove the redundant write lock in addBlockPool.

2022-11-28 Thread GitBox
dingshun3016 opened a new pull request, #5170: URL: https://github.com/apache/hadoop/pull/5170 When patching the datanode's fine-grained lock, we found that the datanode couldn't start,maybe happened deadlock,when addBlockPool, so we can remove it.

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-28 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1329092421 @ayushtkn Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] ayushtkn merged pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-28 Thread GitBox
ayushtkn merged PR #5152: URL: https://github.com/apache/hadoop/pull/5152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1329084117 @ayushtkn Thank you very much for your help! It seems that jenkins is running normally. I will continue to observe and report back the final running results. -- This is an automated

[GitHub] [hadoop] ayushtkn commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
ayushtkn commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1329064937 It is giving "java.nio.file.FileSystemException: /home/jenkins/jenkins-home/workspace/hadoop-multibranch: Read-only file system" for hadoop2 node, I don't know if it is the only node

[jira] [Updated] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread Carl (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl updated HADOOP-18542: -- Description: The `AbfsConfiguration` class requires that we provide a tenant and client ID when using the

[GitHub] [hadoop] slfan1989 commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1329001633 @steveloughran @ayushtkn This pr cannot be compiled by jenkins, do you know how to deal with it? I checked the code and found no problem. -- This is an automated message from the

[jira] [Updated] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18542: Labels: pull-request-available (was: ) > Azure Token provider requires tenant and

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640009#comment-17640009 ] ASF GitHub Bot commented on HADOOP-18542: - CLevasseur commented on PR #4262: URL:

[GitHub] [hadoop] CLevasseur commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2022-11-28 Thread GitBox
CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1328997955 I have created this JIRA to track this bug: https://issues.apache.org/jira/browse/HADOOP-18542 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 closed pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 closed pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL. URL: https://github.com/apache/hadoop/pull/5161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2022-11-28 Thread Carl (Jira)
Carl created HADOOP-18542: - Summary: Azure Token provider requires tenant and client IDs despite being optional Key: HADOOP-18542 URL: https://issues.apache.org/jira/browse/HADOOP-18542 Project: Hadoop

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639996#comment-17639996 ] ASF GitHub Bot commented on HADOOP-18073: - passaro commented on code in PR #5163: URL:

[GitHub] [hadoop] passaro commented on a diff in pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-28 Thread GitBox
passaro commented on code in PR #5163: URL: https://github.com/apache/hadoop/pull/5163#discussion_r1033452559 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java: ## @@ -75,19 +75,20 @@ import java.util.Collection; import java.util.Collections;

[jira] [Resolved] (HADOOP-18498) [ABFS]: Error introduced when SAS Token containing '?' prefix is passed

2022-11-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18498. - Fix Version/s: 3.4.0 3.3.5 Resolution: Fixed > [ABFS]: Error

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639983#comment-17639983 ] ASF GitHub Bot commented on HADOOP-18073: - passaro commented on code in PR #5163: URL:

[GitHub] [hadoop] passaro commented on a diff in pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-28 Thread GitBox
passaro commented on code in PR #5163: URL: https://github.com/apache/hadoop/pull/5163#discussion_r1033447463 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/InconsistentS3ClientFactory.java: ## @@ -18,37 +18,93 @@ package org.apache.hadoop.fs.s3a;

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639981#comment-17639981 ] ASF GitHub Bot commented on HADOOP-18073: - passaro commented on code in PR #5163: URL:

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639980#comment-17639980 ] ASF GitHub Bot commented on HADOOP-18073: - passaro commented on code in PR #5163: URL:

[GitHub] [hadoop] passaro commented on a diff in pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-28 Thread GitBox
passaro commented on code in PR #5163: URL: https://github.com/apache/hadoop/pull/5163#discussion_r1033444036 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/InternalConstants.java: ## @@ -110,11 +110,50 @@ private InternalConstants() {

[GitHub] [hadoop] passaro commented on a diff in pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-28 Thread GitBox
passaro commented on code in PR #5163: URL: https://github.com/apache/hadoop/pull/5163#discussion_r1033443509 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/SDKStreamDrainer.java: ## @@ -58,17 +51,9 @@ public class SDKStreamDrainer implements

[GitHub] [hadoop] slfan1989 opened a new pull request, #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 opened a new pull request, #5169: URL: https://github.com/apache/hadoop/pull/5169 JIRA: YARN-11349. [Federation] Router Support DelegationToken With SQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 closed pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 closed pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL. URL: https://github.com/apache/hadoop/pull/5161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-18498) [ABFS]: Error introduced when SAS Token containing '?' prefix is passed

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639975#comment-17639975 ] ASF GitHub Bot commented on HADOOP-18498: - steveloughran merged PR #5136: URL:

[GitHub] [hadoop] steveloughran merged pull request #5136: HADOOP-18498. ABFS: Removing unwanted ? prefix from SAS Tokens

2022-11-28 Thread GitBox
steveloughran merged PR #5136: URL: https://github.com/apache/hadoop/pull/5136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639973#comment-17639973 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in PR #5117: URL:

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033433849 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -302,33 +325,33 @@ private synchronized boolean

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639972#comment-17639972 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in PR #5117: URL:

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033420242 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -555,7 +579,7 @@ int readRemote(long position,

[jira] [Commented] (HADOOP-17177) Java 17 support

2022-11-28 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639969#comment-17639969 ] Akira Ajisaka commented on HADOOP-17177: Hi [~richa...@gmail.com] now there's no Hadoop version

[jira] [Commented] (HADOOP-18530) ChecksumFileSystem::readVectored might return byte buffers not positioned at 0

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639968#comment-17639968 ] ASF GitHub Bot commented on HADOOP-18530: - mehakmeet commented on code in PR #5168: URL:

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5168: HADOOP-18530. ChecksumFileSystem::readVectored might return byte buffers not positioned at 0

2022-11-28 Thread GitBox
mehakmeet commented on code in PR #5168: URL: https://github.com/apache/hadoop/pull/5168#discussion_r1033426018 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/VectoredReadUtils.java: ## @@ -310,6 +310,7 @@ public static ByteBuffer sliceTo(ByteBuffer

[GitHub] [hadoop] slfan1989 commented on pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-28 Thread GitBox
slfan1989 commented on PR #5161: URL: https://github.com/apache/hadoop/pull/5161#issuecomment-1328907139 This pr cannot trigger jenkins compilation, I will close this pr and submit a new pr. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639959#comment-17639959 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in PR #5117: URL:

[jira] [Commented] (HADOOP-18539) Upgrade ojalgo to 51.4.1

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639960#comment-17639960 ] ASF GitHub Bot commented on HADOOP-18539: - hadoop-yetus commented on PR #5165: URL:

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639958#comment-17639958 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in PR #5117: URL:

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033415579 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferStreamOperations.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5165: HADOOP-18539. Upgrade ojalgo to 51.4.1

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5165: URL: https://github.com/apache/hadoop/pull/5165#issuecomment-1328906045 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033415579 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferStreamOperations.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639950#comment-17639950 ] ASF GitHub Bot commented on HADOOP-18521: - pranavsaxena-microsoft commented on code in PR

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-28 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1033198624 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -454,31 +597,86 @@ ReadBuffer

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639949#comment-17639949 ] ASF GitHub Bot commented on HADOOP-18399: - hadoop-yetus commented on PR #5054: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-28 Thread GitBox
hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1328882853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17725) Improve error message for token providers in ABFS

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639946#comment-17639946 ] ASF GitHub Bot commented on HADOOP-17725: - CLevasseur commented on PR #4262: URL:

  1   2   >