[GitHub] [hadoop] hadoop-yetus commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1509515484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1509483152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1509480390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5556: URL: https://github.com/apache/hadoop/pull/5556#issuecomment-1509458883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712582#comment-17712582 ] ASF GitHub Bot commented on HADOOP-18399: - hadoop-yetus commented on PR #5054: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1509402865 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5127: YARN-11239. Optimize FederationClientInterceptor audit log.

2023-04-14 Thread via GitHub
slfan1989 commented on PR #5127: URL: https://github.com/apache/hadoop/pull/5127#issuecomment-1509394396 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] goiri commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
goiri commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167306643 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -511,90 +687,45 @@ private boolean

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293044 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java: ## @@ -130,11 +129,11 @@ public MutableQuantiles() {}

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293176 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java: ## @@ -431,6 +431,46 @@ public void

[GitHub] [hadoop] rdingankar commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
rdingankar commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167293044 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java: ## @@ -130,11 +129,11 @@ public MutableQuantiles() {}

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712554#comment-17712554 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread via GitHub
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1509294330 `us-west-2`: ``` $ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dprefetch -Dscale $ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale ```

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167254526 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -511,90 +687,45 @@ private boolean

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167254526 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -511,90 +687,45 @@ private boolean

[jira] [Commented] (HADOOP-18687) Remove unnecessary dependency on json-smart

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712528#comment-17712528 ] ASF GitHub Bot commented on HADOOP-18687: - hadoop-yetus commented on PR #5549: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5549: HADOOP-18687. Remove json-smart dependency

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5549: URL: https://github.com/apache/hadoop/pull/5549#issuecomment-1509217403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167250006 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -511,90 +687,45 @@ private boolean

[GitHub] [hadoop] goiri commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
goiri commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167244069 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -511,90 +687,45 @@ private boolean

[GitHub] [hadoop] goiri merged pull request #5127: YARN-11239. Optimize FederationClientInterceptor audit log.

2023-04-14 Thread via GitHub
goiri merged PR #5127: URL: https://github.com/apache/hadoop/pull/5127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on a diff in pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
goiri commented on code in PR #5556: URL: https://github.com/apache/hadoop/pull/5556#discussion_r1167234948 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java: ## @@ -130,11 +129,11 @@ public MutableQuantiles() {} public

[jira] [Resolved] (HADOOP-18702) Remove ozone mailing lists from Hadoop website

2023-04-14 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-18702. -- Resolution: Fixed > Remove ozone mailing lists from Hadoop website >

[GitHub] [hadoop-site] jojochuang commented on pull request #44: HADOOP-18702. Remove ozone mailing lists from Hadoop website

2023-04-14 Thread via GitHub
jojochuang commented on PR #44: URL: https://github.com/apache/hadoop-site/pull/44#issuecomment-1509176469 Merged. Thanks @Hexiaoqiao @ayushtkn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HADOOP-18702) Remove ozone mailing lists from Hadoop website

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18702: Labels: pull-request-available (was: ) > Remove ozone mailing lists from Hadoop website

[GitHub] [hadoop-site] jojochuang merged pull request #44: HADOOP-18702. Remove ozone mailing lists from Hadoop website

2023-04-14 Thread via GitHub
jojochuang merged PR #44: URL: https://github.com/apache/hadoop-site/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712517#comment-17712517 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on code in PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1167231126 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/prefetch/S3APrefetchingInputStream.java: ## @@ -110,11 +117,17 @@ public

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712515#comment-17712515 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on code in PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1167229660 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -221,8 +234,10 @@ protected void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5556: HDFS-16982 Use the right Quantiles Array for Inverse Quantiles snapshot

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5556: URL: https://github.com/apache/hadoop/pull/5556#issuecomment-1509077043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5554: HDFS-16978. RBF: New Router admin command to support bulk add of mount points

2023-04-14 Thread via GitHub
virajjasani commented on code in PR #5554: URL: https://github.com/apache/hadoop/pull/5554#discussion_r1167129819 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -462,6 +481,111 @@ public int run(String[]

[jira] [Commented] (HADOOP-18703) Backport S3A prefetching stream to branch-3.3

2023-04-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712474#comment-17712474 ] Steve Loughran commented on HADOOP-18703: - started with the work as a github pr and patch 1

[jira] [Commented] (HADOOP-18028) High performance S3A input stream with prefetching & caching

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712473#comment-17712473 ] ASF GitHub Bot commented on HADOOP-18028: - steveloughran opened a new pull request, #5559: URL:

[GitHub] [hadoop] steveloughran opened a new pull request, #5559: HADOOP-18028. High performance S3A input stream (#4752)

2023-04-14 Thread via GitHub
steveloughran opened a new pull request, #5559: URL: https://github.com/apache/hadoop/pull/5559 backport branch for S3A prefetching; initial big commit = Contains HADOOP-18028. High performance S3A input stream (#4109) Contributed by Bhalchandra Pandit.

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712472#comment-17712472 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl commented on code in PR #5540: URL:

[GitHub] [hadoop] smengcl commented on a diff in pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread via GitHub
smengcl commented on code in PR #5540: URL: https://github.com/apache/hadoop/pull/5540#discussion_r1167086957 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIdentityProviders.java: ## @@ -51,6 +54,9 @@ public int getPriorityLevel() { } }

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712471#comment-17712471 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl commented on code in PR #5540: URL:

[GitHub] [hadoop] smengcl commented on a diff in pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread via GitHub
smengcl commented on code in PR #5540: URL: https://github.com/apache/hadoop/pull/5540#discussion_r1167086957 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIdentityProviders.java: ## @@ -51,6 +54,9 @@ public int getPriorityLevel() { } }

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712470#comment-17712470 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl commented on code in PR #5540: URL:

[GitHub] [hadoop] smengcl commented on a diff in pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

2023-04-14 Thread via GitHub
smengcl commented on code in PR #5540: URL: https://github.com/apache/hadoop/pull/5540#discussion_r1167086957 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIdentityProviders.java: ## @@ -51,6 +54,9 @@ public int getPriorityLevel() { } }

[jira] [Commented] (HADOOP-18671) Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712461#comment-17712461 ] ASF GitHub Bot commented on HADOOP-18671: - steveloughran commented on code in PR #5553: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5553: HADOOP-18671 Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5553: URL: https://github.com/apache/hadoop/pull/5553#discussion_r1167037740 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -169,7 +169,8 @@ @InterfaceAudience.Public

[jira] [Created] (HADOOP-18703) Backport S3A prefetching stream to branch-3.3

2023-04-14 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18703: --- Summary: Backport S3A prefetching stream to branch-3.3 Key: HADOOP-18703 URL: https://issues.apache.org/jira/browse/HADOOP-18703 Project: Hadoop Common

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712451#comment-17712451 ] ASF GitHub Bot commented on HADOOP-18565: - steveloughran commented on PR #5421: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

2023-04-14 Thread via GitHub
steveloughran commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1508895984 ok, before merging, that spotbugs needs to be quietened ``` ode | Warning -- | -- IS | Inconsistent synchronization of

[jira] [Commented] (HADOOP-18470) Release hadoop 3.3.5

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712444#comment-17712444 ] ASF GitHub Bot commented on HADOOP-18470: - steveloughran opened a new pull request, #5558: URL:

[GitHub] [hadoop] steveloughran opened a new pull request, #5558: HADOOP-18470. 3.3.5 Release wrap-up: jdiff files

2023-04-14 Thread via GitHub
steveloughran opened a new pull request, #5558: URL: https://github.com/apache/hadoop/pull/5558 This is a commit with the final changes for the 3.3.5 release -updating later branches with the jdiff and release info * add jdiff xml files from 3.3.5 release * declare 3.3.5 as

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712440#comment-17712440 ] ASF GitHub Bot commented on HADOOP-18590: - hadoop-yetus commented on PR #: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5555: HADOOP-18590. Publish SBOM artifacts

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #: URL: https://github.com/apache/hadoop/pull/#issuecomment-1508779504 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712437#comment-17712437 ] ASF GitHub Bot commented on HADOOP-18695: - hadoop-yetus commented on PR #5548: URL:

[jira] [Commented] (HADOOP-18696) S3A ITestS3ABucketExistence access point test failure

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712436#comment-17712436 ] ASF GitHub Bot commented on HADOOP-18696: - hadoop-yetus commented on PR #5557: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1508766873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5557: HADOOP-18696. ITestS3ABucketExistence ARN test failures.

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5557: URL: https://github.com/apache/hadoop/pull/5557#issuecomment-1508766686 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18657) Tune ABFS create() retry logic

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712435#comment-17712435 ] ASF GitHub Bot commented on HADOOP-18657: - steveloughran commented on PR #5462: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5462: HADOOP-18657. Tune ABFS create() retry logic

2023-04-14 Thread via GitHub
steveloughran commented on PR #5462: URL: https://github.com/apache/hadoop/pull/5462#issuecomment-1508743152 any updates on this? big issue is whether to retry on 409 or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712431#comment-17712431 ] ASF GitHub Bot commented on HADOOP-18399: - steveloughran commented on code in PR #5054: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1166928173 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -67,6 +70,10 @@ public class

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712416#comment-17712416 ] ASF GitHub Bot commented on HADOOP-18590: - hadoop-yetus commented on PR #: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5555: HADOOP-18590. Publish SBOM artifacts

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #: URL: https://github.com/apache/hadoop/pull/#issuecomment-1508657215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5552: URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1508634372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18701) Generic Build Improvements

2023-04-14 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712404#comment-17712404 ] Ayush Saxena commented on HADOOP-18701: --- Now in the latest surefire version it is by default

[GitHub] [hadoop] hadoop-yetus commented on pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5552: URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1508605229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5552: URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1508592775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18696) S3A ITestS3ABucketExistence access point test failure

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712389#comment-17712389 ] ASF GitHub Bot commented on HADOOP-18696: - steveloughran commented on PR #5557: URL:

[jira] [Updated] (HADOOP-18696) S3A ITestS3ABucketExistence access point test failure

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18696: Labels: pull-request-available (was: ) > S3A ITestS3ABucketExistence access point test

[jira] [Commented] (HADOOP-18696) S3A ITestS3ABucketExistence access point test failure

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712388#comment-17712388 ] ASF GitHub Bot commented on HADOOP-18696: - steveloughran opened a new pull request, #5557: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5557: HADOOP-18696. ITestS3ABucketExistence arn test failures.

2023-04-14 Thread via GitHub
steveloughran commented on PR #5557: URL: https://github.com/apache/hadoop/pull/5557#issuecomment-1508505324 ``` [INFO] --- [INFO] Running org.apache.hadoop.fs.s3a.ITestS3ABucketExistence [INFO] Tests run: 6, Failures: 0, Errors:

[GitHub] [hadoop] steveloughran opened a new pull request, #5557: HADOOP-18696. ITestS3ABucketExistence arn test failures.

2023-04-14 Thread via GitHub
steveloughran opened a new pull request, #5557: URL: https://github.com/apache/hadoop/pull/5557 Explicitly sets the fs.s3a.endpoint.region to eu-west-1 so the arn-referenced fs creation fails with unknown store rather than IllegalArgumentException. ### How was this patch tested?

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712380#comment-17712380 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166807118 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java: ## @@ -192,13 +201,7 @@ public void

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712379#comment-17712379 ] ASF GitHub Bot commented on HADOOP-18695: - dannycjones commented on code in PR #5548: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
dannycjones commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166804606 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AMiscOperations.java: ## @@ -114,7 +114,7 @@ public void testPutObjectDirect() throws

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166803520 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java: ## @@ -119,6 +119,14 @@ protected Configuration

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712378#comment-17712378 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712376#comment-17712376 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166801185 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestAuditIntegration.java: ## @@ -67,6 +71,22 @@ public void testExceptionTranslation()

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712375#comment-17712375 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166800030 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AMiscOperations.java: ## @@ -114,7 +114,7 @@ public void testPutObjectDirect() throws

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712374#comment-17712374 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166798332 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AWSRequestAnalyzer.java: ## @@ -216,6 +216,18 @@ private RequestInfo writing(final String

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712371#comment-17712371 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166794079 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java: ## @@ -590,10 +593,9 @@ public void uploadObject(PutObjectRequest

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712368#comment-17712368 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166791597 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java: ## @@ -590,10 +593,9 @@ public void uploadObject(PutObjectRequest

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712366#comment-17712366 ] ASF GitHub Bot commented on HADOOP-18695: - steveloughran commented on code in PR #5548: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

2023-04-14 Thread via GitHub
steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166788483 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -2590,6 +2591,25 @@ protected DurationTrackerFactory

[jira] [Commented] (HADOOP-18425) [ABFS]: RenameFilePath Source File Not Found (404) error in retry loop

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712364#comment-17712364 ] ASF GitHub Bot commented on HADOOP-18425: - steveloughran closed pull request #5494:

[GitHub] [hadoop] steveloughran closed pull request #5494: HADOOP-18425. ABFS rename recovery

2023-04-14 Thread via GitHub
steveloughran closed pull request #5494: HADOOP-18425. ABFS rename recovery URL: https://github.com/apache/hadoop/pull/5494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18690) Fix for Javac Error of Unchecked Cast

2023-04-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712338#comment-17712338 ] Steve Loughran commented on HADOOP-18690: - those branches aren't going to get any commits;

[jira] [Commented] (HADOOP-18693) Upgrade Apache Derby from 10.10.2.0 to 10.14.2.0 due to CVEs

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712335#comment-17712335 ] ASF GitHub Bot commented on HADOOP-18693: - steveloughran commented on PR #5427: URL:

[jira] [Commented] (HADOOP-18697) transient failure of ITestS3APrefetchingInputStream.testRandomReadLargeFile

2023-04-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712336#comment-17712336 ] Steve Loughran commented on HADOOP-18697: - i think my mbp m1 is too fast :) > transient

[GitHub] [hadoop] steveloughran commented on pull request #5427: HADOOP-18693. Bump derby from 10.10.2.0 to 10.14.2.0 in /hadoop-project

2023-04-14 Thread via GitHub
steveloughran commented on PR #5427: URL: https://github.com/apache/hadoop/pull/5427#issuecomment-1508334324 needs to go back in to branch-3.3. too... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HADOOP-18693) Upgrade Apache Derby from 10.10.2.0 to 10.14.2.0 due to CVEs

2023-04-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18693: Affects Version/s: 3.4.0 > Upgrade Apache Derby from 10.10.2.0 to 10.14.2.0 due to CVEs

[jira] [Updated] (HADOOP-18693) Upgrade Apache Derby from 10.10.2.0 to 10.14.2.0 due to CVEs

2023-04-14 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18693: Component/s: build test > Upgrade Apache Derby from 10.10.2.0 to

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712311#comment-17712311 ] ASF GitHub Bot commented on HADOOP-18689: - hadoop-yetus commented on PR #5502: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1508280194 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5552: HDFS-16979. RBF: Add dfsrouter port in hdfsauditlog

2023-04-14 Thread via GitHub
hadoop-yetus commented on PR #5552: URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1508279582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] YuanbenWang commented on pull request #5520: HDFS-16965. Add switch to decide whether to enable native codec.

2023-04-14 Thread via GitHub
YuanbenWang commented on PR #5520: URL: https://github.com/apache/hadoop/pull/5520#issuecomment-1508272207 @cnauroth Thank you for your very nice suggestion. I'v updated the code and could you review this please? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712301#comment-17712301 ] ASF GitHub Bot commented on HADOOP-18695: - dannycjones commented on code in PR #5548: URL:

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

2023-04-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712302#comment-17712302 ] ASF GitHub Bot commented on HADOOP-18695: - dannycjones commented on code in PR #5548: URL:

  1   2   >