mudit-97 commented on PR #5681:
URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1562290159
@slfan1989 , addressed your existing comments, please check once if this
looks fine now
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hadoop-yetus commented on PR #5673:
URL: https://github.com/apache/hadoop/pull/5673#issuecomment-1562273496
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5676:
URL: https://github.com/apache/hadoop/pull/5676#issuecomment-1562270701
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1562249236
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Hexiaoqiao commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1562234324
Try to improve it as following, JFYI.
```
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
ayushtkn commented on code in PR #5688:
URL: https://github.com/apache/hadoop/pull/5688#discussion_r1204964520
##
hadoop-project-dist/pom.xml:
##
@@ -106,7 +106,7 @@
${maven.compile.source}
${maven.compile.encoding}
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204946163
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/metrics/TestNameserviceRPCMetrics.java:
##
@@ -134,5 +136,26 @@ public
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1562182695
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1562170954
Oh, i am so sorry about forcing push again, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hfutatzhanghb commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204928219
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##
@@ -153,7 +157,7 @@
hadoop-yetus commented on PR #5673:
URL: https://github.com/apache/hadoop/pull/5673#issuecomment-1562051228
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725998#comment-17725998
]
Mukund Thakur commented on HADOOP-17852:
seeing this in one of our customer prod cluster.
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204749915
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##
@@ -153,7 +157,7 @@
slfan1989 commented on PR #5663:
URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1561955378
@goiri Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204730561
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##
@@ -153,7 +157,7 @@
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204751202
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/metrics/TestNameserviceRPCMetrics.java:
##
@@ -134,5 +136,26 @@ public
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204749620
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##
@@ -153,7 +157,7 @@
hadoop-yetus commented on PR #5689:
URL: https://github.com/apache/hadoop/pull/5689#issuecomment-1561911820
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
simbadzina commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204730561
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationRPCPerformanceMonitor.java:
##
@@ -153,7 +157,7 @@
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725941#comment-17725941
]
Chris Bevard commented on HADOOP-18706:
---
Sorry. I just noticed your previous comments about the
hadoop-yetus commented on PR #5688:
URL: https://github.com/apache/hadoop/pull/5688#issuecomment-1561814620
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725928#comment-17725928
]
Steve Loughran commented on HADOOP-18685:
-
the tests went in with HADOOP-17822; we just needed
steveloughran opened a new pull request, #5689:
URL: https://github.com/apache/hadoop/pull/5689
* changes the default value to keep
* doesn't log it at info
* updated docs
* cut all marker tool commands from the SDK qualification commands *
### How was this patch tested?
goiri merged PR #5663:
URL: https://github.com/apache/hadoop/pull/5663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Helen Weng created HADOOP-18753:
---
Summary: S3AFileSystem doesn't consistently handle prefixes that
are both files and directories between versions
Key: HADOOP-18753
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reopened HADOOP-18706:
-
bad news Chris, had to revert this.
Can you do a new pr which has very short filenames
[
https://issues.apache.org/jira/browse/HADOOP-18744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725911#comment-17725911
]
Steve Loughran commented on HADOOP-18744:
-
me too. going to roll back the initial change.
>
[
https://issues.apache.org/jira/browse/HADOOP-18685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725909#comment-17725909
]
Steve Loughran commented on HADOOP-18685:
-
what tests fail
> Amazon S3 disabling ACLs on all
GauthamBanasandra opened a new pull request, #5688:
URL: https://github.com/apache/hadoop/pull/5688
* This PR changes `destDir` attribute of the maven-javadoc-plugin to have a
relative path instead of an absolute path, which would otherwise lead to an
incorrect output path for javadoc.
hadoop-yetus commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1561707132
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran reassigned HADOOP-18752:
---
Assignee: Steve Loughran
> Change fs.s3a.directory.marker.retention to "keep"
>
Steve Loughran created HADOOP-18752:
---
Summary: Change fs.s3a.directory.marker.retention to "keep"
Key: HADOOP-18752
URL: https://issues.apache.org/jira/browse/HADOOP-18752
Project: Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
[
https://issues.apache.org/jira/browse/HADOOP-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautham Banasandra updated HADOOP-18751:
Description:
The javadoc build phase fails with the following error -
{code}
Gautham Banasandra created HADOOP-18751:
---
Summary: Fix incorrect output path in javadoc build phase
Key: HADOOP-18751
URL: https://issues.apache.org/jira/browse/HADOOP-18751
Project: Hadoop
hadoop-yetus commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1561676524
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #5676:
URL: https://github.com/apache/hadoop/pull/5676#discussion_r1204468968
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -4326,6 +4326,23 @@ public static boolean
slfan1989 commented on PR #5663:
URL: https://github.com/apache/hadoop/pull/5663#issuecomment-1561508120
@goiri Can you help to merge this pr into the trunk branch? Thank you very
much! I will continue to follow up on YARN-8337.
--
This is an automated message from the Apache Git
goiri commented on code in PR #5676:
URL: https://github.com/apache/hadoop/pull/5676#discussion_r1204448803
##
goiri commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1204411924
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/metrics/TestNameserviceRPCMetrics.java:
##
@@ -134,5 +136,26 @@ public void
goiri commented on code in PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#discussion_r1204408155
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java:
##
@@ -34,31 +39,32 @@
import
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204372000
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,36 @@ public void testConcatOnSameFile()
hadoop-yetus commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1561271546
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204175628
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,36 @@ public void testConcatOnSameFile()
Hexiaoqiao commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204104857
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,66 @@ public void
lfxy commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204017406
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,36 @@ public void testConcatOnSameFile()
ayushtkn commented on code in PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#discussion_r1203933698
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServiceUtil.java:
ferdelyi commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1560937862
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ferdelyi commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1560935941
buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Hexiaoqiao commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1203851566
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,36 @@ public void
Hexiaoqiao commented on code in PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#discussion_r1203851566
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java:
##
@@ -564,4 +564,36 @@ public void
[
https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725734#comment-17725734
]
Rakesh Radhakrishnan commented on HADOOP-18750:
---
Done! Please raise PR if you have a
[
https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh Radhakrishnan reassigned HADOOP-18750:
-
Assignee: Aman Raj
> Spark History Server 3.3.1 fails to starts with
[
https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725729#comment-17725729
]
Aman Raj commented on HADOOP-18750:
---
Can anyone in the community please give me the contributor
[
https://issues.apache.org/jira/browse/HADOOP-18747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725715#comment-17725715
]
Steve Loughran commented on HADOOP-18747:
-
ok. i do have one of those, probably, or if we know
hadoop-yetus commented on PR #4990:
URL: https://github.com/apache/hadoop/pull/4990#issuecomment-1560722101
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1560709015
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5561:
URL: https://github.com/apache/hadoop/pull/5561#issuecomment-1560707943
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
sodonnel commented on code in PR #5687:
URL: https://github.com/apache/hadoop/pull/5687#discussion_r1203703794
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##
@@ -916,7 +917,7 @@ void waitForAckedSeqno(long seqno) throws
hfutatzhanghb commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1560592625
The failed unit test was passed in my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hadoop-yetus commented on PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#issuecomment-1560571479
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#discussion_r1203482790
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##
@@ -2630,6 +2632,31 @@ public int
66 matches
Mail list logo
