Second patch, somewhat easier, replacing the first one....

2001-12-13 Thread Mika Goeckel
Rob, is that what you thought of? I got rid of the second interface by changing 'Rule'. Seems more straightforward. About other matching methods: Yes, I think other methods of matching (XPath i.e.) could come, but as long as the interface is backwards compatible, selfconfiguring objects will con

Re: selfconfiguring objects patch for digester

2001-12-13 Thread Mika Goeckel
Rob, yes, foolish the second interface is not necessary. I review my code and simplify it M. - Original Message - From: "robert burrell donkin" <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Thursday, December 13, 2001 9:37 PM Subject: Re: se

Re: CollectionsUtils.slice: role of 'end'?

2001-12-13 Thread bayard
Thanks for pointing that out Janek. I've recommited with some commenting and the missing line of 'end--;'. (after the object is added to the new collection). A more important question to now think about is whether the method has any life at all. I wrote it because I had a List-like collection tha

cvs commit: jakarta-commons-sandbox/util/src/java/org/apache/commons/util CollectionsUtils.java

2001-12-13 Thread bayard
bayard 01/12/13 13:54:23 Modified:util/src/java/org/apache/commons/util CollectionsUtils.java Log: Added comment to the point that the start argument is include, and the end argument is exclusive. Need to decide if the method is really useful at all to more than just myself.

cvs commit: jakarta-commons-sandbox/util/src/java/org/apache/commons/util CollectionsUtils.java

2001-12-13 Thread bayard
bayard 01/12/13 13:50:24 Modified:util/src/java/org/apache/commons/util CollectionsUtils.java Log: Some documentation added to the slice method and a missing, all-important end-- added in. Previous versions will only slice off the end of a collection and will not obey the slice

CollectionsUtils.slice: role of 'end'?

2001-12-13 Thread Janek Bogucki
Does anyone know the intention of this method? I'm confused about the role 'end' has. It only affects the method logic when end == start. Many Thanks, Janek org.apache.commons.util.CollectionsUtils static public Collection slice(Collection coll, int start, int end) { if(coll == null

Re: selfconfiguring objects patch for digester

2001-12-13 Thread robert burrell donkin
On Thursday, December 13, 2001, at 06:23 PM, Mika Goeckel wrote: > Hi Robert, > > take your time. > > The reason for me to change the basic rules is, that it is transparent to > existing code. You will see that instantly when you look at the code. i'm a bit confused about why you need another in

Re: selfconfiguring objects patch for digester

2001-12-13 Thread robert burrell donkin
On Thursday, December 13, 2001, at 06:23 PM, Mika Goeckel wrote: > Hi Robert, hi mika > take your time. i'm not a committer for digester, so i don't get a veto. i was just telling people that i might have some opinions on this. > The reason for me to change the basic rules is, that it is tran

Re: Self configuring Objects or is it possible to change the rule set during the parse phase?

2001-12-13 Thread robert burrell donkin
(i've had a look but i need a bit more time to think before i comment on the actual patch) i suppose that i should state my general feelings on the issue of 'how to deal with extensible object models'. in general, i agree with jason approach. the 'right' way is to have a list of reasonable ass

Re: selfconfiguring objects patch for digester

2001-12-13 Thread Mika Goeckel
Hi Robert, take your time. The reason for me to change the basic rules is, that it is transparent to existing code. You will see that instantly when you look at the code. On knowledge about rulesets: The object get's the digester instance so it has full access to the rules that already are in p

Re: selfconfiguring objects patch for digester

2001-12-13 Thread Craig R. McClanahan
On Thu, 13 Dec 2001, robert burrell donkin wrote: > Date: Thu, 13 Dec 2001 18:07:44 + > From: robert burrell donkin <[EMAIL PROTECTED]> > Reply-To: Jakarta Commons Developers List <[EMAIL PROTECTED]> > To: Jakarta Commons Developers List <[EMAIL PROTECTED]> > Subject: Re: selfconfiguring ob

Re: selfconfiguring objects patch for digester

2001-12-13 Thread robert burrell donkin
i haven't had a look at this patch in detail but i'd like the chance to take a decent look and have a little think about it before it's committed. FWIW, my gut instinct is that modifying basic rules is the wrong way to implement this feature and there has to be a better way. a self configuring

selfconfiguring objects patch for digester

2001-12-13 Thread Mika Goeckel
Hi,   please find attached my changes to Digester, ObjectCreateRule and ObjectCreationFactory + two new interfaces (source in the jar). I think my docu is not that good -- English is not my mother tongue.   Some example is in the documentation of SelfConfigureObject.   Looking forward to you

Re: FW: HttpClient

2001-12-13 Thread Rodney Waldhoff
>is there any reason why [HttpMethodBase.setHttp11(boolean)] >should not be public. Not that I'm aware of. Since it's easier to make a private method public than vice versa, we dropped everything down to the lowest level of accessibility that seemed reasonable. Your example: >Unfortunately sil

Re: [BETWIXT] some changes

2001-12-13 Thread James Strachan
Hi Robert - Original Message - From: "robert burrell donkin" <[EMAIL PROTECTED]> > i'd like to start adding some enhancements to betwixt. my starting to do > list is: > > 1. add property getter and setter for the XMLIntrospector used by > BeanWriter. (allowing the introspection behaviour