Re: [lang] ExceptionUtils methods

he suggests ExceptionUtils.toMessage(ex) and ExceptionUtils.toMessage(ex, stackFrameCount). -- Regards, Fredrik Westermarck - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [lang] VOTE 2.1 release based on RC8

Steven Caswell wrote: Now that RC8 (http://www.apache.org/~stevencaswell/commons-lang-2.1) has been up for a few days with no issues, I propose it becomes the 2.1 release. [X] +1 [ ] -1 Regards, Fredrik Westermarck

Re: [lang] checkstyle report

? I agree with your proposal to wait until after a release to decide on how to resolve the issues. After all the number of checkstyle issues have decreased in 2.1-RC6, when comparing it to the 2.0 release. Regards, Fredrik Westermarck

Re: [lang] VOTE 2.1 release

Henri Yandell wrote: Proposing a vote to go ahead and release Commons Lang 2.1. [X] +1 [ ] -1 /Fredrik Westermarck - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [lang] New StringUtils method - defaultIfEmpty

; } else { return str; } } Does this sound OK to add? Since what you describe is a rather common use case I'm +1. /Fredrik Westermarck - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Matthew Inger as Commons Committer Re: [Lang] Commit Karma

Henri Yandell wrote: Quick vote so that Matthew can work on the code he contributed to Lang. He's a Jakarta committer already, so will just be a case of adding karma. [ ] +1 - Fix it [ ] -1 - Send a patch +1 - To unsubscribe,

Re: [lang] CharacterEncoding

Stephen Colebourne wrote: We should move to decide on the inclusion or not of this class. My vote is +1 However I would prefer the name CharEncoding (avoids clash with sun class and fits better with other lang classes) +1 on inclusion of the class and the name of the class.

Re: [lang] Designs and Futures

to support cut-and-paste coding it ought to be stated as a design goal in the docs - it's a bit hard to guess this as a newcomer or an outsider. :-) While we're talking about Validate anyway - how about renaming it to ValidateUtils like all other utility classes? Regards, Fredrik Westermarck

Re: [lang] Markup stuff on lang???

Stephen Colebourne wrote: There was some effort towards creating a 2.1 a couple of months ago, but it came to nothing. We should have another go really ;-) I agree. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [lang] Validate - instanceof test?

Michael Lanzetta wrote: P.S. I'm not a contributor, so does anyone have a pointer to the patch-submission process? Hi! Hava a look at http://jakarta.apache.org/commons/patches.html. - To unsubscribe, e-mail: [EMAIL PROTECTED]

Re: [lang] DateRange

Stephen Colebourne wrote: You might want to consider the API of the Duration/Interval classes there as part of this. Hi! Do you mean that you intend to donate the code of the Interval and Duration classes to commons-lang? Regards, Fredrik Westermarck

Re: [lang] DateRange

to make sure first so that we don't reimplement things. :) Regards, Fredrik Westermarck - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [lang] Removing code from deprecated NumberUtils

exactly the same, then a forwarding implementation would be OK. Stephen Since lang.NumberUtils is deprecated, I don't see a point in making any modifications to it. Fredrik Westermarck wrote: How about removing tha code in o.a.c.lang.NumberUtils and dispatching calls to the corresponding method

Re: [lang] Codestyle (Was: [lang] [patch] Conversion of String to long/double)

Phil Steitz wrote: Strangely, the checkstyle plugin is not complaining about any tabs in the code. Are you finding these in the tests or in the /java sources? The differences is mainly in lines that are blank. In the cvs these lines contains 6 whitespace chars and there are no whitespaces in my

Re: [lang] [patch] Conversion of String to long/double

Stephen Colebourne wrote: Do we feel that the stringToInt() naming is good for these methods? BooleanUtils uses toBoolean(), which is shorter and fits better with JDK standards. Thus toInt(String) toLong(String) etc. Opinions? I agree that the toType methodname is better.

Re: [lang] Codestyle (Was: [lang] [patch] Conversion of String to long/double)

Phil Steitz wrote: Strangely, the checkstyle plugin is not complaining about any tabs in the code. Are you finding these in the tests or in the /java sources? The differences is mainly in lines that are blank. In the cvs these lines contains 6 whitespace chars and there are no whitespaces in

[lang] [patch] Conversion of String to long/double

Hi! Here is the patch that adds stringToLong(String str), stringToLong(String str, long), stringToDouble(String str) and stringToDouble(String str, double), testcases are also included. I have also improved the testcase for stringToFloat(String). Hopefully I managed to get the diff right. I

[lang] Codestyle (Was: [lang] [patch] Conversion of String to long/double)

Henri Yandell wrote: Hopefully I managed to get the diff right. I had to remove several lines by hand because of differences in the indentation (space vs tabs?). Is there any document that describes what codestyle commons-lang is supposed to use? In the long term, a maven site and checkstyle

[lang] [patch] Conversion of String to float

Hi! Here is a patch that adds stringToFloat(String) and stringToFloat(String, float) in o.a.c.lang.math.NumberUtils (including testcases in NumberUtilsTest). commons-lang-NumberUtils.zip Description: Zip compressed data -

[lang] [patch] Javadoc fixes

Hi! Here is a patch that corrects some Javadoc in CharRange, CharSet, CharSetUtils, IntRange, DateUtils and FastDateFormat. lang.zip Description: Zip archive - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: [lang] Javadocfixes and minor changes

Fredrik Westermarck wrote: I will send some more patches mostly javadoc formatting later on today. Hi! Here are the promised patches. I have fixed some javadoc (mostly formatting) in alot of classes and in ReflectionUtils changed to appending a char to the StringBuffer instead of a single char

[lang] Javadocfixes and minor changes

Hi! The following patch includes some javadoc fixes (RandomStringUtils, StringEscapeUtils, StringUtils, SystemUtils and WordWrapUtils), mostly formatting. In StringUtils I also changed rightPad(String, int), leftPad(String, int) and leftPad(String, int, char) to use ' ' instead of when

Javdoc formatting (Was: [lang] [patch] Javadoc improvements)

Henri Yandell wrote: I'm all for having consistent javadoc. Feel like writing up the 'rules' for the javadoc style you've ended up on? Hi! Here is the promised rules that I try to follow when writing javadoc. Ofcourse the Sun javadoc guidelines is used, this is only to be seen as an

Re: [lang] [patch] Javadoc improvements

Stephen Colebourne wrote: Patch applied. (We haven't actually agreed on a format for p /p html tags in javadoc, but I decided that there was other useful formatting in the patch as well - actually since this is committed, now a decision on the style is probably effectively taken for lang ;-).

Re: [lang] [patch] Javadoc improvements

Henri Yandell wrote: I'm all for having consistent javadoc. Feel like writing up the 'rules' for the javadoc style you've ended up on? Sure, I can always try to document it. I'll just want to finish the changes in the javadoc for o.a.c.lang.builder first. [From the files often changed I

[lang] [patch] Javadoc improvements

Hi! Here is a patch where I have added formatting to the Javadoc (only for the classes in o.a.c.lang not in the subpackages) so that the generated Javadoc is easier to read. Some typos was also fixed. -- To unsubscribe, e-mail: mailto:commons-dev-unsubscribe;jakarta.apache.org For additional

Re: [lang] [patch] Javadoc

Stephen Colebourne wrote: I tried to apply the patch, but it failed, so I've done it mostly by hand instead. You may want to check the CVS again ;-) Hi! I've attached a new patch with the most obvious changes that was missed. :) Index: StringUtils.java

Re: [lang] [patch] Javadoc

Stephen Colebourne wrote: Unfortunately its the patch format thats wrong (Eclipse doesn't like it). See: http://jakarta.apache.org/commons/patches.html (I think its the -u you're missing) You're right, I did miss the -u switch. Thats what happens when you try to use an GUI-application... :)

Re: [lang][patch] StringUtils

Fredrik Westermarck wrote: Hi! I have attached a patch that improves the javadoc in StringUtils. Please review the patch and commit it if it meet the standards. -- Fredrik Westermarck -- To unsubscribe, e-mail: mailto:commons-dev-unsubscribe;jakarta.apache.org For additional commands, e

[lang][patch] ExceptionUtils

Hi! In the attached patch I have fixed the TODO that was in the method getStackFrames(String). ExceptionUtils.java.diff Description: Binary data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

[lang] [patch] Removal of unused imports

Hi! Here is a patch where I have removed unused imports in o.a.c.lang. Regards, Fredrik Westermarck lang.diff Description: Binary data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

[lang][patch] StringUtils

Hi! Here is a patch where I have fixed a typo in javadoc and removed some unused code in StringUtils. Regards, Fredrik Westermarck StringUtils.diff Description: Binary data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

[lang][PATCH] StringUtils

Hi! Here is a patch for the StringUtils class with a containsOnly-method. Well actually it's two patches since I also added testcases. Fredrik Westermarck -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

Re: [lang][PATCH] StringUtils

Fredrik Westermarck wrote: Hi! Here is a patch for the StringUtils class with a containsOnly-method. Well actually it's two patches since I also added testcases. Since Mozilla tries to inline attachments they somehow got lost. I packaged them in a zip-file instead. Hopefully