Re: Introducing commons-skin

2007-01-12 Thread Dennis Lundberg
Dennis Lundberg wrote: Dennis Lundberg wrote: Boris Unckel wrote: Hi, yet another issue. snip I had a look at the source and found XHTML transistional in the doctype. Both http://validator.w3.org and http://www.validome.org say it is not valid. I think you know the tools, even when not,

Re: Introducing commons-skin

2007-01-10 Thread Dennis Lundberg
Dennis Lundberg wrote: Boris Unckel wrote: Hi, yet another issue. snip I had a look at the source and found XHTML transistional in the doctype. Both http://validator.w3.org and http://www.validome.org say it is not valid. I think you know the tools, even when not, they are very easy to

Re: Introducing commons-skin

2007-01-10 Thread Dennis Lundberg
Dennis Lundberg wrote: Dennis Lundberg wrote: Henri Yandell wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Yes, I have seen that as well. The problem is that the M2 site plugin does not generate

Re: Introducing commons-skin

2006-12-30 Thread Jörg Schaible
Phil Steitz wrote: Hmmm. http://people.apache.org/~dennisl/commons-lang3/http://people.apache.org/%7Edennisl/commons-lang3/ puts the nav bar in the right place flush left, but shows a big black box between the Jakarta and Lang logos on the top. Same for me with Firefox 1.5.0.9,

Re: Introducing commons-skin

2006-12-30 Thread Boris Unckel
Hello, I have tested on Windows Vista RC1 with a) Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1 b) Internet Explorer 7.0.5600.16384 Both with default settings for fonts and CSS. Phil Steitz wrote: http://people.apache.org/~dennisl/commons-lang3/

Re: Introducing commons-skin

2006-12-30 Thread Boris Unckel
Hello, another test with Opera 9.10 Build 8679 under Windows Vista RC1. Default settings for fonts and CSS. Phil Steitz wrote: http://people.apache.org/~dennisl/commons-lang3/ puts the nav bar in the right place flush left, but shows a big black box between the Jakarta and Lang logos on the

Re: Introducing commons-skin

2006-12-30 Thread Dennis Lundberg
Dennis Lundberg wrote: Phil Steitz wrote: snip http://people.apache.org/~dennisl/commons-lang4/http://people.apache.org/%7Edennisl/commons-lang4/ puts the nav bar in the middle, as before. That's odd. There must be something more that is wrong then. Unfortunately I haven't been able to

Re: Introducing commons-skin

2006-12-30 Thread Jörg Schaible
Dennis Lundberg wrote: Dennis Lundberg wrote: Phil Steitz wrote: snip http://people.apache.org/~dennisl/commons-lang4/http://people.apache.org/%7Edennisl/commons-lang4/ puts the nav bar in the middle, as before. That's odd. There must be something more that is wrong then.

Re: Introducing commons-skin

2006-12-30 Thread Boris Unckel
Hi, Dennis Lundberg wrote: OK, I think I've got it this time. As it turned out I had put in my stylesheet rules in a different place than they should be, so I ended up having contradicting rules for the same selector. The conflicts have been solved and the rules have been moved to the

Re: Introducing commons-skin

2006-12-30 Thread Dennis Lundberg
Boris Unckel wrote: Hi, Dennis Lundberg wrote: OK, I think I've got it this time. As it turned out I had put in my stylesheet rules in a different place than they should be, so I ended up having contradicting rules for the same selector. The conflicts have been solved and the rules have been

Re: Introducing commons-skin

2006-12-30 Thread Phil Steitz
On 12/30/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Dennis Lundberg wrote: Phil Steitz wrote: snip http://people.apache.org/~dennisl/commons-lang4/ http://people.apache.org/%7Edennisl/commons-lang4/ puts the nav bar in the middle, as before. That's odd. There must be something more

Re: Introducing commons-skin

2006-12-30 Thread Boris Unckel
Hi, Dennis Lundberg wrote: Boris Unckel wrote: http://people.apache.org/~dennisl/commons-lang5/ I have tested with: - Firefox 2.0.0.1 on Windows Vista RC1 (my personal reference) - looks fine - Internet Explorer 7 on Windows Vista RC1 -- looks fine, except headings (Commons Lang,

Re: Introducing commons-skin

2006-12-30 Thread Boris Unckel
Hi, yet another issue. Dennis Lundberg wrote: OK, I think I've got it this time. As it turned out I had put in my stylesheet rules in a different place than they should be, so I ended up having contradicting rules for the same selector. The conflicts have been solved and the rules have been

Re: Introducing commons-skin

2006-12-30 Thread Dennis Lundberg
Boris Unckel wrote: Hi, yet another issue. snip I had a look at the source and found XHTML transistional in the doctype. Both http://validator.w3.org and http://www.validome.org say it is not valid. I think you know the tools, even when not, they are very easy to use (I did not write:

Re: Introducing commons-skin

2006-12-30 Thread Dennis Lundberg
Dennis Lundberg wrote: Henri Yandell wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Yes, I have seen that as well. The problem is that the M2 site plugin does not generate a class=externalLink for

Re: Introducing commons-skin

2006-12-29 Thread Dennis Lundberg
Phil Steitz wrote: Hmmm. http://people.apache.org/~dennisl/commons-lang3/http://people.apache.org/%7Edennisl/commons-lang3/ puts the nav bar in the right place flush left, but shows a big black box between the Jakarta and Lang logos on the top. Yes, I used the standard maven-classic-skin

Re: Introducing commons-skin

2006-12-29 Thread Phil Steitz
Thanks, and sorry I can't be of more help. I am pretty clueless when it comes to css. I am happy to help test, though. I don't think my browser font setting are funny. I did not change them from the defaults when I installed FireFox. Phil

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Henri Yandell wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Yes, I have seen that as well. The problem is that the M2 site plugin does not generate a class=externalLink for those links like M1

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) A couple of things I noticed: * The Docs for 2.2 is

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Phil Steitz wrote: Thanks, Dennis! On 12/27/06, Martin Cooper [EMAIL PROTECTED] wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I

Re: Introducing commons-skin

2006-12-28 Thread Phil Steitz
On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Phil Steitz wrote: Thanks, Dennis! On 12/27/06, Martin Cooper [EMAIL PROTECTED] wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows

Re: Introducing commons-skin

2006-12-28 Thread Martin Cooper
On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those.

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) There's no built-in support for these arrows. I'm

Re: Introducing commons-skin

2006-12-28 Thread Phil Steitz
On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those.

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Phil Steitz wrote: On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care.

Re: Introducing commons-skin

2006-12-28 Thread Dennis Lundberg
Phil Steitz wrote: On 12/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Martin Cooper wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care.

Re: Introducing commons-skin

2006-12-28 Thread Phil Steitz
Hmmm. http://people.apache.org/~dennisl/commons-lang3/http://people.apache.org/%7Edennisl/commons-lang3/ puts the nav bar in the right place flush left, but shows a big black box between the Jakarta and Lang logos on the top.

Introducing commons-skin

2006-12-27 Thread Dennis Lundberg
Hi all Finally I took the time to sit down and create a Maven 2 skin for Jakarta Commons. What I have done is taken maven-classic-skin and combined that with the stylesheet rules that can be found in the site.xml file in commons/trunks-sandbox. Then I played around with the site for

Re: Introducing commons-skin

2006-12-27 Thread Henri Yandell
Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Definitely don't care that 'About Lang' is gone; and I'm not bothered that 'Development Process' is gone either. I presume these are standard Maven things that

Re: Introducing commons-skin

2006-12-27 Thread Martin Cooper
On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) A couple of things I noticed: * The Docs for 2.2 is missing. Personally, I

Re: Introducing commons-skin

2006-12-27 Thread Phil Steitz
Thanks, Dennis! On 12/27/06, Martin Cooper [EMAIL PROTECTED] wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) A