Charset Transformation - (previously) Re: [VOTE] Re: 2.0 release

2003-07-11 Thread Sung-Gu
You got me! ;) Sung-Gu - Original Message - From: André-John Mas [EMAIL PROTECTED] To: Commons HttpClient Project [EMAIL PROTECTED] Sent: Friday, June 27, 2003 12:23 AM Subject: Re: [VOTE] Re: 2.0 release - deprecate some methods? This doesn't look correct, if you are really

Re: [VOTE] Re: 2.0 release

2003-06-26 Thread Ortwin Glück
+1 Adrian Sutton wrote: I move the motion that the following methods from org.apache.commons.httpclient.util.URIUtil be depreciated for the 2.0 release and removed in a future release: toDocumentCharset(String) toDocumentCharset(String, String) toProtocolCharset(String)

RE: [VOTE] Re: 2.0 release

2003-06-26 Thread Kalnichevski, Oleg
+1 -Original Message- From: Adrian Sutton [mailto:[EMAIL PROTECTED] Sent: Thu 6/26/2003 11:10 To: Commons HttpClient Project Cc: Subject:[VOTE] Re: 2.0 release All, Personally, I believe that this issue has gone on far too long and so I would like to propose a

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Sung-Gu
-1 My vote... :D FYI, (it's from URI javadoc messages, I think they are related to your topic.) [snip] * The character set used to store files SHALL remain a local decision and * MAY depend on the capability of local operating systems. Prior to the * exchange of URIs they

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Ortwin Glck
Sung-Gu wrote: I've made sample cases and posted it before. (even if it's not a normal junit testcase though.) And I'm not willing to make testcase for that. I'm not interested in unicode values... at all... Sung-Gu, I there are no test cases, how can we be sure these methods do what they are

Re: [VOTE] Re: 2.0 release

2003-06-26 Thread Michael Becke
+1 On Thursday, June 26, 2003, at 05:10 AM, Adrian Sutton wrote: All, Personally, I believe that this issue has gone on far too long and so I would like to propose a vote: I move the motion that the following methods from org.apache.commons.httpclient.util.URIUtil be depreciated for the 2.0

Re: [VOTE] Re: 2.0 release - deprecate some methods? test case always certainly...?

2003-06-26 Thread Sung-Gu
- Original Message - From: Ortwin Glück [EMAIL PROTECTED] are supposed to do? I find it dangerous to have code that nobody Ok, Sorry, then as you wish, I'll change my vote +1. I hope you're happy... understands (except of you) without any test cases. Actually, I don't understand

RE: [VOTE] Re: 2.0 release - deprecate some methods? test case always certainly...?

2003-06-26 Thread Kalnichevski, Oleg
Actually, I don't understand that you might notice and you might wonder why there is encoding change menu in your web browser. and you can test it yourself though. Knock, knock. Hello, anybody home? Half a year ago, when this whole story started I tried to explain you one simple thing: in

Re: [VOTE] Re: 2.0 release

2003-06-26 Thread Eric Johnson
Adrian, +1 OK, my vote is non-binding, but with no test cases, and no code in HttpClient that uses the functions, we SHOULD deprecate them. Even if we decide later, as Sung-Gu suggested, that we might need to ressurrect them, we should still deprecate them! Deprecating them is a flag for

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Sung-Gu
- Original Message - From: Adrian Sutton [EMAIL PROTECTED] If you don't know why the code would be useful or what it was implemented based upon, why is it that you still want it in HttpClient? There is nothing that uses those methods anywhere in HttpClient and the presence of an

Re: [VOTE] Re: 2.0 release - current vote result!

2003-06-26 Thread Sung-Gu
- Original Message - From: Eric Johnson [EMAIL PROTECTED] Even if we decide later, as Sung-Gu suggested, that we might need to ressurrect them, we should still deprecate them! Deprecating them is a Done. Sung-Gu

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Jandalf
+1 As these methods are not used by HttpClient and do not appear useful for httpclient for httpclient users combined with the reality that they do not appear correct and the pending desire to start a Commons-URI project indicates that they should not be in the public interface of HttpClient.

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Laura Werner
Adrian Sutton wrote: The flaw in the toUsingCharset method is two-fold: Firstly, Strings in Java are *always* stored internally as UTF-8 I agree with the rest of your analysis of this, but I thought I should point out that Java Strings and chars are stored in UTF-16 rather than UTF-8. A char

Re: [VOTE] Re: 2.0 release - URI charset transformation HOW-TO

2003-06-26 Thread Sung-Gu
Subject: Re: [VOTE] Re: 2.0 release - deprecate some methods? - Original Message - From: Adrian Sutton [EMAIL PROTECTED] If you don't know why the code would be useful or what it was implemented based upon, why is it that you still want it in HttpClient? There is nothing

Re: [VOTE] Re: 2.0 release - deprecate some methods? test casealways certainly...?

2003-06-26 Thread Ortwin Glück
Sung-Gu wrote: But, not a duty... it's voluteering... no pay... even the code constribution here... I pay you $5 for test cases from my Paypal account. Promise. :-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread André-John Mas
This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[] bytes2 = myString.getBytes(destCharset); Until you have the bytes, you don't have the final

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread secoskem
] Re: 2.0 release - deprecate some methods? This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[] bytes2 = myString.getBytes(destCharset); Until you

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Oleg Kalnichevski
On Thu, 2003-06-26 at 23:40, [EMAIL PROTECTED] wrote: I just got through Internationalizing a website... input and output. I ran into the exact same issues, and as Andre states, you pretty much need to check everywhere for byte[] -String and String-byte[]. Matt, we actually do. We do have

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread André-John Mas
This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[] bytes2 = myString.getBytes(destCharset); Until you have the bytes, you don't have the final