Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Ortwin Glück
[EMAIL PROTECTED] wrote: I just got through Internationalizing a website... input and output. I ran into the exact same issues, and as Andre states, you pretty much need to check everywhere for byte[] ->String and String->byte[]. Be assured that HttpClient uses the right encoding on every platfo

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread André-John Mas
This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[] bytes2 = myString.getBytes(destCharset); Until you have the bytes, you don't have the final output,

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread secoskem
t; To: Commons HttpClient Project <[EMAIL PROTECTED]> cc: Subject: Re: [VOTE] Re: 2.0 release - deprecate some methods? On Thu, 2003-06-26 at 23:40, [EMAIL PROTECTED] wrote: > I just got through Internationalizing a website... input and output. I > ra

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Oleg Kalnichevski
On Thu, 2003-06-26 at 23:40, [EMAIL PROTECTED] wrote: > I just got through Internationalizing a website... input and output. I > ran into the exact same issues, and as Andre states, you pretty much need > to check everywhere for byte[] ->String and String->byte[]. Matt, we actually do. We do h

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread secoskem
> cc: Subject: Re: [VOTE] Re: 2.0 release - deprecate some methods? This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[]

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread André-John Mas
This doesn't look correct, if you are really wanting to convert from one charset to another then you would have to do something such as: String myString = new String(bytes,bytesCharset); byte[] bytes2 = myString.getBytes(destCharset); Until you have the bytes, you don't have the final output,

Re: [VOTE] Re: 2.0 release - deprecate some methods? & test casealways certainly...?

2003-06-26 Thread Ortwin Glück
Sung-Gu wrote: But, not a duty... it's voluteering... no pay... even the code constribution here... I pay you $5 for test cases from my Paypal account. Promise. :-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional comma

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Laura Werner
Adrian Sutton wrote: The flaw in the toUsingCharset method is two-fold: Firstly, Strings in Java are *always* stored internally as UTF-8 I agree with the rest of your analysis of this, but I thought I should point out that Java Strings and "char"s are stored in UTF-16 rather than UTF-8. A "ch

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Jandalf
+1 As these methods are not used by HttpClient and do not appear useful for httpclient for httpclient users combined with the reality that they do not appear correct and the pending desire to start a Commons-URI project indicates that they should not be in the public interface of HttpClient.

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Sung-Gu
- Original Message - From: "Adrian Sutton" <[EMAIL PROTECTED]> > If you don't know why the code would be useful or what it was > implemented based upon, why is it that you still want it in HttpClient? > There is nothing that uses those methods anywhere in HttpClient and > the presence

RE: [VOTE] Re: 2.0 release - deprecate some methods? & test case always certainly...?

2003-06-26 Thread Kalnichevski, Oleg
> Actually, I don't understand that you might notice and you might wonder > why there is encoding change menu in your web browser. and you can > test it yourself though. Knock, knock. Hello, anybody home? Half a year ago, when this whole story started I tried to explain you one simple thing: in

Re: [VOTE] Re: 2.0 release - deprecate some methods? & test case always certainly...?

2003-06-26 Thread Sung-Gu
- Original Message - From: "Ortwin Glück" <[EMAIL PROTECTED]> > are supposed to do? I find it dangerous to have code that nobody Ok, Sorry, then as you wish, I'll change my vote +1. I hope you're happy... > understands (except of you) without any test cases. Actually, I don't underst

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Adrian Sutton
On Thursday, June 26, 2003, at 10:05 PM, Sung-Gu wrote: -1 My vote... :D I've made sample cases and posted it before. (even if it's not a normal junit testcase though.) And I'm not willing to make testcase for that. I'm not interested in unicode values... at all... Sung-Gu, We are in this posi

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Ortwin Glück
Sung-Gu wrote: I've made sample cases and posted it before. (even if it's not a normal junit testcase though.) And I'm not willing to make testcase for that. I'm not interested in unicode values... at all... Sung-Gu, I there are no test cases, how can we be sure these methods do what they are sup

Re: [VOTE] Re: 2.0 release - deprecate some methods?

2003-06-26 Thread Sung-Gu
-1 My vote... :D FYI, (it's from URI javadoc messages, I think they are related to your topic.) [snip] * The character set used to store files SHALL remain a local decision and * MAY depend on the capability of local operating systems. Prior to the * exchange of URIs they SHOULD