[PATCH] ippool: Fix endless loop issue with 32 prefix length

2012-06-19 Thread Guillaume Zajac
While trying to establish a DUN connection with oFono, an endless loop was found when requesting an IP block. The problem was on data connection activation its address with 32 length prefix was notified through ConnMann using __connman_ippool_newaddr() but mask address shifting with 32 bits was obs

[PATCH] ofono: Fix potential crash

2012-06-27 Thread Guillaume Zajac
If a dummy context is created, it might happen that its index is equal to -1. In this particular case the IP address has not been copied to context->address during ipv4 extraction. If we force from oFono a context activation, it will make ConnMan crashing on set_connected(). --- plugins/ofono.c |

Re: [PATCH 0/5] Private Network API

2011-04-14 Thread Guillaume Zajac
Hi Gustavo, On 13/04/2011 18:45, Gustavo F. Padovan wrote: That is my last version of the Private Network API, I'm not able to work on this anymore so I'm sending it here in the case someone wants to continue this work. Thanks for your job, I will try to continue your work as I am spending som

[PATCH] TODO: set owner on core private networks implementation

2011-04-14 Thread Guillaume Zajac
--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index ea0c5ca..75022f6 100644 --- a/TODO +++ b/TODO @@ -115,6 +115,7 @@ Core Priority: Medium Complexity: C4 + Owner: Guillaume Zajac The private networks D-Bus API should provide

[PATCH_v2 0/5] Private Network API

2011-04-18 Thread Guillaume Zajac
__connman_inet_modify_address() Guillaume Zajac (1): private-network: add API declaration to create a tun interface Gustavo F. Padovan (4): manager: Add hooks for the PrivateNetwork API private-network: add support to create TUN interface private-network: add ip configuration and NAT tools: add private

[PATCH_v2 1/5] manager: Add hooks for the PrivateNetwork API

2011-04-18 Thread Guillaume Zajac
From: Gustavo F. Padovan RequestPrivateNetwork() doesn't return an fd yet and both of them are completely dummy. --- src/connman.h |3 ++ src/manager.c | 38 ++ src/tethering.c | 79 +++ 3 files changed, 120

[PATCH_v2 3/5] private-network: add API declaration to create a tun interface

2011-04-18 Thread Guillaume Zajac
--- include/inet.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/inet.h b/include/inet.h index 9a9411d..19f4455 100644 --- a/include/inet.h +++ b/include/inet.h @@ -75,6 +75,7 @@ int connman_inet_remove_from_bridge(int index, const char *bridge); int connman_

[PATCH_v2 2/5] private-network: add support to create TUN interface

2011-04-18 Thread Guillaume Zajac
From: Gustavo F. Padovan --- src/connman.h |2 +- src/inet.c | 36 src/manager.c |8 +++--- src/tethering.c | 61 -- 4 files changed, 99 insertions(+), 8 deletions(-) diff --git a/src/connm

[PATCH_v2 4/5] private-network: add ip configuration and NAT

2011-04-18 Thread Guillaume Zajac
From: Gustavo F. Padovan --- src/manager.c |3 ++- src/tethering.c | 55 ++- 2 files changed, 56 insertions(+), 2 deletions(-) diff --git a/src/manager.c b/src/manager.c index f73330c..06a66b3 100644 --- a/src/manager.c +++ b/src/manag

[PATCH_v2 5/5] tools: add private-network test

2011-04-18 Thread Guillaume Zajac
From: Gustavo F. Padovan --- Makefile.am |4 +- tools/private-network-test.c | 229 ++ 2 files changed, 232 insertions(+), 1 deletions(-) create mode 100644 tools/private-network-test.c diff --git a/Makefile.am b/Makefile.am index 2

[PATCH_v3 0/5] Private Network API

2011-04-20 Thread Guillaume Zajac
Hi, Change log is: - Use dictionnary to pass IP settings through DBus - Merge 2 patches for connman_inet_create_tunnel() implementation - Add initial doc from Padovan Gustavo F. Padovan (5): doc: add PrivateNetwork interface. manager: Add hooks for the PrivateN

[PATCH_v3 1/5] doc: add PrivateNetwork interface.

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan By now PrivateNetwork interface will cover the DUN server case. --- doc/manager-api.txt | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index c247d9f..56fb832 100644 --- a/doc/man

[PATCH_v3 3/5] private-network: add support to create TUN interface

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- include/inet.h |1 + src/connman.h |2 +- src/inet.c | 36 src/manager.c |8 +++--- src/tethering.c | 61 -- 5 files changed, 100 insertions(+), 8 deletions

[PATCH_v3 2/5] manager: Add hooks for the PrivateNetwork API

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan RequestPrivateNetwork() doesn't return an fd yet and both of them are completely dummy. --- src/connman.h |3 ++ src/manager.c | 38 ++ src/tethering.c | 79 +++ 3 files changed, 120

[PATCH_v3 4/5] private-network: add ip configuration and NAT

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- src/manager.c |3 +- src/tethering.c | 77 +- 2 files changed, 77 insertions(+), 3 deletions(-) diff --git a/src/manager.c b/src/manager.c index f73330c..372e2e5 100644 --- a/src/manager.c +++ b/src/manager

[PATCH_v3 5/5] tools: add private-network test

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- Makefile.am |4 +- tools/private-network-test.c | 268 ++ 2 files changed, 271 insertions(+), 1 deletions(-) create mode 100644 tools/private-network-test.c diff --git a/Makefile.am b/Makefile.am index 2

[PATCH_v4 1/5] doc: add PrivateNetwork interface.

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan By now PrivateNetwork interface will cover the DUN server case. --- doc/manager-api.txt | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index c247d9f..56fb832 100644 --- a/doc/man

[PATCH_v4 0/5] Private network API

2011-04-20 Thread Guillaume Zajac
Hi, Change log is: - add missing "h" into DBus RequestPrivateNetwork prototype - fix header issue in private_network_test.c Gustavo F. Padovan (5): doc: add PrivateNetwork interface. manager: Add hooks for the PrivateNetwork API private-network: add support to create TUN int

[PATCH_v4 3/5] private-network: add support to create TUN interface

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- include/inet.h |1 + src/connman.h |2 +- src/inet.c | 36 src/manager.c |8 +++--- src/tethering.c | 61 -- 5 files changed, 100 insertions(+), 8 deletions

[PATCH_v4 2/5] manager: Add hooks for the PrivateNetwork API

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan RequestPrivateNetwork() doesn't return an fd yet and both of them are completely dummy. --- src/connman.h |3 ++ src/manager.c | 38 ++ src/tethering.c | 79 +++ 3 files changed, 120

[PATCH_v4 4/5] private-network: add ip configuration and NAT

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- src/manager.c |3 +- src/tethering.c | 77 +- 2 files changed, 77 insertions(+), 3 deletions(-) diff --git a/src/manager.c b/src/manager.c index f73330c..4fd966a 100644 --- a/src/manager.c +++ b/src/manager

[PATCH_v4 5/5] tools: add private-network test

2011-04-20 Thread Guillaume Zajac
From: Gustavo F. Padovan --- Makefile.am |4 +- tools/private-network-test.c | 268 ++ 2 files changed, 271 insertions(+), 1 deletions(-) create mode 100644 tools/private-network-test.c diff --git a/Makefile.am b/Makefile.am index 8

3G dongle USB

2011-05-18 Thread Guillaume Zajac
Hi Samuel and Marcel, As you know, I have successfully managed to browse the web using Windows 7 DUN client connected to PPP server from oFono running on my computer with Ubuntu. The default interface used by ConnMan is the ethernet one. I am now trying to connect a USB dongle to my computer t

Re: 3G dongle USB

2011-05-25 Thread Guillaume Zajac
Hi Samuel and Marcel, On 18/05/2011 14:49, Guillaume Zajac wrote: Hi Samuel and Marcel, As you know, I have successfully managed to browse the web using Windows 7 DUN client connected to PPP server from oFono running on my computer with Ubuntu. The default interface used by ConnMan is the

[PATCH] doc: Fix typo on ReleasePrivateNetwork() argument

2011-06-08 Thread Guillaume Zajac
--- doc/manager-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 56fb832..367e865 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -203,7 +203,7 @@ Methods dict GetProperties()

Re: [PATCH] doc: Fix typo on ReleasePrivateNetwork() argument

2011-06-08 Thread Guillaume Zajac
Hi Marcel, On 08/06/2011 12:05, Marcel Holtmann wrote: Hi Guillaume, doc/manager-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 56fb832..367e865 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -

Request multiple network

2011-06-10 Thread Guillaume Zajac
Hi Marcel and Samuel, I plan to update the current private network implementation to be able to request multiple private network. I noticed that using fd as key of hash table is not a good idea:) I would like to have your opinion about the best way to do it. Here is my scenario: When an applica

[PATCH 1/2] doc: Update private network method prototypes

2011-06-22 Thread Guillaume Zajac
--- doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..57b13c9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -195,21 +195,20 @@ Methods dict GetProperties()

[PATCH 0/2] Private network APIs update

2011-06-22 Thread Guillaume Zajac
Hi, 1st patch is updating the documentation. 2nd patch contains the update of the current APIs to support multiple private networks. For the moment all the private networks have the same IP in waiting for IP pool tool management. Kind regards Guillaume Zajac (2): doc: Update private network

[PATCH 2/2] private_network: Update APIs to be able to use multiple private networks

2011-06-22 Thread Guillaume Zajac
--- src/connman.h |2 +- src/manager.c | 11 + src/tethering.c | 66 -- 3 files changed, 46 insertions(+), 33 deletions(-) diff --git a/src/connman.h b/src/connman.h index 2faeb1b..4ef6ec1 100644 --- a/src/connman.h +++ b/src

[PATCH] oFono: Fix crash when using oFono plugin

2011-06-24 Thread Guillaume Zajac
Hi, I noticed when using ConnMan with oFono plugin enabled that I had a crash when I close oFono or I disable phonesim modem. It seems that we are unrefing and unregistering the network althugh it has already been done by device object in calling connman_device_remove_network(). Kind regards, Gui

Re: [PATCH] oFono: Fix crash when using oFono plugin

2011-06-27 Thread Guillaume Zajac
Hi Daniel, On 27/06/2011 08:30, Daniel Wagner wrote: Hi Guillaume, I noticed when using ConnMan with oFono plugin enabled that I had a crash when I close oFono or I disable phonesim modem. It seems that we are unrefing and unregistering the network althugh it has already been done by device ob

Re: [PATCH 2/2] private_network: Update APIs to be able to use multiple private networks

2011-06-27 Thread Guillaume Zajac
Hi Samuel, On 24/06/2011 18:08, Samuel Ortiz wrote: Hi Guillaume, The patch looks pretty good. I have one question for you though: On Wed, Jun 22, 2011 at 02:10:17PM +0200, Guillaume Zajac wrote: static void remove_private_network(gpointer user_data) { struct

[PATCH_v2 1/2] doc: Update private network method prototypes

2011-06-27 Thread Guillaume Zajac
--- doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..57b13c9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -195,21 +195,20 @@ Methods dict GetProperties()

[PATCH_v2 0/2] Private network APIs update

2011-06-27 Thread Guillaume Zajac
Hi, This new version only removes the connman_inet_ifdown() call. It is already done while closing fd in removing private network. Guillaume Zajac (2): doc: Update private network method prototypes private_network: Update APIs to be able to use multiple private networks doc/manager

[PATCH_v2 2/2] private_network: Update APIs to be able to use multiple private networks

2011-06-27 Thread Guillaume Zajac
--- src/connman.h |2 +- src/manager.c | 11 + src/tethering.c | 65 -- 3 files changed, 45 insertions(+), 33 deletions(-) diff --git a/src/connman.h b/src/connman.h index 0c6d6b1..e4c35da 100644 --- a/src/connman.h +++ b/src

Re: [PATCH_v2 1/2] doc: Update private network method prototypes

2011-06-28 Thread Guillaume Zajac
Hi Marcel, On 27/06/2011 19:28, Marcel Holtmann wrote: Hi Guillaume, doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..57b13c9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api

[PATCH_v3 1/2] doc: Update private network method prototypes

2011-06-28 Thread Guillaume Zajac
--- doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..961c39b 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -195,21 +195,20 @@ Methods dict GetProperties()

[PATCH_v3 0/2] Private network APIs update

2011-06-28 Thread Guillaume Zajac
Hi, Changelog from v2 is: - RequestPrivateNetwork D-Bus method returns oa{sv}h instead of oha{sv} to be more consistent with rest of the code. Thus fd handle is considered as an extra parameter Guillaume Zajac (2): doc: Update private network method prototypes

[PATCH_v3 2/2] private_network: Update APIs to be able to use multiple private networks

2011-06-28 Thread Guillaume Zajac
--- src/connman.h |2 +- src/manager.c | 11 src/tethering.c | 70 -- 3 files changed, 48 insertions(+), 35 deletions(-) diff --git a/src/connman.h b/src/connman.h index 0c6d6b1..e4c35da 100644 --- a/src/connman.h +++ b/src/

Re: [PATCH_v3 0/2] Private network APIs update

2011-07-04 Thread Guillaume Zajac
Hi Samuel, On 30/06/2011 12:22, Samuel Ortiz wrote: Hi Guillaume, On Tue, Jun 28, 2011 at 03:19:10PM +0200, Guillaume Zajac wrote: Hi, Changelog from v2 is: - RequestPrivateNetwork D-Bus method returns oa{sv}h instead of oha{sv} to be more consistent with rest of the code

Default cellular profile no more published on D-feet

2011-07-18 Thread Guillaume Zajac
Hi Daniel and Marcel, Until release 0.75, I had no problem to plug a 3G USB dongle, activate it and set it online. Then I was able to see on D-feet the default cellular profile and connect it using the Service "Connect()" method. Since the following commits (I don't know which one exactly) I am

Re: Default cellular profile no more published on D-feet

2011-07-22 Thread Guillaume Zajac
Hi Daniel, On 21/07/2011 15:08, Daniel Wagner wrote: Hi Guillaume, On 07/18/2011 04:27 PM, Guillaume Zajac wrote: Hi Daniel and Marcel, Until release 0.75, I had no problem to plug a 3G USB dongle, activate it and set it online. Then I was able to see on D-feet the default cellular profile

[PATCH] update ofono plugin for CDMA devices

2011-07-27 Thread Guillaume Zajac
Hi Marcel, Here is a first version to make CDMA devices publishing an interface to manage data call. It will require a cdma SIM atom into oFono to retrieve the IMSI. Guillaume Zajac (1): ofono: manage CDMA device into plugin plugins/ofono.c | 246

[PATCH] ofono: manage CDMA device into plugin

2011-07-27 Thread Guillaume Zajac
--- plugins/ofono.c | 246 ++- 1 files changed, 245 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 1bd9a30..80555ce 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -50,6 +50,8 @@ #define OFONO_CONTEXT_

Re: Default cellular profile no more published on D-feet

2011-07-28 Thread Guillaume Zajac
Hi Daniel, On 21/07/2011 15:08, Daniel Wagner wrote: Hi Guillaume, On 07/18/2011 04:27 PM, Guillaume Zajac wrote: Hi Daniel and Marcel, Until release 0.75, I had no problem to plug a 3G USB dongle, activate it and set it online. Then I was able to see on D-feet the default cellular profile

[PATCH_v2] ofono: manage CDMA device into plugin

2011-07-28 Thread Guillaume Zajac
--- plugins/ofono.c | 210 ++- 1 files changed, 209 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 1bd9a30..7b89446 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -50,6 +50,7 @@ #define OFONO_CONTEXT_

[PATCH_v2] update ofono plugin for CDMA devices

2011-07-28 Thread Guillaume Zajac
Change log from v1: - remove everything related to CDMA SIM - use hardware serial number instead of IMSI to create CDMA service interface This patch has been tested using Daniel's fix: http://lists.connman.net/pipermail/connman/2011-July/005634.html Guillaume Zajac (1):

Re: [PATCH_v2] ofono: manage CDMA device into plugin

2011-08-01 Thread Guillaume Zajac
Hi Samuel, On 29/07/2011 17:21, Samuel Ortiz wrote: Hi Guillaume, On Thu, Jul 28, 2011 at 02:07:20PM +0200, Guillaume Zajac wrote: --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -50,6 +50,7 @@ #define OFONO_CONTEXT_INTERFACE OFONO_SERVICE ".ConnectionContext"

Re: Default cellular profile no more published on D-feet

2011-08-01 Thread Guillaume Zajac
Hi Daniel, On 28/07/2011 13:17, Daniel Wagner wrote: Hi Guillaume On 07/28/2011 11:11 AM, Guillaume Zajac wrote: Hi Daniel, On 21/07/2011 15:08, Daniel Wagner wrote: Hi Guillaume, On 07/18/2011 04:27 PM, Guillaume Zajac wrote: Hi Daniel and Marcel, Until release 0.75, I had no problem

[no subject]

2011-08-01 Thread Guillaume Zajac
Hi, Change log from v2 is: - remove CDMA network when CDMA interface is removed - use unique name for CDMA networks - remove CDMA specific functions From: Guillaume Zajac Subject: In-Reply-To: ___ connman mailing list

[PATCH_v3] ofono: manage CDMA device into plugin

2011-08-01 Thread Guillaume Zajac
--- plugins/ofono.c | 189 --- 1 files changed, 180 insertions(+), 9 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 8650bfc..44074a5 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -50,6 +50,7 @@ #define OFONO_CONTEXT_

Re: [PATCH_v3] ofono: manage CDMA device into plugin

2011-08-01 Thread Guillaume Zajac
Hi Samuel, On 01/08/2011 14:51, Guillaume Zajac wrote: --- plugins/ofono.c | 189 --- 1 files changed, 180 insertions(+), 9 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 8650bfc..44074a5 100644 --- a/plugins/ofono.c

[PATCH_v4] ofono: manage CDMA device into plugin

2011-08-01 Thread Guillaume Zajac
--- Change log from v2 and v3: - format patch into master - remove CDMA network when CDMA interface is removed - use unique name for CDMA networks - remove CDMA specific functions plugins/ofono.c | 189 --- 1 fi

Re: [PATCH_v4] ofono: manage CDMA device into plugin

2011-08-03 Thread Guillaume Zajac
Hi Samuel, On 03/08/2011 12:48, Samuel Ortiz wrote: Hi Guillaume, Still some more comments: On Mon, Aug 01, 2011 at 03:36:55PM +0200, Guillaume Zajac wrote: struct modem_data { char *path; struct connman_device *device; gboolean has_sim; gboolean has_reg

Re: [PATCH_v4] ofono: manage CDMA device into plugin

2011-08-03 Thread Guillaume Zajac
Hi Marcel, On 03/08/2011 12:54, Marcel Holtmann wrote: Hi Guillaume, + if (g_str_has_prefix(hw_serial, "+GSN:") == TRUE) + hw_serial = hw_serial + 5; + + if (g_str_has_prefix(hw_serial, "+CGSN:") == TRUE) + hw_serial = hw_

[PATCH_v5] ofono: manage CDMA device into plugin

2011-08-03 Thread Guillaume Zajac
--- Change log from v4: - Check if modem name is sent by oFono - CDMA modem name is used as network name - Change modem_data property from is_cdma into has_cdma plugins/ofono.c | 156 +-- 1 files changed, 151 insertions(

Re: [PATCH_v5] ofono: manage CDMA device into plugin

2011-08-05 Thread Guillaume Zajac
Hi Marcel, On 04/08/2011 18:46, Marcel Holtmann wrote: Hi Guillaume, Change log from v4: - Check if modem name is sent by oFono - CDMA modem name is used as network name - Change modem_data property from is_cdma into has_cdma plugins/ofono.c | 156 ++

[PATCH] ofono: Improve coding style

2011-08-05 Thread Guillaume Zajac
--- plugins/ofono.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 2bf777d..060cd8e 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1881,10 +1881,8 @@ static gboolean context_changed(DBusConnection *connection,

[PATCH_v6] ofono: manage CDMA device into plugin

2011-08-12 Thread Guillaume Zajac
--- Change log from v4: - manage CDMA network registration, netwok is retrieved like GSM case - modem path is used as network hash_table key - create CDMA_SERVICE macro to avoid over 80 characters lines plugins/ofono.c | 193 +++

[PATCH 1/3] ippool: Add IP pool layer

2011-08-23 Thread Guillaume Zajac
--- Makefile.am |3 +- src/connman.h | 11 +++ src/ippool.c | 207 + src/main.c|2 + 4 files changed, 222 insertions(+), 1 deletions(-) create mode 100644 src/ippool.c diff --git a/Makefile.am b/Makefile.am index 9c08453..

[PATCH 0/3] IP pool implementation

2011-08-23 Thread Guillaume Zajac
private addresses are in use. - Managed multiple block allocation for network/dhcp wih more than 254 clients. Guillaume Zajac (3): ippool: Add IP pool layer ippool-test: Add binary to test ippool tethering: Use IP pool API with private network Makefile.am |8 +- src/connman.h

[PATCH 3/3] tethering: Use IP pool API with private network

2011-08-23 Thread Guillaume Zajac
--- src/tethering.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index 0357530..82ed6dd 100644 --- a/src/tethering.c +++ b/src/tethering.c @@ -80,8 +80,10 @@ struct connman_private_network { char *interface; in

[PATCH 2/3] ippool-test: Add binary to test ippool

2011-08-23 Thread Guillaume Zajac
--- Makefile.am |5 +- tools/ippool-test.c | 291 +++ 2 files changed, 295 insertions(+), 1 deletions(-) create mode 100644 tools/ippool-test.c diff --git a/Makefile.am b/Makefile.am index cacfa48..f6f5119 100644 --- a/Makefile.am +++

[PATCH_v2 0/7] IP pool implementation

2011-08-29 Thread Guillaume Zajac
Hi, Change log from v1: - Add notifier implementation. - Add notification callback for DHCP and private network. - A static and dynamic range can be specififed while allocating IP blocks. TODO: Add management of bigger than 254 addresses blocks. Guillaume Zajac

[PATCH_v2 1/7] ippool: Add IP pool layer

2011-08-29 Thread Guillaume Zajac
--- Makefile.am |3 +- src/connman.h | 14 src/ippool.c | 218 + src/main.c|2 + 4 files changed, 236 insertions(+), 1 deletions(-) create mode 100644 src/ippool.c diff --git a/Makefile.am b/Makefile.am index de634c6.

[PATCH_v2 2/7] ippool-test: Add binary to test ippool

2011-08-29 Thread Guillaume Zajac
--- Makefile.am |5 +- tools/ippool-test.c | 311 +++ 2 files changed, 315 insertions(+), 1 deletions(-) create mode 100644 tools/ippool-test.c diff --git a/Makefile.am b/Makefile.am index 12c8237..f5aa4f7 100644 --- a/Makefile.am +++

[PATCH_v2 6/7] tethering: Add notification callback implementation

2011-08-29 Thread Guillaume Zajac
--- src/tethering.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index c1a10ee..8940528 100644 --- a/src/tethering.c +++ b/src/tethering.c @@ -329,6 +329,12 @@ static void disable_nat(const char *interface)

[PATCH_v2 3/7] tethering: Use IP pool API with private network

2011-08-29 Thread Guillaume Zajac
--- src/tethering.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index 0357530..e310cf0 100644 --- a/src/tethering.c +++ b/src/tethering.c @@ -58,9 +58,6 @@ #define DEFAULT_MTU1500 -#define PRIVATE_NETWORK_IP "1

[PATCH_v2 4/7] tethering: Use IP pool API with DHCP

2011-08-29 Thread Guillaume Zajac
--- src/tethering.c | 43 +-- 1 files changed, 29 insertions(+), 14 deletions(-) diff --git a/src/tethering.c b/src/tethering.c index e310cf0..75dcce2 100644 --- a/src/tethering.c +++ b/src/tethering.c @@ -49,11 +49,6 @@ #define BRIDGE_PROC_DIR "/proc/sy

[PATCH_v2 7/7] ipconfig: Add IP pool notifier call

2011-08-29 Thread Guillaume Zajac
--- src/ipconfig.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index aa8274c..f025956 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -55,6 +55,8 @@ struct connman_ipconfig { int ipv6_privacy_config;

[PATCH_v2 5/7] ippool: Add API to notify when IP is externally assigned

2011-08-29 Thread Guillaume Zajac
--- src/connman.h |6 src/ippool.c| 76 +++ src/tethering.c |9 +++--- 3 files changed, 87 insertions(+), 4 deletions(-) diff --git a/src/connman.h b/src/connman.h index 47f29b7..7f113f9 100644 --- a/src/connman.h +++ b/src/

Re: [PATCH_v6] ofono: manage CDMA device into plugin

2011-09-02 Thread Guillaume Zajac
Hi Marcel, On 12/08/2011 17:55, Marcel Holtmann wrote: Hi Guillaume, diff --git a/plugins/ofono.c b/plugins/ofono.c index 060cd8e..adb715d 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -51,6 +51,11 @@ #define OFONO_SIM_INTERFACE OFONO_SERVICE ".SimManager" #define OFONO_R

Re: [RFC v3 2/2] ofono: Rewrite of the plugin

2011-11-22 Thread Guillaume Zajac
Hi Daniel, On 21/11/2011 17:56, Daniel Wagner wrote: From: Daniel Wagner This patch will be splittet into smaller patches later. This is work in progress. --- plugins/ofono.c | 1814 ++- 1 files changed, 1804 insertions(+), 10 deletions(-)

Re: [RFC v3 2/2] ofono: Rewrite of the plugin

2011-11-22 Thread Guillaume Zajac
Hi Daniel, On 22/11/2011 13:16, Daniel Wagner wrote: Hi Guillaume, On 22.11.2011 11:04, Guillaume Zajac wrote: +struct modem_data { +char *path; + +struct connman_device *device; +struct connman_network *network; + +struct network_context *ipv4_context; + +/* Modem

Re: [PATCH v4 09/18] ofono: Attach device to core

2011-11-23 Thread Guillaume Zajac
Hi Daniel, On 22/11/2011 14:24, Daniel Wagner wrote: From: Daniel Wagner Create a device object when the ConnectionManager interface has been added. Destroy the device object when either the modem disappears or the ConnectionManager goes away. --- plugins/ofono.c | 94 +

Re: [PATCH v4 09/18] ofono: Attach device to core

2011-11-23 Thread Guillaume Zajac
Hi Denis On 23/11/2011 04:58, Denis Kenzior wrote: Hi Guillaume, Here you should do: if (modem->device == NULL&& has_interface(modem->interfaces, OFONO_API_SIM) == FALSE) create_device(modem); As devinfo and sim interface are created at the same time into oFono, if you receive modem

Re: [PATCH v4 09/18] ofono: Attach device to core

2011-11-24 Thread Guillaume Zajac
Hi Daniel, On 24/11/2011 09:24, Daniel Wagner wrote: Hi Guillaume, On 23.11.2011 17:55, Daniel Wagner wrote: Hi Guillaume& Denis, On 23.11.2011 17:17, Guillaume Zajac wrote: Hi Denis On 23/11/2011 04:58, Denis Kenzior wrote: Hi Guillaume, Here you should do: if (modem->device

Re: [PATCH v4 09/18] ofono: Attach device to core

2011-11-24 Thread Guillaume Zajac
Hi Daniel, On 24/11/2011 10:47, Daniel Wagner wrote: Here you should do: if (modem->device == NULL&&has_interface(modem->interfaces, OFONO_API_SIM) == FALSE) create_device(modem); As devinfo and sim interface are created at the same time into oFono, if you receive modem Serial an

[PATCH_v0] ofono: Add support of CDMA modems

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 356 +-- 1 files changed, 345 insertions(+), 11 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index aa9a776..c071558 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -51,6 +51,9 @@ #define OFONO_CM_INTE

[PATCH_v0] CDMA modem implementation support

2011-12-13 Thread Guillaume Zajac
ation from oFono side. Maybe be should create a add_cdma_network() function no to be context dependant although we need to have one to store the IPv4/IPv6 settings, index, and modem path. Kind regards, Guillaume Guillaume Zajac (1): ofono: Add support of CDMA modems plugins/ofono.c |

[PATCH_v1 3/6] ofono: Add cdma-netreg relative functions

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 120 ++- 1 files changed, 119 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index e39c37a..c23de24 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -126,6 +126,9 @@ struct modem_data {

[PATCH_v1 1/6] ofono: Add CDMA interfaces extraction

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index aa9a776..97b1f24 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -51,6 +51,9 @@ #define OFONO_CM_INTERFACE OFONO_SERVICE ".ConnectionMa

[PATCH_v1 2/6] ofono: Add cdma-connman power and shutdown API

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 68 +- 1 files changed, 66 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 97b1f24..e39c37a 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -511,6 +511,56 @@ static int context_set

[PATCH_v1 4/6] ofono: Add cdma-connman relative functions

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 100 ++- 1 files changed, 99 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index c23de24..4cc98c7 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1598,6 +1598,62 @@ static gboolean cm_

[PATCH_v1 5/6] ofono: Add support for CDMA modems

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 54 ++ 1 files changed, 46 insertions(+), 8 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 4cc98c7..566f6e3 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1764,6 +1764,10 @@ static gboolean sim_

[PATCH_v1 6/6] ofono: Factorize Connection Managers intialization

2011-12-13 Thread Guillaume Zajac
--- plugins/ofono.c | 103 --- 1 files changed, 30 insertions(+), 73 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 566f6e3..f4e5859 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1716,6 +1716,29 @@ static int cdma_cm

[PATCH_v2 1/6] ofono: Add CDMA interfaces extraction

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index aa9a776..97b1f24 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -51,6 +51,9 @@ #define OFONO_CM_INTERFACE OFONO_SERVICE ".ConnectionMa

[PATCH_v2 3/6] ofono: Add cdma-netreg relative functions

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 135 +- 1 files changed, 132 insertions(+), 3 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index e39c37a..7d2eaf8 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -126,6 +126,9 @@ struct modem_data {

[PATCH_v2 2/6] ofono: Add cdma-connman power and shutdown API

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 68 +- 1 files changed, 66 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 97b1f24..e39c37a 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -511,6 +511,56 @@ static int context_set

[PATCH_v2 4/6] ofono: Add cdma-connman relative functions

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 100 ++- 1 files changed, 99 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 7d2eaf8..35bc3b7 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1609,6 +1609,62 @@ static gboolean cm_

[PATCH_v2 5/6] ofono: Add support for CDMA modems

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 54 ++ 1 files changed, 46 insertions(+), 8 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 35bc3b7..3259914 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1775,6 +1775,10 @@ static gboolean sim_

[PATCH_v2 6/6] ofono: Factorize Connection Managers intialization

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 103 --- 1 files changed, 30 insertions(+), 73 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 3259914..04c25a0 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1727,6 +1727,29 @@ static int cdma_cm

Re: [PATCH_v2 3/6] ofono: Add cdma-netreg relative functions

2011-12-15 Thread Guillaume Zajac
Hi Daniel, On 15/12/2011 11:48, Daniel Wagner wrote: Hi Guillaume, On 15.12.2011 10:50, Guillaume Zajac wrote: --- plugins/ofono.c | 135 +- 1 files changed, 132 insertions(+), 3 deletions(-) diff --git a/plugins/ofono.c b/plugins

Re: [PATCH_v2 3/6] ofono: Add cdma-netreg relative functions

2011-12-15 Thread Guillaume Zajac
Hi Daniel, On 15/12/2011 14:19, Daniel Wagner wrote: Hi Guillaume, On 15.12.2011 13:42, Guillaume Zajac wrote: And I would prefer this netreg_update_strength() { uint8_t strength; if (modem->data_strength == 0) strength = modem->strength; else st

[PATCH_v3 1/6] ofono: Add CDMA interfaces extraction

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index aa9a776..97b1f24 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -51,6 +51,9 @@ #define OFONO_CM_INTERFACE OFONO_SERVICE ".ConnectionMa

[PATCH_v3 3/6] ofono: Add cdma-netreg relative functions

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 150 ++- 1 files changed, 149 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index e39c37a..9079844 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -126,6 +126,9 @@ struct modem_data {

[PATCH_v3 2/6] ofono: Add cdma-connman power and shutdown API

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 68 +- 1 files changed, 66 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 97b1f24..e39c37a 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -511,6 +511,56 @@ static int context_set

[PATCH_v3 4/6] ofono: Add cdma-connman relative functions

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 102 ++- 1 files changed, 101 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 9079844..2384a9f 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1628,6 +1628,64 @@ static gboolean cm

[PATCH_v3 6/6] ofono: Factorize Connection Managers intialization

2011-12-15 Thread Guillaume Zajac
--- plugins/ofono.c | 103 --- 1 files changed, 30 insertions(+), 73 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 5163540..45c93f9 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1748,6 +1748,29 @@ static int cdma_cm

  1   2   >