Re: [PATCH v2 1/3] conf: Add description of StartTetheringAutomatically

2013-04-23 Thread Lucas De Marchi
long I set it to be enabled (no matter if the device crashed, restarted, etc). I certainly don't want to set it in the config file every time I want to switch it on or off. Lucas De Marchi ___ connman mailing list connman@connman.net http

[PATCH pacrunner 2/2] build: Use AM_CPPFLAGS instead of INCLUDES

2013-01-10 Thread Lucas De Marchi
Makefile.am:141: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 4e6218f..3205cfe 100644 --- a/Makefile.am +++ b/Makefile.am @@ -138,7 +138,7 @@ AM_CFLAGS =

[PATCH pacrunner 1/2] build: Do not use deprecated AM_CONFIG_HEADER

2013-01-10 Thread Lucas De Marchi
The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d3ce7e2..cb455fc 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7

Re: [PATCH v1 10/24] gdbus: Add GetConnectionSELinuxSecurityContext

2012-10-23 Thread Lucas De Marchi
. We are in the middle of the transition to support DBus.Properties and DBus.ObjectManager. A lot of patches were integrated there. Since there are still some changes needed in gdbus to fully support them, we are postponing forwarding the changes to the other projects. Lucas De Marchi

[PATCH] build-sys: Fix missing -lrt for clock_gettime()

2012-10-02 Thread Lucas De Marchi
librt is needed for using clock_gettime(): /usr/bin/ld: src/ntp.o: undefined reference to symbol 'clock_gettime@@GLIBC_2.2.5' /usr/bin/ld: note: 'clock_gettime@@GLIBC_2.2.5' is defined in DSO /usr/lib/librt.so.1 so try adding it to the linker command line /usr/lib/librt.so.1: could not read

[PATCH 1/2] build-sys: Don't use deprecated AM_PROG_MKDIR_P

2012-10-02 Thread Lucas De Marchi
AM_PROG_MKDIR_P is deprecated since: configure.ac:26: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and will soon be removed. configure.ac:26: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:26: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your

Re: [PATCH v0 1/6] coding-style: Add static variable initialization entry

2012-10-02 Thread Lucas De Marchi
, rather than full name, to name a variable, -- 1.8.0.rc0 already testing new stuff? :) Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH 0/3] gdbus patches

2012-09-27 Thread Lucas De Marchi
These patches were applied to BlueZ repository. Please, have a look and apply them on other projects. Johan Hedberg (1): gdbus: Fix crash when getting disconnected from the bus Lucas De Marchi (2): gdbus: Fix wrong signal handler match gdbus: Refactor filter_data_find() gdbus/mainloop.c

[PATCH 1/3] gdbus: Fix crash when getting disconnected from the bus

2012-09-27 Thread Lucas De Marchi
From: Johan Hedberg johan.hedb...@intel.com When getting disconnected from the bus sometimes (maybe always?) dbus_watch_handle() can cause the info context to be free'd meaning that we should not try to access it after the call. The only member we need access to is the connection pointer and as

[PATCH 2/3] gdbus: Fix wrong signal handler match

2012-09-27 Thread Lucas De Marchi
When we add a signal handler with g_dbus_add_signal_watch(), this function tries to multiplex the matches added in libdbus by checking if there's a previous filter_data with the same fields. However, if the field is NULL it accepts as being the same. The result is that the following watches will

[PATCH 3/3] gdbus: Refactor filter_data_find()

2012-09-27 Thread Lucas De Marchi
Now this function is only used for searching the listeners of a connection and the other parameters are not needed anymore. --- gdbus/watch.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/gdbus/watch.c b/gdbus/watch.c index

Re: [PATCH 1/2] main: Introduce conf file option to ignore DHCP hostname option

2012-08-09 Thread Lucas De Marchi
misbehaved routers don't screw us Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH V3 2/2] storage.c: If there is no d_type support use fstatat()

2012-07-17 Thread Lucas De Marchi
; + + g_string_append_printf(result, %s/, d-d_name); + break; the entire code above should be common to case DT_DIR. An idea to clean this up: Add case DT_UNKOWN before case DT_DIR and let it fall-through without a break statement if it's a dir. Lucas De Marchi

Re: [PATCH V3 2/2] storage.c: If there is no d_type support use fstatat()

2012-07-17 Thread Lucas De Marchi
On Tue, Jul 17, 2012 at 2:05 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Tue, Jul 17, 2012 at 1:44 PM, Andrei Gherzan and...@gherzan.ro wrote: This is useful for filesystems where d_type is always DT_UNKNOWN. In this case use fstatat() function. --- src/storage.c | 19

Re: [PATCH 3/3] main: Remove option to daemonize connmand

2012-07-13 Thread Lucas De Marchi
On Fri, Jul 13, 2012 at 9:06 AM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Thu, Jul 12, 2012 at 12:03 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Hi Jukka, On Wed, Jul 11, 2012 at 3:56 PM, Jukka Rissanen jukka.rissa...@gmail.com wrote: Hi Lucas, On 11 July

Re: [PATCH 3/3] main: Remove option to daemonize connmand

2012-07-13 Thread Lucas De Marchi
On Fri, Jul 13, 2012 at 9:58 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Fri, Jul 13, 2012 at 9:51 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Gustavo, Letting systemd daemonize connmand, as we are already doing, there's no need to have an option -n since it will work

Re: [PATCH RFC] Do not explicitly include config.h

2012-07-12 Thread Lucas De Marchi
they are opposite to each other. Lucas De Marchi PS: Palmeiras campeão!! ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 3/3] main: Remove option to daemonize connmand

2012-07-12 Thread Lucas De Marchi
Hi Jukka, On Wed, Jul 11, 2012 at 3:56 PM, Jukka Rissanen jukka.rissa...@gmail.com wrote: Hi Lucas, On 11 July 2012 18:23, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Letting systemd daemonize connmand, as we are already doing, there's no need to have an option -n since it will work

[PATCH 2/3] log: Rely on systemd sending stderr to journal

2012-07-11 Thread Lucas De Marchi
Systemd can use the daemon output and send it to the journal (or a compatible syslog implementation). Currently in the unit file we are starting connmand with the recommended way by systemd (without forking) but the log messages are duplicated since we are logging both to syslog and stderr due to

[PATCH 3/3] main: Remove option to daemonize connmand

2012-07-11 Thread Lucas De Marchi
Letting systemd daemonize connmand, as we are already doing, there's no need to have an option -n since it will work for both debugging and running it as a daemon. Therefore, just remove the option. Other init systems may use whatever method they have to turn connmand into a daemon. ---

[PATCH RFC] Do not explicitly include config.h

2012-07-11 Thread Lucas De Marchi
There's a much better way of doing that: pass -include to the compiler. --- First of all: I know this should be split :-) I always found weird to include these 3 lines on every single file. There's a much easier way to do this that I find more convenient. If project is insterested in this I can

[PATCH 1/4] bluetooth: Watch for signals only on BLUEZ_SERVICE

2012-06-28 Thread Lucas De Marchi
--- plugins/bluetooth.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 9e1aaa2..6f476e2 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -1194,33 +1194,34 @@ static int bluetooth_init(void)

[PATCH 0/4] Add bus name to signal watches

2012-06-28 Thread Lucas De Marchi
This patch set fixes the calls to g_dbus_add_signal_watch() to actually watch only the desired bus. It depends on previous patch for gdbus to be applied first, otherwise libdbus may call abort() when we exit. Lucas De Marchi (4): bluetooth: Watch for signals only on BLUEZ_SERVICE dundee

[PATCH 2/4] dundee: Watch for signals only on DUNDEE_SERVICE

2012-06-28 Thread Lucas De Marchi
--- plugins/dundee.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/dundee.c b/plugins/dundee.c index 045f639..d0ecdef 100644 --- a/plugins/dundee.c +++ b/plugins/dundee.c @@ -789,18 +789,18 @@ static int dundee_init(void) watch =

[PATCH 3/4] ofono: Watch for signals only on OFONO_SERVICE

2012-06-28 Thread Lucas De Marchi
--- plugins/ofono.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index ae419be..afd752d 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -2547,68 +2547,71 @@ static int ofono_init(void)

[PATCH 4/4] unit: Watch for signals only on CONNMAN_SERVICE

2012-06-28 Thread Lucas De Marchi
--- unit/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit/utils.c b/unit/utils.c index 6ff1c71..758528a 100644 --- a/unit/utils.c +++ b/unit/utils.c @@ -137,7 +137,7 @@ void util_setup(struct test_fix *fix, gconstpointer data)

[PATCH] README: Add information about mailing list and site

2012-06-14 Thread Lucas De Marchi
--- README |9 + 1 file changed, 9 insertions(+) diff --git a/README b/README index bb425ca..fbc5149 100644 --- a/README +++ b/README @@ -220,3 +220,12 @@ server will not always work. Some of the symptons are that additional routes will not be set by ConnMan if the uplink is a

Re: [PATCH 1/3] dnsproxy: Check overlapping memcpy

2012-06-04 Thread Lucas De Marchi
this comment, couldn't we just not set the append_domain flag if it was not appended? Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 2/3] dnsproxy: Use memmove() when discarding domain name

2012-06-04 Thread Lucas De Marchi
. +                                */ +                               memmove(ptr + host_len + 1, I overlooked the point arithmetic. Anyway, I don't think the comment is necessary here... the only reason to use memmove() instead of memcpy() is when memory areas overlap. Lucas De Marchi

[PATCH] gdbus: add macro for methods marked as NOREPLY

2012-05-29 Thread Lucas De Marchi
--- This is not used by ConnMan, but it's in other projects using gdbus. gdbus/gdbus.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index e2e160d..0a8a27c 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -144,6 +144,13 @@ typedef struct {

[PATCH 1/3] dnsproxy: fix constiness of variables

2012-05-23 Thread Lucas De Marchi
There's no point in casting 'domain' and 'query' to char* to remove the const since we are not modifying them. Also we can avoid another var entirely by updating the pointers only. --- src/dnsproxy.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-)

[PATCH 2/3] dnsproxy: avoid useless memset

2012-05-23 Thread Lucas De Marchi
--- src/dnsproxy.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 83ec419..6a9b138 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -2272,7 +2272,7 @@ static int parse_request(unsigned char *buf, int len, if (hdr-qr != 0 ||

[PATCH 3/3] dnsproxy: fix wrong domain len causing crash in memmove

2012-05-23 Thread Lucas De Marchi
If host_len is 0, strlen(*ptr) will return 0 as well and domain_len will have the wrong value (-1). This causes connman to crash with the following backtrace: connmand[13361]: backtrace connmand[13361]: #0 0x7f33a5e49140 in /lib/libpthread.so.0 connmand[13361]: #1

[PATCH ell 1/6] util: add macros for dealing with unaligned access

2012-05-22 Thread Lucas De Marchi
From: Lucas De Marchi lucas.de.mar...@gmail.com --- ell/util.h | 16 1 file changed, 16 insertions(+) diff --git a/ell/util.h b/ell/util.h index 1c805cf..d7849c1 100644 --- a/ell/util.h +++ b/ell/util.h @@ -36,6 +36,22 @@ extern C { #define L_PTR_TO_INT(p) ((int) ((intptr_t

[PATCH ell 2/6] hashmap: better hash function

2012-05-22 Thread Lucas De Marchi
From: Lucas De Marchi lucas.de.mar...@gmail.com Add hash function with better spread of items. It is used by WebKit, EFL, kmod and others. Its intent is to be used by string hashes and types other than a simple pointer, although it could be used for this later case, too. Reference: http

[PATCH ell 3/6] hashmap: introduce string hash

2012-05-22 Thread Lucas De Marchi
From: Gustavo Sverzut Barbieri barbi...@profusion.mobi keys are copied so we avoid crashes if they go away. keys may be kept in another format than user provided, for instance we keep the size for easier comparison and hashing. --- ell/hashmap.c | 146

[PATCH ell 4/6] Add array type

2012-05-22 Thread Lucas De Marchi
From: Gustavo Sverzut Barbieri barbi...@profusion.mobi Array with configurable member size and optimized operations such as binary search and insert sorted. --- .gitignore|1 + Makefile.am | 11 +- ell/array.c | 758 +

[PATCH ell 5/6] hashmap: optimize and cleanup by using array

2012-05-22 Thread Lucas De Marchi
From: Gustavo Sverzut Barbieri barbi...@profusion.mobi Using an ordered array will allow binary search, the code is also reduced. Bonus for less memory fragmentation due less memory allocations and less cache trashing due using linear memory for lookups. --- ell/hashmap.c | 159

[PATCH ell 6/6] util: safely derive the size of an array

2012-05-22 Thread Lucas De Marchi
With this trick from CCAN (http://ccodearchive.net/info/array_size.html) we ensure at build-time user is indeed passing an array and not a pointer. The code in CCAN uses several other macros like BUILD_ASSERT, BUILD_ASSERT_OR_ZERO. Since this is a public header, i think it's preferred not to

[HEADS UP] vim users

2012-05-22 Thread Lucas De Marchi
to this email the fixed c.vim file. Replace /usr/share/vim/vim73/syntax/c.vim with this one and highlight will be fixed. Regards, Lucas De Marchi c.vim Description: Binary data ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo

[PATCH pacrunner 01/12] Constify GDBus tables

2012-05-18 Thread Lucas De Marchi
Constify method tables with the following commands: --- src/client.c |2 +- src/manager.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client.c b/src/client.c index 154685e..b2735d9 100644 --- a/src/client.c +++ b/src/client.c @@ -104,7 +104,7 @@ static

[PATCH pacrunner 02/12] gdbus: add argument info to methods and signals

2012-05-18 Thread Lucas De Marchi
--- gdbus/gdbus.h |8 1 file changed, 8 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index a0583e6..e5e7938 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -85,16 +85,24 @@ typedef enum { typedef struct { const char *name; const char *signature; +}

[PATCH pacrunner 04/12] gdbus: add macro for methods marked as NOREPLY

2012-05-18 Thread Lucas De Marchi
--- gdbus/gdbus.h | 16 1 file changed, 16 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 8354633..868c8d5 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -155,6 +155,15 @@ typedef struct { .function = _function, \ .flags =

[PATCH pacrunner 03/12] gdbus: add and use helpers for table declarations

2012-05-18 Thread Lucas De Marchi
--- gdbus/gdbus.h | 86 gdbus/object.c |3 +- 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index e5e7938..8354633 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -118,6 +118,92 @@

[PATCH pacrunner 05/12] Convert GDBus methods to use macro helpers

2012-05-18 Thread Lucas De Marchi
With these macro helpers we can separate in/out arguments and use their own vector. --- src/client.c |6 -- src/manager.c |9 +++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/client.c b/src/client.c index b2735d9..807fd25 100644 --- a/src/client.c +++

[PATCH pacrunner 07/12] gdbus: loop over args to check message signature

2012-05-18 Thread Lucas De Marchi
--- gdbus/object.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index 3ac6a0b..b187bb5 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -374,6 +374,27 @@ static struct interface_data

[PATCH pacrunner 06/12] gdbus: use GDBusArgInfo to generate introspection

2012-05-18 Thread Lucas De Marchi
By using GDBusArgInfo in methods and signals, the introspection generation is much simpler and we can add each argument name. --- gdbus/object.c | 75 +++- 1 file changed, 14 insertions(+), 61 deletions(-) diff --git a/gdbus/object.c

[PATCH pacrunner 08/12] Do not set signature and reply in GDBus tables

2012-05-18 Thread Lucas De Marchi
Use GDBUS_* macros, so signature and reply fields are not set in each method/signal. --- src/client.c |2 +- src/manager.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/client.c b/src/client.c index 807fd25..c41a738 100644 --- a/src/client.c +++

[PATCH pacrunner 09/12] gdbus: remove signature and reply from tables

2012-05-18 Thread Lucas De Marchi
--- gdbus/gdbus.h | 60 gdbus/object.c |2 +- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 868c8d5..0a8a27c 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -89,8 +89,6 @@

[PATCH pacrunner 10/12] gdbus: add Deprecated annotation in introspection

2012-05-18 Thread Lucas De Marchi
--- gdbus/object.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index fcdd6ec..95947f3 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -82,7 +82,11 @@ static void generate_interface_xml(GString *gstr, struct

[PATCH pacrunner 11/12] gdbus: add Method.NoReply annotation in introspection

2012-05-18 Thread Lucas De Marchi
--- gdbus/object.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbus/object.c b/gdbus/object.c index 95947f3..dacbe58 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct interface_data

[PATCH pacrunner 12/12] gdbus: do not check signature twice

2012-05-18 Thread Lucas De Marchi
Message signature is already checked in generic_message(), so there's no need to check again in the callback. --- gdbus/object.c |5 - 1 file changed, 5 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index dacbe58..2dd7c0e 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@

[PATCH 1/2] provider: Fix NULL netmask being passed to atoi

2012-05-07 Thread Lucas De Marchi
--- src/provider.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/provider.c b/src/provider.c index a3604d4..66f93b6 100644 --- a/src/provider.c +++ b/src/provider.c @@ -113,22 +113,22 @@ static void set_user_networks(struct connman_provider *provider,

[PATCH 1/3] gdhcp: fix strict-aliasing warning

2012-04-20 Thread Lucas De Marchi
The previous way was giving the following warning with gcc 4.7: CC gdhcp/common.o gdhcp/common.c: In function 'dhcp_add_simple_option': gdhcp/common.c:275:38: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing Change it slightly so not to

[PATCH 2/3] gweb: don't use deprecated gnutls_session typedef

2012-04-20 Thread Lucas De Marchi
According to gnutls/compat.h, gnutls_session typedef was deprecated since 2.x in favor of gnutls_session_t. Use the new typedef then. --- gweb/giognutls.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gweb/giognutls.c b/gweb/giognutls.c index d92ae95..8f672fe 100644 ---

[PATCH 3/3] build: add unit tests to .gitignore

2012-04-20 Thread Lucas De Marchi
--- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index dee0232..23ac231 100644 --- a/.gitignore +++ b/.gitignore @@ -54,6 +54,8 @@ tools/stats-tool tools/stats-ringbuffer-dump tools/private-network-test unit/test-session +unit/test-ippool

[PATCH 1/2] Remove call to deprecated function

2011-07-01 Thread Lucas De Marchi
If we use gnutls 2.12.0 or later it's necessary to call gnutls_transport_set_lowat() to disable the lowat functionality. Since this function is deprecated in new versions of gnutls, call it only if using an older version. --- gweb/giognutls.c |2 ++ 1 files changed, 2 insertions(+), 0

[PATCH 2/2] Use priority string to provide wide compatibility

2011-07-01 Thread Lucas De Marchi
This priority string will only enable SSL 3.0 and TLS 1.0 as protocols and will disable, via the %COMPAT keyword, several TLS protocol options that are known to cause compatibility problems. Reference: http://www.gnu.org/software/gnutls/manual/html_node/Interoperability.html#Interoperability ---

Re: [PATCH 1/2] Remove call to deprecated function

2011-07-01 Thread Lucas De Marchi
On Fri, Jul 1, 2011 at 8:50 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: If we use gnutls 2.12.0 or later it's necessary to call gnutls_transport_set_lowat() to disable the lowat functionality. Since this function is deprecated in new versions of gnutls, call it only if using

Re: [PATCH v1 01/13] main: Do not call syslog in signal handler

2011-06-27 Thread Lucas De Marchi
); -        g_main_loop_quit(main_loop); Additionally, shouldn't you add connman_info(Terminating) after g_main_loop_run() returns? Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] Distribute and install configuration file

2011-06-21 Thread Lucas De Marchi
this file should not be part of the ConnMan package, it will be part of some hardware specific package. Humn... so maybe it's better not to print an error message saying we didn't find the file? regards, Lucas De Marchi ___ connman mailing list connman

[PATCH] main: be quiet when config file isn't found

2011-06-21 Thread Lucas De Marchi
It's ok to run ConnMann without a configuration file, so don't print an error message when this happens. --- src/main.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/main.c b/src/main.c index 0f96d6c..bb08e40 100644 --- a/src/main.c +++ b/src/main.c @@ -57,7

[PATCH] dhcp: do not overwrite dhcp servers

2011-03-21 Thread Lucas De Marchi
The counter 'i' was not being incremented, making secondary dns servers to overwrite the first ones. --- src/dhcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index bedc555..529c93a 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -167,7 +167,7 @@

[PATCH] Do not fail when systemd is not installed

2011-01-24 Thread Lucas De Marchi
Use --with-systemdsystemunitdir instead of --enabled-systemd so it's possible to enable systemd even if systemd is not installed. --- configure.ac | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 63506ac..efdd874 100644

[PATCH v2] Do not fail when systemd is not installed

2011-01-24 Thread Lucas De Marchi
Use --with-systemdsystemunitdir instead of --enabled-systemd so it's possible to enable systemd even if systemd is not installed. --- configure.ac | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 63506ac..a86f112 100644

Re: ConnMan (0.65.63) Weekly Test Report - WW03

2011-01-14 Thread Lucas De Marchi
case failed because of known/new I suppose you meant 231 cases, right? thanks Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH] Fix cast from pointer to int

2010-11-12 Thread Lucas De Marchi
--- tools/iptables-test.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/iptables-test.c b/tools/iptables-test.c index e8e9228..8f9299d 100644 --- a/tools/iptables-test.c +++ b/tools/iptables-test.c @@ -781,11 +781,11 @@ static void

[RFC] Add compiler flags to discard unused functions

2010-10-01 Thread Lucas De Marchi
Request compiler to emit every function and data variable in its own section, then request the linker to remove unused sections. This reduces the size of the final binary. Compiling with --disable-iwmx, we have the following results: Before: === textdata bss dec hex

[PATCH] Simplify linker script

2010-09-21 Thread Lucas De Marchi
Version linker scripts support function names and globs, so there's no need to rely on nm tool to gather the exported symbols. --- .gitignore |2 -- Makefile.am | 12 +--- configure.ac|3 --- src/connman.ver |8 4 files changed, 9 insertions(+), 16

[PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
Let configure generate connman.ver file and copy it to the build directory. --- configure.ac |2 +- src/connman.ver.in |8 2 files changed, 9 insertions(+), 1 deletions(-) create mode 100644 src/connman.ver.in diff --git a/configure.ac b/configure.ac index

[PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
Let configure generate connman.ver file and copy it to the build directory. --- configure.ac |2 +- src/connman.ver|8 src/connman.ver.in |8 3 files changed, 9 insertions(+), 9 deletions(-) delete mode 100644 src/connman.ver create mode 100644

Re: [PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
On Tue, Sep 21, 2010 at 11:55 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Let configure generate connman.ver file and copy it to the build directory. ---  configure.ac       |    2 +-  src/connman.ver.in |    8  2 files changed, 9 insertions(+), 1 deletions(-) Sorry

Re: IPv4.Configuration failure

2010-09-20 Thread Lucas De Marchi
Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Ubuntu workitems for connman

2010-05-28 Thread Lucas De Marchi
De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Interface for editing stored connections

2010-05-13 Thread Lucas De Marchi
. Lucas De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] Fix typo in test-connman.

2010-04-16 Thread Lucas De Marchi
De Marchi ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] Fix typo in test-connman.

2010-04-16 Thread Lucas De Marchi
On Fri, Apr 16, 2010 at 10:09 AM, Forest Bond for...@alittletooquiet.net wrote: Hi, On Fri, Apr 16, 2010 at 10:06:34AM -0700, Lucas De Marchi wrote: On Fri, Apr 16, 2010 at 9:46 AM, Forest Bond for...@alittletooquiet.net wrote: diff --git a/test/test-connman b/test/test-connman index

re-ordering services

2010-03-23 Thread Lucas De Marchi
__connman_error_invalid_service(msg); So, if the favorite service has a failure state while the other (that i'm trying to put on top) is in idle, i'm not able to reorder them. thanks Lucas De Marchi ___ connman mailing list connman@connman.net http

[PATCH] dnsproxy: add server even upon connection error

2010-01-21 Thread Lucas De Marchi
When using plugins like 'plugins/google.c' with no previously working connection, DNS server is not added because it is not possible to connect to it. This patch changes the error to a warning and adds the server anyway. We know that upon start there's no working connection and hope server will

Re: [PATCH] dnsproxy: add server even upon connection error

2010-01-21 Thread Lucas De Marchi
the __connman_plugin_init_postponed() only after a connection is established. What do you think? Lucas De Marchi commit 3a796da45eac6d8c2628acc290609f1c932ba3b0 Author: Lucas De Marchi lucas.demar...@profusion.mobi Date: Wed Jan 20 11:37:32 2010 -0200 temp diff --git a/include/plugin.h b/include