Re: [PATCH] gdbus: move typedefs for interwork with strict compilers

Hi Grant, > Move enumeration type defintions AFTER the enumerations themselves are > declared > and defined such that the header works with strict compilers. > --- > gdbus/gdbus.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h >

Re: [PATCH 6/6] service: Implement ClearProperty properly

Hi Patrik, > Thanks for these patches. I'm going to add text from the cover letter to > this patch and nitpick on clearing AutoConnect below. > > On Thu, 2015-10-15 at 10:41 +0300, Jaakko Hannikainen wrote: >> The previous implementation only cleared Error, which as per >> documentation is wrong

Re: Regd. using two WPA Supplicant in ConnMan

Hi Debojyoti, This should work with one wpa_supplicant, unless the chip vendor's driver is weirdly done. Afaik, intel or atheros work properly, but if it's none of those... ;) Unfortunately our chip is not Intel nor Atheros and the chip vendor suggested that with one supplicant this use

Re: RFC: Storage based service retrieval

Hi Adam, I¹d like to throw out another use case in support of Slava Monich¹s suggestion of upstreaming a D-Bus getter for configured services: For stationary devices, (like connected home gadgets) there is usually a Setup mode in which the user is able to send network credentials to the

Re: RFC: D-Bus access to all configured services

Hi Slava, Does upstream have any interest in providing D-Bus access to all configured services, including those that have no network associated with it? Before I start writing any code, I would like to know whether it's going to be accepted upstream or will remain part of our fork.

Re: RFC: D-Bus access to all configured services

Hi Slava, Does upstream have any interest in providing D-Bus access to all configured services, including those that have no network associated with it? Before I start writing any code, I would like to know whether it's going to be accepted upstream or will remain part of our fork.

Re: connman online test

Hi Jussi, Now that we're talking about the online check... I've talked to people who considered this behaviour calling home and thought it unreasonable that a) it's not possible to prevent the online check from happening via configuration and an actual HTTP request is needed no matter

Re: connman online test

secret embedded product demo on top of Yocto suddenly realizing that their device is connecting to a web server they don't control or even know about (aka who is this Marcel Holtmann why is our IOT Fridge fetching web pages from him?) if this super secret fridge is connected to the Internet

Re: [PATCH] device: Add configurable DontBringDownAtStartup list

Hi Slava, connman brings down managed interfaces at startup. Sometimes it's unnecessary or even harmful. DontBringDownAtStartup list in main.conf allows to make exceptions for some interfaces. this is a horrible name for an option. It is like triple negation and will make everyones head hurt

Re: [PATCH 4/4] main.conf: Add example PassiveWiFiScan

Hi Pasi, --- src/main.conf | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/main.conf b/src/main.conf index 93c7a50..b553523 100644 --- a/src/main.conf +++ b/src/main.conf @@ -95,3 +95,9 @@ # re-enabling a technology, and after restarts and reboots. # Default value is

Re: [RFC] Discontinuing 6to4 support

Hi Tore, Over the years operational experience has revealed that the 6to4 protocol suffers from so severe operational problems that it simply cannot be fixed. Therefore, the IETF recently decided to deprecate 6to4: http://tools.ietf.org/html/draft-ietf-v6ops-6to4-to-historic The document

Re: [PATCH 1/3] Do not assume the gateway is also a NTP server

Hi Tore, This patch prevents connman from [ab]using the default gateway as a fallback NTP server. The rationale for the previous behaviour was apparently that if the DHCP server does not advertise an NTP server option, then attempting to use the default gateway has at least a non-zero chance

Re: [PATCH 1/3] Do not assume the gateway is also a NTP server

Hi Tore, This patch prevents connman from [ab]using the default gateway as a fallback NTP server. The rationale for the previous behaviour was apparently that if the DHCP server does not advertise an NTP server option, then attempting to use the default gateway has at least a non-zero chance

Re: [PATCH] device/inet: Create read-only devices instead of ignoring completely

Hi Andreas, first of all: Whenever you boot from NFS and change your network device address, the system is going to freeze. This goal of this patch is to be able to run ConnMan in an nfsroot (during development) with as little difference to a local boot as possible. There may be additional

Re: Architechture/Block diagram of Connman ??

Hi Patrik, Apart from the documentation available in Connman sources - Do we also have a block/architectural high level diagram of connman, both Daemon and Client ? So far nobody has had the energy to put such a document together. The best clue here is to look at the data structures

Re: [PATCH] device/inet: Create read-only devices instead of ignoring completely

Hi Andreas, Booting an nfsroot with connman requires passing -I eth0 to ignore the interface. This isn't very nice, for at least the following reasons: * A User interface based on connman is led to believe that there's no network interface and thus connman seems to be offline when it's

Re: [PATCH] device/inet: Create read-only devices instead of ignoring completely

Hi Andreas, first of all: Whenever you boot from NFS and change your network device address, the system is going to freeze. This goal of this patch is to be able to run ConnMan in an nfsroot (during development) with as little difference to a local boot as possible. There may be additional

Re: Feature roadmap

Hi Mihai, We're looking into using connman as the network manager for our programmable embedded systems. It currently has most of the desired features, but we would still need the following functionality: 1. DHCP-only method - to not fall back to link-local if no DHCP lease is issued

Re: Online status

Hi Tom, When a service transitions from ready to online status, connman makes an http request to ipv[4,6].connman.net/online/status.html. I have been asked if this is a requirement or is there a way to prevent this from happening? how else would you do it? You need to ensure that you are

Re: [PATCH 1/5] util: Use proper source for random numbers

Hi Patrik, Use /dev/urandom as the proper source for random numbers. Verify the existence of /dev/urandom at compile time and program startup. Out of curiosity, why does it matter that we have /dev/urandom at compile time? automake/autoconf is old skool and assumes that the device where

Re: [PATCH] gweb: Enable TLSv1.2 and TLSv1.1

Hi Pasi, As the web servers are migrating away from SSLv3 more secure protocols need to be enabled. I just wonder should we just disable sslv3 support all together? I thought about it but was bit afraid there are still systems which only support sslv3 (even it is broken++). On the other

Re: [PATCH 3/5 v2] plugins: Add a wifi.conf configuration file template for the wifi plugin

Hi Tomasz, I want this centralized in a daemon so that if users change things, they get applied by ConnMan and BlueZ at the same time and not get out of sync. This sounds great to me but just to double check: I will be able to set the chassis to something that makes connman use the TV

Re: [PATCH 3/5 v2] plugins: Add a wifi.conf configuration file template for the wifi plugin

Hi Tomasz, why would we do such a thing? Integrate with systemd-hostnamed to read a proper value and follow changes from systemd-hostnamed via hostnamectl utility. BlueZ is happily doing it this way and so can ConnMan. Ok I did not know about that. However, hostnamed works only with

Re: [PATCH 3/5 v2] plugins: Add a wifi.conf configuration file template for the wifi plugin

Hi Tomasz, This specific file, installed in /etc/connman/, can be used to set specific values related to wifi plugin only. --- Makefile.plugins | 1 + plugins/wifi.conf | 16 2 files changed, 17 insertions(+) create mode 100644 plugins/wifi.conf diff --git

Re: [PATCH 4/4] gdhcp: Workaround for buggy AP that handle broadcast flag incorrectly

Hi Jukka, Some routers/AP handle the DHCP broadcast flag incorrectly. This means that some AP discard the DHCP packet if broadcast flag is present and some discard it if broadcast flag is missing. The workaround is to send two DISCOVER packets in INIT state and two REQUEST packets in

Re: Unreachable favorite network

Hi Julien, My users are requesting stronger than before to be able to remove unreachable favorites services. At the moment it's not possible with ConnMan API. I understand that returning unreachable networks is quiet confusing, but I think their request is legitimate. Often they think

Re: [PATCH] config: add ifb in NetworkInterfaceBlacklist default

Hi Alban, ifb (Intermediate Functional Block) are virtual network interfaces used for Traffic Control. If the admin installed Traffic Control rules using ifb, ConnMan must not touch these network interfaces. what kind of ARPHRD_ do these have? Are they are really showing up as Ethernet?

Re: [PATCH v0 10/13] ipv4ll: Initialize socket variable

Hi Tomasz, FWIW, in a couple of other functions memset is used. I do not really care, but would like to have a consistent style. What's the preference? We need Marcel's input on that ;) I prefer the memset() of the address structs before using them. Regards Marcel

Re: [RFC 0/3] Publish dhcp statistics to dbus

Hi Grant, We do indeed have a sleep manager that will put our system to deep sleep/suspend. This sleep manager also uses the RTC to schedule a wake for future tasks. However, the wifi chip we use performs suspend-idle association and is configured with wake-on-WLAN filters to wake the host

Re: [PATCH] iptables: iptables_replace returns the wrong error code

Hi Daniel, I have a case where the init_firewall() is failing. After some digging I've found that iptables_replace() is failing. My assumption here is that iptables_replace() is returning the wrong error code, it should be returning errno. My assumption is based on the caller

Re: [PATCH 5/9] ntp: Support NTPv3 protocol version

Hi Peter, NTPv3 is advertised by Windows 7, but only v4 is accepted I am failing to understand this comment. What does this actually mean. Windows 7 is still using NTP version 3 from 1992. Instead of NTP version 4 from 2010. rc/ntp.c:send_timeout() send timeout (retries 1)

Re: [PATCH] Tethering: Add the hidden Access Point

Hi Chengyi, I'm not sure we want the capability of hiding the SSID when tethering, let's figure out that one as well. I do not think this is a good idea in the first place. Hidden SSID is the most stupid concept invented. It does not provide any extra security. Especially not if you have

Re: [PATCH] Tethering: Add the hidden Access Point

Hi Patrik, I'm not sure we want the capability of hiding the SSID when tethering, let's figure out that one as well. I do not think this is a good idea in the first place. Hidden SSID is the most stupid concept invented. It does not provide any extra security. Especially not if you have

Re: [PATCH 1/3] doc: add documentation for P2P related API modifications

Hi Simon, +boolean P2P [readwrite] + +This option allows to enable or disable the support +for P2P wireless network also known as WiFi Direct. + +When P2P is enabled scanning will scan for P2P peer +clients as well. Ok + +

Re: [PATCH 1/3] doc: add documentation for P2P related API modifications

Hi Simon, +boolean P2P [readwrite] + +This option allows to enable or disable the support +for P2P wireless network also known as WiFi Direct. + +When P2P is enabled scanning will scan for P2P peer +clients as well. Ok + +

Re: [PATCH] Fix gcc compiler warning with -Wformat-security.

Hi Justin, Cosmetic fix. --- client/agent.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/agent.c b/client/agent.c index 921f2fc..5499d9c 100644 --- a/client/agent.c +++ b/client/agent.c @@ -112,7 +112,7 @@ static void pending_command_complete(char

Re: [PATCH 1/2] main: Rename AllowedTetheringTechnologies to TetheredTechnologies

Hi Patrik, Rename AllowedTetheringTechnologies to TetheredTechnologies to be consistent with the related PreferredTechnologies naming. I do not think this naming is a good one. If we call it TetheredTechnologies, then this sounds more like they are already tethered at that point. So I would

Re: [PATCH v3 0/5] Add support for ethernet tethering

Hi Patrik, v3: - Changed the name and semantics of the main.conf variable. Now it is a list of technologies that are allowed to tether. Patches 1, 2 and 5 - Reworked the rtnl patch 4, get rid of extra variable - Combined patches 5 and 6 together Applied, thanks! actually I was not

Re: PowerPC Build Failure

Hi Jack, Upgrading connman to the 1.3 git tag in OpenEmbedded threw up the following compile error under a 64bit Power PC build. | powerpc64-poky-linux-gcc -mhard-float -m64 -mcpu=e5500 --sysroot=/local/home/b19537/gcr/opensource/poky/buildmaster/tmp/sysroots/p5020ds-64b

Re: PowerPC Build Failure

Hi Jack, Upgrading connman to the 1.3 git tag in OpenEmbedded threw up the following compile error under a 64bit Power PC build. | powerpc64-poky-linux-gcc -mhard-float -m64 -mcpu=e5500 --sysroot=/local/home/b19537/gcr/opensource/poky/buildmaster/tmp/sysroots/p5020ds-64b

Re: [PATCH v2 1/6] conf: Add description of AllowEthernetTethering

Hi Jukka, --- src/main.conf | 9 + 1 file changed, 9 insertions(+) diff --git a/src/main.conf b/src/main.conf index 2985613..a0608d4 100644 --- a/src/main.conf +++ b/src/main.conf @@ -76,3 +76,12 @@ # setting enabled applications will notice more network breaks than # normal.

Re: [PATCH v3 1/3] conf: Add description of PersistentTetheringMode

Hi Jukka, src/main.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/src/main.conf b/src/main.conf index a0608d4..7e509f7 100644 --- a/src/main.conf +++ b/src/main.conf @@ -85,3 +85,8 @@ # This is a dangerous setting so the default value is false. # Do not activate this

Re: [PATCH v2 1/3] conf: Add description of StartTetheringAutomatically

Hi Jukka, --- src/main.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/src/main.conf b/src/main.conf index a0608d4..7b155af 100644 --- a/src/main.conf +++ b/src/main.conf @@ -85,3 +85,8 @@ # This is a dangerous setting so the default value is false. # Do not activate this

Re: [PATCH] iptabes-test2: Rename iptables-unit

Hi Daniel, This is an end to end test and not a prober unit test. --- .gitignore | 2 +- Makefile.am| 14 +- tools/iptables-test2.c | 556 + tools/iptables-unit.c | 556 -

Re: DHCPv6 client compliance to RFCs.

Hi Harshal, The network should know better than the user what is the correct setting. The end user probably has no idea what the dhcpv6 mode should be or what dhcpv6 even means. There is also a issue that if the network says we should use statefull addresses, and user configures the system

Re: [PATCH] storage: Check if file exist before trying to load it

Hi Daniel, Instead of trying to open an file which does not exist and then print an error message, check if that file exist first. --- src/storage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/storage.c b/src/storage.c index 1ceafb9..8278293 100644 --- a/src/storage.c +++

Re: [PATCH] technology: Start tethering automatically

Hi Jukka, On Wed, 2013-03-06 at 16:10 +0200, Jukka Rissanen wrote: If the user activated tethering, then remember the status and restart the tethering when connman starts. This is much needed feature when we have a headless system. There is a user problem here with someone enabling WiFi

Re: [PATCH 0/5] Add current git HEAD commit id to version prints

Hi Jukka, there was someone in irc/ml missing information about what is the git HEAD commit id of the connman sources when the binary was built. I have been also missing this information lately so decided to generate this piece of data. Cheers, Jukka Jukka Rissanen (5): build:

Re: [PATCH 2/3] systemd: Use environment file for connmand debug options

Hi Jukka, src/connman.service.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/connman.service.in b/src/connman.service.in index 2e9e4d5..fa57d4e 100644 --- a/src/connman.service.in +++ b/src/connman.service.in @@ -6,7 +6,8 @@ After=syslog.target Type=dbus

Re: [PATCH 0/5] Add current git HEAD commit id to version prints

Hi Jukka, there was someone in irc/ml missing information about what is the git HEAD commit id of the connman sources when the binary was built. I have been also missing this information lately so decided to generate this piece of data. Cheers, Jukka Jukka Rissanen (5): build:

Re: [PATCH 2/3] systemd: Use environment file for connmand debug options

Hi Jukka, src/connman.service.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/connman.service.in b/src/connman.service.in index 2e9e4d5..fa57d4e 100644 --- a/src/connman.service.in +++ b/src/connman.service.in @@ -6,7 +6,8 @@ After=syslog.target Type=dbus

Re: [RFC 01/12] doc: Add method call and signal for tethering information

Hi Patrik, this does not look like an useful interface. I find it actually pretty ugly and glued on. It does not fit. So lets not do it this way. Yes, all attributes you mentioned describes it well. Martin wanted to see the code, so it was better to send it here early as an RFC. If we

Re: [RFC 01/12] doc: Add method call and signal for tethering information

Hi Martin, I do not even know what any of these information mean. What are they good for. What value are they providing. What would the user interface do with this information? The idea here is to provide a list of the clients that are tethered. Some additional information about each one

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

Hi Daniel, Let's adapt (and fix if necessary) rtnl instead. In the near future there is a nicer netlink handling code which is coming also, so it will require a bit of work in rtnl anyway. You might want to wait for this maybe. Check this with Marcel. is ACCT netfilter plain netlink or

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

Hi Daniel, Let's adapt (and fix if necessary) rtnl instead. In the near future there is a nicer netlink handling code which is coming also, so it will require a bit of work in rtnl anyway. You might want to wait for this maybe. Check this with Marcel. is ACCT netfilter plain netlink or

Re: [RFC 01/12] doc: Add method call and signal for tethering information

Hi Patrik, --- doc/manager-api.txt | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index ed23c8d..ebbb8e0 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -145,6 +145,10 @@ Methods dict

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

Hi Daniel, Instead of factoring out common parts from rtnl.c we add a new implementation for handling the upcoming ACCT netfilter netlink messages. The main reason is not to disturb the working rtnl code (although it has several hidden bugs, which are not triggered by the ussage pattern).

Re: UI implemetation for connecting to a hidden network

Hi Tomasz, Services are grouped by security. You could have 100 hidden service, if all are wpa/wpa2 -- you will see only 1 hidden service on security psk. I had no idea about this. I imagined that each hidden service would be listed. Your response makes a lot of send to me now.

Re: UI implemetation for connecting to a hidden network

Hi Sameer, Now, this is fine if there is only one hidden network listed. Say for example there are 2 hidden networks, user would have a difficult time figuring out the networks they are suppposed to connect to. Of course you can take a best guess based on the security being used, the

Re: [PATCH v1 1/2] main: Move signalfd setup down

Hi Daniel, In the next patch we like to access the option flags, therefore move the signal_handler(), setup_signalfd and disconnect_callback() after the parser functions and the option_* decleration. --- src/main.c | 158 ++--- 1

Re: [PATCH v1 2/2] main: Add memory profiling support

Hi Daniel, When the debug option is set ('-d') then the glib memory profiling subsystem is enabled. To see the profiling information send a SIGRTMIN to connman, e.g. killall -34 connmand Unfortunatly we need to parse argv by hand because no glib function can be called before setting

Re: dnsproxy signaling

Hi Lorn, Just wondering if there are any dbus signals to be had when there is no connection and something makes a request? i.e. (no connection) user tries to opens link - udp_listener_event - parse_request - send_response[MSG_NOSIGNAL] - dbus - [some client pops up Do you want to

Re: Missing Gateway Property for Service IPv6 Dictionary?

Hi Grant, Is there any reason why a Gateway property is missing from the service IPv6 dictionary? Is this assumed to be implicit from the address prefix and therefore unnecessary? it is documented in the API. If it is not returned that normally means we do not have it (or we have a bug here).

Re: Use always glib memory functions

Hi Patrik, [PATCH 1/4] core: Use glib memory functions [PATCH 2/4] gdhcp: Use glib memory functions [PATCH 3/4] gweb: Use glib memory functions These patches are small cleanups which I found during my attempt to get some memory profile output. So only path 1-3 should be applied.

Re: [PATCH] technology: Enable wifi tethering open network type

Hi Arron, some device want to support wifi open tethering network type our ConnMan already supported, just not export the API, I also not sure whether we force the user to use encrypied wifi network for security consideration I am strictly against providing anything else than a WPA2

Re: coordinating wired MAC address override with connman

Hi Peter, I believe you can set the MAC address from the bootloader if this is an option? AFAIK you can't. In earlier versions of OpenEmbedded the kernel (3.0.0 at the time) had been patched to provide the MAC address through a module parameter, but the patch was rejected upstream and

Re: [PATCH 1/3] service: Substitute connman_uint8_t with unsigned char

Hi Patrik, 'connman_uint8_t' is rarely used, use the real type instead. --- src/service.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 67889de..1ad71d3 100644 --- a/src/service.c +++ b/src/service.c @@ -72,7 +72,7 @@

Re: Cannot connect to EAP (ieee8021x) without a .config file

informations to the user. Perhaps by checking the service's security property is ieee8021x? I remember that there was a discussion here and Marcel Holtmann said that Agents shouldn't ask this kind of information to the user, that's why there is no API for that. But as we are discussing now we

Re: [PATCH] gdhcp: Fix resource leak

Hi Danny, The socket was not closed when the sendto got failed. --- gdhcp/ipv4ll.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdhcp/ipv4ll.c b/gdhcp/ipv4ll.c index 17ab3d5..283bb9b 100644 --- a/gdhcp/ipv4ll.c +++ b/gdhcp/ipv4ll.c @@ -110,11 +110,12 @@

Re: [PATCH] systemd: prevent duplicate logging messages in journal

Hi Marti, By default, both stdout and syslog messages go to the systemd journal, which results in duplicate messages being logged. Thanks to Vinicius Costa Gomes for pointing out this problem. --- src/connman.service.in | 1 + 1 file changed, 1 insertion(+) patch has been applied.

Re: [PATCH 0/3] Check if we already know the wifi AP credentials

Hi Jukka, if the system has multiple wifi cards and user has connected to access point successfully using one of the cards, then we know the credentials to that AP. So we can reuse this information when connecting to the same AP using different card (=service). so explain to me why this is

Re: [PATCH v5 3/5] gdhcp: Use host byte order internally

Hi Jukka, Convert to network byte order just before sending the packet. --- gdhcp/client.c | 47 +-- gdhcp/common.c | 20 +++- gdhcp/common.h | 17 + gdhcp/ipv4ll.c | 4 ++-- gdhcp/server.c | 41

Re: [PATCH v5 3/5] gdhcp: Use host byte order internally

Hi Jukka, Convert to network byte order just before sending the packet. --- gdhcp/client.c | 47 +-- gdhcp/common.c | 20 +++- gdhcp/common.h | 17 + gdhcp/ipv4ll.c | 4 ++-- gdhcp/server.c | 41

Re: [PATCH v5 0/5] clang compile fixes

Hi Jukka, v5: - patch order changed - new patch (#4) that replaces dhcp_add_simple_option() with three variants for different data sizes (uint8, uint16 and uint32) v4: - remove inclusion guard from header file (#1) - really remove unneccesary cast in client.c (#2) - use host byte

Re: [PATCH v2 2/3] gdhcp: Use unalignment macros from unaligned.h

Hi Jukka, gdhcp/client.c | 17 +++-- gdhcp/common.c | 19 +++ gdhcp/common.h | 16 gdhcp/server.c | 8 4 files changed, 26 insertions(+), 34 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index

Re: [PATCH v3 2/3] gdhcp: Use unalignment macros from unaligned.h

Hi Jukka, gdhcp/client.c | 17 ++--- gdhcp/common.c | 21 + gdhcp/common.h | 17 + gdhcp/server.c | 7 +++ 4 files changed, 27 insertions(+), 35 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index cf04ced..6632c2c 100644

Re: [PATCH 5/9] main.conf: Add SingleConnection description

Hi Patrik, however the description in the main.conf is bad. That needs at least work. That's fixable for sure :-) And the one important question is that if this means READY connections or ONLINE connections. For example if you have a working ONLINE connection in single mode and you

Re: [PATCH v4 3/4] gdhcp: Remove obsolete load lease function

Hi Jukka, gdhcp/gdhcp.h | 2 -- gdhcp/server.c | 6 -- 2 files changed, 8 deletions(-) diff --git a/gdhcp/gdhcp.h b/gdhcp/gdhcp.h index 169b81f..f011690 100644 --- a/gdhcp/gdhcp.h +++ b/gdhcp/gdhcp.h @@ -186,8 +186,6 @@ int g_dhcp_server_set_option(GDHCPServer *server,

Re: [PATCH v4 2/4] gdhcp: Use host byte order internally

Hi Jukka, Convert to network byte order just before sending the packet. --- gdhcp/client.c | 47 +-- gdhcp/common.c | 20 +++- gdhcp/common.h | 17 + gdhcp/ipv4ll.c | 4 ++-- gdhcp/server.c | 41

Re: [PATCH v4 2/4] gdhcp: Use host byte order internally

Hi Jukka, Convert to network byte order just before sending the packet. --- gdhcp/client.c | 47 +-- gdhcp/common.c | 20 +++- gdhcp/common.h | 17 + gdhcp/ipv4ll.c | 4 ++-- gdhcp/server.c | 41

Re: [PATCH v4 3/4] gdhcp: Remove obsolete load lease function

Hi Jukka, gdhcp/gdhcp.h | 2 -- gdhcp/server.c | 6 -- 2 files changed, 8 deletions(-) diff --git a/gdhcp/gdhcp.h b/gdhcp/gdhcp.h index 169b81f..f011690 100644 --- a/gdhcp/gdhcp.h +++ b/gdhcp/gdhcp.h @@ -186,8 +186,6 @@ int g_dhcp_server_set_option(GDHCPServer *server,

Re: [PATCH 5/9] main.conf: Add SingleConnection description

Hi Patrik, explain what this does in simpler English to me. I am not really getting why we would need this and what good does it do. The feature was requested by a customer, apparently they want to disconnect all other connections so that they are left with only one at a time. It's a

Re: [PATCH v2 1/3] core: Add unalignment macros

Hi Jukka, These come from kernel include/linux/unalignment directory. --- Makefile.am | 7 ++- include/unaligned.h | 54 +++ include/unaligned_be_byteshift.h | 90 +++

Re: [PATCH 1/4] dhcp: Use memcpy() when get/set data from buffer

Hi Jukka, In order to avoid clang error, just use memcpy() when reading or setting variable according to memory buffer read from wire. --- gdhcp/client.c | 14 +++--- gdhcp/common.c | 2 +- gdhcp/server.c | 9 - 3 files changed, 12 insertions(+), 13 deletions(-) diff

Re: [PATCH 2/4] unit: Wrong enum type used in session code

Hi Jukka, --- unit/session-api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I applied this one. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH 4/4] build: Add cast to avoid unused result clang warning

Hi Jukka, src/iptables.c| 4 ++-- src/stats.c | 10 +- tools/iptables-test.c | 4 ++-- tools/stats-tool.c| 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 43a2782..1ca8758 100644 ---

Re: [PATCH 3/4] build: Add (void *) cast to avoid clang error

Hi Jukka, --- gdhcp/common.c| 2 +- gdhcp/server.c| 2 +- plugins/loopback.c| 4 ++-- src/config.c | 2 +- src/dnsproxy.c| 4 ++-- src/inet.c| 37 - src/iptables.c| 13 +++--

Re: [PATCH 0/4] Rfkilling technology fixes

Hi Tomasz, Consistency. Removing any evidence that the device is wifi-capable is just wrong. Not exposing the hw-block state to UI is wrong as well and now that you mention it, I think I've complained about it before:) True, you opened a bug long ago on BMC. Anyway wifi card has no

Re: [PATCH] log: Enable/disable connman stack trace at compile time

Hi Patrik, Add compile time configuration switch '--enable-external-stacktrace' to let operating system/distribution handle stack traces. The default is to have ConnMan to print out a backtrace as before. --- Makefile.am |3 ++- configure.ac | 11 +++ src/log.c|6

Re: [RFC] doc: Move Ethernet dict from service to technology

Hi Jukka, The technology API contains network interface information as a property of the certain network technology. --- Hi, as the Ethernet property in service is not really related to service, lets move that information into technology. So technology could contain a list of network

Re: [PATCH 0/3] Return interface Vendor and Model information

Hi Jukka, this patch returns interface Vendor and Model information in service Ethernet dict. This information is useful in UI if there are more than one wifi cards in the system. In this case the user is presented multiple services with the same name without any means to determine what

Re: [PATCHv2] tethering: fix bridge module loading problem

Hi Patrik, Patch has been applied, thanks for fixing this. While applying I shortened the commit message somewhat. except that now the error message is gone. If we have a kernel build without bridge support, I want an error message in the logs. Regards Marcel

Re: ntp server : pool.ntp.org

Hi Danny, ConnMan support ntp protocol and automatic time configuration. But, ntp server should be feed and pre-requisite to support it. How about to use pool.ntp open time servers and select nearest time server based on time-zone selection? please read the usage policy of pool.ntp.org.

Re: [PATCH 00/12] New CLI v3

Hi Tudor, This patch set introduces a new CLI for Connman to use with the current tree. The new files in the client directory compile under a single executable called cmn, which provides a larger range of functions. It consists of patches that add the new client and documentation, remove the

Re: [PATCH 8/8] Delete old client, update Makefile and configure.

Hi Patrik, Makefile.am | 17 +++- client/main.c | 244 configure.ac |3 + Split this into three parts in such an order that it can be always compiled in between. and I like to keep client/main.c as main entry point for the client. Regards Marcel

Re: [PATCH] ofono: Retry to set property on errors

Hi Daniel, This is a workaround for modems which behave stupidly. So if oFono reports back an error when we try to set a property, e.g. Powered on the modem or Active on the context, then we just retry a few times before we stop giving up. I assumed this was clear. NAK. We are not working

Re: [RFC] ofono: Retry on modem powered error

Hi Daniel, My modem was not always powered up. So I tried added this retry logic and suddenly I don't get the failure case anymore. Maybe a heisenbug. Anyway, we have some more of those set property calls in the oFono plugin. Do we want to add this kind of retry logic everywhere? Sounds

Re: [PATCH 1/2] main: Introduce conf file option to ignore DHCP hostname option

Hi Jukka, The DisableDHCPHostnameOption in system config file can be used to ignore the received DHCP hostname option (12). --- src/main.c| 13 + src/main.conf |6 ++ 2 files changed, 19 insertions(+) diff --git a/src/main.c b/src/main.c index 1e4809f..70c73ef

Re: [PATCH V5 1/2] storage.c: Search for settings file even if d_type is DT_UNKNOWN.

Hi Andrei, This is useful for filesystems where d_type is always DT_UNKNOWN. For example: reiserfs is this really only reiserfs? Is that filesystem still in use? Regards Marcel ___ connman mailing list connman@connman.net

Re: [PATCH V5 1/2] storage.c: Search for settings file even if d_type is DT_UNKNOWN.

Hi Patrik, This is useful for filesystems where d_type is always DT_UNKNOWN. For example: reiserfs is this really only reiserfs? Is that filesystem still in use? Got a comment from Samuel saying that jffs2, ubifs and nfs might also do this. I tried to figure out that this was the

  1   2   3   4   5   6   7   8   9   >