Hi,
> CC src/ipconfig.o
> CC src/detect.o
> CC src/inet.o
> make[1]: *** No rule to make target `src/ipv4.c', needed by
> `src/ipv4.o'. Stop.
> make: *** [all] Error 2
run ./bootstrap-configure again.
Regards
Marcel
___
connman ma
Hi Lucas,
> The counter 'i' was not being incremented, making secondary dns servers
> to overwrite the first ones.
> ---
> src/dhcp.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
c
Hi Daniel,
> src/service.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Hi Samuel,
> > > > + array{string} AllowedBearers [readwrite]
> > > > +
> > > > + A list of bearers that can be used for this
> > > > session.
> > > > + In general this list should be empty to
> > > > indicate that
> > > > +
Hi Jukka,
> >> diff --git a/src/inet.c b/src/inet.c
> >> index 858d34c..40d8a8d 100644
> >> --- a/src/inet.c
> >> +++ b/src/inet.c
> >> @@ -4,6 +4,10 @@
> >> *
> >> * Copyright (C) 2007-2010 Intel Corporation. All rights reserved.
> >> *
> >> + * Portions (IPv6 router solicitation handlin
Hi Samuel,
> > diff --git a/doc/session-api.txt b/doc/session-api.txt
> > new file mode 100644
> > index 000..bede642
> > --- /dev/null
> > +++ b/doc/session-api.txt
> > @@ -0,0 +1,240 @@
> > +Serviceunique name
> > +Interface net.connman.Notification
> I would prefer a more verbo
Hi Jukka,
> diff --git a/src/6to4.c b/src/6to4.c
> new file mode 100644
> index 000..68472e6
> --- /dev/null
> +++ b/src/6to4.c
> @@ -0,0 +1,498 @@
> +/*
> + *
> + * Connection Manager
> + *
> + * Copyright (C) 2011 Nokia Corporation. All rights reserved.
> + *
> + * Portions copyright by
Hi Jukka,
> diff --git a/src/inet.c b/src/inet.c
> index 858d34c..40d8a8d 100644
> --- a/src/inet.c
> +++ b/src/inet.c
> @@ -4,6 +4,10 @@
> *
> * Copyright (C) 2007-2010 Intel Corporation. All rights reserved.
> *
> + * Portions (IPv6 router solicitation handling from MIPL project) are
>
Hi Jukka,
> + boolean 6to4 [readonly]
> +
> + If true, the service created 6to4
> + tunnel if the service IPv4 address is not
> + private and autoconfiguration does not work.
> +
Hi Grant,
> Added support for optionally specifying, via a global, read-only
> configuration file, system resource limits for address space, core
> files, data segment size, file size, lockable memory, open files,
> number of processes and stack size.
>
> This mirrors in function, almost identica
Hi Samuel,
> > > > >> +boolean 6to4 [readonly]
> > > > >> +
> > > > >> +If set to true, the service will create
> > > > >> 6to4
> > > > >> +tunnel if the service IPv4 address is
> > > > >> not
> > > > >> +
Hi Sebastien,
a gentle reminder to not top post on this mailing.
> User agent profiles are URL like this one :
> "http://nds1.nds.nokia.com/uaprof/N6230ir200.xml";.
So essentially it is just a URL. So we might not need something with a
format string, but I can see it kinda useful for supporting
Hi Samuel,
> > >> +boolean 6to4 [readonly]
> > >> +
> > >> +If set to true, the service will create
> > >> 6to4
> > >> +tunnel if the service IPv4 address is
> > >> not
> > >> +
Hi Samuel,
> > +gboolean g_web_set_ua_profile(GWeb *web, const char *profile)
> I pondered wether this one would need a variable number of arguments, but I
> guess for profiles URLs it doesnt.
that is actually a good point. We do that for the user agent for the
reason to do things like ..., "Conn
Hi Grant,
> Address an issue in which connman incorrectly handles DBus main
> loop timeouts by only removing timeouts that are not enabled when
> DBus requests a timeout removal.
>
> Please see http://lists.connman.net/pipermail/connman/2011-March/004147.html
> for more information.
> ---
> gdb
Hi Grant,
> Ensure that the DBUS_{CFLAGS,LIBS} substitutions are performed before
> checking for dbus_watch_get_unix_fd. This allows handling cross-compiled
> or other environments in which dbus-1 is not installed in a standard
> system location where the target environment dbus-1 version might be
Hi Claudio,
> Connman support different PDP type for 3G connection (auto, PPP and
> IP) ? If yes, what is the d-bus interface to use ?
check the doc/connman-api.txt inside the oFono project. All PDP
configuration is done via oFono.
However we are not planning to talk PPP over air at any point in
Hi Henri,
> doc/agent-api.txt | 27 +++
> 1 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/doc/agent-api.txt b/doc/agent-api.txt
> index 98499a3..fbae242 100644
> --- a/doc/agent-api.txt
> +++ b/doc/agent-api.txt
> @@ -61,10 +61,15 @@ Fields
Hi Martin,
> When exit from ConnMan, __connman_connection_cleanup() is called
> before __connman_service_cleanup() which then calls update_order().
> __connman_connection_cleanup() sets gateway_hash as NULL, so update_order()
> will access NULL hash and causes GLib-CRITICAL abort
> ---
> src/conn
Hi Samuel,
> > doc/service-api.txt | 18 ++
> > 1 files changed, 18 insertions(+), 0 deletions(-)
> >
> > diff --git a/doc/service-api.txt b/doc/service-api.txt
> > index b3e758e..55c5b6e 100644
> > --- a/doc/service-api.txt
> > +++ b/doc/service-api.txt
> > @@ -375,6 +375,24 @
Hi Gustavo,
> I've been thinking a bit on this an here is my proposed API for the DUN Server
> case. As I do not understand all the ConnMan internals yet I might be missing
> something basic here.
>
> Current oFono implementation runs the IPCP negotiation before create the PPP
> interface. That
Hi Martin,
> If bridge is built in knerl, /sys/module/bridge can not be used to detect
> the support of bridge in kernel.
> ---
> src/tethering.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/tethering.c b/src/tethering.c
> index 705f5ee..15e1ed9 100644
> ---
Hi Henri,
> > > This patchset tries to fix handling of APNs that are provisioned in
> > > ofono ConnectionContexts rather than written there by connman.
> > After reviewing your patch, and looking at the oFono GPRS provisioning, we
> > decided to actually remove the ConnMan APN service property.
>
Hi Kalle,
> >> --- a/doc/service-api.txt
> >> +++ b/doc/service-api.txt
> >> @@ -367,7 +367,7 @@ Properties string State [readonly]
> >>
> >>The current configured IPv6 address.
> >>
> >> - uint8 PrefixLength [readonly]
> >> + s
Hi Kalle,
> Also the dict type is a{ss}, not a{sv} as I expected, but don't know
> how I should mark that.
> ---
> doc/service-api.txt |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/doc/service-api.txt b/doc/service-api.txt
> index b3e758e..ff6b044 100644
> --- a/
Hi Kalle,
> > After reviewing your patch, and looking at the oFono GPRS provisioning, we
> > decided to actually remove the ConnMan APN service property.
> > APNs, Username and Password should be provisioned or set through oFono.
> >
> > What we're now missing from ConnMan is an agent interface w
Hi Kalle,
> The network-manager compatibility interface doesn't start unless
> we allow connman to own the interface in the dbus configuration.
> ---
> src/connman-dbus.conf |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
you need to create a separate one that belongs to the plugin.
Hi Daniel,
> In case dnsproxy can't create the socket listener we
> should fall back to resolv.conf.
>
> Reported by Kalle Valo
> ---
> src/main.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index 08f2555..3a8d44d 100644
> --- a/src
Hi Kalle,
> TAGS is created with 'make tags'.
> ---
> .gitignore |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 835ee2a..28a679a 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -23,6 +23,7 @@ ltmain.sh
> missing
> stamp-h1
> au
Hi Kalle,
> >> > I investigated more about network-manager compat support and here is
> >> > what I found. Please take a look.
> >> >
> >> > ---
> >> >
> >> > Kalle Valo (2):
> >> > dbus: allow owning org.freedesktop.NetworkManager
> >> > manager: support nm dbus properties
> >>
> >>
Hi Daniel,
> v4: - remove new line at end of file
> - pass option_dnsproxy into __connman_dnsproxy_init()
> v3: - use '-r' instead of '-x' for disabling the DNS Proxy
> v2: - remove resolver module
> - cleanup configure.ac and README (dnsproxy: plugin -> core)
> v1: - remove ondemand
> v0
Hi Daniel,
> > > - __connman_dnsproxy_init();
> > > + if (option_dnsproxy == TRUE)
> > > + __connman_dnsproxy_init();
> >
> > this might be better done as,
> >
> > __connman_dnsproxy_init(option_dnsproxy);
> >
> > I do have the slight suspicion that we have to run basic DNS
Hi Kalle,
> > I investigated more about network-manager compat support and here is
> > what I found. Please take a look.
> >
> > ---
> >
> > Kalle Valo (2):
> > dbus: allow owning org.freedesktop.NetworkManager
> > manager: support nm dbus properties
>
> Any comments?
I think we are
Hi Daniel,
> - __connman_dnsproxy_init();
> + if (option_dnsproxy == TRUE)
> + __connman_dnsproxy_init();
this might be better done as,
__connman_dnsproxy_init(option_dnsproxy);
I do have the slight suspicion that we have to run basic DNS proxy
enabling to ha
Hi Daniel,
> Makefile.am|4 +-
> Makefile.plugins | 12 -
> README | 17 +-
> configure.ac |7 -
> plugins/dnsproxy.c | 1517
>
> src/connman.h |4 +
> src/dnsproxy.c | 1512
Hi Samuel,
> > So I've been thinking about how ConnMan could support the DUN server case.
> > I gathered that the ConnMan requirements for that use case are the
> > following:
> >
> > - Provide a free IP range for oFono's ppp gateway address. The address range
> > should be a /24 one, in which o
Hi Samuel,
> So I've been thinking about how ConnMan could support the DUN server case.
> I gathered that the ConnMan requirements for that use case are the following:
>
> - Provide a free IP range for oFono's ppp gateway address. The address range
> should be a /24 one, in which oFono can freely
Hi Lucas,
> > > We can see on it that nothing occurs when I run the enable-tethering
> > script and that the bridge is never created :(
> >
> > if the bridge does not get created, then no wonder that Tethering does
> > not work.
> >
> > Can you check with brctl (part of bridge-utils) that bridge
Hi Jussi,
> >> The test scripts are useful when asking users for debugging info,
> >> but the sensitive information makes using the output on open forums
> >> problematic.
> >> ---
> >> test/get-services |2 ++
> >> test/list-services |2 ++
> >> test/test-manager |2 ++
> >> 3 file
Hi Daniel,
> src/main.c | 10 --
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index a38eb60..8eaab16 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -63,6 +63,7 @@ static gchar *option_nodevice = NULL;
> static gchar *option_noplugin
Hi Guillaume,
> > > I'm currently trying to test the USB tethering with connman-0.65.
> > > I'm facing some issues and I'll appreciate your help.
> >
> > Before going further into debugging this issue, could you please add
> > some debug in rtnl.c/read_uevent() to see which file it's reading, and
Hi Jukka,
> A simple script for setting and getting the service auto connect
> flag.
>
> test/set-autoconnect | 21 +
> 1 files changed, 21 insertions(+), 0 deletions(-)
> create mode 100755 test/set-autoconnect
what is wrong with using test-connman autoconnect for this?
Hi Jussi,
> The test scripts are useful when asking users for debugging info,
> but the sensitive information makes using the output on open forums
> problematic.
> ---
> test/get-services |2 ++
> test/list-services |2 ++
> test/test-manager |2 ++
> 3 files changed, 6 insertions(
Hi Guillaume,
> I'm currently trying to test the USB tethering with connman-0.65.
> I'm facing some issues and I'll appreciate your help.
can you run connmand with -d '*ethernet*:*tethering*' to get some extra
debug info where this goes wrong.
I am interested in what happens with enable-tetherin
Hi Denis,
please refrain from top posting on this mailing list. It is against the
used etiquette here.
> It functions well for wpa, but for wep we must add an extra argument because
> of ">3" in case below
> So we are obliged to write
> ./connect-service INTELTEST_WEP acdc123456 wep x
Hi Denis,
> This modification allows to take wep security into account
> without having to add an extra argument on the command line
> in case of wep security
please use git send-email to send patches and if in doubt just use
linux.intel.com for SMTP server. That works just fine.
We do not use S
Hi Samuel,
> > I needed some clarification on the connman technology states. I have put
> > down what I understand from the code (and some testing), please correct me
> > if I am wrong.
> >
> > 1. If there is no Technology driver and no devices then connman won't list
> > such a technology.
> A te
Hi Alok,
> I have a lenovo thinkpad T410 with integrated bluetooth.
> When I do a rfkill block bluetooth, the internal bluetooth device disappears
> from the list.
> A external USB bluetooth adapter on the system does not disappear.
>
> here are the observations :
>
> A. rfkill list shows 2 blue
Hi Pekka,
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index 3a6a9c1..a83602b 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -81,6 +81,11 @@ struct modem_data {
> gboolean requested_online;
> gboolean online;
>
> + /* org.ofono.ConnectionManager properties */
>
Hi Pekka,
>
> + if (service->favorite)
> + set_reconnect_state(service, TRUE);
> +
the preference here is to do check explicitly for TRUE or FALSE.
if (service->favorite == TRUE)
Regards
Marcel
___
Hi Pekka,
> ---
> plugins/ofono.c |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
these do not apply anymore. So you might have to rebase.
Regards
Marcel
___
connman mailing list
connman@connman.net
http://lists.connman.net/listin
Hi Pekka,
> Clears the error so that the corresponding service can retry
> autoconnecting.
> ---
> src/connman.h |1 +
> src/network.c | 17 +
> src/service.c | 17 +
> 3 files changed, 35 insertions(+), 0 deletions(-)
>
> diff --git a/src/connman.h b/src/
Hi Pekka,
> Do not request SetProperty("Online") if the modem is already in desired
> Online state.
> ---
> plugins/ofono.c | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
co
Hi Dave,
> > You can always set RoamingAllowed=true and you will not be bothered of
> > course.
>
> Not until I really *do* go abroad, and then receive my next bill :)
so you care about your roaming bills these days ;)
Regards
Marcel
___
connman
Hi Dave,
> This reminds me of a problem I'm currently having with Maemo, that's
> going to recur on MeeGo with ConnMan.
>
> The Orange and T-Mobile networks in the UK have merged, and I can now
> use either of them. My handset thinks that I'm roaming when I'm using
> T-Mobile signal, and keeps as
Hi Pekka,
> ---
> doc/service-api.txt |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
all 4 patches have been applied. Thanks.
Regards
Marcel
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Hi Pekka,
> Do not request SetProperty("Online") if the modem is already in desired
> Online state.
> ---
> plugins/ofono.c | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
I am getting this warning:
CC plugins/ofono.o
cc1: warnings being treated as errors
plugins/of
Hi Tomas,
> gsupplicant/supplicant.c |2 ++
> plugins/wifi.c | 10 +++---
> 2 files changed, 9 insertions(+), 3 deletions(-)
patch in general looks fine to me.
> diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
> index 8452656..39302d7 100644
> --- a/gsupplic
Hi Leena,
> When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the
> existing interface and the BSSs list. For BSSs list the next iterator
> contains the object path of next BSS but interface_bss_added() wrongly
> assumes that the next iterator contains the key/value pairs for the BSS
Hi Mohamed,
> I am looking at proxy patched to resubmit them I just have a question
> in some code in src/proxy.c in function connman_proxy_lookup
> we are creating timer then calling find proxy from the timer callback.
> Is this timer really needed? Why I can not call pacrunner from
> connman_pro
Hi Leena,
> When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the
> existing interface and the BSSs list. For BSSs list the next iterator
> contains the object path of next BSS but interface_bss_added() wrongly
> assumes that the next iterator contains the key/value pairs for the BSS
Hi Leena,
> >>> - interface_bss_added(iter, interface);
> >>> + interface_bss_added_with_keys(iter, interface);
> >>> }
> >
> >>I am not so thrilled about the naming here. Could we just not check if
> >>the extra iter with keys is present?
> >
> >For both the cases we have a next DBusMessageItera
Hi Leena,
> When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the
> existing interface and the BSSs list. For BSSs list the next iterator
> contains the object path of next BSS but interface_bss_added() wrongly
> assumes that the next iterator contains the key/value pairs for the BSS
Hi Leena,
> From: Leena Gunda
>
> Fixes BMC#10454 and #11201
>
> ---
> When ConnMan is SIGKILLed and restarted WiFi plugin will reuse the existing
> interface. It will get a list of existing BSSs and for each BSS in the BSSs
> list, interface_bss_added() is called. In interface_bss_added() if
Hi Leena,
> Free the interface properties before doing a g_strdup.
> Fixes BMC#11687
>
> ---
> gsupplicant/supplicant.c | 12 +---
> 1 files changed, 9 insertions(+), 3 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
conn
Hi Leena,
> From: Leena Gunda
>
> Fixes BMC#11684
>
> ---
> g_supplicant_unregister first destroys the interface table and then invokes
> system_killed callback which will trigger wifi device driver removal.
> wifi_remove will now set it's interface data to NULL but the
> GSupplicantInterfac
Hi Leena,
> diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
> index 6302af0..1459aea 100644
> --- a/gsupplicant/supplicant.c
> +++ b/gsupplicant/supplicant.c
> @@ -1272,20 +1272,32 @@ static void interface_property(const char *key,
> DBusMessageIter *iter,
> const c
Hello everyone,
I am trying to track down pending or not yet applied patches. So if you
have send patches in the last weeks that neither Samuel nor I have
commented on or applied, please resend them now.
Regards
Marcel
___
connman mailing list
connma
Hi Mohamed,
> Reflect new and modify *.config to connman config list. with
> patch any modified or added .config file will be read by connman
> and add these configuration for new provisioning.
> ---
> src/config.c | 171
> +++---
> 1 files ch
Hi Jukka,
> while doing IPv6 work I found some more memory leak problems.
>
> The patch 1 is optional as it just adds some more debug output
> in ipconfig ref/unref functions but I needed it to find the
> problem described in second patch.
>
> The patch 2 fixes reference counting issue in servic
Hi Mohamed,
> Reflect new and modify *.config to connman config list. with
> patch any modified or added .config file will be read by connman
> and add these configuration for new provisioning.
> ---
> src/config.c | 168
> --
> 1 files ch
Hi Mohamed,
> Reflect new and modify *.config to connman config list. with
> patch any modified or added .config file will be read by connman
> and add these configuration for new provisioning.
> ---
> src/config.c | 174 -
> 1 files change
Hi Mohamed,
> Reflect new and modify *.config to connman config list. with
> patch any modified or added .config file will be read by connman
> and add these configuration for new provisioning.
>
> P.S
> I will submit another patch to refelect new provisioning on current
> avialable network.
> --
Hi Jukka,
> I just noticed that the v2 resend was incorrect (the first patch was over my
> previous patch and not the original).
> So this one is correct and as mentioned in v2 patch description, the second
> patch is optional.
I saw the v3 too late. So ignore my other email. Both patches have
Hi Jukka,
> src/service.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
this patch does not apply cleanly.
Applying: memoryleak: check return value correctly before clearing pointer
error: patch failed: src/service.c:3406
error: src/service.c: patch does not apply
Patch failed
Hi Jukka,
> >> --- a/src/service.c
> >> +++ b/src/service.c
> >> @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct
> >> connman_service *service)
> >> __connman_ipconfig_clear_address(service->ipconfig_ipv4);
> >> __connman_ipconfig_clear_address(service->ipconfig_ipv6);
Hi Jukka,
> src/service.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index befd026..68606dd 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct
> connman_servic
Hi Jukka,
> Here are the memory leak patches that I sent before christmas.
> There are still issues with supplicant.c but as it is being
> deprecated I have not really looked the memory leaks in it.
so I applied all of the patches except one. Thanks for re-sending the
whole patchset.
Regards
Ma
Hi Leena,
> From: Leena Gunda
>
> Fixes BMC#11878
>
> ---
> plugins/dnsproxy.c |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
connman mailing list
connman@connman.net
http://li
Hi Jukka,
> I had some extra time and decided to fix some memory leaks
> that valgrind showed up. These leaks were the most obvious
> ones from my valgrind run so there are still mem leaks
> left in the code.
> There are quite a lot of "possibly lost" blocks but they
> seem to be from resources th
Hi Mohamed,
> Append all multiple message-header fields with the same name and
> remove any white space in front of fiels value.
> ---
> gweb/gweb.c | 119
> +++
> 1 files changed, 79 insertions(+), 40 deletions(-)
I applied this patch, h
Hi Grant,
> I recently came across a use case in which connmand-0.64 generates two
> conflicting network service entries for a wireless access point with an SSID
> from the "special" list that ultimately results in not being able to connect
> to the SSID at all.
>
> In this scenario, I bring up m
Hi Leena,
> Fixes BMC#11830
>
> ---
> src/iptables.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connma
Hi Leena,
thanks for the patch. It has been applied.
> From: Leena Gunda
>
> Free WiFi network strings in network_destruct.
> Fixes BMC#11815
And now I am getting a bit picky, but there is no need to repeat the
subject inside the commit message. When I use "git am" to apply the
patch, then it
Hi Yang,
> eventually I found the weird behaviour, our smtp server will replace blank
> line with "=20".
>
> I send them as attachments before I can change or fix the mailer problem.
> Could you please merge?
check using git send-email, but for now I have applied both patches.
Regards
Marcel
Hi Leena,
> Re-creating patch with latest git repo.
>
> Free the network path when removing the network.
>
> ---
> gsupplicant/supplicant.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
patch has been applied, but same comments apply.
Regards
Marcel
_
Hi Leena,
> From: Leena Gunda
>
> Re-create patch. Fix Invalid Read error reported by Valgrind while removing
> gsupplicant interface.
so I fixed the commit message up manually. However as a general rule,
please not reply to a patch with another patch. Rather do a new patch
with [PATCH v2] sub
Hi Yang,
> src/stats.c and src/tools/stats-tool.c use glib function g_mkstemp_full
> g_mkstemp_full comes since GLib 2.21.6, see following changelog:
> http://linuxtesting.org/upstream-tracker/changelogs/glib/2.21.6/changelog.html
>
> So here fix the dependency of glib in configure.ac to >=2.22
Hi Yang,
> I got build failing as below:
> cc1: warnings being treated as errors
> gdhcp/client.c: In function ‘alloc_dhcp_option’:
> gdhcp/client.c:1455: error: implicit declaration of function ‘strnlen’
>
> define _GNU_SOURCE fixes this problem.
> ---
> gdhcp/client.c |1 +
> 1 files cha
Hi Yang,
> src/stats.c and src/tools/stats-tool.c use glib function g_mkstemp_full
> g_mkstemp_full comes since GLib 2.21.6, see following changelog:
> http://linuxtesting.org/upstream-tracker/changelogs/glib/2.21.6/changelog.html
>
> So here fix the dependency of glib in configure.ac to >=2.22
>
Hi Leena,
> Below is patch for:
> http://bugs.meego.com/show_bug.cgi?id=11764
>
> Free the network path when removing the network.
>
> ---
> gsupplicant/supplicant.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
this one fails:
Applying: Free gsupplicant network path when remov
Hi Lenna,
> Below is patch for:
> http://bugs.meego.com/show_bug.cgi?id=11763
>
> Free the network path of the connected WiFi when removing the interface.
>
> ---
> gsupplicant/supplicant.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
M
Hi Leena,
> Below is patch for:
> http://bugs.meego.com/show_bug.cgi?id=11784
>
> The WiFi plugin initiates a interface removal by invoking
> g_supplicant_interface_remove which invokes the RemoveInterface D-Bus method
> and sets interface_remove_result as the result callback.
>
> Once the in
Hi Mohamed,
> Append all multiple message-header fields with the same name and
> remove any white space in front of fiels value.
> ---
> gweb/gweb.c | 34 +++---
> 1 files changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/gweb/gweb.c b/gweb/gweb.c
> index c
Hi Mohamed,
> Add all http response header to hash table and allow
> user to get these header values.
>
> P.S.
> I added multi line support but I really did not test that code,
> if you knew a URL that has multi line header please email it to
> me so I can test this.
>
> Header with same key wil
Hi Dave,
> > > > And please use g_hash_table_replace() instead of insert. See the GLib
> > > > documentation for details or test it by yourself. There is a
> > > > different.
> > >
> > > Hrm. Can't you have repeated headers? If you replace, wouldn't you throw
> > > away the previous one when you
Hi Yang,
> I got build failing as below:
> cc1: warnings being treated as errors
> gdhcp/client.c: In function ‘alloc_dhcp_option’:
> gdhcp/client.c:1455: error: implicit declaration of function ‘strnlen’
>
> define _GNU_SOURCE fixes this problem.
>
> Here add -D_GNU_SOURCE in Makefile instead o
Hi Yang,
> src/stats.c and src/tools/stats-tool.c use glib function g_mkstemp_full
> g_mkstemp_full comes since GLib 2.21.6, see following changelog:
> http://linuxtesting.org/upstream-tracker/changelogs/glib/2.21.6/changelog.html
>
> So here fix the dependency of glib in configure.ac to >=2.22
>
over the leadership of
ConnMan and his constant contributions to the project. Also a big thank
you to Martin, Daniel and Mohamed for their excellent work.
Developers with the most changed lines
--
Marcel Holtmann 85627 (55.8%)
Samuel Ortiz
Hi Dave,
> > So even if we ignore the multi line headers right now,
>
> Don't. Get it right from the start, please.
yes, better get it right from the start.
> > And please use g_hash_table_replace() instead of insert. See the GLib
> > documentation for details or test it by yourself. There is
501 - 600 of 1199 matches
Mail list logo
