[PATCH l2tp/pptp 04/21] pptp: Add pptp vpn support

From: Mohamed Abbas mab...@linux.intel.com Initial revision. --- plugins/pptp.c | 278 1 files changed, 278 insertions(+), 0 deletions(-) create mode 100644 plugins/pptp.c diff --git a/plugins/pptp.c b/plugins/pptp.c new file mode

[PATCH l2tp/pptp 05/21] pptp: Add ppp plugin library.

From: Mohamed Abbas mab...@linux.intel.com pppd will use this library to talk with connman vpn plugin. Original patch comes from Mohamed Abbas. Jukka Rissanen changed the pptp function prefix to ppp as the plugin is used by both pptp and l2tp plugins. --- scripts/libppp-plugin.c | 308

[PATCH l2tp/pptp 06/21] l2tp: Add l2tp vpn support.

From: Mohamed Abbas mab...@linux.intel.com Initial revision. --- plugins/l2tp.c | 470 1 files changed, 470 insertions(+), 0 deletions(-) create mode 100644 plugins/l2tp.c diff --git a/plugins/l2tp.c b/plugins/l2tp.c new file mode

[PATCH l2tp/pptp 07/21] test: Add test script support for pptp/l2tp.

From: Mohamed Abbas mab...@linux.intel.com Modify connect-vpn script to handle pptp/l2tp connection. --- test/connect-vpn | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index a43c4cd..00fa717 100755 ---

[PATCH l2tp/pptp 08/21] l2tp: Add l2tp makefile and configure file.

--- Makefile.plugins | 18 ++ configure.ac | 14 ++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 23524df..4e33524 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -137,6 +137,24 @@

[PATCH l2tp/pptp 09/21] pptp: Add pptp makefile and configure file.

--- Makefile.plugins | 19 +++ configure.ac | 20 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 4e33524..5b1225d 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -155,6 +155,25 @@

[PATCH l2tp/pptp 10/21] scripts: Compile libppp-plugin.so properly.

--- Makefile.plugins | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 5b1225d..3fdfac0 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -3,6 +3,8 @@ plugin_cflags = -fvisibility=hidden -I$(srcdir)/gdbus \

[PATCH l2tp/pptp 11/21] l2tp: Set the provider IP address when connected.

Without this patch the service connect timeout handler will stop the provider service after two minutes. --- plugins/l2tp.c | 37 ++--- 1 files changed, 34 insertions(+), 3 deletions(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index 0209b2f..84f4843 100644

[PATCH l2tp/pptp 13/21] l2tp: Check authentication error properly.

--- plugins/l2tp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index 84f4843..6bfc725 100644 --- a/plugins/l2tp.c +++ b/plugins/l2tp.c @@ -157,6 +157,9 @@ static int l2tp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp 12/21] scripts: Report authentication error to connman.

The ppp plugin now checks ppp authentication error and report it to correct connman plugin. --- scripts/libppp-plugin.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/scripts/libppp-plugin.c b/scripts/libppp-plugin.c index 74f6207..b0276c2 100644 ---

[PATCH l2tp/pptp 14/21] pptp: Return authentication errors properly.

--- plugins/pptp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index ea0b599..7c62276 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -120,6 +120,9 @@ static int pptp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp 01/21] vpn: Add support to allow ppp tunnelling.

. This patch is prepared by Jukka Rissanen and it contains Mohamed Abbas original patch + fixes suggested by Daniel Wagner. --- plugins/vpn.c | 116 + plugins/vpn.h |4 ++ 2 files changed, 88 insertions(+), 32 deletions(-) diff --git

[PATCH l2tp/pptp 15/21] pptp: Set the provider IP address when connected.

Without this patch the service connect timeout handler will stop the provider service after two minutes. --- plugins/pptp.c | 37 ++--- 1 files changed, 34 insertions(+), 3 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 7c62276..fed322b 100644

[PATCH l2tp/pptp 17/21] readme: Add l2tp and pptp information.

--- README | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/README b/README index 0cec62b..532e327 100644 --- a/README +++ b/README @@ -41,6 +41,21 @@ To compile and install run: make make install +VPN +=== + +In order to compile pptp and l2tp

[PATCH l2tp/pptp 16/21] pptp: Do not put password in command line options.

--- plugins/pptp.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index fed322b..465f2dc 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -55,7 +55,6 @@ struct { int type; } pptp_options[] = { { PPTP.User, user, NULL,

[PATCH l2tp/pptp 18/21] vpn: Fix memory leak.

--- plugins/vpn.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index ee85dd7..8a51bda 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -158,6 +158,8 @@ vpn_exit: connman_provider_set_index(provider, -1);

[PATCH l2tp/pptp 19/21] provider: Fix memory leak.

Provider name is already allocated in connman_provider_get() so we must deallocate it before setting it again. --- src/provider.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/provider.c b/src/provider.c index 90f145d..5a1dffb 100644 --- a/src/provider.c +++

[PATCH l2tp/pptp 20/21] task: Make sure the process is eventually killed.

If a task refuses to kill itself, then wait two secs before trying again and if that does not help then forcefully kill it. --- src/task.c | 44 +++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/src/task.c b/src/task.c index

[PATCH l2tp/pptp 21/21] todo: Mark l2tp and pptp as done.

--- TODO | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/TODO b/TODO index 36f8240..7bf512d 100644 --- a/TODO +++ b/TODO @@ -153,20 +153,6 @@ Cellular VPN === -- l2tp support - - Priority: Low - Complexity: C2 - Owner: Mohamed Abbas

Re: [PATCH dns cache v3 1/2] dnsproxy: Implement A and AAAA DNS record caching.

Hi Marcel, On 07/20/2011 03:45 PM, Marcel Holtmann wrote: Hi Jukka, +static void send_cached_response(int sk, unsigned char *buf, int len, + const struct sockaddr *to, socklen_t tolen, + int protocol, int id, uint16_t answers) +{ +

Re: [PATCH dns cache v3 1/2] dnsproxy: Implement A and AAAA DNS record caching.

Hi Marcel, On 07/21/2011 02:11 PM, Marcel Holtmann wrote: Hi Jukka, + hdr = (void *) (buf + offset); + + hdr-id = id; + hdr-qr = 1; + hdr-rcode = 0; + hdr-ancount = htons(answers); + hdr-nscount = 0; + hdr-arcount = 0; I am still worried about

[PATCH] dnsproxy: Add error print when DNS response send failed.

--- src/dnsproxy.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 9701343..33206c0 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -215,8 +215,11 @@ static void send_response(int sk, unsigned char *buf, int len,

[PATCH dns cache v4 0/2] Implement DNS caching

. Regards, Jukka Jukka Rissanen (2): dnsproxy: Implement A and DNS record caching. TODO: DNS caching TODO |9 - src/dnsproxy.c | 787 +++- 2 files changed, 778 insertions(+), 18 deletions

[PATCH dns cache v4 2/2] TODO: DNS caching

--- TODO |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 36f8240..22078c8 100644 --- a/TODO +++ b/TODO @@ -36,15 +36,6 @@ Core credentials, ConnMan should be able to initiate a WiSPR authentication. -- DNS caching - - Priority: Low -

[PATCH dns cache v4 1/2] dnsproxy: Implement A and AAAA DNS record caching.

--- src/dnsproxy.c | 787 +++- 1 files changed, 778 insertions(+), 9 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 33206c0..1241a61 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -32,6 +32,7 @@ #include sys/types.h

Re: [PATCH l2tp/pptp 01/21] vpn: Add support to allow ppp tunnelling.

Hi Daniel, On 07/22/2011 12:43 PM, Daniel Wagner wrote: Hi Jukka, + data-if_name = (char *)g_strdup(ifname); I know this should not part of your patch, but I think we do not free data-if_name. Or do I miss something? cheers, daniel The free is done in patch #18. So I did not

Re: [PATCH l2tp/pptp 04/21] pptp: Add pptp vpn support

Hi Daniel, On 07/22/2011 12:57 PM, Daniel Wagner wrote: Hi Jukka, On Wed, Jul 20, 2011 at 10:30:38AM +0300, Jukka Rissanen wrote: From: Mohamed Abbasmab...@linux.intel.com Initial revision. --- plugins/pptp.c | 278 1 files changed

Re: [PATCH l2tp/pptp 11/21] l2tp: Set the provider IP address when connected.

Hi Daniel, On 07/22/2011 01:19 PM, Daniel Wagner wrote: Hi Jukka, @@ -187,14 +193,39 @@ static int l2tp_notify(DBusMessage *msg, struct connman_provider *provider) ... + + g_free(addressv4); + g_free(netmask); + g_free(gateway); + connman_ipaddress_free(ipaddress);

[PATCH dhcp 1/4] service: Remember last DHCP IP address.

--- src/connman.h |3 +++ src/service.c | 36 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 408b809..e687502 100644 --- a/src/connman.h +++ b/src/connman.h @@ -552,6 +552,9 @@ void

[PATCH dhcp 0/4] Reuse last IP address.

Hi, the following patchset fixes the problem in bug #21068 https://bugs.meego.com/show_bug.cgi?id=21068 We suggest the DHCP server to give us the IP address we had last time. This is done by sending the DHCP REQUESTED IP option to server. Regards, Jukka Jukka Rissanen (4): service: Remember

[PATCH dhcp 3/4] tools: Add missing parameter.

--- tools/dhcp-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/dhcp-test.c b/tools/dhcp-test.c index 1fbf1f9..18527c8 100644 --- a/tools/dhcp-test.c +++ b/tools/dhcp-test.c @@ -170,7 +170,7 @@ int main(int argc, char *argv[]) timer = g_timer_new();

[PATCH dhcp 2/4] gdhcp: Enable DHCP REQUESTED IP address option when starting client.

--- gdhcp/client.c | 22 ++ gdhcp/gdhcp.h |2 +- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 0cf39cd..9ac7752 100644 --- a/gdhcp/client.c +++ b/gdhcp/client.c @@ -109,6 +109,7 @@ struct _GDHCPClient {

[PATCH dhcp 4/4] dhcp: Try to reuse the IP address we had last time.

This fix sends the DHCP_REQUESTED_IP option to server. Fixes BMC #21068 --- src/dhcp.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 20fc599..0f93b95 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -42,6 +42,7 @@ struct

[PATCH dhcp v2 1/2] ipconfig: Remember last DHCP IP address.

--- src/connman.h |3 +++ src/ipconfig.c | 40 +++- 2 files changed, 42 insertions(+), 1 deletions(-) diff --git a/src/connman.h b/src/connman.h index 408b809..d6acae4 100644 --- a/src/connman.h +++ b/src/connman.h @@ -257,6 +257,9 @@ unsigned char

Re: [PATCH dhcp v2 0/2] Reuse last IP address.

I just noticed that this patch is not yet ready. I missed the non-authoritative server case where the server ignores the request with REQUESTED IP option. I will send a new version soonish. Jukka On 07/27/2011 01:58 PM, Jukka Rissanen wrote: Hi, changes in this v2 patch: - The IP address

[PATCH dhcp v3 1/2] ipconfig: Remember last DHCP IP address.

--- src/connman.h |3 +++ src/ipconfig.c | 40 +++- 2 files changed, 42 insertions(+), 1 deletions(-) diff --git a/src/connman.h b/src/connman.h index 681b29f..3fc5a8a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -257,6 +257,9 @@ unsigned char

[PATCH dhcp v3 0/2] Reuse last IP address.

patchset fixes the problem in bug #21068 https://bugs.meego.com/show_bug.cgi?id=21068 We suggest the DHCP server to give us the IP address we had last time. This is done by sending the DHCP REQUESTED IP option to server. Regards, Jukka Jukka Rissanen (2): ipconfig: Remember last DHCP IP

[PATCH dhcp v3 2/2] dhcp: Try to reuse the IP address we had last time.

This fix will cause the DHCP_REQUESTED_IP option to be sent to the server. Fixes BMC #21068 --- gdhcp/client.c| 27 +++ gdhcp/gdhcp.h |2 +- src/dhcp.c| 23 ++- tools/dhcp-test.c |2 +- 4 files changed, 47 insertions(+), 7

[PATCH dhcp v4 1/2] ipconfig: Remember last DHCP IP address.

--- src/connman.h |3 +++ src/ipconfig.c | 40 +++- 2 files changed, 42 insertions(+), 1 deletions(-) diff --git a/src/connman.h b/src/connman.h index 681b29f..3fc5a8a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -257,6 +257,9 @@ unsigned char

[PATCH dhcp v4 0/2] Reuse last IP address.

by sending the DHCP REQUESTED IP option to server. Regards, Jukka Jukka Rissanen (2): ipconfig: Remember last DHCP IP address. dhcp: Try to reuse the IP address we had last time. gdhcp/client.c| 27 +++ gdhcp/gdhcp.h |2 +- src/connman.h |3

[PATCH dhcp v4 2/2] dhcp: Try to reuse the IP address we had last time.

This fix will cause the DHCP_REQUESTED_IP option to be sent to the server. Fixes BMC #21068 --- gdhcp/client.c| 27 +++ gdhcp/gdhcp.h |2 +- src/dhcp.c| 15 ++- tools/dhcp-test.c |2 +- 4 files changed, 39 insertions(+), 7

Re: [PATCH dhcp v4 1/2] ipconfig: Remember last DHCP IP address.

Hi Marcel, On 07/28/2011 02:13 PM, Marcel Holtmann wrote: Hi Jukka, src/connman.h |3 +++ src/ipconfig.c | 40 +++- 2 files changed, 42 insertions(+), 1 deletions(-) @@ -2169,9 +2198,18 @@ int __connman_ipconfig_save(struct connman_ipconfig

[PATCH pre-l2tp/pptp v2 00/14] Preliminary patches for L2TP/PPTP patchset

the dhcp. I had no time to investigate this. Regards, Jukka Jukka Rissanen (14): provider: NULL pointer check. vpn: Set authentication failure error code properly in provider. service: Add function to get the ipconfig state. network: Change the service disconnect state when necessary

[PATCH pre-l2tp/pptp v2 01/14] provider: NULL pointer check.

--- src/provider.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/provider.c b/src/provider.c index 9ae62cd..633ca40 100644 --- a/src/provider.c +++ b/src/provider.c @@ -879,6 +879,9 @@ int connman_provider_append_route(struct connman_provider *provider, const

[PATCH pre-l2tp/pptp v2 02/14] vpn: Set authentication failure error code properly in provider.

This patch is needed so that we can catch the authentication error from vpn driver and inform the failure to user. --- plugins/vpn.c |5 + plugins/vpn.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index e028b63..efeb959 100644 ---

[PATCH pre-l2tp/pptp v2 04/14] network: Change the service disconnect state when necessary.

If we are in idle or failure states, then we should not change to disconnect state when the service is disconnected. This is because we were not connected in the first place. --- src/network.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/network.c

[PATCH pre-l2tp/pptp v2 03/14] service: Add function to get the ipconfig state.

--- src/connman.h |3 +++ src/service.c | 13 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 681b29f..ff3ea97 100644 --- a/src/connman.h +++ b/src/connman.h @@ -499,6 +499,9 @@ void __connman_service_set_string(struct

[PATCH pre-l2tp/pptp v2 05/14] service: Set the user connect status correctly for VPN.

If the userconnect is not set, then informatation about authentication errors cannot be reported by agent API. --- src/service.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 091233a..257fe3c 100644 --- a/src/service.c +++

[PATCH pre-l2tp/pptp v2 06/14] service: Fix function name as it is static.

--- src/service.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 257fe3c..d8fe898 100644 --- a/src/service.c +++ b/src/service.c @@ -3426,7 +3426,7 @@ static void report_error_cb(struct connman_service *service, } }

[PATCH pre-l2tp/pptp v2 07/14] service: Change the debug print location to be more useful.

--- src/service.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index d8fe898..fcbfc87 100644 --- a/src/service.c +++ b/src/service.c @@ -3437,9 +3437,6 @@ static int service_indicate_state(struct connman_service *service)

[PATCH pre-l2tp/pptp v2 08/14] service: Fix state combining.

If we have IPv6 state as DISCONNECT and IPv4 state as ONLINE or READY then we are not disconnected. --- src/service.c | 64 ++-- 1 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/service.c b/src/service.c index

[PATCH pre-l2tp/pptp v2 10/14] provider: Add ref counting debug.

--- src/provider.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/provider.c b/src/provider.c index 633ca40..bbd462e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -143,7 +143,7 @@ static void provider_unregister(struct connman_provider *provider) struct

[PATCH pre-l2tp/pptp v2 09/14] service: Set the service state to IDLE if method is off or unknown.

--- src/service.c | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 9319323..34dbc79 100644 --- a/src/service.c +++ b/src/service.c @@ -3642,6 +3642,7 @@ int __connman_service_ipconfig_indicate_state(struct

[PATCH pre-l2tp/pptp v2 12/14] connection: Service was not ref counted properly.

The reference counting problems were clearly seen with VPN service. --- src/connection.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 4f3b3f8..38269d6 100644 --- a/src/connection.c +++ b/src/connection.c @@ -227,6 +227,7

[PATCH pre-l2tp/pptp v2 11/14] provider: Return existing service path if already connected.

--- src/provider.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/provider.c b/src/provider.c index bbd462e..8f1862e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -571,11 +571,12 @@ int __connman_provider_create_and_connect(DBusMessage *msg)

[PATCH pre-l2tp/pptp v2 13/14] network: Add NULL check.

--- src/network.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index ae82dc5..4a1e33c 100644 --- a/src/network.c +++ b/src/network.c @@ -1333,6 +1333,9 @@ int __connman_network_set_ipconfig(struct connman_network *network, enum

[PATCH pre-l2tp/pptp v2 14/14] service: Add NULL check.

--- src/service.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 34dbc79..dd75eba 100644 --- a/src/service.c +++ b/src/service.c @@ -4609,6 +4609,9 @@ struct connman_service *__connman_service_lookup_from_network(struct

[PATCH] dnsproxy: Fix possible alignment issue when handling DNS packet.

--- Hi, this patch fixes possible memory alignment issue when dealing with DNS packet. I will send the fixed DNS cache patch after this has been commited. Regards, Jukka src/dnsproxy.c | 85 +++ 1 files changed, 48 insertions(+), 37

[PATCH v2] dnsproxy: Fix possible alignment issue when handling DNS packet.

--- Hi, this patch fixes possible memory alignment issue when dealing with DNS packet. This version uses alignment macros from Bluez. Jukka include/types.h | 17 +++ src/dnsproxy.c | 134 +-- 2 files changed, 98 insertions(+), 53

[PATCH v3] dnsproxy: Fix possible alignment issue when handling DNS packet.

--- Hi, this 3rd version fixes the alignment macro namespace issue. Jukka include/types.h | 16 src/dnsproxy.c | 114 +++ 2 files changed, 97 insertions(+), 33 deletions(-) diff --git a/include/types.h b/include/types.h index

[PATCH 1/2] connection: Fix indentation.

--- src/connection.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/connection.c b/src/connection.c index 9ceefd3..3cd89eb 100644 --- a/src/connection.c +++ b/src/connection.c @@ -269,8 +269,8 @@ static void set_default_gateway(struct gateway_data *data,

[PATCH 2/2] connection: Fix IPv6 host route setting when using VPN.

--- src/connection.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/connection.c b/src/connection.c index 3cd89eb..5ea3c9b 100644 --- a/src/connection.c +++ b/src/connection.c @@ -282,7 +282,8 @@ static void set_default_gateway(struct gateway_data *data,

[PATCH service move 1/6] service: Ignore ipconfig that is not active when moving service.

--- src/service.c | 49 + 1 files changed, 45 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index 7cd21b5..4cb90fb 100644 --- a/src/service.c +++ b/src/service.c @@ -2920,6 +2920,8 @@ static DBusMessage

[PATCH service move 2/6] service: Allow ready service to be moved before online one.

--- src/service.c | 28 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index 4cb90fb..5f7242d 100644 --- a/src/service.c +++ b/src/service.c @@ -2912,6 +2912,22 @@ static DBusMessage *remove_service(DBusConnection

[PATCH service move 3/6] service: Allow state downgrade from online to ready.

--- src/connman.h |1 + src/service.c | 19 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 6e68c99..3d9f459 100644 --- a/src/connman.h +++ b/src/connman.h @@ -559,6 +559,7 @@ void __connman_service_notify(struct

[PATCH service move 4/6] service: Prefer online state over ready when comparing services.

--- src/service.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index e92412e..1382705 100644 --- a/src/service.c +++ b/src/service.c @@ -3297,9 +3297,21 @@ static gint service_compare(gconstpointer a, gconstpointer b,

[PATCH service move 6/6] connection: Default gateway is changed when reorganizing services.

Fixes BMC#22540 --- src/connection.c | 93 - 1 files changed, 91 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 84e3ab4..ef39ff2 100644 --- a/src/connection.c +++ b/src/connection.c @@ -326,6 +326,70 @@

[PATCH 0/2] device and wifi cleanup

Hi, attached patches do minor cleanup for device.c and wifi.c Regards, Jukka Jukka Rissanen (2): device: Device scan function made private. wifi: Remove not used code. plugins/wifi.c | 14 -- src/connman.h |1 - src/device.c |4 ++-- 3 files changed, 2 insertions

[PATCH 1/2] device: Device scan function made private.

The __connman_device_scan() is now static as it is only called from device.c --- src/connman.h |1 - src/device.c |4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..9ed9d24 100644 --- a/src/connman.h +++ b/src/connman.h @@

[PATCH 2/2] wifi: Remove not used code.

--- plugins/wifi.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 469ec67..f3ea836 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -764,26 +764,12 @@ static void interface_removed(GSupplicantInterface *interface)

[PATCH service move v2 1/6] service: Ignore ipconfig that is not active when moving service.

--- src/service.c | 49 + 1 files changed, 45 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index fc90934..b8f1c70 100644 --- a/src/service.c +++ b/src/service.c @@ -2920,6 +2920,8 @@ static DBusMessage

[PATCH service move v2 0/6] Fix moving services

properly set. Regards, Jukka Jukka Rissanen (6): service: Ignore ipconfig that is not active when moving service. service: Allow ready service to be moved before online one. service: Allow state downgrade from online to ready. service: Prefer online state over ready when comparing services

[PATCH service move v2 3/6] service: Allow state downgrade from online to ready.

--- src/connman.h |1 + src/service.c | 19 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..d74e653 100644 --- a/src/connman.h +++ b/src/connman.h @@ -560,6 +560,7 @@ void __connman_service_notify(struct

[PATCH service move v2 5/6] test: Script for testing service.MoveBefore interface.

--- test/service-move-before | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) create mode 100755 test/service-move-before diff --git a/test/service-move-before b/test/service-move-before new file mode 100755 index 000..f1fddd1 --- /dev/null +++

[PATCH service move v2 2/6] service: Allow ready service to be moved before online one.

--- src/service.c | 28 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index b8f1c70..2819d51 100644 --- a/src/service.c +++ b/src/service.c @@ -2912,6 +2912,22 @@ static DBusMessage *remove_service(DBusConnection

[PATCH service move v2 6/6] connection: Default gateway is changed when reorganizing services.

Fixes BMC#22540 --- src/connection.c | 90 - 1 files changed, 88 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 84e3ab4..3a6a116 100644 --- a/src/connection.c +++ b/src/connection.c @@ -326,6 +326,70 @@

[PATCH fast connect 0/9] Fast connect resend

Hi, here is the fast connect patches sent again. The patches consists of Mohamed's original patches + some fixes to make the fast connect work properly. The patches also require supplicant changes (patch sent to supplicant mailing list 23 Aug). Jukka Jukka Rissanen (4): gsupplicant: Fix

[PATCH fast connect 1/9] service: Add frequency support to service.

From: Mohamed Abbas mohamed.ab...@intel.com Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++

[PATCH fast connect 4/9] gsupplicant: Get the number of scan ssids from supplicant.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/gsupplicant.h |2 ++ gsupplicant/supplicant.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index a634141..5f7adc0 100644 ---

[PATCH fast connect 6/9] gsupplicant: Fix the ssid array.

--- gsupplicant/gsupplicant.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 059837f..93e1c8e 100644 --- a/gsupplicant/gsupplicant.h +++ b/gsupplicant/gsupplicant.h @@ -135,7 +135,7 @@ typedef struct

[PATCH fast connect 5/9] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 134 ++-- plugins/wifi.c| 217 - 3 files changed, 357 insertions(+), 10 deletions(-) diff --git

[PATCH fast connect 8/9] device: Make debug print more useful.

--- src/device.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/device.c b/src/device.c index 6b8e873..6e84bc4 100644 --- a/src/device.c +++ b/src/device.c @@ -106,7 +106,7 @@ static void reset_scan_trigger(struct connman_device *device) } else

[PATCH fast connect 7/9] wifi: Removed extra scan request call.

The wifi_scan_fast() is already called in connman_device_set_powered() so no need to call it again immediately. --- plugins/wifi.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index b9e30db..c0607f5 100644 --- a/plugins/wifi.c +++

[PATCH fast connect 9/9] wifi: Fallback to normal scan if fast scan is not supported.

--- plugins/wifi.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index c0607f5..410095d 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -506,13 +506,16 @@ static int wifi_scan_fast(struct connman_device *device) if

[PATCH misc 03/14] service: Add function to get the ipconfig state.

--- src/connman.h |3 +++ src/service.c | 13 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..6b2216a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -502,6 +502,9 @@ void __connman_service_set_string(struct

[PATCH misc 01/14] provider: NULL pointer check.

--- src/provider.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/provider.c b/src/provider.c index 9ae62cd..633ca40 100644 --- a/src/provider.c +++ b/src/provider.c @@ -879,6 +879,9 @@ int connman_provider_append_route(struct connman_provider *provider, const

[PATCH misc 08/14] service: Fix state combining.

If we have IPv6 state as DISCONNECT and IPv4 state as ONLINE or READY then we are not disconnected. --- src/service.c | 64 ++-- 1 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/service.c b/src/service.c index

[PATCH misc 07/14] service: Change the debug print location to be more useful.

--- src/service.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 7ec4a30..089a715 100644 --- a/src/service.c +++ b/src/service.c @@ -3501,9 +3501,6 @@ static int service_indicate_state(struct connman_service *service)

[PATCH misc 09/14] service: Set the service state to IDLE if method is off or unknown.

--- src/service.c | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 2aebff2..a081b79 100644 --- a/src/service.c +++ b/src/service.c @@ -3711,6 +3711,7 @@ int __connman_service_ipconfig_indicate_state(struct

[PATCH misc 10/14] provider: Add ref counting debug.

--- src/provider.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/provider.c b/src/provider.c index 633ca40..bbd462e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -143,7 +143,7 @@ static void provider_unregister(struct connman_provider *provider) struct

[PATCH misc 13/14] network: Add NULL check.

--- src/network.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index 31e7eaa..b8175a5 100644 --- a/src/network.c +++ b/src/network.c @@ -1330,6 +1330,9 @@ int __connman_network_set_ipconfig(struct connman_network *network, enum

[PATCH misc 11/14] provider: Return existing service path if already connected.

--- src/provider.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/provider.c b/src/provider.c index bbd462e..8f1862e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -571,11 +571,12 @@ int __connman_provider_create_and_connect(DBusMessage *msg)

[PATCH misc 12/14] connection: Service was not ref counted properly.

The reference counting problems were clearly seen with VPN service. --- src/connection.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 84e3ab4..6323401 100644 --- a/src/connection.c +++ b/src/connection.c @@ -229,6 +229,7

[PATCH fast connect v2 0/5] Fast connect resend

Hi, v2 contains the fixes to comments by Samuel. Jukka Mohamed Abbas (5): service: Add frequency support to service. wifi: Add support to multi scan type. gsupplicant: Add support to append char ** entries to dbus dict. gsupplicant: Get the number of scan ssids from supplicant.

[PATCH fast connect v2 2/5] wifi: Add support to multi scan type.

From: Mohamed Abbas mohamed.ab...@intel.com Allow multi scan type for fast connect. Scanning request removed from interface_added() because it is already called in connman_device_set_powered() so no need to call it again immediately (fix by Jukka Rissanen jukka.rissa...@linux.intel.com

[PATCH fast connect v2 1/5] service: Add frequency support to service.

From: Mohamed Abbas mohamed.ab...@intel.com Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++

[PATCH fast connect v2 4/5] gsupplicant: Get the number of scan ssids from supplicant.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/gsupplicant.h |2 ++ gsupplicant/supplicant.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 8e3690b..1419157 100644 ---

[PATCH fast connect v2 5/5] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

From: Mohamed Abbas mohamed.ab...@intel.com Quite many fixes by Jukka Rissanen jukka.rissa...@linux.intel.com --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 135 - plugins/wifi.c| 206

[PATCH] service: Do not allow service to be moved before a VPN service.

This is needed as the default routes are not set properly if we allow a service to be moved before a VPN service. --- Hi, it would be nice to allow a service to be moved before VPN service but unfortunately it would require bigger changes in connection.c so atm just disallow this. Jukka

[PATCH] network: Read only the ipconfig data if we have no address.

We must not read ipconfig data from file if there is already a valid address that was set by service set_property(). Fixes BMC#22767 --- Hi, the following patches fix the bug https://bugs.meego.com/show_bug.cgi?id=22767 where user is unable to set manual ipaddress. The bug is about IPv6 but the

<    1   2   3   4   5   6   7   8   9   10   >