Re: RFR: javax.xml.stream: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2013-01-07 Thread Daniel Fuchs
Thanks Joe. To make things clear I have pushed a revised webrev with solution 3. http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.stream/webrev.02.3/ The lines of interest are in FactoryFinder.java - right hand side: 267 if (type.getName().equals(factoryId)) { 268

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-07 Thread Alexey Utkin
I am sorry. Seems that I am out of discussion context, but did we get that sort of problem: https://code.google.com/p/android/issues/detail?id=42265#c114 http://forum.xda-developers.com/showthread.php?t=1987032nocache=0 The article in Russian: http://habrahabr.ru/post/164881/ Regards, -uta

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-07 Thread Aleksey Shipilev
Seriously doubt Android uses (recent) OpenJDK HashMap code, otherwise many lawyers around the world would now be having heart attacks. Also, java.util.Random is plain congruent PRNG, having nothing to do with entropy pools, preseeded with nanoTime() at most. -Aleksey. On 07.01.2013, at 16:19,

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-07 Thread Alexey Utkin
Thanks for explanation, Aleksey! Regards, -uta On 07.01.2013 16:30, Aleksey Shipilev wrote: Seriously doubt Android uses (recent) OpenJDK HashMap code, otherwise many lawyers around the world would now be having heart attacks. Also, java.util.Random is plain congruent PRNG, having nothing to

Re: Scaling problem of HashMap (introduced with alternative hashing)

2013-01-07 Thread Remi Forax
On 01/07/2013 01:19 PM, Alexey Utkin wrote: I am sorry. Seems that I am out of discussion context, but did we get that sort of problem: https://code.google.com/p/android/issues/detail?id=42265#c114 http://forum.xda-developers.com/showthread.php?t=1987032nocache=0 The article in Russian:

Re: RFR 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-07 Thread Chris Hegarty
Updated webrev and javadoc: http://cr.openjdk.java.net/~chegar/8005311/ver.01/ I plan to finalize the API based on this updated version. Note: the links in the javadoc do not work. It is simply the way that I copied the html files. I verified that they all link correctly in a full docs

Re: RFR 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-07 Thread Joe Darcy
Hello, I had a question about how the double accumulation logic was intended to be used. I've taken a quick look at the code and it uses straightforward sum = sum + nextValue code to compute the double sum. Summing doubles values with code numerical accuracy is surprisingly tricky and if

hg: jdk8/tl/jdk: 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set

2013-01-07 Thread kumar . x . srinivasan
Changeset: 1d9638ba5202 Author:ksrini Date: 2013-01-07 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d9638ba5202 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set Reviewed-by: mchung, kcr, ksrini Contributed-by: david.deha...@oracle.com

Re: RFR 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-07 Thread Louis Wasserman
Hmmm. Is that algorithm doable concurrently without needing a 128-bit CAS? On Mon, Jan 7, 2013 at 11:07 AM, Joe Darcy joe.da...@oracle.com wrote: Hello, I had a question about how the double accumulation logic was intended to be used. I've taken a quick look at the code and it uses

Re: RFR 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder

2013-01-07 Thread Doug Lea
On 01/07/13 14:07, Joe Darcy wrote: Hello, I had a question about how the double accumulation logic was intended to be used. I've taken a quick look at the code and it uses straightforward sum = sum + nextValue code to compute the double sum. Summing doubles values with code numerical accuracy

hg: jdk8/tl/langtools: 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows

2013-01-07 Thread james . holmlund
Changeset: a9cb93cca229 Author:jjh Date: 2013-01-07 17:51 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a9cb93cca229 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows Summary: Fix javap to not output \r\r\n Reviewed-by: jjg !

hg: jdk8/tl/jdk: 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx]

2013-01-07 Thread naoto . sato
Changeset: dbc692ea3f0a Author:bchristi Date: 2013-01-07 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dbc692ea3f0a 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] Summary: Hard-code sun.jnu.encoding to UTF-8 on Mac Reviewed-by: naoto !

Re: RFR: 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently

2013-01-07 Thread Stuart Marks
(Note for other readers: StreamPipe is not part of this webrev; the source is viewable at [1].) Hi Mandy, I don't see any place where the StreamPipe threads are interrupted, so the silent exit on InterruptedIOException probably doesn't ever get exercised. This handling does seem a bit odd to

Fwd: OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip

2013-01-07 Thread Mani Sarkar
Hi, I have been recommended to post my below query to your mailing list, if it is the right place to post. If not could you recommend who would be best placed to answer the below questions. I couldn't find an appropriate mailing list for 'jarzip' (as it is part of langtools) - any suggestions?

Re: RFR: 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently

2013-01-07 Thread Mandy Chung
On 1/7/2013 3:01 PM, Stuart Marks wrote: (Note for other readers: StreamPipe is not part of this webrev; the source is viewable at [1].) Hi Mandy, I don't see any place where the StreamPipe threads are interrupted, so the silent exit on InterruptedIOException probably doesn't ever get

Re: RFR: 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently

2013-01-07 Thread Stuart Marks
On 1/7/13 3:39 PM, Mandy Chung wrote: Swallowing an exception with no good reason seems a potential cause of reliability issue. As you think this seems a pretty rare case, I'm fine if you prefer to do this in a future cleanup. Just wanted to point this out. Right. You know how I feel

hg: jdk8/tl/jdk: 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently

2013-01-07 Thread stuart . marks
Changeset: 797e8a3dcd51 Author:smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to

Re: RFR: javax.xml.stream: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

2013-01-07 Thread Mandy Chung
Hi Daniel, I also agree with option 3 be the best option among them. Joe's suggestion to throw an exception if factoryId is not the base service type is good so that any existing application depending on that behavior will catch this change. Are you going to revise the spec - there is

Re: Request for Review: Java SE 8 Compact Profiles

2013-01-07 Thread David Holmes
I've generated a fresh webrev with your changes. http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/ Looking to get the Thumbs up on the src and test changes. Thanks, David On 4/01/2013 5:54 PM, Alan Bateman wrote: On 02/01/2013 18:53, Mandy Chung wrote: I reviewed the src/test

Build Failure in JPRT Job

2013-01-07 Thread Dan Xu
Hi, Today I submitted several jprt jobs asusual, but all jobs failed in building processat the same place. I tried to build jdk locally, and it worked fine. And I also tried to create a new jdk repo from the scratch, and then submitteda job. But the jprt job also failed in the buildwith the

Re: Build Failure in JPRT Job

2013-01-07 Thread David Holmes
Hi Dan, On 8/01/2013 5:11 PM, Dan Xu wrote: Hi, Today I submitted several jprt jobs asusual, but all jobs failed in building processat the same place. I tried to build jdk locally, and it worked fine. And I also tried to create a new jdk repo from the scratch, and then submitteda job. But the

Re: Build Failure in JPRT Job

2013-01-07 Thread Dan Xu
David, Thanks for your reply. I saw other jobs also had the similar jprt command. I wonder why others could succeed in the build. -Dan On Mon 07 Jan 2013 11:20:18 PM PST, David Holmes wrote: Hi Dan, On 8/01/2013 5:11 PM, Dan Xu wrote: Hi, Today I submitted several jprt jobs asusual, but

Re: Build Failure in JPRT Job

2013-01-07 Thread David Holmes
On 8/01/2013 5:30 PM, Dan Xu wrote: David, Thanks for your reply. I saw other jobs also had the similar jprt command. I wonder why others could succeed in the build. I'm not seeing such successes. I am seeing similar failures eg: