Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

2016-01-19 Thread Chris Hegarty
Felix, On 14 Jan 2016, at 06:07, Felix Yang wrote: > Hi all, >please review the fix for > test/java/net/SocketPermission/SocketPermissionTest.java, which fails > frequently with "java.net.BindException: Address already in use". > > Bug: https://bugs.openjdk.java.net/browse/JDK-8065076 > W

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-19 Thread David Holmes
On 20/01/2016 8:39 AM, David Holmes wrote: On 20/01/2016 12:50 AM, Roger Riggs wrote: Hi, How about "jdk.process.reaperStackSize". Based on some internal discussion that seems appropriate to me ... Except of course that the property is just a boolean not a size. :) So jdk.process.reaperUse

Re: RFR 8146803: Update to the sharding API

2016-01-19 Thread Lance Andersen
Thank you Joe. I had made those changes earlier and will sanity check before I push… Best Lance On Jan 19, 2016, at 5:30 PM, huizhe wang wrote: > Looks good overall. > > A few minor things and typos: > CommonDataSource: >Lic header: 2013 --> 2016; createShardingKeyBuilder: "@since 1.9" -

Re: RFR 8146803: Update to the sharding API

2016-01-19 Thread huizhe wang
Looks good overall. A few minor things and typos: CommonDataSource: Lic header: 2013 --> 2016; createShardingKeyBuilder: "@since 1.9" --> since 9 ConnectionPoolDataSource: Lic header: 2013 --> 2016; createShardingKeyBuilder: "@since 1.9" --> since 9

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-19 Thread David Holmes
On 20/01/2016 12:50 AM, Roger Riggs wrote: Hi, How about "jdk.process.reaperStackSize". Based on some internal discussion that seems appropriate to me ... It will need a CCC . ... and if not then the CCC will show the way. :) Thanks, David Roger On 1/19/16 7:10 AM, David Holmes wrote:

Re: GNU-style options for the Jar Tool

2016-01-19 Thread Martin Buchholz
A change such as this is reasonable and welcome. The compatibility interface will need to be maintained forever, and will continue to be the preferred interface for casual human use, the same way that humans stubbornly prefer the non-standard "head -1". So I would not drop the old usage text. Op

Re: RFR JDK-8147531,To add named character construct \N{...} to support Unicode name property

2016-01-19 Thread Martin Buchholz
Many years ago I considered implementing this cool feature. I thought that few would find it worth the cost - it would be hard to keep the cost low if this feature is used only rarely. You might want an expiring cache of character name mappings, and the JDK doesn't have such a thing yet. (I haven

RFR 8146803: Update to the sharding API

2016-01-19 Thread Lance Andersen
Hi, Please review the attached webrev which addresses some changes we needed to make to the sharding API. The CCC has been approved. The webrev can be found at: http://cr.openjdk.java.net/~lancea/8146803/webrev.00/ Here is a brief description of the changes -ConnectionPooledDataSource neede

RFR: JDK-8146568 NegativeArraySizeException in ArrayList.grow(int)

2016-01-19 Thread Martin Buchholz
Hi Stuart et al, Please review my fix for this corner case bug, including more importantly some performance improvements. https://bugs.openjdk.java.net/browse/JDK-8146568 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/ArrayList-grow/

Re: GNU-style options for the Jar Tool

2016-01-19 Thread Chris Hegarty
Please reply-to core-libs-dev@openjdk.java.net, which is more appropriate for discussion on Jar Tool. -Chris. On 19 Jan 2016, at 16:54, Chris Hegarty wrote: > GNU-style options for Jar Tool > > Prompted by the impending addition of new options for both multi-release jars > and jigsaw, it becam

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-19 Thread Roger Riggs
Hi, How about "jdk.process.reaperStackSize". It will need a CCC . Roger On 1/19/16 7:10 AM, David Holmes wrote: On 19/01/2016 9:53 PM, Kevin Walls wrote: | Hi Cheleswer, I think Martin is suggesting something like: | // Use a modest stack size, unless requested otherwise: long stackSize =

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-19 Thread David Holmes
On 19/01/2016 9:53 PM, Kevin Walls wrote: | Hi Cheleswer, I think Martin is suggesting something like: | // Use a modest stack size, unless requested otherwise: long stackSize = Boolean.getBoolean("processReaperUseDefaultStackSize") ? 0 : 32768; Someone from core-libs needs to chime on what t

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

2016-01-19 Thread Kevin Walls
| Hi Cheleswer, I think Martin is suggesting something like: | // Use a modest stack size, unless requested otherwise: long stackSize = Boolean.getBoolean("processReaperUseDefaultStackSize") ? 0 : 32768; Thread t = new Thread(systemThreadGroup, grimReaper, "process reaper", stackSize); ||| If