Looks good.
I would probably have had the hook interrupt the main thread while it
was running ie sleep(5000); main.interrupt(); sleep(5000); but
pre-interrupting itself before calling exit is probably functionally
equivalent.
David
On 24/06/2016 2:32 AM, Chris Hegarty wrote:
The shutdown h
Hi Dan,
On 6/23/2016 5:03 PM, Dan Smith wrote:
On Jun 23, 2016, at 2:04 PM, Roger Riggs wrote:
Hi Dan,
On 6/23/2016 2:53 PM, Dan Smith wrote:
On Jun 23, 2016, at 11:37 AM, Roger Riggs
wrote:
Hi Dan,
I was concerned about inter-operation between versions because serialized
objects
are p
> On Jun 23, 2016, at 2:04 PM, Roger Riggs wrote:
>
> Hi Dan,
>
> On 6/23/2016 2:53 PM, Dan Smith wrote:
>>> On Jun 23, 2016, at 11:37 AM, Roger Riggs
>>> wrote:
>>>
>>> Hi Dan,
>>>
>>> I was concerned about inter-operation between versions because serialized
>>> objects
>>> are passed betw
+1
> On 23/6/16 上午10:34, Naoto Sato wrote:
I see that you tested thoroughly :-)
Naoto
On 6/23/16 1:13 PM, Brent Christian wrote:
On 23/6/16 上午10:34, Naoto Sato wrote:
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 4
On 23/6/16 上午10:34, Naoto Sato wrote:
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 47 language
tags are case insensitive, so it would be better to check [a-z] in line
94/95 as well.
Done (and I've simplified the ass
Hi Dan,
On 6/23/2016 2:53 PM, Dan Smith wrote:
On Jun 23, 2016, at 11:37 AM, Roger Riggs wrote:
Hi Dan,
I was concerned about inter-operation between versions because serialized
objects
are passed between Java runtimes with different versions and both need to
compute
the same serial version
On 23/06/2016 17:32, Chris Hegarty wrote:
The shutdown hooks race against the shutdown sequence if the thread
invoking System.exit() is interrupted. This happens because
ApplicationShutdownHooks::runHooks joins the shutdown hooks. This
may lead to premature VM shutdown, with shutdown hooks not
> On Jun 23, 2016, at 11:37 AM, Roger Riggs wrote:
>
> Hi Dan,
>
> I was concerned about inter-operation between versions because serialized
> objects
> are passed between Java runtimes with different versions and both need to
> compute
> the same serial version uid (if it is not explicitly de
Thanks, Sergey.
Can someone from the core-libs launcher group please approve? (looks at Kumar)
-DrD-
> Looks fine.
>
> On 22.06.16 1:58, David DeHaven wrote:
>>
>>> JBS:
>>> https://bugs.openjdk.java.net/browse/JDK-8022291
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ddehaven/8022291/jdk.
Hello,
I'm not sure if this is the right forum for posting an issue we are
experiencing with JRE 1.8.0_92.
The JVM crashes in the Windows native code and generates a log (see
attachment, hs_err_pid15724.log), but not the usual stack-trace due to
uncaught exceptions. The root cause is uncle
On 6/23/16 8:24 AM, Naoto Sato wrote:
On 6/22/16 9:48 PM, Brent Christian wrote:
On 6/22/16 3:58 PM, Naoto Sato wrote:
2. I think mapping language/script combination to a typical locale is ok
to keep the compatibility (e.g., "sr-Latn" to "sr_CS", done by the JRS,
right?) In the meantime, I wou
Hi Dan,
I was concerned about inter-operation between versions because
serialized objects
are passed between Java runtimes with different versions and both need
to compute
the same serial version uid (if it is not explicitly declared). The
older java runtimes will
compute the serial version u
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 47 language
tags are case insensitive, so it would be better to check [a-z] in line
94/95 as well.
- Line 82: Does the API actually returns "zh-Hans_HK"? Underscore ('_'
> On Jun 23, 2016, at 8:51 AM, Roger Riggs wrote:
>
> Hi Dan,
>
> Is setting ACC_FINAL for anonymous inner classes a unique feature of the
> latest bytecode version?
> (javac -target 9)
>
> Was it always clear in class files with earlier bytecode versions?
This is a choice that the compiler m
On 23.06.2016 19:32, Chris Hegarty wrote:
> The shutdown hooks race against the shutdown sequence if the thread
> invoking System.exit() is interrupted. This happens because
> ApplicationShutdownHooks::runHooks joins the shutdown hooks. This
> may lead to premature VM shutdown, with shutdown hooks
The shutdown hooks race against the shutdown sequence if the thread
invoking System.exit() is interrupted. This happens because
ApplicationShutdownHooks::runHooks joins the shutdown hooks. This
may lead to premature VM shutdown, with shutdown hooks not fully
executed.
http://cr.openjdk.java.net/
Hi,
Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8150173/webrev.03/
On 23/06/16 14:55, Daniel Fuchs wrote:
if I understand correctly JAXBContextWithSubclassedFactory is supposed
to capture the idea of Test9 but it doesn't.
[...]
Oh - I see, I missed that - I was chasing
On 6/22/16 9:48 PM, Brent Christian wrote:
On 6/22/16 3:58 PM, Naoto Sato wrote:
Hi Brent,
1. It seems that the display language in the new code seems to have some
problems. I see (in es-419.txt):
---
locale[Default|Display|Format].getLanguage () is
user.language: it is
---
And in fact, displ
Hi,
Doug suggested to try another variant of resolving hash collisions in
open-addressing table - using a secondary hash for increment value of
consecutive probes. Since Java Objects provide only one hashCode()
function, "secondary" hash is computed from primary hash by
xorShift(hashCode), fo
Hi Dan,
Is setting ACC_FINAL for anonymous inner classes a unique feature of the
latest bytecode version?
(javac -target 9)
Was it always clear in class files with earlier bytecode versions?
Thanks, Roger
On 6/22/2016 7:05 PM, Dan Smith wrote:
Hi, making a change to serialization's computa
Dear all,
thank you, Claes, Vladimir, and Paul, for your reviews. See
http://cr.openjdk.java.net/~mhaupt/8143211/webrev.01/ for the next round.
The difference to the previous version is, roughly, as follows. Rev 01 ...
... honours the possibility of there being more than one loop in a LambdaFor
Hi Georgiy
On 23/06/16 13:48, Georgiy Rakov wrote:
Hi Daniel,
if I understand correctly JAXBContextWithSubclassedFactory is supposed
to capture the idea of Test9 but it doesn't. FactoryBase shouldn't
implement JAXBContextFactory but Factory should:
public static class FactoryBase {
Hi Daniel,
if I understand correctly JAXBContextWithSubclassedFactory is supposed
to capture the idea of Test9 but it doesn't. FactoryBase shouldn't
implement JAXBContextFactory but Factory should:
public static class FactoryBase {
public JAXBContext createContext(...) ...
On 06/23/2016 02:24 PM, Paul Sandoz wrote:
Hi Uwe,
Note that javac does not currently use MethodHandle.@PolymorphicSignature, so
it only serves as marker for documentation purposes. There may be some
unfinished business here, or the unique and limited scope of such methods meant
there was,
Hi Uwe,
Note that javac does not currently use MethodHandle.@PolymorphicSignature, so
it only serves as marker for documentation purposes. There may be some
unfinished business here, or the unique and limited scope of such methods meant
there was, contrary to what was originally thought, no nee
Hi Paul,
How about making the used (currently internal) annotation @PolymorphicSignature
public in MethodHandle? Then the spec would be much easier to define (and
future-proof). Of course, a separate ACC_POLYMORPHIC method access flag would
have been better from the beginning! I assume, you had
Hi Uwe,
The JL and JVM specifications have yet to be updated to take into account the
new sig-poly methods on VarHandle, they will be in due course by Alex.
It’s not clear yet if we can specify this generally or we will have to
enumerate on a per-class/method basis. Ideally it should be future
27 matches
Mail list logo
