RFR: JDK-8265029: Preserve SIZED characteristics on slice operations (skip, limit)

With the introduction of `toList()`, preserving the SIZED characteristics in more cases becomes more important. This patch preserves SIZED on `skip()` and `limit()` operations, so now every combination of `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and `toList()`, `toArray(

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 16:54:51 GMT, Ioi Lam wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > LGTM. Just a small nit. > @iklam > I thought the fingerprint code was als

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 16:54:51 GMT, Ioi Lam wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > LGTM. Just a small nit. @iklam I thought the fingerprint code was also us

Re: jpackage ea-17 --mac-entitlements

> > OK, probable user error. I eliminated my entitlement changes and it worked. > Related to the same functionality that I am trying to add, I should, or have to, make changes to my Info.plist This being the addition of NSAppleEventsUsageDescription. If I remember correctly in prior discussion

RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file"

The test actually failed starting from jdk13, but the error is masked by JDK-8264667 (and shell part of the test didn't verify result of the java execution) The fix: - updates JvmtiClassFileReconstituter to add attributes in the same order as javac does - makes the test java instead of shell - a

Re: RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file"

On Sat, 10 Apr 2021 01:10:37 GMT, Alex Menkov wrote: > The test actually failed starting from jdk13, but the error is masked by > JDK-8264667 (and shell part of the test didn't verify result of the java > execution) > The fix: > - updates JvmtiClassFileReconstituter to add attributes in the sam

Re: RFR: 8264208: Console charset API [v2]

Hello, I like the API, it is useful, however not enough to replace the defaultCharset once the Change to UTF8 is done. You still need a way to query the platforms file encoding (especially on Windows). Also I wonder if the Javadoc needs to discuss platform aspects of console, especially System

Re: jpackage ea-17 --mac-entitlements

> On Apr 9, 2021, at 6:59 PM, Michael Hall wrote: > > Should bug reports be written against this yet? > > I codesign generated a entitlements file and then tried adding… > >com.apple.private.tcc.allow-prompting > > > I added this to my invocation… > > --mac-entitlements “entitlemen

jpackage ea-17 --mac-entitlements

Should bug reports be written against this yet? I codesign generated a entitlements file and then tried adding… com.apple.private.tcc.allow-prompting I added this to my invocation… --mac-entitlements “entitlements.xml" And the app crashed… System Integrity Protection: enabled Crashe

Re: [External] : Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Apr 9, 2021, at 4:00 PM, John Rose mailto:john.r.r...@oracle.com>> wrote: The MH combinator for lookupswitch can use a data-driven reverse lookup in a (frozen/stable) int[] array, using binary search. The bytecode emitter can render such a thing as an internal lookupswitch, if that seems desi

Re: [External] : Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Apr 9, 2021, at 11:15 AM, fo...@univ-mlv.fr wrote: > > - Mail original - >> De: "John Rose" >> À: "Remi Forax" >> Cc: "Jorn Vernee" , "core-libs-dev" >> >> Envoyé: Vendredi 9 Avril 2021 20:01:18 >> Objet: Re: RFR: 8263087: Add a MethodHandle combinator that switches over a >> set o

Re: RFR: 8264806: Remove the experimental JIT compiler

On Fri, 9 Apr 2021 17:35:11 GMT, Vladimir Kozlov wrote: > As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Java-based JIT compiler (Graal) from JDK: > > - `jdk.internal.vm.compiler` — the Graal compiler > - `jdk.internal.vm.compiler.management` — Graal's `MBean`

Re: RFR: 8264806: Remove the experimental JIT compiler [v2]

> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Java-based JIT compiler (Graal) from JDK: > > - `jdk.internal.vm.compiler` — the Graal compiler > - `jdk.internal.vm.compiler.management` — Graal's `MBean` > - `test/hotspot/jtreg/compiler/graalunit` — Graal's unit

Re: RFR: 8264208: Console charset API [v2]

On Fri, 9 Apr 2021 21:02:26 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/io/Console.java line 404: >> >>> 402: * >>> 403: * @return A {@code Charset} object used in this {@code Console}. >>> 404: * @since 17 >> >> A couple of minor comments: >> May replace {@code C

Re: RFR: 8264208: Console charset API [v2]

On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been drafte

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v5]

On Fri, 9 Apr 2021 21:59:04 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v5]

> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Ahead-of-Time Compiler from JDK: > > - `jdk.aot` module — the `jaotc` tool > - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution > - related HotSpot code guarded by `#if INCLUDE_AOT` > > A

Re: RFR: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices [v2]

On Fri, 19 Mar 2021 15:20:00 GMT, Rafael Winterhalter wrote: >> 8263763: The constructor of an enumeration prefixes with two synthetic >> arguments for constant name and ordinal index. For this reason, the >> constructor annotations need to be shifted two indices to the right, such >> that th

Re: RFR: 8264208: Console charset API [v2]

> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome > [[2](https://bugs.openjdk.

Re: RFR: 8264208: Console charset API [v2]

On Fri, 9 Apr 2021 19:25:02 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflected the review comments. > > src/java.base/share/classes/java/io/Console.java line 404: > >> 402: * >> 403: *

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Fri, 9 Apr 2021 18:27:07 GMT, Jorn Vernee wrote: >> This patch adds a `tableSwitch` combinator that can be used to switch over a >> set of method handles given an index, with a fallback in case the index is >> out of bounds, much like the `tableswitch` bytecode. Here is a description >> of

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Fri, 9 Apr 2021 19:57:10 GMT, Jorn Vernee wrote: >>> yes, for all the switches, pattern-switch, enum-switch but not for the >>> string switch which requires a lookup switch. >> Can you outline how to use the tableswitch combinator in the case of a >> switch on strings ? >> >> Jan Lahoda has

Re: 8214761: Bug in parallel Kahan summation implementation

Hi Anirvan, You can contact contact Oracle’s open-source administrators at opensource_ww_...@oracle.com, who run the OCA app. We don't use the github usernames from the OCA app for OpenJDK pull requests, so you should not be running into issues with that for contributions to OpenJDK. If you

Re: RFR: 8264208: Console charset API

On Fri, 9 Apr 2021 16:47:55 GMT, Naoto Sato wrote: > Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, a

Re: RFR: 8264806: Remove the experimental JIT compiler

On Fri, 9 Apr 2021 17:35:11 GMT, Vladimir Kozlov wrote: > As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to > Java-based JIT compiler (Graal) from JDK: > > - `jdk.internal.vm.compiler` — the Graal compiler > - `jdk.internal.vm.compiler.management` — Graal's `MBean`

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 16:54:35 GMT, Ioi Lam wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/share/oops/methodCounters.cpp line 77: > >> 75: } >> 76: >>

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 16:34:58 GMT, Igor Veresov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/share/jvmci/jvmciCodeInstaller.cpp line 1184: > >> 1182:

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 16:30:41 GMT, Igor Veresov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/share/oops/instanceKlass.hpp line 257: > >> 255: _mi

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 08:32:59 GMT, Aleksey Shipilev wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/share/code/compiledIC.cpp line 715: > >> 713: tt

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote: > This patch adds a `tableSwitch` combinator that can be used to switch over a > set of method handles given an index, with a fallback in case the index is > out of bounds, much like the `tableswitch` bytecode. Here is a description of > how

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 03:03:33 GMT, David Holmes wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/share/memory/heap.hpp line 174: > >> 172: bool contain

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 08:29:21 GMT, Aleksey Shipilev wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/cpu/x86/globalDefinitions_x86.hpp line 73: > >> 71:

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

- Mail original - > De: "John Rose" > À: "Remi Forax" > Cc: "Jorn Vernee" , "core-libs-dev" > > Envoyé: Vendredi 9 Avril 2021 20:01:18 > Objet: Re: RFR: 8263087: Add a MethodHandle combinator that switches over a > set of MethodHandles Hi John, > On Apr 9, 2021, at 9:55 AM, Remi Fora

Integrated: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase

On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. It is not actually related to > "parenthesized", but period-comma sequence was regarded as a break on a > backward traverse. This pull request has now been integrated. Changeset: 9ebc497b Author:

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On Apr 9, 2021, at 9:55 AM, Remi Forax wrote: > > I think the combinator should be lookupswitch which is more general than > tableswitch with a special case when generating the bytecode to generate a > tableswitch instead of a lookupswitch if the indexes are subsequent. We can get there in the

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 02:44:23 GMT, David Holmes wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove exports from Graal module to jdk.aot > > src/hotspot/cpu/x86/compiledIC_x86.cpp line 134: > >> 132: #ifdef AS

RFR: 8264806: Remove the experimental JIT compiler

As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to Java-based JIT compiler (Graal) from JDK: - `jdk.internal.vm.compiler` — the Graal compiler - `jdk.internal.vm.compiler.management` — Graal's `MBean` - `test/hotspot/jtreg/compiler/graalunit` — Graal's unit tests Remo

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 17:09:58 GMT, Vladimir Kozlov wrote: >> Hi Vladimir, >> >> This looks good to me - I went through all the files. >> >> It was nice to see how nicely compartmentalized the AOT feature was - that >> made checking the changes quite simple. The one exception was the >> fingerpr

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

On 09/04/2021 18:54, Remi Forax wrote: - Mail original - De: "Jorn Vernee" À: "core-libs-dev" Envoyé: Vendredi 9 Avril 2021 12:51:53 Objet: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles This patch adds a `tableSwitch` combinator that can be used

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Fri, 9 Apr 2021 04:32:14 GMT, David Holmes wrote: > Hi Vladimir, > > This looks good to me - I went through all the files. > > It was nice to see how nicely compartmentalized the AOT feature was - that > made checking the changes quite simple. The one exception was the > fingerprinting cod

Re: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16

I'm decorating existing user or framework code. If they have custom behavior, i want to respect that instead of override it. Get Outlook for iOS From: fo...@univ-mlv.fr Sent: Friday, April 9, 2021 6:33:10 PM To: Marcin Grzejszczak Cc: core

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results

On Fri, 9 Apr 2021 16:39:45 GMT, Brian Burkhalter wrote: >> Hello, >> >> here's some background information for those that didn't follow the mailing >> list for the last couple of years. >> >> Some enjoyable properties of the novel algorithm: >> * No intermediate objects are instantiated. >> *

RFR: 8264208: Console charset API

Please review the changes for the subject issue. This has been suggested in a recent discussion thread for the JEP 400 [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. A CSR has also been drafted, and comments are welcome [[2](https://bugs.openjdk.java.net/b

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

- Mail original - > De: "Jorn Vernee" > À: "core-libs-dev" > Envoyé: Vendredi 9 Avril 2021 12:51:53 > Objet: RFR: 8263087: Add a MethodHandle combinator that switches over a set > of MethodHandles > This patch adds a `tableSwitch` combinator that can be used to switch over a > set > of

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results

On Fri, 9 Apr 2021 16:44:18 GMT, Raffaello Giulietti wrote: >> @rgiulietti Please issue the `/csr/` command here [1]. Speaking of which, >> does the CSR [2] need to be updated? >> >> [1] >> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/csr >> [2] https

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results

On Fri, 9 Apr 2021 16:39:45 GMT, Brian Burkhalter wrote: >> Hello, >> >> here's some background information for those that didn't follow the mailing >> list for the last couple of years. >> >> Some enjoyable properties of the novel algorithm: >> * No intermediate objects are instantiated. >> *

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results

On Fri, 9 Apr 2021 16:33:43 GMT, Raffaello Giulietti wrote: >> Forgot to add that other changes in the code are the use of switch >> expressions and the use of instanceof patterns. > > Hello, > > here's some background information for those that didn't follow the mailing > list for the last c

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results

On Thu, 8 Apr 2021 21:20:34 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 15:47:35 GMT, Conor Cleary wrote: >> src/java.naming/share/classes/com/sun/jndi/ldap/LdapPoolManager.java line >> 413: >> >>> 411: return AccessController.doPrivileged( >>> 412: (PrivilegedAction) () -> Long.getLong(propName, >>> defVal).longValue() >

Re: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16

> De: "Marcin Grzejszczak" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Vendredi 9 Avril 2021 17:41:28 > Objet: Re: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16 > That's the thing, I'm not using an agent. We're doing the wrapping at runtime > by > instrumenting spring

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:46:46 GMT, Roger Riggs wrote: >> ### Description >> This fix is part of a previous effort to both cleanup/modernise JNDI code, >> the details of which can be seen in >> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number >> JNDI methods under `java.n

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 14:01:32 GMT, Roger Riggs wrote: >> That is a very neat alternative yes. Approaching the problem like that >> especially improves the readability >> [JdkLDAP.java](https://github.com/openjdk/jdk/pull/3416/files#diff-bf4c67da93cf2b9196508db2d57f7e01bc884f2268f5bfd43a9f01dfd55e

Re: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16

That's the thing, I'm not using an agent. We're doing the wrapping at runtime by instrumenting spring beans. Pobierz aplikację Outlook dla systemu iOS Od: Remi Forax Wysłane: Friday, April 9, 2021 5:18:11 PM Do: Marcin Grzejszczak DW: core

Re: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16

- Mail original - > De: "Marcin Grzejszczak" > À: "core-libs-dev" > Envoyé: Vendredi 9 Avril 2021 16:29:32 > Objet: Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16 > Hi! > > I'm the lead of Spring Cloud Sleuth [1], a project dedicated to working with > distributed trac

Re: RFR: 8261301: StringWriter.flush() is NOOP but documentation does not indicate it

On Thu, 8 Apr 2021 13:46:00 GMT, Roger Riggs wrote: >> The specification of the method `flush()` in the `java.io` classes >> `CharArrayWriter` and `StringWriter` is not explicit about the fact that the >> method has no effect. This request proposes to add to the specification of >> each flush(

Instrumenting Executors - issues in Spring Cloud Sleuth and JDK16

Hi! I'm the lead of Spring Cloud Sleuth [1], a project dedicated to working with distributed tracing. We're propagating the tracing context e.g. through threads. That means that when a user spawns a new thread we need to pass the context from the old thread to the new one. Example - if the user

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:51:30 GMT, Conor Cleary wrote: >> An alternative here would be to use >> sun.security.action.privilegedGetProperty(prop, default). >> The package is already exported from java.base to java.desktop, etc. > > That is a very neat alternative yes. Approaching the problem like t

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:45:03 GMT, Roger Riggs wrote: >> src/java.naming/share/classes/com/sun/jndi/ldap/LdapPoolManager.java line >> 401: >> >>> 399: return AccessController.doPrivileged( >>> 400: (PrivilegedAction) () -> >>> System.getProperty(propName, defVal) >>> 401:

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:15:16 GMT, Conor Cleary wrote: > ### Description > This fix is part of a previous effort to both cleanup/modernise JNDI code, > the details of which can be seen in > [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number > JNDI methods under `java.namin

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:30:27 GMT, Alan Bateman wrote: >> ### Description >> This fix is part of a previous effort to both cleanup/modernise JNDI code, >> the details of which can be seen in >> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number >> JNDI methods under `java.

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

On Fri, 9 Apr 2021 13:15:16 GMT, Conor Cleary wrote: > ### Description > This fix is part of a previous effort to both cleanup/modernise JNDI code, > the details of which can be seen in > [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number > JNDI methods under `java.namin

RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI

### Description This fix is part of a previous effort to both cleanup/modernise JNDI code, the details of which can be seen in [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number JNDI methods under `java.naming` use Anonymous Inner Classes in cases where only a single obje

Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote: > Avoid overflow when calculating the number of pages for large mapped segment > sizes. Looks okay to me. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3378

RFR: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles

This patch adds a `tableSwitch` combinator that can be used to switch over a set of method handles given an index, with a fallback in case the index is out of bounds, much like the `tableswitch` bytecode. The combinator does not support specifying the starting index, so the switch cases always

Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote: > Avoid overflow when calculating the number of pages for large mapped segment > sizes. Note for reviewers on the test. A 3GB file is sufficient to demonstrate the issue in the old code, as follows (with a 4K page size, since the narrowing

RFR: 8264976: Minor numeric bug in AbstractSplittableWithBrineGenerator.makeSplitsSpliterator

SonarCloud reports: Cast one of the operands of this subtraction operation to a "long". Here: Spliterator makeSplitsSpliterator(long index, long fence, SplittableGenerator source) { ... long multiplier = (1 << SALT_SHIFT) - 1; // < here The shift is integer,

RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

Avoid overflow when calculating the number of pages for large mapped segment sizes. - Commit messages: - Test update - Initial changes Changes: https://git.openjdk.java.net/jdk/pull/3378/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3378&range=00 Issue: https://bu

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution