Re: RFR: 8273314: Add tier4 test groups [v3]

2021-09-06 Thread David Holmes
On 7/09/2021 2:20 pm, Igor Ignatyev wrote: On Mon, 6 Sep 2021 13:22:03 GMT, Aleksey Shipilev wrote: During the review of JDK-8272914 that added hotspot:tier{2,3} groups, @iignatev suggested to create tier4 groups that capture all tests not in tiers{1,2,3}. I have excluded `vmTestbase` and

Re: RFR: 8273314: Add tier4 test groups [v3]

2021-09-06 Thread Igor Ignatyev
On Mon, 6 Sep 2021 13:22:03 GMT, Aleksey Shipilev wrote: >> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, >> @iignatev suggested to create tier4 groups that capture all tests not in >> tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they >> take

Re: RFR: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

2021-09-06 Thread Jovan Stevanovic
On Wed, 1 Sep 2021 13:28:34 GMT, Jovan Stevanovic wrote: > GraalVM Native Image supports loading classes at runtime if they are known > during image build (class predefinition). This is achieved by the JVMTI agent > that registers dynamically generated classes in a regular HotSpot run. The >

RFR: 8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

2021-09-06 Thread Jovan Stevanovic
GraalVM Native Image supports loading classes at runtime if they are known during image build (class predefinition). This is achieved by the JVMTI agent that registers dynamically generated classes in a regular HotSpot run. The Native Image build uses these registered classes to embed them into

RFR: 8273401: Remove JarIndex support in URLClassPath

2021-09-06 Thread wxiang
There is a bug for URLClassPath.findResources with JarIndex. With some discussions about the bug, the current priority is to remove the JAR index support in URLClassPath, and don’t need to do anything to the jar tool in the short term, except just to move JarIndex to the jdk.jartool module.

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-06 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v7]

2021-09-06 Thread Nick Gasson
On Mon, 30 Aug 2021 06:26:01 GMT, Wang Huang wrote: >> Dear all, >> Can you do me a favor to review this patch. This patch use `ldp` to >> implement String.compareTo. >> >> * We add a JMH test case >> * Here is the result of this test case >> >> Benchmark

Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array [v2]

2021-09-06 Thread Claes Redestad
On Mon, 6 Sep 2021 06:45:07 GMT, q2q-2q2 wrote: >> Shortcut String equality checks by checking equality of the value array > > q2q-2q2 has updated the pull request incrementally with one additional commit > since the last revision: > > JDK-8272192 Shortcut String equality checks by checking

Re: RFR: 8273314: Add tier4 test groups

2021-09-06 Thread David Holmes
On 7/09/2021 1:17 am, Aleksey Shipilev wrote: @dholmes-ora: Generally speaking, all `tierX` definitions are rather arbitrary, as there seem to be nothing intrinsic about the tests to be in a particular tier. In other words, what `tierX` consists of is a matter of agreement. I'd say

Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array [v2]

2021-09-06 Thread David Holmes
On Mon, 6 Sep 2021 06:45:07 GMT, q2q-2q2 wrote: >> Shortcut String equality checks by checking equality of the value array > > q2q-2q2 has updated the pull request incrementally with one additional commit > since the last revision: > > JDK-8272192 Shortcut String equality checks by checking

Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array [v2]

2021-09-06 Thread David Holmes
On Mon, 6 Sep 2021 06:41:38 GMT, q2q-2q2 wrote: >> src/java.base/share/classes/java/lang/String.java line 1964: >> >>> 1962: public boolean equalsIgnoreCase(String anotherString) { >>> 1963: if (anotherString != null) { >>> 1964: return false; >> >> This one is

Re: better random numbers

2021-09-06 Thread John Rose
On Sep 5, 2021, at 3:23 PM, John Rose mailto:john.r.r...@oracle.com>> wrote: To increase throughput use vectors or generate more than one random sample per crank turn. But back to back aes steps are probably always twice the latency of a single wide multiply. So I think there might be some

Re: RFR: 8273314: Add tier4 test groups

2021-09-06 Thread Sergey Bylokhov
On Sat, 4 Sep 2021 02:51:50 GMT, Sergey Bylokhov wrote: >> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, >> @iignatev suggested to create tier4 groups that capture all tests not in >> tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they >> take

Re: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

2021-09-06 Thread Sergey Bylokhov
On Mon, 6 Sep 2021 09:39:58 GMT, Alan Bateman wrote: > As I see it, this is just one piece of the overall cleanup and I assume there > are more substantive changes to the java.desktop module coming, is that right? Yes, you are right. - PR:

Re: RFR: 8273314: Add tier4 test groups

2021-09-06 Thread Aleksey Shipilev
On Sat, 4 Sep 2021 03:13:58 GMT, Igor Ignatyev wrote: >>> > <...> I have excluded `vmTestbase` and `hotspot:tier4`<...> I have also >>> > excluded `applications` from `hotspot:tier4` <...> >>> >>> assuming the goal of tier4 is to catch the rest of the tests, I don't think >>> we should

Re: RFR: 8273314: Add tier4 test groups [v3]

2021-09-06 Thread Aleksey Shipilev
> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, > @iignatev suggested to create tier4 groups that capture all tests not in > tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they > take 10+ hours on my highly parallel machine. I have also excluded

Re: RFR: 8273314: Add tier4 test groups [v2]

2021-09-06 Thread Aleksey Shipilev
> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, > @iignatev suggested to create tier4 groups that capture all tests not in > tiers{1,2,3}. I have excluded `vmTestbase` and `hotspot:tier4,` because they > take 10+ hours on my highly parallel machine. I have also excluded

Re: RFR: 8255878: FilterInputStream is missing implementations of Java 9 InputStream methods [v2]

2021-09-06 Thread Alan Bateman
On Mon, 6 Sep 2021 09:41:54 GMT, Daniel Fuchs wrote: > readAllBytes/readNBytes no longer call any variant of `this.read` - so any > subclass that implement the two `read` methods to do something more than what > `in.read` does might fail in unexpected ways if `readAllBytes` or > `readNBytes`

Re: RFR: 8255878: FilterInputStream is missing implementations of Java 9 InputStream methods [v2]

2021-09-06 Thread Daniel Fuchs
On Sat, 4 Sep 2021 07:02:32 GMT, Alan Bateman wrote: > Can you explain this a bit further? InputStream has one abstract method so > that's the minimum that has to be implemented. It has base implementations of > readAllBytes and readNBytes that would be very inefficient if the 3-arg read > is

Re: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

2021-09-06 Thread Alan Bateman
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > The "java.util.logging.LogManager" class uses the "threadgroup sandboxing" > via an AppContext to support "applet logging isolation". The AppContext class > became useless since the plugin and webstart are no longer supported and >

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v12]

2021-09-06 Thread Lin Zang
> 4890732: GZIPOutputStream doesn't support optional GZIP fields Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - Merge branch 'master' into gzip-field - delete trailing spaces - refine code - Merge branch

Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

2021-09-06 Thread Andrey Turbanov
Hello. I found suspicious condition in the method java.util.regex.Grapheme#isExcludedSpacingMark It's detected by IntelliJ IDEA inspection 'Condition is covered by further condition' https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/regex/Grapheme.java#L157 ```

Re: RFR: JDK-8272192 Shortcut String equality checks by checking equality of the value array [v2]

2021-09-06 Thread q2q-2q2
> Shortcut String equality checks by checking equality of the value array q2q-2q2 has updated the pull request incrementally with one additional commit since the last revision: JDK-8272192 Shortcut String equality checks by checking equality of the value array - Changes: -