On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
This pull req
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
Joe Wang has updated the pull request incrementally with one addit
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
Clarifies the supported types for the evaluateExpression methods.
Other changes were javadoc tag usages, e.g. s/the code tag/{@code
-
Commit messages:
- 8266559:
On Fri, 23 Apr 2021 00:41:17 GMT, Joe Wang wrote:
> Update module summary, add a few existing properties and features into the
> tables.
This pull request has now been integrated.
Changeset: 8c4719a5
Author: Joe Wang
URL:
https://git.openjdk.java.net/jdk/
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it
> offends some code analysis tools.
> Although the fix is to change the condition error, it turned out that
> `JapaneseImperialCalendar.roll()` did not work for
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Consolidated impl specific properties; deprecated legacy properties; made new
ones take pref
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contai
On Tue, 18 May 2021 23:35:12 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleTest.java line 683:
>>
>>> 681: * @bug 4052404 4778440 8263202
>>> 682: */
>>> 683: public void TestChangedISO639Codes() {
>>
>> Could probably be simplified with a DataProvider.
>
> That would
On Tue, 18 May 2021 23:39:37 GMT, Naoto Sato wrote:
>> Please review the changes to the subject issue. java.util.Locale class has a
>> long-standing issue for those obsolete ISO 639 languages where its
>> normalization ends up in the obsolete codes. This change intends to flip the
>>
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote:
> Please review this fix for a typo in the copyright header in HashTest which
> the jdk-tier1 does not catch
>
> Best
> Lance
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4034
On Wed, 12 May 2021 16:28:54 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3998
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Thanks Roger. Changed to fully qualified names. Also made them align left
instead of
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Add legacy property names table
-
Changes:
- all: https://git.openjdk.java.n
On Thu, 6 May 2021 00:17:40 GMT, Joe Wang wrote:
> Update BCEL to the latest version (6.5.0). The majority of the changes were
> code refactoring (name format changes).
>
> XML tests passed on both Linux and Windows.
This pull request has now been integrated.
Changeset: 1a0
> Update BCEL to the latest version (6.5.0). The majority of the changes were
> code refactoring (name format changes).
>
> XML tests passed on both Linux and Windows.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
up
On Mon, 10 May 2021 23:12:04 GMT, Naoto Sato wrote:
> Please review this test case fix for the upcoming jtreg 6. The test was using
> `@BeforeGroups` annotation, and the behavior of it has changed in TestNG 7.1
> so that it is only issued when the test was configured with filtering.
> Changed
Update BCEL to the latest version (6.5.0). The majority of the changes were
code refactoring (name format changes).
XML tests passed on both Linux and Windows.
-
Commit messages:
- 8255035: Update BCEL to Version 6.5.0
Changes: https://git.openjdk.java.net/jdk/pull/3893/files
On Wed, 5 May 2021 19:10:21 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which updates
> test/jdk/java/lang/ProcessHandle/PermissionTest.java &
> test/jdk/java/sql/testng/util/TestPolicy.java to include :
>
> `new PropertyPermission("testng.memory.friendly", "read");
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Thu, 29 Apr 2021 13:39:58 GMT, Roger Riggs wrote:
>> Thanks, Joe and Iris. I agree with Iris and that's the reason I chose the
>> description. System properties are inherently mutable. There are some
>> "protected" ones, by that I mean a private copy is made just after
>> initialization
On Wed, 28 Apr 2021 22:24:31 GMT, Naoto Sato wrote:
> After some internal discussion, we thought it was good to expose the native
> environment's default character encoding, which Charset.defaultCharset() is
> currently based on. This way applications will have a better migration path
> after
On Wed, 28 Apr 2021 17:32:04 GMT, Roger Riggs wrote:
>> Good question. Given that the earlier changes in the whole set
>> (impl-specific properties) were backported, I assumed this would too, to be
>> complete. Code consistency and clean backport may exceed the benefit of a
>> more advanced
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
replace isAssignableFrom with instanceof
-
Changes:
- all:
On Wed, 28 Apr 2021 16:21:00 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the CSR. See Update 03 in the CSR
>
> src/java.xml/share/classes/com/sun/o
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Update the CSR. See Update 03 in the CSR
-
Changes:
- all:
Update module summary, add a few existing properties and features into the
tables.
-
Commit messages:
- 8265248: Implementation Specific Properties: change prefix, plus add
existing properties
Changes: https://git.openjdk.java.net/jdk/pull/3644/files
Webrev:
On Fri, 16 Apr 2021 21:10:42 GMT, Naoto Sato wrote:
> Please review the fix to the tier4 build failure. The piece of code that made
> into `CLDRLocaleProviderAdapter.java` was also needed in the build tool
> counterpart (`CLDRConverter`).
Marked as reviewed by joehw (Reviewer).
-
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
>
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Tue, 13 Apr 2021 18:24:55 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/System.java line 2020:
>>
>>> 2018: setIn0(new BufferedInputStream(fdIn));
>>> 2019: setOut0(newPrintStream(fdOut, cs));
>>> 2020: setErr0(newPrintStream(fdErr, cs));
>>
>> It
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Fri, 9 Apr 2021 21:02:26 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 404:
>>
>>> 402: *
>>> 403: * @return A {@code Charset} object used in this {@code Console}.
>>> 404: * @since 17
>>
>> A couple of minor comments:
>> May replace {@code
On Fri, 9 Apr 2021 21:06:00 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Fri, 9 Apr 2021 16:47:55 GMT, Naoto Sato wrote:
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted,
On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. It is not actually related to
> "parenthesized", but period-comma sequence was regarded as a break on a
> backward traverse.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Tue, 6 Apr 2021 16:53:03 GMT, Mahendra Chhipa
wrote:
>> JDK-8264454 : Jaxp unit test from open jdk needs to be improved
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Updated copyright year.
Marked as reviewed by
On Tue, 30 Mar 2021 16:56:57 GMT, Mahendra Chhipa
wrote:
> JDK-8264454 : Jaxp unit test from open jdk needs to be improved
Ok, this is enough of improvement for now. I created a bug to keep track of the
ISE case.
-
PR: https://git.openjdk.java.net/jdk/pull/3274
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. Thanks to the contribution by
> Chris Johnson.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3300
On Tue, 30 Mar 2021 16:56:57 GMT, Mahendra Chhipa
wrote:
> JDK-8264454 : Jaxp unit test from open jdk needs to be improved
test/jaxp/javax/xml/jaxp/unittest/common/Bug6350682.java line 47:
> 45: @Test
> 46: public void testSAXParserFactory() {
> 47: runWithAllPerm(() ->
>
On Tue, 23 Mar 2021 07:24:47 GMT, Alan Bateman wrote:
>> Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019
>
> The JDK's copy of the xalan and xerces code has diverged significantly from
> upstream so maybe this change is okay, Joe Wang can say.
Hi Alex, tha
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote:
> Consolidate and move javadoc for the lookup mechanism to the module summary.
This pull request has now been integrated.
Changeset: 289d48ae
Author: Joe Wang
URL: https://git.openjdk.java.net/jdk/commit/289d48ae
Stats: 602 li
On Fri, 19 Mar 2021 21:23:03 GMT, Naoto Sato wrote:
>> Fixed several broken links to Unicode.org.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments.
Looks all good. Thanks Naoto.
-
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Some minor comments.
src/java.base/share/classes/java/text/Collator.java line 211:
> 209: * FULL_DECOMPOSITION corresponds to Normalization Form KD as
> 210: * described in
> 211: *
On Tue, 16 Mar 2021 16:59:47 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos: s/XMLEventFactory/XMLInputFactory
>> s/XMLEventFactory/XMLOutputFactory
>
>
> Consolidate and move javadoc for the lookup mechanism to the module summary.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Fix typos: s/XMLEventFactory/XMLInputFactory
s/XMLEventFactory/XMLOutputFactory
-
Chan
Consolidate and move javadoc for the lookup mechanism to the module summary.
-
Commit messages:
- 8261673: Move javadoc for the lookup mechanism to module-info
Changes: https://git.openjdk.java.net/jdk/pull/3020/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3020=00
On Thu, 25 Feb 2021 22:04:41 GMT, Joe Wang wrote:
> Add the documentation for XML processing limits to module summary. The limits
> were previously documented in Java tutorial and guide.
This pull request has now been integrated.
Changeset: 6635d7a5
Author: Joe Wang
URL:
On Tue, 2 Mar 2021 00:19:22 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change the description of the property table to indicate that the list of
>> the propertie
> Add the documentation for XML processing limits to module summary. The limits
> were previously documented in Java tutorial and guide.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Change the description of the property
> Add the documentation for XML processing limits to module summary. The limits
> were previously documented in Java tutorial and guide.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
s/NumericFormatException/NumberFormatExc
> Add the documentation for XML processing limits to module summary. The limits
> were previously documented in Java tutorial and guide.
Joe Wang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains two commits:
- Merge branch '
On Thu, 25 Feb 2021 22:33:02 GMT, Naoto Sato wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> src/java.xml/share/classes/module-info.java line 233:
>
>> 231: * If the value is not an integer,
On Thu, 25 Feb 2021 22:28:43 GMT, Naoto Sato wrote:
>> Add the documentation for XML processing limits to module summary. The
>> limits were previously documented in Java tutorial and guide.
>
> src/java.xml/share/classes/module-info.java line 231:
>
>> 229: *
>> 230: * A positive integer.
Add the documentation for XML processing limits to module summary. The limits
were previously documented in Java tutorial and guide.
-
Commit messages:
- 8261670: Add javadoc for the XML processing limits
Changes: https://git.openjdk.java.net/jdk/pull/2732/files
Webrev:
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote:
> Please review the fix to this test case failure that occurs with the usage
> tracker enabled JRE.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2683
On Fri, 19 Feb 2021 22:12:35 GMT, Joe Wang wrote:
> A quick fix to the test, removing Windows carriage return in the result.
This pull request has now been integrated.
Changeset: 47559584
Author: Joe Wang
URL: https://git.openjdk.java.net/jdk/commit/47559584
Stats: 3 lines i
A quick fix to the test, removing Windows carriage return in the result.
-
Commit messages:
- 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java
fails after JDK-8260858
Changes: https://git.openjdk.java.net/jdk/pull/2656/files
Webrev:
On Fri, 19 Feb 2021 16:52:12 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2650
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang wrote:
> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were
> the two tests marked with bug id 8260858 and related data and methods.
This pull req
On Sun, 14 Feb 2021 21:27:49 GMT, Naoto Sato wrote:
>> Adds a property similar to 'isStandalone' in JDK-8249867.
>>
>> Please note that the test received an auto-format. The material changes were
>> the two tests marked with bug id 8260858 and related data and methods.
>
>
Adds a property similar to 'isStandalone' in JDK-8249867.
Please note that the test received an auto-format. The material changes were
the two tests marked with bug id 8260858 and related data and methods.
-
Commit messages:
- JDK-8260858: Implementation specific property
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Sat, 6 Feb 2021 00:38:15 GMT, Joe Wang wrote:
> A quick fix to remove isStandalone's dependency on pretty-print.
This pull request has now been integrated.
Changeset: 7c565f8b
Author: Joe Wang
URL: https://git.openjdk.java.net/jdk/commit/7c565f8b
Stats: 36 lines in 3 fi
On Mon, 8 Feb 2021 21:42:36 GMT, Naoto Sato wrote:
> Please review this simple test case fix. By sampling locales to test, it
> reduces the possibility of the time out.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2465
On Tue, 9 Feb 2021 00:04:44 GMT, Naoto Sato wrote:
>> The fix looks ok to me. Just an interesting note that this test took such a
>> long time to run. Given the amount of locales, limit(30) would reduce the
>> time to approximately 1/5 of the time, that would still be about 100,000ms
>>
On Mon, 8 Feb 2021 21:52:45 GMT, Lance Andersen wrote:
>> Please review this simple test case fix. By sampling locales to test, it
>> reduces the possibility of the time out.
>
> Marked as reviewed by lancea (Reviewer).
The fix looks ok to me. Just an interesting note that this test took such
A quick fix to remove isStandalone's dependency on pretty-print.
-
Commit messages:
- 8261209: isStandalone property: remove dependency on pretty-print
Changes: https://git.openjdk.java.net/jdk/pull/2442/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2442=00
Issue:
On Thu, 4 Feb 2021 22:17:12 GMT, Naoto Sato wrote:
> Please review this fix. The bug was revealed while porting CLDR v39 into the
> JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
> regression tests started failing with it because COMPAT provider's "nb"
> resource was
On Tue, 12 Jan 2021 01:24:38 GMT, Joe Wang wrote:
> Please review a patch to add an explicit control over whether a newline
> should be added after the XML header. This is done by adding a DOM
> LSSerializer property "jdk-is-standalone" and System property
>
On Fri, 29 Jan 2021 18:40:55 GMT, Lance Andersen wrote:
>> src/java.xml/share/classes/module-info.java line 78:
>>
>>> 76: * System Properties
>>> 77: * A property may have a corresponding System Property that has the
>>> same name
>>> 78: * except the prefix as shown above. A System
On Fri, 29 Jan 2021 17:57:14 GMT, Daniel Fuchs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated the patch based on review comments. Refer to the previous reviews.
>
> src/java.xml/
ddresses an incompatibility introduced during 7u4 as an update
> to Xalan 2.7.1.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update javadoc
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2041/files
- new: h
ddresses an incompatibility introduced during 7u4 as an update
> to Xalan 2.7.1.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Updated the patch based on review comments. Refer to the previous reviews.
-
Changes:
- all: h
On Wed, 27 Jan 2021 15:41:02 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update: add javadoc for impl specific features and properties in
>> module-info; update
On Wed, 27 Jan 2021 15:34:26 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update: add javadoc for impl specific features and properties in
>> module-info; update
On Wed, 27 Jan 2021 11:39:29 GMT, Lance Andersen wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update: add javadoc for impl specific features and properties in
>> module-info; update
ddresses an incompatibility introduced during 7u4 as an update
> to Xalan 2.7.1.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Update: add javadoc for impl specific features and properties in module-info;
update the patch accordingly
On Tue, 12 Jan 2021 23:56:12 GMT, Naoto Sato wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
On Tue, 12 Jan 2021 21:25:54 GMT, Roger Riggs wrote:
>> Please review a patch to add an explicit control over whether a newline
>> should be added after the XML header. This is done by adding a DOM
>> LSSerializer property "jdk-is-standalone" and System property
>> "jdk.xml.isStandalone".
>>
Please review a patch to add an explicit control over whether a newline should
be added after the XML header. This is done by adding a DOM LSSerializer
property "jdk-is-standalone" and System property "jdk.xml.isStandalone".
This change addresses an incompatibility introduced during 7u4 as an
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2028
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Oops, forgot to submit the review ;-)
src/java.base/share/classes/java/text/Normalizer.java line 48:
> 46: * The {@code normalize} method supports the standard normalization forms
> 47: * described in
>
On Tue, 5 Jan 2021 17:59:01 GMT, Naoto Sato wrote:
> Please review this copyright notice update in the CLDR Converter tool. It is
> now synched with src/java.base/share/legal/cldr.md file.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/85
On Tue, 15 Dec 2020 01:36:27 GMT, Brent Christian wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java
>> line 152:
>>
>>> 150: *
>>> 151: * Care must be taken when defining such a filter, as defining
>>> 152: * an accept-list too
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote:
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
>
On Fri, 11 Dec 2020 01:28:59 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleProvidersRun.java line 177:
>>
>>> 175:
>>> 176: //testing 8257964 fix. (macOS/Windows only)
>>> 177: testRun("HOST", "bug8257964Test", "", "", "");
>>
>> This test runs only if the platform
On Fri, 11 Dec 2020 01:25:48 GMT, Naoto Sato wrote:
>> src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
>> line 78:
>>
>>> 76: // CalendarData value types
>>> 77: private static final int CD_FIRSTDAYOFWEEK = 0;
>>> 78: private static final
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Looks good to me. Some minor comments below.
On Thu, 10 Dec 2020 01:06:16 GMT, Michael Edgar
wrote:
>> Looks good! Some minor comments below.
>
> @JoeWang-Java - thanks for the additional feedback - all good. Do you suggest
> I make them now in this PR? Just confirming before pushing the change and
> dismissing your approval.
Yes,
On Wed, 9 Dec 2020 11:49:51 GMT, Michael Edgar
wrote:
>> Allow `XMLStreamException` to be thrown to the application when a filtered
>> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
>> `XMLStreamReader`.
>>
>> Note, this PR includes a method signature change
On Tue, 8 Dec 2020 19:10:37 GMT, Joe Wang wrote:
>> Marius Volkhart has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fixup! Fix: javax.xml.stream.XMLEventReader produces incorrect
>> START_D
On Tue, 8 Dec 2020 16:25:25 GMT, Marius Volkhart
wrote:
>> The default implementation of javax.xml.stream.XMLEventReader produced a
>> StartDocument event that always indicated that the "standalone" attribute
>> was set.
>>
>> The root cause of this was that the
>>
On Wed, 18 Nov 2020 07:18:16 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Update test for jtreg
>> - 8255918: Throw XMLStreamExcep
On Sun, 6 Dec 2020 00:00:24 GMT, Michael Edgar
wrote:
>> Allow `XMLStreamException` to be thrown to the application when a filtered
>> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
>> `XMLStreamReader`.
>>
>> Note, this PR includes a method signature change
On Fri, 4 Dec 2020 00:32:26 GMT, Joe Wang wrote:
>> Marius Volkhart has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Adjust test so it works with jtreg
>> - Fix: javax.xml.
On Sat, 5 Dec 2020 12:02:26 GMT, Marius Volkhart
wrote:
>> The default implementation of javax.xml.stream.XMLEventReader produced a
>> StartDocument event that always indicated that the "standalone" attribute
>> was set.
>>
>> The root cause of this was that the
>>
On Thu, 3 Dec 2020 14:44:05 GMT, Marius Volkhart
wrote:
>> @MariusVolkhart Here is a PR for your branch so the test works with jtreg:
>> https://github.com/MariusVolkhart/jdk/pull/1
>>
>> Fails before the JDK patch and passes after.
>>
>> Run it with:
>> $ rm -rf JTwork JTreport && jtreg
>>
201 - 300 of 897 matches
Mail list logo
