Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

Thinking about this again. Looks like the absolute path is not necessary. Even if there are multiple files using the same name, they will be in different directories, no matter absolute or relative. Suppose the jarPath info is used for debugging purpose mostly like the developer can find out

Re: RFR JDK-8066709 Make some JDK system properties read only

Not a native English speaker, so my feeling might be incorrect. Will someone interpret this as that System.getProperty() will return a cached value? I would say “Although getProperty() always returns the last value set by setProperty() (I assume this is the current behavior), it is not

On 8175846: Provide javadoc descriptions for jdk.policytool and jdk.crypto.ec modules

Hi All I'm looking at this bug and have several questions: 1. jdk.jartool is newly introduced in jdk9 (well, all modules are new) but the main class inside it -- sun.security.tools.policytool.PolicyTool -- is already deprecated. Can I also add @deprecated/@Deprecated to the module-info.java

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

Ping again. > On Dec 22, 2016, at 8:23 AM, Wang Weijun <weijun.w...@oracle.com> wrote: > > Hi Roger > >> On Dec 20, 2016, at 11:49 PM, Roger Riggs <roger.ri...@oracle.com> wrote: >> >> Hi Max, >> >> Comments: >> >> - Is ther

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

be > omitted. OK. I'll use take Xuelei's advice to expand this line to This means "/-" implies "/foo" but not "foo". > > - To make the source version more readable, I would keep each statement on > its own line. OK. Thanks Max > >Note that thi

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

this means "/-" implies "/foo" but not "foo".". Good advice. Thanks Max > > Use the one you like, I'm OK with the either. > > Xuelei > > On 12/21/2016 3:58 PM, Wang Weijun wrote: >> >>> On Dec 22, 2016, at 4:39 AM, Xuelei Fan <

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

ildcard flag is "-", the simple pathname's path > * must be recursively inside the wildcard pathname's path. Yes. But the precise meaning of "recursively inside" is different between the pre-jdk9 and jdk9 behaviors. The @implNote explains more. --Max > > Xuelei &

Re: JDK 9 RFR of JDK-8156595: java/io/pathNames/GeneralWin32.java fail intermittently on windows-x64

> For the failing case, the first time it calls checkNames, the "ans" (the 3rd > arg) is "current working dir" (/path/scratch/1). Is it possible to use ./tmp as "ans"? --Max

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

Ping again. > On Dec 14, 2016, at 1:53 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > An clarification is added to FilePermission::implies: > > * @implNote > > * a simple {@code npath} is recursively inside a wildcard {@code npath} >

RFR 8171340: HttpNegotiateServer/java test should not use system proxy on Mac

Please take a review at http://cr.openjdk.java.net/~weijun/8171340/webrev.00/ All "openConnection()" modified to "openConnection(Proxy.NO_PROXY)". Everything else is whitespace change. Thanks Max

RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

An clarification is added to FilePermission::implies: * @implNote * a simple {@code npath} is recursively inside a wildcard {@code npath} * if and only if {@code simple_npath.relativize(wildcard_npath)} - * is a series of one or more "..". An invalid {@code

Re: RFR 8168979: @implNote for invalid FilePermission

> On Dec 14, 2016, at 10:11 AM, Xuelei Fan <xuelei@oracle.com> wrote: > > On 12/13/2016 5:45 PM, Wang Weijun wrote: >> A major behavior change is that <> now implies an invalid >> permission, I hope this is good to minimize incompatibility. > L

Re: RFR 8168979: @implNote for invalid FilePermission

n if two {@code FilePermission} are created with the same >invalid path, one does *not* imply the other. > > best regards, > > -- daniel > > On 12/12/16 09:01, Wang Weijun wrote: >> Please take a review at >> >> http://cr.openjdk.java.net/~weijun/816

Re: RFR 8168979: @implNote for invalid FilePermission

o {@code FilePermission} > 542 * are created with the same invalid path, one does imply the other. > > should this be: > >Even if two {@code FilePermission} are created with the same >invalid path, one does *not* imply the other. Ah, yes. Thanks Max > > best reg

RFR 8168979: @implNote for invalid FilePermission

Please take a review at http://cr.openjdk.java.net/~weijun/8168979/webrev.00/ This further clarifies what an invalid FilePermission behaves. A major behavior change is that <> now implies an invalid permission, I hope this is good to minimize incompatibility. Thanks Max

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

http://cr.openjdk.java.net/~weijun/8170408/webrev.01 jdk_lang passes on all JPRT platforms. Thanks Max > On Nov 29, 2016, at 9:26 PM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Max, > > On 29/11/16 12:30, Wang Weijun wrote: >> Maybe I should use &g

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

Maybe I should use (p, a) -> p.startsWith(Paths.get("dump/com/example")) && a.isRegularFile()).count(), On Windows it's \. I'll run some test now. Thanks Max > On Nov 29, 2016, at 8:25 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > Li

Re: RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

Like this? (p, a) -> p.toString().startsWith("dump/com/example") && a.isRegularFile()).count(), Thanks Max > On Nov 29, 2016, at 7:22 PM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Max, > > On 29/11/16 06:46, Wang Weijun wr

RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

http://cr.openjdk.java.net/~weijun/8170408/webrev.00/ A lambda inside JDK is dumped, we should not count it in this test. Thanks Max

Re: RFR 8170364: FilePermission path modified during merge

Hi Alan Updated webrev at http://cr.openjdk.java.net/~weijun/8170364/webrev.01 Changes since webrev.00: - a private constructor that can clones 4 fields and modifies 5 others - using lambda - test enhancement Thanks Max

Re: RFR 8170364: FilePermission path modified during merge

> On Nov 27, 2016, at 7:13 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > >> >> On Nov 27, 2016, at 6:12 PM, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> On 26/11/2016 08:54, Wang Weijun wrote: >> >>> Please take a review

Re: RFR 8170364: FilePermission path modified during merge

> On Nov 27, 2016, at 6:12 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 26/11/2016 08:54, Wang Weijun wrote: > >> Please take a review at >> >>http://cr.openjdk.java.net/~weijun/8170364/webrev.00/ >> >> The compatib

RFR 8170364: FilePermission path modified during merge

Please take a review at http://cr.openjdk.java.net/~weijun/8170364/webrev.00/ The compatibility layer introduced in the new FilePermission implementation requires one FilePermission to imply another with either a relative path or an absolute path. This is solved with a private field npath2

Re: RFR 8167646: Better invalid FilePermission

; An additional reviewer would be good too. > > Roger > > > On 10/20/2016 4:51 AM, Wang Weijun wrote: >> Please review the code change at >> >>http://cr.openjdk.java.net/~weijun/8167646/webrev.00/ >> >> A new flag invalid is added so invalid F

RFR 8167646: Better invalid FilePermission

Please review the code change at http://cr.openjdk.java.net/~weijun/8167646/webrev.00/ A new flag invalid is added so invalid FilePermissions (invalid Path) do not equal or imply or is implied by anything else except for itself. Thanks Max

RFR 8168127: FilePermissionCollection merges incorrectly

Please review the code change at http://cr.openjdk.java.net/~weijun/8168127/webrev.00/ Two changes: 1. npath2 is considered in equals and hashCode of FilePermission, so 2 objects with different npath2 can be added to a map and different entries. 2. special name for newPermUsingAltPath and

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/037c095ba0c345edbeaaab52fda913a76c3930c0 My understanding is that if the changeset already has your name as the author then there is no need to add your name again into Contributed-by. --Max > On Oct 17, 2016, at 10:13 AM, Frank Yuan

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

The ObjectInputFilter interface has only one method. Are we expecting more methods to be added later and maybe some people will only be interested in a new method? If yes, I suggest we provide a default implementation of the current method to return ALLOWED. --Max > On Jul 19, 2016, at 10:02

os.name will be "macOS"? (was Re: RFR 9 : 8160370 : System.getProperty("os.version") returns "Unknown" on Mac)

I have an off-topic question: Will os.name be macOS for 10.12? I have several places checking "if (!osname.contains("OS X"))", is there a helper method I can check for this in the future no matter if it's running on pre- or post-10.12? Thanks Max > On Jul 1, 2016, at 2:23 AM, Brent Christian

Get user.dir as a symlink not resolved

I'm on a Mac inside /tmp, which is a symlink to /private/tmp. System.getProperty("user.dir") shows me "/private/tmp". Is there a way to get "/tmp" which is exactly what `pwd` return? I only like "/private/tmp" if I called "cd /private/tmp". Thanks Max

Re: JDK 9 RFR of JDK-8159330: Improve deprecation text for Class.newInstance

Why not just clazz.getConstructor().newInstance()? > + * can be replaced by > + * > + * {@code > + * clazz.getConstructor(new Class[0]).newInstance((Object[])null); > + * }

Re: RFR: regex changes -- sun.security.util.Debug issue

Security-dev, If we can live with "engine=keystore" happily, why not just make the whole string lowercase and search for "permission=java.io.filepermission"? I don't think there are permission types or URL names that are only different in cases. Although file names are case-sensitive in Unix,

Re: RFR: 8154231: Simplify access to System properties from JDK code

This is quite convenient. We not cover the other modules? exports sun.security.action to java.desktop, java.security.jgss, jdk.crypto.pkcs11; Thanks Max > On Apr 20, 2016, at 10:44 PM, Claes Redestad > wrote: > > Hello, > > now that the

Fwd: How do I import a sun.* class in jshell

Does anyone here know the answer? It will be quite useful for me if I am either authoring an internal class or using it when implementing a public API. Thanks Max > Begin forwarded message: > > From: Wang Weijun <weijun.w...@oracle.com> > Subject: How do I import a sun

Re: Code Review Request, 8152237 Support BigInteger.TWO

> On Mar 23, 2016, at 7:23 PM, Xuelei Fan <xuelei@oracle.com> wrote: > > On 3/23/2016 5:44 PM, Wang Weijun wrote: >> Then why not fix the 2 bugs in a single changeset? >> > Both need spec update approval. As they are completely different spec > update, b

Re: Code Review Request, 8152237 Support BigInteger.TWO

Then why not fix the 2 bugs in a single changeset? --Max > 在 2016年3月23日，17:06，Xuelei Fan <xuelei@oracle.com> 写道： > >> On 3/23/2016 3:34 PM, Wang Weijun wrote: >> >>> On Mar 23, 2016, at 12:48 PM, Xuelei Fan <xuelei@oracle.com> wrote: >>&g

Re: Code Review Request, 8152237 Support BigInteger.TWO

> On Mar 23, 2016, at 12:48 PM, Xuelei Fan <xuelei@oracle.com> wrote: > > On 3/23/2016 12:10 PM, Wang Weijun wrote: >> Only 3 files touched. Are you going to make the >> s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another >> b

Re: Code Review Request, 8152237 Support BigInteger.TWO

Only 3 files touched. Are you going to make the s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with another bug fix? Thanks Max > On Mar 23, 2016, at 11:26 AM, Xuelei Fan wrote: > > Hi, > > Please review the update for the supporting of BigInteger.TWO:

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

Shouldn't you also include the FileOuputStream in try-with-resources? --Max > On Jan 28, 2016, at 5:32 PM, Chris Hegarty wrote: > > > On 28 Jan 2016, at 00:35, Steve Drach wrote: > >> Please review a small change to the zipfs test library.

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

> On Jan 14, 2016, at 11:00 PM, Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com> wrote: > > On 2015-12-18 15:11, Wang Weijun wrote: >> Hi Vinnie >> >> I take a look and it includes a change for >> src/jdk.crypto.mscap

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

I am OK with the change for krb5 in both src and test. Thanks Max > On Jan 4, 2016, at 10:02 PM, Chris Hegarty wrote: > > sun.misc.VM provides a low-level interface for a small number > of specific operations with the VM. In preparation for JEP 260, > this class

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the java side. Is the function useless now?

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

> On Dec 2, 2015, at 11:26 PM, Chris Hegarty <chris.hega...@oracle.com> wrote: > > Thanks Max, > > I'm ok with this version, if you are. I'll include it in the final push. Please. --Max > > -Chris. > > On 02/12/15 15:13, Wang Weijun wrote: >> >&

Re: RFR [9] 8144480: Remove test dependencies on sun.misc.BASE64Encoder and BASE64Decoder

> On Dec 2, 2015, at 10:52 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > My fault to use an internal class. I should have simply used the hex > encoding. Please wait a while and I'll send you a fix. > > Thanks > Max

Re: RFR 8142927: Feed some text to STDIN in ProcessTools.executeProcess()

http://cr.openjdk.java.net/~weijun/8142927/webrev.01/ > Please also document that the exit status of the process is ignored. It is not really ignored. Process remembers it and OutputAnalyzer can retrieve it later. Thanks Max > > Roger > > > On 11/13/15 3:21 AM, Wang Weijun wr

Re: RFR 8143015/9: 5 tests fail with error "Can't find source for class: java.util.stream.OpTestCase"

Hi Felix The fix looks fine. Do you want me pushing the changeset? If yes, please tell me what the full comment should be. Thanks Max > On Nov 16, 2015, at 11:44 AM, Felix Yang wrote: > > Hi, >please review the following fix for 5 broken test cases, which was >

RFR 8142927: Feed some text to STDIN in ProcessTools.executeProcess()

Hi All 8142927: Feed some text to STDIN in ProcessTools.executeProcess() http://cr.openjdk.java.net/~weijun/8142927/webrev.00/ With this change, you can call ProcessTools.executeProcess(new ProcessBuilder("keytool -printcert", certInAscii) which means "echo $certInAscii | keytool

RFR 8142926: OutputAnalyzer's shouldXXX() calls return this

Hi All 8142926: OutputAnalyzer's shouldXXX() calls return this http://cr.openjdk.java.net/~weijun/8142926/webrev.00/ With this change, you can write output.shouldA().shouldB().shouldC(). Do I need to write a test for testlibrary? Thanks Max

Re: dlsym(RTLD_DEFAULT, "getentropy") return non-NULL on Mac

> On Nov 8, 2015, at 7:18 PM, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Wang Weijun, > >> The function is rather new in the latest Solaris beta [1] and it's >> preferred to reading from /dev/random. There are already people >> sugg

Re: dlsym(RTLD_DEFAULT, "getentropy") return non-NULL on Mac

> On Nov 8, 2015, at 4:29 AM, Dmitry Samersoff <dmitry.samers...@oracle.com> > wrote: > > Wang Weijun, > > 1. RTLD_DEFAUL call is expensive and dangerous because it cause symbol > search across all loaded images. So it can pick up something absolutely > irreleva

dlsym(RTLD_DEFAULT, "getentropy") return non-NULL on Mac

I find something strange. Background: a new method getentropy() is available on OpenBSD [1] and Solaris and people are also proposing it on other OSes. Therefore inside JDK I write a piece of native code to detect it, something like typedef int (*GETENTROPY_FN)(char* buffer, int len);

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

Curious that you added a new method called jarFile.getRuntimeVersionedEntry(entryName). Is this the *only* method you would call for a multi-release jar? If so, is it still necessary to modify the old getEntry() method? Thanks Max > On Nov 4, 2015, at 1:11 AM, Steve Drach

Re: Optional used as method argument?

> 在 2015年10月2日，下午8:49，Roger Riggs 写道： > > +1 > > The "no such value" makes me curious about the context. > The @param tag really should be saying something about the parameter. In fact, I'm working on a method which is similar to /* * Generates some random bytes.

Re: Optional used as method argument?

> 在 2015年10月2日，下午9:51，Sean Mullan <sean.mul...@oracle.com> 写道： > > > > On 10/2/15 9:27 AM, Wang Weijun wrote: >> >>> 在 2015年10月2日，下午8:49，Roger Riggs <roger.ri...@oracle.com> 写道： >>> >>> +1 >>> >>> The "

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> 在 2015年10月1日，下午7:36，Sean Mullan <sean.mul...@oracle.com> 写道： > > > > On 10/1/15 5:10 AM, Wang Weijun wrote: >> >>> 在 2015年10月1日，上午7:53，Steve Drach <steve.dr...@oracle.com> 写道： >>> >>> - JDK 8 jar signer does not work with a JDK

Optional used as method argument?

I hear people saying Optional is usually used as return values. Can I use it as an argument, like this? void consume(Optional value) This way, I don't need to add spec like "@param value can be null if there is no such value". Thanks Max

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> 在 2015年10月2日，上午12:15，Steve Drach 写道： > > I think I’m getting distracted here, not focusing on getting tests created. > Is it okay to move on? Please move on. If you think anything is strange, just send me all related files. One last request about the SSLException,

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> 在 2015年10月1日，上午7:53，Steve Drach 写道： > > - JDK 8 jar signer does not work with a JDK 9 created keystore > - JDK 8 signed jar with JDK 8 created keystore is not the same size as JDK 9 > signed jar with JDK 9 keystore > - JDK 8 signed jar with JDK 8 created keystore is

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> 在 2015年10月1日，上午2:51，Sean Mullan 写道： > >> The jarsigner from jdk9/dev can not, giving me the error >> >> jarsigner: unable to sign jar: javax.net.ssl.SSLException: >> java.lang.RuntimeException: Unexpected error: >> java.security.InvalidAlgorithmParameterException:

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

> 在 2015年10月1日，上午8:21，Steve Drach 写道： > >> Can you add a -debug option to show the full exception stack info? I even >> could not see how SSL is involved here. > > Would you still like me to do this? Yes, please. I cannot reproduce the problem in my jdk9 repo using a

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

Can you describe if there is any effect on signed jars? Including: 1. Will jarsigner be able to sign such a jar? Are all items inside signed? If you sign a jar using jarsigner from different versions of JDK, will there be any difference? 2. Will jarsigner be able to verify such a jar? Will it

A PEM base64 decoder? (was: RFR 8074935: jdk8 keytool doesn't validate pem files for RFC 1421 correctness, as jdk7 did)

Begin forwarded message: Date: March 23, 2015 at 16:33:18 GMT+8 From: Florian Weimer fwei...@redhat.com To: Wang Weijun weijun.w...@oracle.com, OpenJDK Dev list security-...@openjdk.java.net Subject: Re: RFR 8074935: jdk8 keytool doesn't validate pem files for RFC 1421 correctness

Re: A PEM base64 decoder?

In jdk8, we use Base64.getMimeDecoder() to parse PEM-encoded certs and it ignores every character not in the base-64 alphabet. PEM is more restricted and as I know openssl rejects PEM with illegal chars (Ex, ! as in bug report and test). This fix will also reject them. Shouldn't you add

Re: FilePermission Canonical path optimization

On Feb 9, 2015, at 14:42, Peter Levart peter.lev...@gmail.com wrote: Hi Max, Of course you are aware that by trusting the symlinks, you potentially give much more permission than you would hope to. Suppose that some code has permission to read and write into a particular directory (for

Re: FilePermission Canonical path optimization

Max Thanks a lot! 2015-02-09 11:51 GMT+08:00 Wang Weijun weijun.w...@oracle.com: On Feb 9, 2015, at 11:22, deven you ydwch...@gmail.com wrote: Hi Weijun, I see JDK-4141872 marked as Not an Issue, is there any further task continue, or there is any link else to track

Re: FilePermission Canonical path optimization

On Feb 9, 2015, at 11:22, deven you ydwch...@gmail.com wrote: Hi Weijun, I see JDK-4141872 marked as Not an Issue, is there any further task continue, or there is any link else to track this problem to remove the canonical path? It was marked as Not an Issue, but we are reconsidering

Re: FilePermission Canonical path optimization

Hi Deven Sorry for the noise, but in fact we are looking into removing the canonicalization step because of 4141872: FilePermission makes symlinks useless https://bugs.openjdk.java.net/browse/JDK-4141872 This will be a very big incompatible change and we are still doing a feasibility study.

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

JarUtils: You can break after line 83. Otherwise very good. Thanks Max On Jan 26, 2015, at 15:55, Artem Smotrakov artem.smotra...@oracle.com wrote: Hi Max, Here is an updated webrev, please take a look. http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/ Artem On 01/26/2015

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

On Jan 22, 2015, at 19:40, Artem Smotrakov artem.smotra...@oracle.com wrote: I am not sure if I understand updateJar correctly. It looks like srcJarFile is opened multiple times so its entries are duplicated a lot in the destination. Or is there a secret break? There is no any secret,

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

Thanks for adding so many tests. Some suggestions: - JarUtils.java You can use the new InputStream.transferTo() method. I am not sure if I understand updateJar correctly. It looks like srcJarFile is opened multiple times so its entries are duplicated a lot in the destination. Or is there a

Re: RFR: 8067951: System.loadLibrary cannot find library when path contains quoted entry

On Dec 23, 2014, at 21:31, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: BUGURL: https://bugs.openjdk.java.net/browse/JDK-8067951 WEBREV: http://cr.openjdk.java.net/~igerasim/8067951/0/webrev/ I am not sure why you want to rewrite the loop entirely. Isn't it OK to just add that long if

Copy a ZipEntry into another zip file

Hi Sherman The jarsigner tool contains these 2 methods to copy a ZipEntry into the signer jar: private void writeEntry(ZipFile zf, ZipOutputStream os, ZipEntry ze) throws IOException { ZipEntry ze2 = new ZipEntry(ze.getName()); ze2.setMethod(ze.getMethod());

Re: Should some JDK system properties be read only ?

A System.setFinalProperty() method that creates a new property with a final value? Maybe also a System.isFinalProperty() method allowing people to detect if a property is final. --Max

Re: FilePermission Canonical path optimization

Do you need some kind of synchronization on the get_dir_rec() method? --Max On Dec 1, 2014, at 16:06, deven you youd...@linux.vnet.ibm.com wrote: Hi All, File.getCanonicalPath() is a very time-consuming method, we observed significant performance degradation from some application's startup

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

I hope we can restrict the code change to what the bug description is about. IMHO this bug should only include cleanup and introduce no obvious behavior change. Any other fix can go to another bug. --Max On Nov 13, 2014, at 08:57, Otávio Gonçalves de Santana otavioj...@java.net wrote:

How to extract matches from (\d+[hms])+ ?

Hi Sherman I want to match a time duration like 1h20m30s and 2h. It looks like if I directly use the pattern ((\\d+)([hms]))+, group(2) and group (3) only return the last match (i.e. 30 and s for 1h20m30s). So I tried multiple matching with (\\d)([hms]) only, but find() does not always match

Re: How to extract matches from (\d+[hms])+ ?

problem caused by the outer + iteration disappear (but you may need to check whether the original string was empty). Yes, this is much better. But maybe that takes all the fun out of it. Let someone else enjoy it then. :-) Thanks Max --Guy Steele On Sep 25, 2014, at 12:51 AM, Wang Weijun

Re: Replace concat String to append in StringBuilder parameters

So it's not that the optimization fails but there is no optimization on them yet. I do see the .append(x) case will be easy to deal with, but it looks like historically javac has not been a place to do many optimizations. It mostly converts the java source to byte codes in a 1-to-1 mapping and

Re: Swing Dev Replace concat String to append in StringBuilder parameters

OK, I'll remember that. So you will include the StringBuilder changes into your fix? --Max On Aug 28, 2014, at 2:10, Ivan Gerasimov ivan.gerasi...@oracle.com wrote: Hi Max! The core part is updated again at http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ Can you please

Re: Swing Dev Replace concat String to append in StringBuilder parameters

string =\n) StringBuilder sb = new StringBuilder(\ + ti.getThreadName() + \ + tagBuffer.append(tr bgcolor=\+ color[selColorIndex] + \); ... Thanks Max On Aug 26, 2014, at 11:28, Wang Weijun weijun.w...@oracle.com wrote: New webrevs available at http://cr.openjdk.java.net/~weijun/8055723

Re: Swing Dev Replace concat String to append in StringBuilder parameters

Webrev updated again, this time include more changes. http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/ The change to a demo file is removed because that file itself is already removed. *Otávio*: I believe Andrej's

Re: Swing Dev Replace concat String to append in StringBuilder parameters

(c) instead of append((int)c). Here c is already an integer and this redundant cast will be treated as an error when -Werror specified. --Max On Aug 27, 2014, at 10:07, Wang Weijun weijun.w...@oracle.com wrote: Webrev updated again, this time include more changes. http://cr.openjdk.java.net

Re: Swing Dev Replace concat String to append in StringBuilder parameters

New webrevs available at http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/ http://cr.openjdk.java.net/~weijun/8055723/core/webrev.01/ There are only 2 now. Everything non-client is in core. Everyone, please do code review quickly because the patch touches too many files and

Re: Swing Dev Replace concat String to append in StringBuilder parameters

New webrevs updated http://cr.openjdk.java.net/~weijun/8055723/core/webrev.00/ Includes modules java.base and security-related modules and the jarsigner tool http://cr.openjdk.java.net/~weijun/8055723/client/webrev.00 Includes the java.desktop module

Re: Trusted service?

On Aug 13, 2014, at 23:31, mark.reinh...@oracle.com wrote: 2014/8/13 7:20 -0700, alan.bate...@oracle.com: The usual thing is to just have a default implementation that is used when ServiceLoader doesn't locate a useful provider. You'll find many examples of this in the JDK. In those cases

Re: Replace concat String to append in StringBuilder parameters

, 2014 at 10:55 PM, Wang Weijun weijun.w...@oracle.com wrote: Hi Otávio I see TABs in the first page of sun_security.diff, too long line in javax_security.diff. Also, it's unfortunate that you will need to rename the file names to the new style with modules. See http://cr.openjdk.java.net

Re: Replace concat String to append in StringBuilder parameters

On Aug 21, 2014, at 21:18, Andrej Golovnin andrej.golov...@gmail.com wrote: https://bugs.openjdk.java.net/browse/JDK-8038277 This is not the right bug report. The subject of this bug report is Improve the bootstrap performance of carets keystore. Oh, my mistake, it should be

Re: Replace concat String to append in StringBuilder parameters

I also see a lot of .toString() and String.valueOf() calls. $ cat string_concat_updated.patch | perl -ne 'print if /^\+ .*append.*(String\.valueOf|\.toString\(\))/' | wc 62 2104626 Wrapped lines not indented correctly in

Re: Replace concat String to append in StringBuilder parameters

Hi Otávio I see TABs in the first page of sun_security.diff, too long line in javax_security.diff. Also, it's unfortunate that you will need to rename the file names to the new style with modules. See http://cr.openjdk.java.net/~chegar/docs/portingScript.html for how to do this. I can create

How to use jvisualvm to find memory leaks?

I am looking at 8054896: Loading a KeyStore prevents GC of Classloader and am now able to reproduce it on my system. I do see the webapp-related classes present in a heapdump created by VisualVM but not sure what the next steps should be to tell why they are not GC'ed. Is there a good tutorial

Re: Trusted service?

On Aug 14, 2014, at 16:03, Alan Bateman alan.bate...@oracle.com wrote: Or writing the class name in a services file automatically exports it as a service? Now my preferred order will be if (loadProviderFromProperty()) return provider; if

Trusted service?

Hi All I'm working on 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine which will separate the implementation of Kerberos-related TLS ciphersuites from the other TLS codes. I am thinking of defining a ServiceLoader interface called ExternalCipherSuiteProvider

Re: Trusted service?

Yes, I see a lot of places using if (loadProviderFromProperty()) return provider; if (loadProviderAsService()) return provider; The 1st using Class.forName() and 2nd ServiceLoader.load(). I was thinking that the 1st method will not work because Class.forName() on an

Re: Swing Dev Replace concat String to append in StringBuilder parameters

No TAB, no \r, and no trailing space are hard requirements enforced by jcheck. Otherwise it's only styles, including 4-space-indentation. { at the end of a line, 8-space wrap indentation... --Max (an Oracle dev) On Aug 12, 2014, at 15:48, Andrej Golovnin andrej.golov...@gmail.com wrote: As

Re: Swing Dev Replace concat String to append in StringBuilder parameters

'\' can be written as '': com_sun.diff:209:+sb.append(' ').append(nodeName).append(=\).append(att.getNodeValue()).append('\'); java_lang.diff:31:+ sb.append('\').append(getThreadName()).append('\') java_security.diff:78:+.append('\');

Re: RFR 8054095: No space allowed in platforms string in ProblemList.txt

The change looks good. So does the closed side. I read jtharness and it seems a line is broken into 3 parts separated by space(s). Either the 2nd or the 3rd part will be used by jtreg as platforms, but not both. I'm not sure if jtharness or jtreg should also be updated. Thanks Max On Aug 1,

Re: JEP 198: Light-Weight JSON API

On Jul 31, 2014, at 8:35, Remi Forax fo...@univ-mlv.fr wrote: On 07/25/2014 04:45 PM, mark.reinh...@oracle.com wrote: New JEP Candidate: http://openjdk.java.net/jeps/198 - Mark Hi Mark, Hi Mike, Implementing a json API was one of the use case I've used during the development of the

Re: please review draft JEP: Convenience Factory Methods for Collections

A .with(k, v) to create a new immutable map with an extra pair. --Max On Jul 18, 2014, at 16:11, Michael Kay m...@saxonica.com wrote: Well, Remi had proposed raising the limit. Suppose we offered 7 key-value pairs instead of 5. Would you then complain about having to rewrite your code if

Different notations for static and instance methods

We should define different notations for static and instance methods. For example, List.of and List::of, although I admit it is quite confusing. --Max On Jul 18, 2014, at 5:56, Stuart Marks stuart.ma...@oracle.com wrote: On 7/17/14 12:46 AM, Tom Hawtin wrote: I note that with the basic

Re: Guidance about binary / data files for JTREG tests

Florian Just curious, how do you deal with a file like this http://hg.openjdk.java.net/jdk9/dev/jdk/file/4e7f3aac979b/test/sun/security/krb5/ktab/HighestKvno.java Is the byte array inside considered binary? Thanks Max On Apr 30, 2014, at 18:54, Florian Weimer fwei...@redhat.com wrote: On

  1   2   >