Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

Looks good! Thanks, /Staffan > On 19 sep. 2016, at 11:17, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ >> 62 lines changed: 56 ins; 2 del; 4 mod; > > Hi all, > > could you please review this small patch which removes usage of jtreg > internal API from fai

Re: RFR : 8132961 : JEP 279 Improve Test-Failure Troubleshooting

Looks good and sorry for the delay. Thanks, /Staffan > On 24 nov. 2015, at 20:13, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8132961/webrev.00/ >> 3579 lines changed: 3579 ins; 0 del; 0 mod; 0 unchg > > Hi, > > Could you please review the webrev[0] for JEP 279[1]? > > The

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

Also remember that that java launcher is not the only launcher used with the JVM. There are lots of apps that use the invocation API to start the JVM, and there is no standardized way to propagate the command line or even the Main-Class to the JVM. This is currently an outage in serviceability t

Re: JDK 9 RFR of JDK-8143583: Several tests don't work with latest jtreg due to non-existing files in @build

Looks good! Thanks, /Staffan > On 23 nov. 2015, at 08:10, Amy Lu wrote: > > Below tests failed with latest nightly jtreg due to non-existing files in > @build > > com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java > sun/tools/jmap/BasicJMapTest.java > com/sun/jdi/DoubleAgentTest.java >

Re: [RFR] (XS) 8141489: [TESTBUG] requiredVersion in TEST.ROOT needs to updated to 4.1 b12

Looks good! Thanks, /Staffan > On 5 nov. 2015, at 03:25, Chris Plummer wrote: > > Please review the following changes: > > http://cr.openjdk.java.net/~cjplummer/8141489/ > https://bugs.openjdk.java.net/browse/JDK-8141489 > > The changes I did for 8140189 require that version 4.1 b12 of jtreg

Re: [RFR] (S) 8140189: [TESTBUG] Get rid of "@library /../../test/lib" in jtreg tests

ew jvmci tests that are >>> using "/../../test/lib". I can fix them with this push, or file a separate >>> bug or send out a fix after I do this push. If I fix with this push, do you >>> want another review? I'll test with jprt and run the jvmci tests lo

Re: [RFR] (S) 8140189: [TESTBUG] Get rid of "@library /../../test/lib" in jtreg tests

Looks good! Thanks for doing this. /Staffan > On 23 okt. 2015, at 07:54, Chris Plummer wrote: > > Hello, > > Please review the following fix for 8140189: > > http://cr.openjdk.java.net/~cjplummer/8140189/webrev.00/webrev.hotspot > http://cr.openjdk.java.net/~cjplummer/8140189/webrev.00/webrev

Re: RFR(M, v14): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

> -Dmitry > > On 2015-06-05 11:20, Staffan Larsen wrote: >> Dmitry, >> >> I’d like to propose the following change to get prettier output (more in >> line with GC.class_histogram): >> >> diff --git a/src/share/vm/services/diagnosticCommand.cpp >

Re: RFR(M, v14): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Dmitry, I’d like to propose the following change to get prettier output (more in line with GC.class_histogram): diff --git a/src/share/vm/services/diagnosticCommand.cpp b/src/share/vm/services/diagnosticCommand.cpp --- a/src/share/vm/services/diagnosticCommand.cpp +++ b/src/share/vm/services/di

Re: JDK 9 RFR of JDK-8081775: two lib/testlibrary tests are failing with "Error. failed to clean up files after test" with jtreg 4.1 b12

Looks good! Thanks, /Staffan > On 3 jun 2015, at 05:31, Amy Lu wrote: > > lib/testlibrary/OutputAnalyzerReportingTest.java > lib/testlibrary/OutputAnalyzerTest.java > > These tests fail with jtreg4.1/b12 because jtreg4.1/b12 adds stricter > checking of @library tags and the library directory

Re: RFR(M, v10): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Dmitry, Instead of hardcoding the field offsets, you can use InstanceKlass::find_field and fieldDescriptor::offset to find the offset at runtime. Thanks, /Staffan > On 31 maj 2015, at 13:43, Dmitry Samersoff > wrote: > > Everyone, > > Please take a look at new version of the fix. > > http

Re: RFR(M, v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

> On 28 maj 2015, at 20:06, Mandy Chung wrote: > > > On 05/28/2015 07:35 AM, Peter Levart wrote: >> Hi Mandy, >> >> On 05/27/2015 03:32 PM, Mandy Chung wrote: >>> Taking it further - is it simpler to return String[] of all classnames >>> including the duplicated ones and have the VM do the co

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

ava.lang.ref.DiagnosticCommands) with >>>>>>>>> static method(s) (printFinalizationQueue)... You could just expose >>>>>>>>> a package-private forEach static method from Finalizer and code the >>>>>>>>> rest in Diagnost

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Dmitry, I think this should be reviewed on hotspot-gc and core-libs-dev as well considering the changes to Finalizer. I’m a little worried about the potentially very large String that is returned from printFinalizationQueue(). A possible different approach would be to write printFinalizationQu

Re: RFR 9: 8077350 Process API Updates Implementation Review

> On 16 apr 2015, at 21:01, Thomas Stüfe wrote: > > Hi Roger, > > thank you for your answer! > > The reason I take an interest is not just theoretical. We (SAP) use our JVM > for our test infrastructure and we had exactly the problem allChildren() is > designed to solve: killing a process tree

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

I would like to backport this bug fix to jdk8 - does anyone see any problems with that? The patch applies cleanly (after shuffling) and the java/lang/invoke/ tests succeed. Thanks, /Staffan

Re: RFR: JDK-8072842 Add support for building native JTReg tests

As far as I can tell (I’m not a makefile expert) this looks good. Thanks, /Staffan > On 25 feb 2015, at 12:21, Magnus Ihse Bursie > wrote: > > On 2015-02-11 13:08, Staffan Larsen wrote: >> >>>>>>>> Okay so if I just cd into hotspot/test and use the M

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

> On 17 feb 2015, at 02:16, John Rose wrote: > > On Feb 16, 2015, at 6:25 AM, Staffan Larsen <mailto:staffan.lar...@oracle.com>> wrote: >> >> new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ >> <http://cr.openjdk.java.net/~sla/8025636/web

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

lling > visitCode so > I think you shoud call visitAnnotation before calling new > ForwardingMethodGenerator(mv).generate(). > > cheers, > Rémi > > On 02/16/2015 08:47 AM, Staffan Larsen wrote: >> Brian pointed out to me that this change missed to add the anno

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

bridges being used. new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.01/ <http://cr.openjdk.java.net/~sla/8025636/webrev.01/> Thanks, /Staffan > On 3 feb 2015, at 10:15, Staffan Larsen wrote: > > Hi, > > Please review this patch for hiding the lambda proxy

Re: RFR: JDK-8072842 Add support for building native JTReg tests

> On 11 feb 2015, at 12:15, David Holmes wrote: > > On 11/02/2015 8:36 PM, Staffan Larsen wrote: >> >>> On 11 feb 2015, at 09:39, David Holmes wrote: >>> >>> On 11/02/2015 6:34 PM, Staffan Larsen wrote: >>>> >>>>> On 1

Re: RFR: JDK-8072842 Add support for building native JTReg tests

> On 11 feb 2015, at 09:39, David Holmes wrote: > > On 11/02/2015 6:34 PM, Staffan Larsen wrote: >> >>> On 11 feb 2015, at 09:27, Magnus Ihse Bursie >>> mailto:magnus.ihse.bur...@oracle.com>> >>> wrote: >>> >>> On 2015-02-11

Re: RFR: JDK-8072842 Add support for building native JTReg tests

> On 11 feb 2015, at 09:27, Magnus Ihse Bursie > wrote: > > On 2015-02-11 09:23, David Holmes wrote: >> On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: >>> On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: > Here is an add

Re: RFR: JDK-8072842 Add support for building native JTReg tests

> On 10 feb 2015, at 15:23, Magnus Ihse Bursie > wrote: > > Here is an addition to the build system, that will compile native libraries > and executables and make them available for JTReg tests written in Java. > > This patch is the result of the work (in serial, most

Re: JEP 102 Process Updates revised API draft

Happy to see this! In ProcessHandle.Info would it be possible to include the environment variables of the process as well? How does ProcessHandle.allChildren() behave when process A launches B which launches C, and B terminates? Is C included in allChildren() of A? Thanks, /Staffan > On 10 fe

Re: RFR - 8072450: 9-dev build failed on elinux-i586 and rlinux-i586

Looks good! Thanks, /Staffan > On 4 feb 2015, at 12:31, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > > 8072450: 9-dev build failed on elinux-i586 and rlinux-i586 > > My fix for JDK-8068730 which was integrated from hs-rt into jdk9-dev > yesterday is causing a build failure

RFR: JDK-8072458 jdk/test/Makefile references (to be removed) win32 directory in jtreg

The platform specific directories in jtreg are going away in favor of a platform-agnostic directory. Small fix below. Thanks, /Staffan diff --git a/test/Makefile b/test/Makefile --- a/test/Makefile +++ b/test/Makefile @@ -267,8 +267,8 @@ EXTRA_JTREG_OPTIONS += -concurrency:$(CONCURRENCY) e

RFR: JDK-8072456 @since tags missing from TimeUnit

The MINUTES, HOURS, and DAYS fields of TimeUnit are missing an "@since 1.6" tag. webrev: http://cr.openjdk.java.net/~sla/8072456/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8072456

RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Hi, Please review this patch for hiding the lambda proxy frame in stack traces: bug: https://bugs.openjdk.java.net/browse/JDK-8025636 webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/

Re: RFR 8068730: Increase the precision of the implementation of java.time.Clock.systemUTC()

> On 13 jan 2015, at 13:26, David Holmes wrote: > > Hi Daniel, > > On 13/01/2015 7:53 PM, Daniel Fuchs wrote: >> On 13/01/15 04:52, David Holmes wrote: Here is the new webrev with Stephen & your feedback included http://cr.openjdk.java.net/~dfuchs/webrev_8068730/webrev.01/

Re: RFR (S) 8059677: Thread.getName() instantiates Strings

SA changes look good. /Staffan > On 11 nov 2014, at 15:40, Aleksey Shipilev > wrote: > > Hi, > > On 11/09/2014 09:45 PM, Aleksey Shipilev wrote: >> Thread.getName() returns String, and does new String instantiation every >> time, because the thread name is stored in char[]. Even though we use

Re: RFR (S) 8059677: Thread.getName() instantiates Strings

ant to complicate your review. Thanks, /Staffan > On 10 nov 2014, at 19:09, Aleksey Shipilev > wrote: > > On 10.11.2014 19:39, Staffan Larsen wrote: >>> On 10 nov 2014, at 15:55, Aleksey Shipilev >>> wrote: >>> Ow, it seems very like it. >

Re: RFR (S) 8059677: Thread.getName() instantiates Strings

about that. /Staffan > > -Aleksey. > > On 11/10/2014 05:51 PM, Staffan Larsen wrote: >> I’m afraid this change requires changes in the Serviceability Agent as well. >> See OopUtilities.threadOopGetName() for example. >> >> /Staffan >> >>> On 10 no

Re: RFR (S) 8059677: Thread.getName() instantiates Strings

I’m afraid this change requires changes in the Serviceability Agent as well. See OopUtilities.threadOopGetName() for example. /Staffan > On 10 nov 2014, at 15:19, Aleksey Shipilev > wrote: > > Hi David, Chris, > > On 11/10/2014 04:53 PM, Chris Hegarty wrote: >> On 10/11/14 12:56, David Holme

Re: Review request: JDK-8043277: Update jdk regression tests to extend the default security policy instead of override

On 24 okt 2014, at 18:16, Mandy Chung wrote: > On 10/24/2014 6:33 AM, Staffan Larsen wrote: > >> Since this is the first use of jtreg 4.1b10 features, this would also be >> good time to tag the jdk test suite to require at least 4.1b10. >> >> This latest ve

Re: Review request: JDK-8043277: Update jdk regression tests to extend the default security policy instead of override

Since this is the first use of jtreg 4.1b10 features, this would also be good time to tag the jdk test suite to require at least 4.1b10. This latest version of jtreg has support for checking which version of jtreg the test suite requires. So you can add a line saying: requiredVersion=4.1 b10

Re: [8u40] RFR: JDK-8058632: Revert JDK-8054984 from 8u40

Looks good! Thanks, /Staffan On 18 sep 2014, at 11:00, Joel Borggrén-Franck wrote: > Hi, > > Can I get a review for this anti-patch for JDK-8054984 (which is a backport > of JDK-8044629 "(reflect) Constructor.getAnnotatedReceiverType() returns > wrong value” to 8u). > > The fix shouldn’t

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

avior isn't changed by running "svc" > regression tests set. There was no related test failures observed. > > Best Regards, > Aleksej > > On 05/15/2014 01:11 PM, Staffan Larsen wrote: >> On 15 maj 2014, at 03:48, David Holmes wrote: >> >>>

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

Looks good! Thanks, /Staffan On 20 maj 2014, at 15:48, Yekaterina Kantserova wrote: > Thanks Staffan! > > New webrev can be found here: > http://cr.openjdk.java.net/~ykantser/8043520/webrev.01/ > > // Katja > > > > On 05/20/2014 03:07 PM, Staffan Larsen

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.java “Dummy” is being built twice. Otherwise good! /Staffan On 20 maj 2014, at 14:24, Yekaterina Kantserova wrote: > Staffan, Alan, > > could you please review the following fix. > > Bug: https://bugs.openjdk.java.net/bro

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

On 15 maj 2014, at 03:48, David Holmes wrote: > On 14/05/2014 11:18 PM, Aleksej Efimov wrote: >> David, Vitaly, >> >> I totally agree with Vitaly's explanation (Vitaly - thank you for that) >> and code in shmemBase.c (the usage of enterMutex() function for >> sending/receiving bytes through sha

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

0/webrev.02/ > > Thanks, > Katja > > > > Original Message > Subject: Re: RFR(S): 8034960: Serviceability tests using @library > failing with java.lang.NoClassDefFoundError > Date: Fri, 9 May 2014 12:48:56 +0200 > From: Staffan Larsen > T

Re: Build failures on solaris

Looks good. Many apologies. /Staffan On 9 maj 2014, at 21:08, Eric McCorkle wrote: > The following patch will fix it: > > diff -r 7426549b1e3b > src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c > --- a/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c > +++ b/src/solaris

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

ve made a new webrev > to be sure the changes fit in in the latest jdk9 source. The webrev can be > found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01. > > Thanks, > Katja > > > > On 03/25/2014 01:14 PM, Staffan Larsen wrote: >> I’ve looked

Re: Urgent: Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

, as we still do not have the JPRT changes in place, > but that was the agreement we have for jdk9: > tightly coupled changes should be pushed through the hotspot repos. > had that been pushed this week there, it would be in jdk9/dev next Tuesday > > > Alejandro > >

Re: Urgent: Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

Thanks Joe - fix has been pushed. (I will now retreat to a dark place and grumble over the impossibility of pushing coordinated changes). /Staffan On 25 apr 2014, at 18:43, Joe Darcy wrote: > Approved! > > -Joe > > On 04/25/2014 09:36 AM, Staffan Larsen wrote: >> Here

Urgent: Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

). Thanks, /Staffan On 25 apr 2014, at 18:24, Staffan Larsen wrote: > It looks like a completely messed this up by not pushing the hotspot parts > first and now I have broken the build in jdk9-dev. > > Should I push an anti-delta of the patch? I can prepare a review of it in

Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

It looks like a completely messed this up by not pushing the hotspot parts first and now I have broken the build in jdk9-dev. Should I push an anti-delta of the patch? I can prepare a review of it in a moment. /Staffan On 25 apr 2014, at 17:16, Staffan Larsen wrote: > Thanks Keith! >

RFR: 8039256 Add sun/jvmstat/monitor/MonitoredVm/CR6672135.java to ProblemList.txt

Please review the change below to add a test to ProblemList.txt. For details, see https://bugs.openjdk.java.net/browse/JDK-8033104 Thanks, /Staffan diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++ b/test/ProblemList.txt @@ -273,4 +273,7 @@ # 8031482 sun

Re: Experimental patches for unsafe cleanup Re: The s.m.Unsafe representation in hotspot and method registration

(Adding hotspot-runtime-dev since some changes are in hotspot code). On 25 mar 2014, at 14:20, Paul Sandoz wrote: > > On Mar 25, 2014, at 9:34 AM, Paul Sandoz wrote: > >> >> On Mar 24, 2014, at 7:49 PM, Staffan Larsen >> wrote: >> >>> We ha

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted. Thanks, /

Re: RFR: 8036786: Update jdk7 testlibrary to match jdk8

I’ve looked at the changes in StreamPumper and ProcessTools: they look good. Since the rest of the code is a straight backport, I didn’t look at it. Reviewed. Thanks, /Staffan On 6 mar 2014, at 16:34, Vladimir Kempik wrote: > Please review this change to update jdk part of testlibrary in jdk7

Re: The s.m.Unsafe representation in hotspot and method registration

We have abandoned the HSX model. From JDK 8 one version of Hotspot will be tied to one version of the JDK. This looks like old code that has not been cleaned up. /Staffan On 24 mar 2014, at 19:13, Peter Levart wrote: > > On 03/24/2014 07:02 PM, Paul Sandoz wrote: >> On Mar 24, 2014, at 6:37

Re: JDK 9 RFR of 8038163: Build failure on Mac OS 10.9.2 (Mavericks) due to warning treated as error

Looks good to me. The version with JNI_TRUE/JNI_FALSE is more correct, but I’m fine with either one. (note: this review request should have been sent to serviceability-dev). Thanks, /Staffan On 21 mar 2014, at 20:41, Brian Burkhalter wrote: > Please review at your convenience: > > Issue:

Re: RFR 9: 8035889: jdk testlibrary - add printing of values of failed assertions

Looks good to me! Thanks, /Staffan On 27 feb 2014, at 16:34, roger riggs wrote: > Hi Mandy, > > I updated the webrev: > http://cr.openjdk.java.net/~rriggs/webrev-testlibrary-asserts-8035889/ > > Alan suggested copying serviceability-dev so they have a chance to review if > desired. > >

Re: RFR 6835233 : Fedora 9 jdk regression test failed: java/lang/instrument/ParallelTransformerLoader.sh

Looks good! Thanks, /Staffan On 26 feb 2014, at 20:34, Brent Christian wrote: > File under "chipping away at test stabilization issues." > > https://bugs.openjdk.java.net/browse/JDK-6835233 > > I've done some repeated runs of this test on my Linux machine. The test > fails every time with 6

Re: RFR: JDK-8033917 Keep track of file paths in file streams and channels for instrumentation purposes

he value. Thanks, /Staffan > > (the same is applicable to other files) > > I'm a bit scared changing signature of public methods of FileChannelImpl > but if Alan says it's OK - lets go with it. > > -Dmitry > > > On 2014-02-07 16:07, Staffan Lar

Re: RFR(S): JDK-8033911 Simplify instrumentation of FileInputStream and RandomAccessFile

Alan, Jaroslav, Dmitry: Thanks! On 7 feb 2014, at 12:38, Jaroslav Bachorik wrote: > Looks good. Additional benefit is the compliance with the secure coding guide. > > -JB- > > On February 7, 2014 11:46:07 AM CET, Staffan Larsen > wrote: > A few of the public read

Re: RFR: JDK-8033917 Keep track of file paths in file streams and channels for instrumentation purposes

Thanks Alan! On 7 feb 2014, at 14:22, Alan Bateman wrote: > On 07/02/2014 12:49, Staffan Larsen wrote: >> >> Updated webrev here: http://cr.openjdk.java.net/~sla/8033917/webrev.01/ >> <http://cr.openjdk.java.net/%7Esla/8033917/webrev.01/> >> > Thanks for the updates, looks good. > > -Alan.

Re: RFR: JDK-8033917 Keep track of file paths in file streams and channels for instrumentation purposes

On 7 feb 2014, at 13:27, Alan Bateman wrote: > On 07/02/2014 12:07, Staffan Larsen wrote: >> Instrumentation agents that want to instrument >> FileInputStream/FileOutputStream to see which files are being accessed do >> not currently have access to the file system path o

RFR: JDK-8033917 Keep track of file paths in file streams and channels for instrumentation purposes

Instrumentation agents that want to instrument FileInputStream/FileOutputStream to see which files are being accessed do not currently have access to the file system path of the stream. This is because the path is never stored in the stream class, only the file descriptor is. (This is also true

Re: RFR(S): JDK-8033911 Simplify instrumentation of FileInputStream and RandomAccessFile

On 7 feb 2014, at 11:56, Alan Bateman wrote: > On 07/02/2014 10:46, Staffan Larsen wrote: >> A few of the public read and write methods in FileInputStream and >> RandomAccessFile are declared native. This means that it is hard to >> instrument them using byte code inst

Re: RFR(S): JDK-8033911 Simplify instrumentation of FileInputStream and RandomAccessFile

readBytes => readBytes0 > > it's pure cosmetic, but fairly simplify core dump reading and later > grep-ing. > > -Dmitry > > On 2014-02-07 14:46, Staffan Larsen wrote: >> A few of the public read and write methods in FileInputStream and >> RandomAccessFile

RFR(S): JDK-8033911 Simplify instrumentation of FileInputStream and RandomAccessFile

A few of the public read and write methods in FileInputStream and RandomAccessFile are declared native. This means that it is hard to instrument them using byte code instrumentation. Changing the public methods to be to non-native and instead calling private native methods simplifies instrument

Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

defined, and code attempts to > load the library more than once. In that scenario then both functions are > called. > > Staffan Larsen did the hard work in JDK-8031968 where he observed that > dlopen(NULL, RTLD_LAZY) behaves differently on OS X and that we should be > using d

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

comments inline: > >> > >> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen > >> wrote: > >>> > >>> Volker, > >>> > >>> I’ve look at the following files: > >>> > >>> src/share/native/sun/manageme

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 15 jan 2014, at 18:27, Volker Simonis wrote: > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis > wrote: >> Hi Staffan, >> >> thanks for the review. Please find my comments inline: >> >> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen >> wrote:

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Yes, that looks like a good solution. /Staffan On 15 jan 2014, at 17:34, Volker Simonis wrote: > Hi Staffan, > > thanks for the review. Please find my comments inline: > > On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen > wrote: > Volker, > > I’ve look at th

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Volker, I’ve look at the following files: src/share/native/sun/management/DiagnosticCommandImpl.c: nit: “legel” -> “legal” (two times) In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if you allow dcmd_info_array to become NULL, then jmm_interface->GetDiagnosticCommandInf

Re: RFR for JDK-7027502: Test failures in demo/jvmti/hprof testcases, need to be othervm

Looks good! Thanks, /Staffan On 13 jan 2014, at 07:21, Tristan Yan wrote: > Hi All > I add more trace output to track down possible reason of this failure. Please > help to review it again. > > http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.05/ > Thank you > Tristan > > On 01/10/2014 07

Re: RFR for JDK-7027502: Test failures in demo/jvmti/hprof testcases, need to be othervm

On 10 jan 2014, at 09:34, Alan Bateman wrote: > On 09/01/2014 23:20, Tristan Yan wrote: >> Hi David >> I wasn't able to reproduce this failure either in local or in our same >> binaries running(This is a continuous running with same JDK binaries). So >> intention for this code change is bringi

Re: [8] WXP minor fixes for a cleaner compile of c code

I see you were directed here from the build-dev list. Unfortunately these are core library fixes, not hotspot fixes. I’ve added core-libs and bcc:d hotspot-dev. Thanks, /Staffan On 11 dec 2013, at 07:34, Francis ANDRE wrote: > > Hi > > Below are some warnings produced by the build of jdk8.

hg: jdk8/tl/jdk: 6461635: [TESTBUG] BasicTests.sh test fails intermittently

Changeset: d30f49aa2d01 Author:sla Date: 2013-12-03 17:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f49aa2d01 6461635: [TESTBUG] BasicTests.sh test fails intermittently Summary: Transform dummy class instead of BigInteger to avoid complication by -Xshare. Ported from

hg: jdk8/tl/jdk: 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423

Changeset: fc9f24b9408e Author:sla Date: 2013-11-21 12:57 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc9f24b9408e 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Summary: Removed 5 testcases from the ProblemList Reviewed-by: sla Contributed-by: balchan

Re: Review Request for ProblemList.txt update

Looks good! Thanks, /Staffan On 19 Nov 2013, at 04:34, Mandy Chung wrote: > java/lang/management/ThreadMXBean/ThreadStateTest.java has been fixed in [1]. > > This patch removes it from jdk/test/ProblemList.txt: > > $ hg diff ProblemList.txt > diff --git a/test/ProblemList.txt b/test/ProblemLi

hg: jdk8/tl/jdk: 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently

Changeset: 64a492bc0ba7 Author:sla Date: 2013-11-14 12:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64a492bc0ba7 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Summary: Port tests for java/lang/instrument/PremainClass from s

hg: jdk8/tl/jdk: 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Changeset: 65f7b83ab477 Author:sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

Looks good! Thanks, /Staffan On 12 Nov 2013, at 20:29, Mandy Chung wrote: > This is a simple code deletion in sun.misc.JavaAWTAccess and its > implementation class: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ > > This patch removes the methods from sun.mi

hg: jdk8/tl/jdk: 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary

Changeset: a42a416351b8 Author:ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/t

hg: jdk8/tl/jdk: 8014506: Test of Jdp feature

Changeset: 0cacac7f5c37 Author:sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/Dynam

hg: jdk8/tl/jdk: 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

Changeset: 8a4405fb40ba Author:ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Re

hg: jdk8/tl/jdk: 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.

Changeset: c59ccad6eb72 Author:sla Date: 2013-11-01 15:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Reviewed-by: dcubed ! test/com/sun/jdi/JdbMethodExitTest.sh !

hg: jdk8/tl/jdk: 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt

Changeset: c35f6df5bce9 Author:sla Date: 2013-11-01 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Reviewed-by: stefank, alanb ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8022229: Intermittent test failures in sun/tools/jstatd

Changeset: b04b124418d8 Author:ykantser Date: 2013-10-30 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b04b124418d8 809: Intermittent test failures in sun/tools/jstatd Reviewed-by: sla, egahlin, jbachorik, allwin + test/lib/testlibrary/jdk/testlibrary/Asserts.java

hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code

Changeset: ecba02f6be31 Author:sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java + test/com/su

hg: jdk8/tl/jdk: 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads

Changeset: e6bc0dca294b Author:sla Date: 2013-10-15 12:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6bc0dca294b 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Reviewed-by: sla, allwin Contributed-by: mikael.a...

hg: jdk8/tl/jdk: 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection

Changeset: 8c20e9ef8709 Author:sla Date: 2013-10-23 15:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c20e9ef8709 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Reviewed-by: dcubed ! test/ProblemList.t

hg: jdk8/tl/jdk: 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt

Changeset: bb2fb6be8b2a Author:ykantser Date: 2013-10-22 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Reviewed-by: sla, jbachorik ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

Changeset: 8479a48d9fd4 Author:sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUnini

Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

rev is at > http://cr.openjdk.java.net/~allwin/auno/8009681/webrev.00/. > > Thanks, > Mikael > > On 2013-05-28 08:46, Staffan Larsen wrote: >> Looks good. >> >> You could optimize it a bit by not doing the Arrays.asList() on every >> methodExit event. >

hg: jdk8/tl/jdk: 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java

Changeset: 998560cccefc Author:allwin Date: 2013-10-10 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998560cccefc 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar ! tes

hg: jdk8/tl/jdk: 8025427: jstat tests fails on 32-bit platforms

Changeset: 6aa637dde16e Author:sla Date: 2013-10-10 09:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6aa637dde16e 8025427: jstat tests fails on 32-bit platforms Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn ! src/share/classes/sun/tools/jstat/RowClosure.java ! test/

hg: jdk8/tl/jdk: 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist

Changeset: 77ba1e67707c Author:allwin Date: 2013-10-04 15:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77ba1e67707c 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist Reviewed-by: sla, jbachorik ! test/ProblemList.txt

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

On 4 okt 2013, at 00:49, Coleen Phillmore wrote: > > Thanks Dan - > > On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote: >> > open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk >> >> test/java/lang/instrument/RedefineMethodInBacktrace.sh >>No comments. >> >> test/java/lang/inst

Re: RFR (S) 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV

Looks good! (Obviously I would think so for the testcase :-) ) Thanks for fixing, /Staffan On 3 okt 2013, at 20:02, Coleen Phillimore wrote: > Summary: Redefined class in stack trace may not be found by method_idnum so > handle null. > > This is a simple change. I had another change to save

hg: jdk8/tl/jdk: 6696975: JTop plugin fails if connected readonly to target JVM

Changeset: 3bb89c509d59 Author:egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java

hg: jdk8/tl/jdk: 8023492: jfr.jar gets loaded even though it's not used

Changeset: cceaad499685 Author:sla Date: 2013-09-30 12:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cceaad499685 8023492: jfr.jar gets loaded even though it's not used Reviewed-by: erikj, mgronlun ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java

hg: jdk8/tl/jdk: 7200277: [parfait] potential buffer overflow in npt/utf.c

Changeset: 94cc251d0c45 Author:sla Date: 2013-09-20 16:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94cc251d0c45 7200277: [parfait] potential buffer overflow in npt/utf.c Reviewed-by: dsamersoff, dcubed ! src/share/npt/utf.c

RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

Please review this change to avoid a buffer overflow in npt/utf.c. webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7200277 Thanks, /Staffan

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 58fd427b454d Author:sla Date: 2013-09-20 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58fd427b454d 8024985: com/sun/jdi/StepTest.java failed since jdk8b107 Reviewed-by: dcubed ! test/com/sun/jdi/ExceptionEvents.java ! test/com/sun/jdi/FilterNoMatch.java !

  1   2   >