Re: RFR - JDK-8212975 ClassDesc should have a full name method

looks good to me, Vicente On 4/23/19 10:58 AM, Jim Laskey wrote: Revision based on Joe review webrev: http://cr.openjdk.java.net/~jlaskey/8212975/webrev-03 On Apr 22, 2019, at 3:34 PM, Jim Laskey wrote: ClassDesc.displayName(boolean detail) allows the user the option to fetch the fully

Re: RFR: JDK-8222151: refactoring: enhancements to java.lang.Class::methodToString and java.lang.Class::getTypeName

() + '.' + name + (argTypes == null || argTypes.length == 0) ? "()":   Arrays.stream(argTypes)   .map(c -> c == null ? "null" : c.getName())   .collect(Collectors.joining(",", "(", ")")); HTH, -Joe On 4/11/2019 1:30 PM, Vicente Romero wrote: H

Re: RFR: JDK-8222151: refactoring: enhancements to java.lang.Class::methodToString and java.lang.Class::getTypeName

be preferable, but otherwise the patch looks fine. Thanks, -Joe On 4/11/2019 10:22 AM, Vicente Romero wrote: Please review the enhancements to java.lang.Class proposed by Sergei Tsypanov see discussion at [1]. The bug can be found at [2] and the fix at [3]. This enhancement is removing uses

RFR: JDK-8222151: refactoring: enhancements to java.lang.Class::methodToString and java.lang.Class::getTypeName

Please review the enhancements to java.lang.Class proposed by Sergei Tsypanov see discussion at [1]. The bug can be found at [2] and the fix at [3]. This enhancement is removing uses of StringBuilder in:     ::toGenericString     ::methodToString, and     ::getTypeName Thanks, Vicente [1]

Re: [PATCH] Some improvements for java.lang.Class

Hi Sergei, I have created issue [1] to track your enhancement. Please cc me in your next mails I will be helping you to do the paperwork. Talking about that did you sign the OCA, [2]? Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8222151 [2]

Re: [PATCH] Some improvements for java.lang.Class

Hi, From the benchmark data, it seems that the patched code is not a lot much faster than the original code, plus as Peter mentioned java.base is not compiled with the -XDstringConcat=inline option, so there is no way the compiler will generate any indy for the patched code. The new code is

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

thanks :) Vicente On 2/22/19 2:50 PM, Mandy Chung wrote: On 2/22/19 8:37 AM, Vicente Romero wrote: Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ Looks good

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

, Vicente Romero wrote: Please review the simple patch to fix [1] at [2]. The patch is simply adding a comment to the API, (javadoc) to sync it with the implementation. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8219480 [2] http://cr.openjdk.java.net/~vromero/8219480/webrev.00

RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

Please review the simple patch to fix [1] at [2]. The patch is simply adding a comment to the API, (javadoc) to sync it with the implementation. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8219480 [2] http://cr.openjdk.java.net/~vromero/8219480/webrev.00/

Re: Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

looks good to me, Vicente On 2/6/19 3:13 PM, Mandy Chung wrote: This patch fixes up X-VarHandleTest* template files that are used to generate VarHandles tests.  Since VarHandle::equals and VarHandle::hashCode methods are no longer implemented [1], I rename the testEqualsAndHashCode method to

Re: RFR: JDK-8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec

I have updated the webrev after additional feedback from the TCK tester please check last version at [1] Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/8215510/webrev.01 On 1/3/19 12:21 PM, Vicente Romero wrote: Please review the fix for bug [1] at [2]. Basically the constants API

RFR: JDK-8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec

Please review the fix for bug [1] at [2]. Basically the constants API introduced as part of JEP-334 [3] were accepting descriptors and class names not allowed by the spec. This implementation fixes several issues found by TCK tests on JEP-334, Thanks, Vicente [1]

Re: RFR - CSR JDK-8215490 Remove String::align

looks good, Vicente On 12/19/18 2:47 PM, Jim Laskey wrote: CSR: https://bugs.openjdk.java.net/browse/JDK-8215490 Thank you. Cheers, — Jim JBS: https://bugs.openjdk.java.net/browse/JDK-8215489

Re: RFR: JDK-8215648: remove equals and hashCode implementations from j.l.i.VarHandle

Please review also the related CSR: https://bugs.openjdk.java.net/browse/JDK-8215649 Thanks, Vicente On 12/19/18 4:27 PM, Vicente Romero wrote: Please review fix for [1] at [2]. The fx is basically removing the implementation of methods VarHandle::equals and VarHandle::hashCode to make var

RFR: JDK-8215648: remove equals and hashCode implementations from j.l.i.VarHandle

Please review fix for [1] at [2]. The fx is basically removing the implementation of methods VarHandle::equals and VarHandle::hashCode to make var handles consistent with method handles which don't override the default implementation for these methods, Thanks, Vicente [1]

Re: RFR JDK-8215300: additional changes to constants API

Hi all, I have provided another iteration to the webrev at [1]. This one includes additional changes to make sure that no array descriptor with more than 255 dimensions is created. Thanks, Vicente http://cr.openjdk.java.net/~vromero/8215300/webrev.01/ On 12/12/18 12:02 PM, Vicente Romero

RFR JDK-8215300: additional changes to constants API

Hi, Please review some final changes to the constants API. The changes should make the API clearer and more precise and were recommended in the CSR [3] Thanks, Vicente [1] (jira issue) https://bugs.openjdk.java.net/browse/JDK-8215300 [2] (webrev)

Re: Type variable information is not always maintained for anonymous classes

Hi Sergey, Thanks for your interest in the bug, yes if you feel like, please feel free to give it a try. Vicente On 12/7/18 6:53 PM, Sergey wrote: Hi everyone, Recently I've stumbled upon this bug https://bugs.openjdk.java.net/browse/JDK-8213465 which is named the same way as in the header

Re: RFR: JDK-8210031: implementation for JVM Constants API

Hi Rogers, Thanks for your comments, I have uploaded another webrev [1], some comments below: [1] http://cr.openjdk.java.net/~vromero/8210031/webrev.14/ On 12/6/18 11:07 AM, Roger Riggs wrote: Hi Vicente, On 12/05/2018 09:13 PM, Vicente Romero wrote: Hi Roger, Thanks for your comments

Re: RFR: JDK-8210031: implementation for JVM Constants API

Hi Mandy, On 12/5/18 1:12 PM, Mandy Chung wrote: On 12/3/18 11:12 AM, Vicente Romero wrote: Hi all, Can I have the final nod to the JVM constants API, there have been some changes since the last review iteration. Thanks to the internal and external developers that have taken the time

Re: RFR: JDK-8210031: implementation for JVM Constants API

/~vromero/8210031/webrev.10/ javadoc: http://cr.openjdk.java.net/~vromero/8210031/javadoc.18/overview-summary.html specdiff: http://cr.openjdk.java.net/~vromero/8210031/specdiff.08/overview-summary.html Thanks, Vicente On 10/18/18 9:55 PM, Mandy Chung wrote: On 10/15/18 11:12 AM, Vicente

Re: Reflection, TYPE_USE annotation on THROWS on inner class constructor, Java 9+

Hi Michael, Thanks for the report. I have created: https://bugs.openjdk.java.net/browse/JDK-8213905 to track it, Vicente On 11/9/18 10:13 AM, Michael Rasmussen wrote: Hi When adding a TYPE_USE annotation with runtime retention to the throws exception clause of a constructor of an inner

JDK12 talks ASM7 now!

Hi guys, Thanks everyone for the feedback. I pushed the patch yesterday, Vicente

Re: RFR: JDK-8213480: update internal ASM version to 7.0

g tools which expect @ignore to be followed by a space-separated list of bug ids. the rest looks good to me. Thanks, -- Igor On Nov 13, 2018, at 5:11 PM, Vicente Romero wrote: Hi Alan, On 11/13/18 9:18 AM, Alan Bateman wrote: On 13/11/2018 14:00, Vicente Romero wrote: any other comment afte

Re: RFR: JDK-8213480: update internal ASM version to 7.0

Hi Alan, On 11/13/18 9:18 AM, Alan Bateman wrote: On 13/11/2018 14:00, Vicente Romero wrote: any other comment after the last iteration? we are in a bit of a hurry to push this before the JDK 12 train departs :( The original patch updated all the use sites (and tests) to specify ASM7

Re: RFR: JDK-8213480: update internal ASM version to 7.0

any other comment after the last iteration? we are in a bit of a hurry to push this before the JDK 12 train departs :( Thanks, Vicente On 11/8/18 11:39 AM, Vicente Romero wrote: Hi David, Igor On 11/7/18 10:03 PM, David Holmes wrote: Hi Vicente, All of the javadoc comment reformatting

Re: RFR: JDK-8213480: update internal ASM version to 7.0

Hi David, On 11/8/18 11:00 PM, David Holmes wrote: Hi Vicente, On 9/11/2018 2:39 AM, Vicente Romero wrote: Hi David, Igor On 11/7/18 10:03 PM, David Holmes wrote: Hi Vicente, All of the javadoc comment reformatting makes it nearly impossible to see the actual substantive changes :( ASM

Re: RFR: JDK-8213480: update internal ASM version to 7.0

/~vromero/8213480/webrev.asm.7.additional.changes.00/ On 8/11/2018 1:56 AM, Vicente Romero wrote: Hi, Version 7.0 of ASM has been released. This version supports condy, yay!, and we want to include it in JDK 12. Please review [1] which includes: - the new version perse substituting the preview ASM

Re: RFR: JDK-8213480: update internal ASM version to 7.0

On 11/8/18 8:14 AM, Alan Bateman wrote: On 07/11/2018 19:33, Igor Ignatyev wrote: Hi Vicente, I recall an (internal?) discussion about updating ASM somewhen in JDK 11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK needs that, has it been changed? put somewhat

Re: RFR: JDK-8213480: update internal ASM version to 7.0

tps://bugs.openjdk.java.net/browse/JDK-8194826>) and mark all tests which throw this exception w/ '@ignore 8194951' jtreg tag. sounds good, I will do this Thanks, -- Igor Thanks, Vicente On Nov 7, 2018, at 7:56 AM, Vicente Romero <mailto:vicente.rom...@oracle.com>> wrote: Hi, Version 7.0

RFR: JDK-8213480: update internal ASM version to 7.0

Hi, Version 7.0 of ASM has been released. This version supports condy, yay!, and we want to include it in JDK 12. Please review [1] which includes: - the new version perse substituting the preview ASM internal version in the JDK - changes to additional files in particular some tests, mostly

Re: JDK 12 RFR of JDK-6304578: (reflect) toGenericString fails to print bounds of type variables on generic methods

last iteration looks good to me, Vicente On 10/25/18 5:47 PM, joe darcy wrote: Hi Peter, Coming back to this review after my Code One activities this year have run their course... On 10/17/2018 3:07 PM, Peter Levart wrote: Hi Joe, On 10/17/2018 09:16 PM, joe darcy wrote: PS In response

Re: RFR: JDK-8210031: implementation for JVM Constants API

Hi all, Thanks Mandy for the review. I have uploaded a new iteration [1]. Vicente [1] http://cr.openjdk.java.net/~vromero/8210031/webrev.02/ On 10/18/18 9:55 PM, Mandy Chung wrote: On 10/15/18 11:12 AM, Vicente Romero wrote: [1] http://cr.openjdk.java.net/~vromero/8210031/webrev.01 I

Re: RFR: JDK-8210031: implementation for JVM Constants API

Hi all, Please review also the CSR at [1]. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8202031 On 10/15/18 2:12 PM, Vicente Romero wrote: Hi all, sorry for the repeated number of mails on this issue. I have added a direct link to the patch the right link to the webrev

Re: RFR: JDK-8210031: implementation for JVM Constants API

] http://openjdk.java.net/jeps/334 On 10/15/2018 01:51 PM, Vicente Romero wrote: adding core-libs in the loop On 10/10/2018 12:30 PM, Vicente Romero wrote: Hi all, I have updated the webrev [1], this version removes the `implements Constable` from the symbolic descriptor classes. Feedback is mostly

Re: RFR: JDK-8210031: implementation for JVM Constants API

adding core-libs in the loop On 10/10/2018 12:30 PM, Vicente Romero wrote: Hi all, I have updated the webrev [1], this version removes the `implements Constable` from the symbolic descriptor classes. Feedback is mostly appreciated, Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero

Re: RFR 7183985: Class.getAnnotation() throws an ArrayStoreException when the annotation class not present

I'm not an expert in the area, but the patch looks good to me, Vicente On 05/31/2018 08:39 PM, Liam Miller-Cushon wrote: Hi, Are there any concerns with the patch that I can address? I was hoping to get this in to JDK 11. I confirmed that it still builds and passes all tests at head.

Re: RFR: implementation for JEP 334: JVM Constants API

On 05/31/2018 05:09 PM, Vicente Romero wrote: Hi all, I have uploaded another iteration of the implementation of the constants API + the javadoc. Thanks for the comments so far, Vicente [1] http://cr.openjdk.java.net/~vromero/constant.api/webrev.09 [2] http://cr.openjdk.java.net/~vromero

Re: RFR: implementation for JEP 334: JVM Constants API

, Vicente Romero wrote: Thanks for the comments so far, I have uploaded another iteration of the implementation + javadoc Vicente [1] http://cr.openjdk.java.net/~vromero/constant.api/webrev.08 [2] http://cr.openjdk.java.net/~vromero/constant.api/javadoc.08 On 05/23/2018 02:41 PM, Vicente Romero

Re: RFR: implementation for JEP 334: JVM Constants API

Thanks for the comments so far, I have uploaded another iteration of the implementation + javadoc Vicente [1] http://cr.openjdk.java.net/~vromero/constant.api/webrev.08 [2] http://cr.openjdk.java.net/~vromero/constant.api/javadoc.08 On 05/23/2018 02:41 PM, Vicente Romero wrote: Hi all

Re: RFR: 8195072: Update ASM 3rd party legal (TPL) copyright to 6.0

looks good, Vicente On 01/12/2018 07:31 PM, Kumar Srinivasan wrote: Hello, Could I get a review for this simple update to the 3rd party legal (TPL) information. Thanks Webrev: http://cr.openjdk.java.net/~ksrini/8195072/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8195072

RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

Hi, Please review the fix for issue [1]. The fix can be found at [2]. The fix is minimal, reproduced below: --- old/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java 2017-08-16 16:31:21.403085344 -0400 +++

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

On 02/15/2017 04:25 PM, Alan Bateman wrote: On 15/02/2017 20:41, Vicente Romero wrote: Hi, Thanks guys for your comments. I have uploaded another iteration of the review at [1], Vicente [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch I assume you use getClass

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

/webrev.01/jdk.patch On 02/15/2017 02:06 PM, Kumar Srinivasan wrote: On 2/15/2017 10:39 AM, Alan Bateman wrote: On 15/02/2017 17:21, Vicente Romero wrote: The simplest reproductor for this issue

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

Hi, Thanks guys for your comments. I have uploaded another iteration of the review at [1], Vicente [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch On 02/15/2017 02:06 PM, Kumar Srinivasan wrote: On 2/15/2017 10:39 AM, Alan Bateman wrote: On 15/02/2017 17:21, Vicente

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

FoundError is produced then it will be: "because class Foo is not defined" Thanks, Vicente On 02/15/2017 12:12 PM, Alan Bateman wrote: On 15/02/2017 17:03, Vicente Romero wrote: Hi, Please review the fix for bug [1]. The fix is improving an already existing error message. The public patch

hg: jdk8/tl/langtools: 8029721: javac crash for annotated parameter type of lambda in a field

Changeset: 8832b6048e65 Author:vromero Date: 2013-12-13 14:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8832b6048e65 8029721: javac crash for annotated parameter type of lambda in a field Reviewed-by: rfield, jfranck !

hg: jdk8/tl/langtools: 8029569: internal javac cast exception when resolving varargs ambiguity

Changeset: 5bf0af735c61 Author:vromero Date: 2013-12-09 19:29 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5bf0af735c61 8029569: internal javac cast exception when resolving varargs ambiguity Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java

hg: jdk8/tl/langtools: 8029179: javac produces a compile error for valid boolean expressions

Changeset: fb8c59cf26c8 Author:vromero Date: 2013-12-03 18:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb8c59cf26c8 8029179: javac produces a compile error for valid boolean expressions Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8028504: javac generates LocalVariableTable even with -g:none

Changeset: 66bcd5d4b3d1 Author:vromero Date: 2013-11-19 23:35 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1 8028504: javac generates LocalVariableTable even with -g:none Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8026231: Look at 'static' flag when checking method references

Changeset: d4cbb671de1c Author:vromero Date: 2013-11-15 11:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4cbb671de1c 8026231: Look at 'static' flag when checking method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java !

hg: jdk8/tl/langtools: 8026963: type annotations code crashes for code with erroneous trees

Changeset: e79d6425f1c4 Author:vromero Date: 2013-11-14 19:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8027660: javac crash while creating LVT entry for a local variable defined in an inner block

Changeset: cc80c03c41e4 Author:vromero Date: 2013-11-01 19:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/langtools: 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo

Changeset: 537fa895fd74 Author:vromero Date: 2013-10-30 18:09 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo Reviewed-by: ksrini !

hg: jdk8/tl/langtools: 8025290: javac implicit versus explicit lambda compilation error

Changeset: 963c57175e40 Author:vromero Date: 2013-10-22 13:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40 8025290: javac implicit versus explicit lambda compilation error Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java

hg: jdk8/tl/langtools: 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change

Changeset: 9f876bd43f55 Author:vromero Date: 2013-10-21 15:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f876bd43f55 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Reviewed-by: jfranck !

hg: jdk8/tl/jdk: 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis

Changeset: fbb7510f788d Author:vromero Date: 2013-10-19 17:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbb7510f788d 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis Reviewed-by: psandoz !

hg: jdk8/tl/langtools: 8024809: javac, some lambda programs are rejected by flow analysis

Changeset: c4292590fc70 Author:vromero Date: 2013-10-19 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4292590fc70 8024809: javac, some lambda programs are rejected by flow analysis Reviewed-by: jjg, dlsmith !

hg: jdk8/tl/langtools: 8025816: javac crash with method reference with a type variable as the site

Changeset: 70a301b35e71 Author:vromero Date: 2013-10-15 19:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70a301b35e71 8025816: javac crash with method reference with a type variable as the site Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears

Changeset: d8d6b58f1ebf Author:vromero Date: 2013-10-15 21:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d8d6b58f1ebf 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8023679: Improve error message for '_' used as a lambda parameter name

Changeset: 1e6088da1740 Author:vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith !

hg: jdk8/tl/langtools: 8024497: crash returning this-referencing lambda from default method

Changeset: 16194509e483 Author:vromero Date: 2013-09-27 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16194509e483 8024497: crash returning this-referencing lambda from default method Reviewed-by: jjg, rfield !

hg: jdk8/tl/langtools: 8025139: javac patch for using bootstrap compiler for debugging is not working properly

Changeset: 13eba2e322e6 Author:vromero Date: 2013-09-26 19:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13eba2e322e6 8025139: javac patch for using bootstrap compiler for debugging is not working properly Reviewed-by: jjg ! make/netbeans/langtools/build.xml !

hg: jdk8/tl/langtools: 8024696: Missing null check in bound method reference capture

Changeset: 571f8ebc2d51 Author:vromero Date: 2013-09-22 12:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/571f8ebc2d51 8024696: Missing null check in bound method reference capture Reviewed-by: jjg, briangoetz !

hg: jdk8/tl/langtools: 8024437: Inferring the exception thrown: sometimes fails to compile

Changeset: 2375ce96e80d Author:vromero Date: 2013-09-19 20:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2375ce96e80d 8024437: Inferring the exception thrown: sometimes fails to compile Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8021112: Spurious unchecked warning reported by javac; ...

Changeset: 4ce8148ffc4f Author:jlahoda Date: 2013-09-16 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ce8148ffc4f 8021112: Spurious unchecked warning reported by javac 6480588: No way to suppress deprecation warnings when implementing deprecated interface

hg: jdk8/tl/langtools: 8024207: javac crash in Flow.AssignAnalyzer.visitIdent

Changeset: 03c26c60499c Author:vromero Date: 2013-09-14 15:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/03c26c60499c 8024207: javac crash in Flow.AssignAnalyzer.visitIdent Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java +

hg: jdk8/tl/langtools: 7047734: javac, the LVT is not generated correctly in several scenarios

Changeset: 4932bb04c4b8 Author:vromero Date: 2013-09-14 19:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4932bb04c4b8 7047734: javac, the LVT is not generated correctly in several scenarios Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case

Changeset: 3ae1814f7c59 Author:vromero Date: 2013-09-12 22:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae1814f7c59 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/langtools: 8024414: javac, should facilitate the use of the bootstrap compiler for debugging

Changeset: d87f017ec217 Author:mcimadamore Date: 2013-09-10 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217 8024414: javac, should facilitate the use of the bootstrap compiler for debugging Reviewed-by: jjg ! make/netbeans/langtools/build.xml !

hg: jdk8/tl/langtools: 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests

Changeset: a4b9a8859e58 Author:vromero Date: 2013-09-09 16:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4b9a8859e58 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests Reviewed-by: jjg, jfranck !

hg: jdk8/tl/langtools: 8024398: javac, compiler crashes with try with empty body

Changeset: 2de3750d65a5 Author:vromero Date: 2013-09-08 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2de3750d65a5 8024398: javac, compiler crashes with try with empty body Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java +

hg: jdk8/tl/langtools: 8024039: javac, previous solution for JDK-8022186 was incorrect

Changeset: 7c7b4aea6d50 Author:vromero Date: 2013-09-06 09:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c7b4aea6d50 8024039: javac, previous solution for JDK-8022186 was incorrect Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java !

hg: jdk8/tl/langtools: 8008275: javac.Main should be @Supported

Changeset: b94824ddcbb6 Author:vromero Date: 2013-09-04 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b94824ddcbb6 8008275: javac.Main should be @Supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java

hg: jdk8/tl/langtools: 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied

Changeset: 438547d895dc Author:vromero Date: 2013-09-04 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/438547d895dc 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied Reviewed-by: jjg,

hg: jdk8/tl/langtools: 8023389: Javac fails to infer type for lambda used with intersection type and wildcards

Changeset: fb5a846c4a49 Author:vromero Date: 2013-09-03 23:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb5a846c4a49 8023389: Javac fails to infer type for lambda used with intersection type and wildcards Reviewed-by: jjg, vromero Contributed-by:

hg: jdk8/tl/langtools: 8023545: Misleading error message when using diamond operator with private constructor

Changeset: 9be0afbdf244 Author:vromero Date: 2013-09-03 23:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9be0afbdf244 8023545: Misleading error message when using diamond operator with private constructor Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8022162: Incorrect signature determination for certain inner class generics

Changeset: 2bf4c132bf90 Author:vromero Date: 2013-09-02 22:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2bf4c132bf90 8022162: Incorrect signature determination for certain inner class generics Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8016177: structural most specific and stuckness

Changeset: 4a6acc42c3a1 Author:vromero Date: 2013-09-02 22:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a6acc42c3a1 8016177: structural most specific and stuckness Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8022316: Generic throws, overriding and method reference

Changeset: 7a4717f3ea7b Author:vromero Date: 2013-08-22 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b 8022316: Generic throws, overriding and method reference Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java +

hg: jdk8/tl/langtools: 8023112: javac should not use lazy constant evaluation approach for method references

Changeset: 25aaff78d754 Author:vromero Date: 2013-08-22 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754 8023112: javac should not use lazy constant evaluation approach for method references Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8022053: javac generates unverifiable initializer for nested subclass of local class

Changeset: a6378c19836b Author:vromero Date: 2013-08-16 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b 8022053: javac generates unverifiable initializer for nested subclass of local class Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/jdk: 8015780: java/lang/reflect/Method/GenericStringTest.java failing

Changeset: 70c8f4a4b8d6 Author:vromero Date: 2013-08-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6 8015780: java/lang/reflect/Method/GenericStringTest.java failing Reviewed-by: darcy, jfranck ! test/ProblemList.txt !

hg: jdk8/tl/langtools: 8009640: -profile compact does not work when -bootclasspath specified

Changeset: 0d9bc764cac7 Author:vromero Date: 2013-08-10 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d9bc764cac7 8009640: -profile compact does not work when -bootclasspath specified Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java !

hg: jdk8/tl/langtools: 8022622: javac, two tests are failing with compile time error after class Collector was modified

Changeset: 8f282dc58dfc Author:vromero Date: 2013-08-10 16:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f282dc58dfc 8022622: javac, two tests are failing with compile time error after class Collector was modified Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6983297: methods missing from NewArrayTree

Changeset: aa6c6f8b5622 Author:vromero Date: 2013-08-10 16:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa6c6f8b5622 6983297: methods missing from NewArrayTree Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java !

hg: jdk8/tl/langtools: 8019486: javac, generates erroneous LVT for a test case with lambda code

Changeset: b8610a65fbf9 Author:vromero Date: 2013-08-08 11:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9 8019486: javac, generates erroneous LVT for a test case with lambda code Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations

Changeset: f3deeccbf4cf Author:vromero Date: 2013-08-07 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations Reviewed-by: jjg, jfranck !

hg: jdk8/tl/langtools: 8008274: javac should not reference/use sample code

Changeset: c7dcf899 Author:vromero Date: 2013-08-07 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899 8008274: javac should not reference/use sample code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java

hg: jdk8/tl/langtools: 8022186: javac generates dead code if a try with an empty body has a finalizer

Changeset: 99b60bcf3862 Author:vromero Date: 2013-08-06 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862 8022186: javac generates dead code if a try with an empty body has a finalizer Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6

Changeset: 7696282873f6 Author:vromero Date: 2013-07-31 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7696282873f6 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8009924: some langtools tools do not accept -cp as an alias for -classpath

Changeset: d6158f8d7235 Author:vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg !

hg: jdk8/tl/langtools: 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members

Changeset: 79c3146e417b Author:vromero Date: 2013-07-04 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8019397: javap does not show SourceDebugExtension properly

Changeset: 27a2e8c78bd0 Author:vromero Date: 2013-07-02 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27a2e8c78bd0 8019397: javap does not show SourceDebugExtension properly Reviewed-by: jjg Contributed-by: dmytro_she...@hotmail.com !

hg: jdk8/tl/langtools: 6326693: variable x might already have been assigned, when assignment is in catch block

Changeset: 3b4f92a3797f Author:vromero Date: 2013-07-02 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f 6326693: variable x might already have been assigned, when assignment is in catch block Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6983646: javap should identify why a DefaultAttribute is being used

Changeset: 891c5ecb8306 Author:vromero Date: 2013-06-29 20:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891c5ecb8306 6983646: javap should identify why a DefaultAttribute is being used Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Attribute.java !

hg: jdk8/tl/langtools: 6473148: TreePath.iterator() should document the iteration order

Changeset: bb06c412d079 Author:vromero Date: 2013-06-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079 6473148: TreePath.iterator() should document the iteration order Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/TreePath.java

hg: jdk8/tl/langtools: 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string

Changeset: bdd699d7378d Author:vromero Date: 2013-06-28 14:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5.

Changeset: a47e28759666 Author:vromero Date: 2013-06-27 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a47e28759666 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5. Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory)

Changeset: 8e3d391c88c6 Author:vromero Date: 2013-06-27 09:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e3d391c88c6 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory) Reviewed-by: jjg !

<    1   2   3   4   >