On Mon, 26 Oct 2020 20:24:35 GMT, Igor Ignatyev wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8238263: Create at-requires mechanism for containers
>
> LGTM, modulo my earlier comment/doubt about the name, but I
On Mon, 26 Oct 2020 18:13:29 GMT, Harold Seigel wrote:
>> Please review this change to add an @requires mechanism called
>> "jdk.containerized" to help mark tests that are incompatible with
>> containers. Users would add "@requires jdk.containerized != true" to the
>> incompatible tests and
On Mon, 26 Oct 2020 18:13:29 GMT, Harold Seigel wrote:
>> Please review this change to add an @requires mechanism called
>> "jdk.containerized" to help mark tests that are incompatible with
>> containers. Users would add "@requires jdk.containerized != true" to the
>> incompatible tests and
On Mon, 26 Oct 2020 14:25:14 GMT, Igor Ignatyev wrote:
>> Defining an environment variable works when running JTReg from the command
>> line. But, mach5 does not pass environment variable settings to its JTReg
>> test runs. Some mach5 special command args would still be needed.
>
>> Defining
> Please review this change to add an @requires mechanism called
> "jdk.containerized" to help mark tests that are incompatible with containers.
> Users would add "@requires jdk.containerized != true" to the incompatible
> tests and then use "make test ... OPTIONS=-Djdk.containerized=true" or
On Mon, 26 Oct 2020 13:49:26 GMT, Harold Seigel wrote:
> Defining an environment variable works when running JTReg from the command
> line. But, mach5 does not pass environment variable settings to its JTReg
> test runs. Some mach5 special command args would still be needed.
right, yet given
On Fri, 23 Oct 2020 20:08:01 GMT, Igor Ignatyev wrote:
>>> I think it depends on whether the tests will be permanently or temporarily
>>> excluded from running with containers. I thought this mechanism would be to
>>> permanently exclude the tests. That's why I used `@requires`.
>>
>> I see,
On Fri, 23 Oct 2020 19:54:40 GMT, Igor Ignatyev wrote:
>> Hi Igor,
>> I think it depends on whether the tests will be permanently or temporarily
>> excluded from running with containers. I thought this mechanism would be to
>> permanently exclude the tests. That's why I used @requires.
>>
> On Oct 23, 2020, at 3:57 PM, Igor Ignatyev wrote:
>
> On Fri, 23 Oct 2020 19:25:27 GMT, Harold Seigel wrote:
>
>> I think it depends on whether the tests will be permanently or temporarily
>> excluded from running with containers. I thought this mechanism would be to
>> permanently
On Fri, 23 Oct 2020 19:25:27 GMT, Harold Seigel wrote:
> I think it depends on whether the tests will be permanently or temporarily
> excluded from running with containers. I thought this mechanism would be to
> permanently exclude the tests. That's why I used `@requires`.
I see, if this is
On Fri, 23 Oct 2020 19:17:40 GMT, Igor Ignatyev wrote:
>> Please review this change to add an @requires mechanism called
>> "jdk.containerized" to help mark tests that are incompatible with
>> containers. Users would add "@requires jdk.containerized != true" to the
>> incompatible tests and
Hi Bob,
Thanks for looking at this. I'll look into basing the option on an
environment variable.
Thanks, Harold
On 10/23/2020 3:12 PM, Bob Vandette wrote:
I wonder if it makes sense to add this option to
open/test/jtreg-ext/requires/VMProps.java and have it
automatically enable this
On Fri, 23 Oct 2020 18:44:54 GMT, Harold Seigel wrote:
> Please review this change to add an @requires mechanism called
> "jdk.containerized" to help mark tests that are incompatible with containers.
> Users would add "@requires jdk.containerized != true" to the incompatible
> tests and then
I wonder if it makes sense to add this option to
open/test/jtreg-ext/requires/VMProps.java and have it
automatically enable this option based on an environment variable so we don’t
have to remember the
cryptic command line sequence.
It’s too bad we can’t automatically detect that we are running
Please review this change to add an @requires mechanism called
"jdk.containerized" to help mark tests that are incompatible with containers.
Users would add "@requires jdk.containerized != true" to the incompatible tests
and then use "make test ... OPTIONS=-Djdk.containerized=true" or "bash
15 matches
Mail list logo
