On Mon, 1 Mar 2021 11:09:31 GMT, Peter Levart wrote:
>> Attila Szegedi has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
>> commit
On Sun, 28 Feb 2021 10:28:56 GMT, Attila Szegedi wrote:
>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
>> "AssertionError: Should have GCd a method handle by now"
>
> Attila Szegedi has updated the pull request with a new target base due to a
> merge or a rebase.
On Sun, 28 Feb 2021 10:28:56 GMT, Attila Szegedi wrote:
>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
>> "AssertionError: Should have GCd a method handle by now"
>
> Attila Szegedi has updated the pull request with a new target base due to a
> merge or a rebase.
On Sun, 28 Feb 2021 07:20:19 GMT, Aleksey Shipilev wrote:
>> Attila Szegedi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
> "AssertionError: Should have GCd a method handle by now"
Attila Szegedi has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
8261483: Eliminate
On Sat, 27 Feb 2021 20:01:10 GMT, Attila Szegedi wrote:
>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
>> "AssertionError: Should have GCd a method handle by now"
>
> Attila Szegedi has refreshed the contents of this pull request, and previous
> commits have been
On Sat, 27 Feb 2021 20:10:15 GMT, Attila Szegedi wrote:
>> test/jdk/jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java line 79:
>>
>>> 77:
>>> 78: public static void main(String[] args) {
>>> 79: for (int count = 0; count < MAX_ITERATIONS; ++count) {
>>
>> Here and later: use
On Fri, 26 Feb 2021 08:03:26 GMT, Peter Levart wrote:
>> The good test would be trying with all current GCs (Serial, Parallel, G1,
>> Shenandoah, ZGC):
>>
>> make run-test TEST=jdk/dynalink TEST_VM_OPTS=-XX:+UseSerialGC
>>
>> Also, make sure that GH actions are able to run this test. You
On Thu, 25 Feb 2021 15:34:10 GMT, Aleksey Shipilev wrote:
>> Attila Szegedi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
On Thu, 25 Feb 2021 15:34:30 GMT, Aleksey Shipilev wrote:
>> Attila Szegedi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
> "AssertionError: Should have GCd a method handle by now"
Attila Szegedi has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to
On Thu, 25 Feb 2021 15:37:39 GMT, Aleksey Shipilev wrote:
>> Attila Szegedi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> The good test would be trying
On Thu, 18 Feb 2021 19:31:02 GMT, Attila Szegedi wrote:
>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
>> "AssertionError: Should have GCd a method handle by now"
>
> Attila Szegedi has refreshed the contents of this pull request, and previous
> commits have been
On Fri, 19 Feb 2021 11:22:57 GMT, Peter Levart wrote:
>I would like 1st to understand why the MH created in the
>TestLinker.convertToType is actually GCed at all.
The whole original issue was about allowing these objects to be GCd .
Short story: because all data is scoped to objects created
On Thu, 18 Feb 2021 19:41:21 GMT, Attila Szegedi wrote:
>> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
>> "AssertionError: Should have GCd a method handle by now"
>
> @plevart can I bother you for a follow-up review of my original issue?
> (Alternatively,
On Wed, 17 Feb 2021 19:44:35 GMT, Attila Szegedi wrote:
> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
> "AssertionError: Should have GCd a method handle by now"
@plevart can I bother you for a follow-up review of my original issue?
(Alternatively, @shipilev?)
> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
> "AssertionError: Should have GCd a method handle by now"
Attila Szegedi has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to
8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
"AssertionError: Should have GCd a method handle by now"
-
Commit messages:
- 8261483: Try to eliminate flakiness of the test by extending its allowed
runtime and reducing the memory
Changes:
18 matches
Mail list logo
