ce Andersen
Cc: nio-dev ; Java Core Libs
Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permissions
Hi Lance, Alan, et al.,
as it seems we are getting close to CSR approval, the changeset should also be
finally reviewed.
Here is the most current version:
http://cr.openjdk.
k and reviewed from your end?
>
> Thanks
> Christoph
>
> From: Langer, Christoph
> Sent: Mittwoch, 5. Juni 2019 16:45
> To: Alan Bateman ; Lance Andersen
>
> Cc: nio-dev ; Java Core Libs
>
> Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permi
) Add support for POSIX file permissions
Hi Lance, Alan, et al.,
as it seems we are getting close to CSR approval, the changeset should also be
finally reviewed.
Here is the most current version:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.14/
I have made some updates to
Hi Lance, Alan, et al.,
as it seems we are getting close to CSR approval, the changeset should also be
finally reviewed.
Here is the most current version:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.14/
I have made some updates to ZipConstants as suggested by Lance in a private
mail.
From: Alan Bateman
Sent: Mittwoch, 5. Juni 2019 11:53
To: Langer, Christoph
Cc: nio-dev ; Java Core Libs
; Lance Andersen
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
On 04/06/2019 15:25, Langer, Christoph wrote:
Hi Alan,
I made some updates to the CSR. The ma
On 04/06/2019 15:25, Langer, Christoph wrote:
Hi Alan,
I made some updates to the CSR. The main update was that I transferred
the new documentation part from module-info.java to the CSR’s
Specification section.
Can you please review the CSR?
The CSR mostly looks good. One thing is that the
stoph ; Lance Andersen
Cc: nio-dev ; Java Core Libs
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
On 02/06/2019 22:35, Langer, Christoph wrote:
Hi Alan, Lance,
thanks for the updated wording in module-info, that really looks good. I
incorporated it into my change, no we
On 02/06/2019 22:35, Langer, Christoph wrote:
Hi Alan, Lance,
thanks for the updated wording in module-info, that really looks good.
I incorporated it into my change, no we’d be here:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.13/
To be honest, I was hoping it would still make it i
SR to get it reviewed, correct?
Thanks
Christoph
From: Lance Andersen
Sent: Freitag, 31. Mai 2019 20:01
To: Alan Bateman
Cc: Langer, Christoph ; nio-dev
; Java Core Libs
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
On May 31, 2019, at 12:32 PM, Alan Ba
> On May 31, 2019, at 12:32 PM, Alan Bateman wrote:
>
> On 29/05/2019 13:16, Langer, Christoph wrote:
>> Hi Alan,
>>
>>> The table items in L119-150 look fine, we just need to avoid really long
>>> lines One minor comment on L123 is that it might be clearer if you drop
>>> "created" from the s
On 29/05/2019 13:16, Langer, Christoph wrote:
Hi Alan,
The table items in L119-150 look fine, we just need to avoid really long
lines One minor comment on L123 is that it might be clearer if you drop
"created" from the sentence.
L48-78 is a "wall of text" and links that I don't think will be e
Hi Alan,
> The table items in L119-150 look fine, we just need to avoid really long
> lines One minor comment on L123 is that it might be clearer if you drop
> "created" from the sentence.
>
> L48-78 is a "wall of text" and links that I don't think will be easy for
> most developers to read. Can
On 26/05/2019 21:54, Langer, Christoph wrote:
:
It's alright as it is. If you look at the source of
AccessController.doPrivileged for a PrivilegedExceptionAction, you will see
that RuntimeExceptions are caught and rethrown, not yielding a PAE. So I must
catch UOE here explicitly because it's a
Hi Alan,
> > http://cr.openjdk.java.net/~clanger/webrevs/8213031.10/
> I see your other mail with v11 so I switch to that version.
Right. 😊
> > Ok, makes sense. I've updated the coding such that the zip's file owner
> would be the default owner, in case it can be retrieved.
> I think this is mos
On 21/05/2019 16:24, Langer, Christoph wrote:
Hi Alan,
Thank you for your comments. Here comes the next update... increasing the
turnaround time a little bit 😊
http://cr.openjdk.java.net/~clanger/webrevs/8213031.10/
I see your other mail with v11 so I switch to that version.
:
Ok, makes
, Christoph
> Sent: Dienstag, 21. Mai 2019 17:24
> To: Alan Bateman
> Cc: nio-dev ; Java Core Libs d...@openjdk.java.net>
> Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
> Hi Alan,
>
> Thank you for your comments. Here comes the next update
Hi Alan,
Thank you for your comments. Here comes the next update... increasing the
turnaround time a little bit 😊
http://cr.openjdk.java.net/~clanger/webrevs/8213031.10/
> Thanks. I think you've addressed most of my points. The only thing that
> isn't clear is the group owner as I thought we h
On 09/05/2019 16:16, Langer, Christoph wrote:
Hi Alan,
I've got a new iteration for the zipfs POSIX support and addressed your
concerns: http://cr.openjdk.java.net/~clanger/webrevs/8213031.9/
Thanks. I think you've addressed most of my points. The only thing that
isn't clear is the group owner
Hi Alan,
I've got a new iteration for the zipfs POSIX support and addressed your
concerns: http://cr.openjdk.java.net/~clanger/webrevs/8213031.9/
The new change bases on the proposal for JDK-876, which I created to factor
out changes unrelated to POSIX to facilitate easier reviewing of this
On 01/04/2019 14:38, Langer, Christoph wrote:
:
Hm, when I was looking at it initially, I was also wondering if it would be cleaner either have a
default ZipFileAttributeView/ZipFileAttributes implementation that doesn't extend Posix or an
"Enhanced" ZipFileAttributeView/ZipFileAttributes that
Hi Alan,
thanks for getting back on this.
> One thing that is puzzling is that
> ZipFileAttributeView/ZipFileAttributes extend
> PosixFileAttributeView/PosixFileAttributes. I don't think that will work
> because the "zip" view is supported by default whereas "posix" view
> needs the file system t
On 20/03/2019 16:25, Langer, Christoph wrote:
Hi Alan,
I now found time to get back to the POSIX file permissions in zipfs. The goal
would be to get it done for JDK13 😊
:
Here is an updated webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.8/
What's next?
I skimmed through the up
Hi Alan,
I now found time to get back to the POSIX file permissions in zipfs. The goal
would be to get it done for JDK13 😊
I went through your mail in details, please see my comments:
> 1. By default, a zip file system will have no support for the "posix"
> and "owner" views of file attributes,
ginal Message-
> From: Alan Bateman
> Sent: Montag, 25. Februar 2019 09:31
> To: Langer, Christoph
> Cc: nio-dev ; Java Core Libs d...@openjdk.java.net>
> Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
> On 21/02/2019 15:04, Langer, Christoph wr
On 21/02/2019 15:04, Langer, Christoph wrote:
Hi Alan,
here is the next
iteration:http://cr.openjdk.java.net/~clanger/webrevs/8213031.7/
I focused on your comments regarding implementation details:
:
Are there other major implementation points left? If not I guess we should
start refining th
Hi Alan,
here is the next iteration:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.7/
I focused on your comments regarding implementation details:
> I'm not sure about using ${user.name} and "" as default.
> Have you looked at using the zip file owner/group (or owner/owner on
> Windows) a
On 13/02/2019 22:26, Langer, Christoph wrote:
:
Also the "Zip" view of file attributes will need to be fleshed out more
(the view name for example).
I don't know if that's really necessary as the "Zip" view currently is internal
to jdk.zips and I don't propose to export it.
Not exporting it is
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
Hi Christoph
On Feb 13, 2019, at 5:30 PM, Langer, Christoph
mailto:christoph.lan...@sap.com>> wrote:
Hi Lance,
thanks for looking.
Just starting to take a peek at this and noticed one quick thing in you
Hi Christoph
> On Feb 13, 2019, at 5:30 PM, Langer, Christoph
> wrote:
>
> Hi Lance,
>
> thanks for looking.
>
>> Just starting to take a peek at this and noticed one quick thing in your
>> test:
>>
>> Paths.get(System.getProperty("test.dir", "."), "testPosix.zip")
>> ——
>>
Hi Lance,
thanks for looking.
> Just starting to take a peek at this and noticed one quick thing in your test:
>
> Paths.get(System.getProperty("test.dir", "."), "testPosix.zip")
> ——
>
> You do not need the test.dir property or the permission added to test.policy
> to access i
Hi Alan,
thanks for taking a first look into this new edition.
> I think the javadoc changes will need a few iterations but we can get to
> that once some of the finer details are sorted out. For example, "Posix
> Support" isn't quite right as this is about optional support for the
> POSIX view o
ing in a restricted environment.
>
> Module-info and CSR have been adopted, too.
>
> Thanks in advance for reviewing.
>
> Best regards
> Christoph
>
>> -Original Message-
>> From: Langer, Christoph
>> Sent: Montag, 21. Januar 2019 10:17
>>
On 12/02/2019 21:57, Langer, Christoph wrote:
Hi Alan, all,
here comes the next proposal for POSIX support in jdk.zipfs - which hopefully
represents the converged solution, at least in its overall design.
I don't have time to do a detailed code review right now but I did read
the updated propo
.
Module-info and CSR have been adopted, too.
Thanks in advance for reviewing.
Best regards
Christoph
> -Original Message-
> From: Langer, Christoph
> Sent: Montag, 21. Januar 2019 10:17
> To: 'Alan Bateman'
> Cc: nio-dev ; OpenJDK Dev list d...@openjdk.java.net>; Java
On 21/01/2019 09:17, Langer, Christoph wrote:
:
OK, I can see the point that in a PosixFileAttributeView as it is, there's no
place for optionality/null values. However, with this approach the benefits
would be that Files::get/setPosixPermissions would work and that's why I think
we should
Hi Alan,
first of all, thank you for your input on this.
> I think the approach to explore are:
>
> 1. zipfs supports PosixFileAttributeView without subsetting. If
> readAttribute(file, BasicFileAttributes.class) succeeds then
> readAttribute(file, PosixFileAttributes.class) should also succeed,
On 12/01/2019 13:02, Langer, Christoph wrote:
Hi Alan,
as I did not hear back from you I continued to work on the POSIX file
permission support for zipfs and specified/implemented the value of 'null' for
zip entries with no permission information associated (vs.
UnsupportedOperationException)
On 14/01/2019 07:42, Langer, Christoph wrote:
Hi Lance,
I was not aware of JDK-8182117 and by its description it does not fit
exactly to the updates to jdk.zipfs module documentation that I
propose. However, yes, it is probably a bit more natural to include
that part in a potential patch for
Hi Alan,
> I will try to get time next week to reply to you on this. Part of the
> issue with your current approach is that it breaks PosixFileAttribtues.
> There are also issues trying to force the API to optionally support a
> subset of POSIX attributes on some zip entries and not on others. So
On 12/01/2019 13:02, Langer, Christoph wrote:
Hi Alan,
as I did not hear back from you I continued to work on the POSIX file
permission support for zipfs and specified/implemented the value of 'null' for
zip entries with no permission information associated (vs.
UnsupportedOperationException)
nger, Christoph
>> Sent: Dienstag, 8. Januar 2019 09:27
>> To: 'Alan Bateman' ; Volker Simonis
>>
>> Cc: nio-dev ; OpenJDK Dev list > d...@openjdk.java.net>; Java Core Libs
>> Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permissions
>&g
imonis
>
> Cc: nio-dev ; OpenJDK Dev list d...@openjdk.java.net>; Java Core Libs
> Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
> Hi Alan, Volker,
>
> thanks for bringing up these discussion points. I agree that we shall
> ca
penjdk.java.net>; OpenJDK Dev list d...@openjdk.java.net>; Java Core Libs
> Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
> On 07/01/2019 19:26, Volker Simonis wrote:
> > :
> > We considered this, but it is problematic because it is perfect
On 07/01/2019 19:26, Volker Simonis wrote:
:
We considered this, but it is problematic because it is perfectly
valid to have a file with external file attributes where none of the
Posix attributes is actually set (i.e. an empty set of Posix files
attributes). This wouldn't be distinguishable from
Hi Alan,
thaks for looking at the javadoc/CSR.
On Mon, Jan 7, 2019 at 8:10 PM Alan Bateman wrote:
>
> On 07/01/2019 11:13, Langer, Christoph wrote:
>
> Hi,
>
>
>
> I’ve amended the jdk.zipfs module documentation in
> src/jdk.zipfs/share/classes/module-info.java to document the new behavior
> (
On 07/01/2019 11:13, Langer, Christoph wrote:
Hi,
I’ve amended the jdk.zipfs module documentation in
src/jdk.zipfs/share/classes/module-info.java to document the new
behavior (e.g. support of PosixFileAttributeView) as requested by
Alan. I’ve also updated the CSR.
Webrev: http://cr.openjdk
; security-dev
; SHEN, XUEMING ; Alan
Bateman ; nio-dev
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
Hi Christoph,
thanks for updating the change. I think it is in a good state now and ready to
go!
Also the documentation in the CSR for this issue
(https
On 21/12/2018 13:43, Langer, Christoph wrote:
Hi Alan,
Adding support for POSIX file permissions to the zip APIs is problematic
as we've been discussing here. There are security concerns and also
concerns that how it interacts with JAR files and signed JAR in
particular. I don't disagree that w
ithout any side effects on java.util.zip and
java.util.jar.
Please find my comments for the CSR below (for some reason I couldn't
add them to the CSR directly).
I'd really appreciate if you could reconsider reviewing Christoph's
change ("RFR 8213031: (zipfs) Add support for PO
Hi Christoph,
thanks for updating the change. I think it is in a good state now and ready
to go!
Also the documentation in the CSR for this issue (
https://bugs.openjdk.java.net/browse/JDK-8213082) is greatly appreciated
and answers all the questions which have been raised so far. So if there
are
Hi all,
here comes the updated webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.3/
I've rebased the change to the current state of the JDK depot. Thanks to
Volker, the test has been enhanced and now also tests more copy operations
(from zip file system to zip file system and from zi
Hi Alan,
> Adding support for POSIX file permissions to the zip APIs is problematic
> as we've been discussing here. There are security concerns and also
> concerns that how it interacts with JAR files and signed JAR in
> particular. I don't disagree that we can come to agreement on zipfs
> suppor
On 21/12/2018 10:41, Langer, Christoph wrote:
Hi folks,
getting back to the topic of adding POSIX file permission support to
jdk.zipfs... I think as we are now in the early stages of JDK13, it's a good
point in time to get some (hopefully final) activity on that one.
In the last review discus
> From: Chris Hegarty
> Sent: Montag, 5. November 2018 17:19
> To: Langer, Christoph ; core-libs-dev d...@openjdk.java.net>; security-...@openjdk.java.net; Xueming Shen
>
> Cc: nio-dev
> Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
>
> On
ava.base/java/nio/file/Files.html#getFileAttributeView(java.nio.file.Path,java.lang.Class,java.nio.file.LinkOption...)
>
> With class
> https://download.java.net/java/early_access/jdk11/docs/api/java.base/java/nio/file/attribute/PosixFileAttributeView.html
>
>
>
> Thanks in advance
On 05/11/18 15:59, Alan Bateman wrote:
On 05/11/2018 13:05, Langer, Christoph wrote:
...
I think you'll need to do a write-up of the overall proposal so that
folks can jump in and point out the implications. It's not easy to do
this in a code review of a small piece of the solution.
Righ
On 05/11/2018 13:05, Langer, Christoph wrote:
Hi Alan, all,
I’d welcome a discussion, for sure. Unfortunately there hasn’t been so
much participation in this yet. I think this is an item where it’s
hard to have a clear opinion and where it’s difficult to oversee all
implications it might hav
Hi Chris
> The reason I asked about the CSR scope clarification is that it was
> unclear to me what the ultimate intentions are, given that the previous
> mails ( linked to from the CSR ) did have Java SE API changes ( in the
> java.util.zip package ).
>
> Are you now happy to reduce the scope of
On 05/11/18 12:54, Langer, Christoph wrote:
Hi Chris,
yes, there's no impact on Java SE with this item. No API is changed. I've set the scope
to JDK, as it affects the features that are available with the "jar" filesystem
provider from module jdk.zipfs.
...
The reason I asked about the CSR
lling to have a look from security perspective?
Thanks & Best regards
Christoph
From: Alan Bateman
Sent: Montag, 5. November 2018 11:23
To: Langer, Christoph ; core-libs-dev
; security-...@openjdk.java.net; Xueming Shen
Cc: Volker Simonis ; nio-dev
Subject: Re: RFR 8213031: (zipfs) Add support f
rom: Chris Hegarty
> Sent: Montag, 5. November 2018 13:20
> To: Langer, Christoph ; core-libs-dev d...@openjdk.java.net>; security-...@openjdk.java.net
> Cc: nio-dev
> Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions
>
> Hi Christoph,
Hi Christoph,
On 05/11/18 07:32, Langer, Christoph wrote:
..
CSR: https://bugs.openjdk.java.net/browse/JDK-8213082
Can you please add a `Scope` value to the CSR?
I can't quite tell, but I assume it should be `JDK` or
`Implementation`, right? I want to clarify that there is
no impact on Java
On 05/11/2018 07:32, Langer, Christoph wrote:
Hi,
Ping.
May I get reviews/substantial feedback on this zipfs enhancement?
It might be bit early to be asking for a code review on just one piece
of this. I think the first step on this feature has to be to put all the
issues on the table. The
: Montag, 29. Oktober 2018 15:55
To: 'Alan Bateman' ; core-libs-dev
; security-...@openjdk.java.net; Xueming Shen
Cc: Volker Simonis ; nio-dev
Subject: RE: RFR 8213031: (zipfs) Add support for POSIX file permissions (was:
Enhance jdk.nio.zipfs to support Posix File Permissions
; nio-dev
Subject: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions (was:
Enhance jdk.nio.zipfs to support Posix File Permissions)
On 29/10/2018 09:26, Langer, Christoph wrote:
:
As per request from Alan, I'm adding security-dev to get a review from security
perspective.
F
On 29/10/2018 09:26, Langer, Christoph wrote:
:
As per request from Alan, I’m adding security-dev to get a review from
security perspective.
For security-dev then I think it would be better to write-up a summary
of the overall proposal and the implications for applications/libraries
that u
Hi,
here's an update of my webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8213031.1/
I added synchronization to the updating of permCache in ZipUtils.java to avoid
concurrent modifications.
As per request from Alan, I'm adding security-dev to get a review from security
perspective.
Than
67 matches
Mail list logo
