On 13/07/2012 01:13, Stuart Marks wrote:
But for creating a registry, createRegistry(0) will usually work the
first time. If it throws ExportException, it does so for a specific
reason, so we should retry once on an unused random port. But if this
still fails, don't think retrying repeatedly ma
Changeset: 934a89402f85
Author:mcimadamore
Date: 2012-07-13 12:58 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/934a89402f85
7181578: javac reports uninitialized variable with nested try...finally blocks
Summary: regression introduced in refactoring of Flow.java
Review
On 11/07/2012 00:11, Xueming Shen wrote:
Hi,
In JDK7, the decoder and encoder implementation of most of our
single-byte charsets
and UTF-8 charset are optimized to implement the internal interfce
sun.nio.cs.ArrayDecoder/
Encoder to provide a fastpath for String.getBytes(...) and new
String(b
On 10/07/2012 21:42, Naoto Sato wrote:
Hello,
Please review the JDK8 changes for JEP 127: Improve Locale Data
Packaging and Adopt Unicode CLDR Data
(http://openjdk.java.net/jeps/127). The webrev is located at:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
There's a lot here, lots of g
On 07/13/2012 05:19 AM, Alan Bateman wrote:
On 11/07/2012 00:11, Xueming Shen wrote:
Hi,
In JDK7, the decoder and encoder implementation of most of our
single-byte charsets
and UTF-8 charset are optimized to implement the internal interfce
sun.nio.cs.ArrayDecoder/
Encoder to provide a fastpa
Hi, Naoto.
Wow. Tons of fantastic work!
Looks like many files contain fairly trivial changes related to resources being
moved to another package, but there are many others which require more careful
review.
Scanning the list of files in the webrev, one comment pops to mind. You've
made ch
I think we need to (re)start the discussion on core-libs-dev with a
view to eliminating the patches that the JDK has to zlib, see:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/native/java/util/zip/zlib-1.2.5/patches/ChangeLog_java
One of these changes relates to the zip64 s
I think, you could drop the comma before "or" and align indentation after
@param, @return and @throws.
-Ulf
Am 30.06.2012 00:29, schrieb Stuart Marks:
Hi Core Libbers,
Please review some small wording and markup changes to the doc for String.subSequence. The wording
change is simply fixing
Anthony and Alan,
Thanks for your comments. I've reverted the changes to CommonSetup.sh so
that XToolkit is no longer forced. Tests still pass.
Please see the new webrev:
http://cr.openjdk.java.net/~juh/7162111/webrev.01/
Thanks,
Jason
On 06/25/2012 06:19 AM, Anthony Petrov wrote:
Hi Alan
Hi Jonathan
I have these questions:
1. Why always CAPITAL letters for month and weekday?
2. Why always "dd HH:mm:ss zzz " for the rest? Some locales uses "."
instead of ":" as times delimiters.
3. Why always dd after MMM? Some locales prefer dd before MMM.
Well, if you really think the
Hi Iris,
Thank you for your comment. We had a meeting with the build infra team
when Erik was here last week, so they are aware of this change. The
initial review request actually involved 'build-dev' alias besides
'i18n-dev' and 'core-libs-dev'.
Naoto
On 12/07/13 11:32, Iris Clark wrote:
2012/7/6 3:27 -0700, weijun.w...@oracle.com:
> I have these questions:
>
> ...
>
> Well, if you really think the current "Fri Jul" output is too English, instead
> of localizing the string, how about we de-localize it totally and choose a
> neutral format?
Excellent idea!
> There are several fl
Hi, Naoto.
Fantastic! Sorry I didn’t catch that 'build-dev' was in the set of reviewers.
Thanks for being on top of this.
iris
-Original Message-
From: Naoto Sato
Sent: Friday, July 13, 2012 11:59 AM
To: Iris Clark
Cc: Alan Bateman; Java Core Libs; i18n-dev
Subject: Re: [8] Review re
Am 13.07.2012 14:19, schrieb Alan Bateman:
Ulf - you've got several patches to the double byte charsets and I wonder if you have cycles to
try Sherman's patch with jdk8 to see if there is any more to be gained?
First, most of those patches have been closed from official side, don't really
un
Am 13.07.2012 14:19, schrieb Alan Bateman:
Ulf - you've got several patches to the double byte charsets and I wonder if
you have cycles to
try Sherman's patch with jdk8 to see if there is any more to be gained?
Additionally, I'm wondering, that EUC_TW is not part of the patch.
I've worked on
Something seems strange here:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
It's like someone was avoiding overall quotes, but using them to add spaces
somehow...
I sure would like to get rid of this shell logic, seems like there are lots
repeated
On 13/07/2012 20:22, Ulf Zibis wrote:
First, most of those patches have been closed from official side,
don't really understand why:
https://bugs.openjdk.java.net/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&long_desc_type=substring&long_desc=&bug_file_loc_type=a
On 07/12/2012 05:13 PM, Stuart Marks wrote:
OK, I took a look at the revised webrev. Most stuff is good. A couple
changes are necessary though.
*** MultipleRegistries.java
Not a big deal, but the comment at lines 65-67 is no longer necessary.
Comment removed.
*** TestLibrary.java
I th
Hi Kelly,
The shell script in question is pretty likely to be removed, or at least
rewritten when we make modifications for Jigsaw packaging of the locale
data. Right now the script creates the pre-baked locale list based on
the existing resource bundle source files in the repository, but that
On 7/13/12 9:22 PM, Ulf Zibis wrote:
> Am 13.07.2012 14:19, schrieb Alan Bateman:
>>
>> Ulf - you've got several patches to the double byte charsets and I wonder if
>> you have cycles to try Sherman's patch with jdk8 to see if there is any more
>> to be gained?
>
> First, most of those patches h
I am pushing this changeset but backing out the changes to
ProblemList.txt. Those tests
are still failing depending on the machine and user permissions. I have
a fair idea what is going wrong with them, and will
work on them with their associated CR (7150557).
Thanks,
Kurchi
On 7/12/2012 7:55
Changeset: e9461aeff91f
Author:khazra
Date: 2012-07-13 16:02 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9461aeff91f
7160252: (prefs) NodeAddedEvent was not delivered when new node add when new
Node
Summary: Change native code to convey to Java code whether a new node wa
On 7/13/12 1:59 AM, Alan Bateman wrote:
On 13/07/2012 01:13, Stuart Marks wrote:
But for creating a registry, createRegistry(0) will usually work the first
time. If it throws ExportException, it does so for a specific reason, so we
should retry once on an unused random port. But if this still fa
Hello all;
About a month ago a significant change was made to the Java SE 7 and 8 hash
based Map implementations. This change was previously proposed and discussed on
this list[1]. The change affects all of the hashing based Map implementations
(HashMap, Hashtable, WeakHashMap, LinkedHashMap, C
Hello,
On 7/13/2012 2:59 PM, Dalibor Topic wrote:
On 7/13/12 9:22 PM, Ulf Zibis wrote:
Am 13.07.2012 14:19, schrieb Alan Bateman:
Ulf - you've got several patches to the double byte charsets and I wonder if
you have cycles to try Sherman's patch with jdk8 to see if there is any more to
be ga
Hello,
Thanks for the patch Louis.
On 7/12/2012 3:21 AM, Andrew Haley wrote:
On 07/12/2012 10:32 AM, Louis Wasserman wrote:
It was attached to the previous message? I don't know if this list works
with attachments. Alternately, the patch was attached here:
https://bugs.openjdk.java.net/show_
26 matches
Mail list logo
