> Please review this PR which updates the Scientific Notation section of
> Decimal Format. It aims to resolve
> [JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
> [JDK-6282188](https://bugs.openjdk.org/browse/JDK-6282188).
>
> **Scientific Notation** in Decimal Format
On Mon, 22 May 2023 23:31:37 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: Use Static dfs, error message, and exponent digit. Hard code min
>> and max digits instead of calculating at
On Mon, 22 May 2023 10:22:16 GMT, Volker Simonis wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly
On Mon, 15 May 2023 00:28:41 GMT, Ichiroh Takiguchi
wrote:
> According to "JDK 20 Internationalization Guide"
> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html
> Following Solaris related charsets are in "contained in jdk.charsets module"
> list.
>
> - PCK (x-PCK)
> -
On Sat, 20 May 2023 17:26:53 GMT, Naoto Sato wrote:
>> Hello @naotoj .
>> I'd like to confirm about DoubleByte-X.java.template and
>> EUC_JP.java.template.
>> I think the values are package-private.
>> Even if class is changed to `public`, the classes in`sun.nio.cs.ext` package
>> could not
On Mon, 22 May 2023 23:03:10 GMT, Justin Lu wrote:
>> Please review this PR which updates the Scientific Notation section of
>> Decimal Format. It aims to resolve
>> [JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
>>
On Mon, 22 May 2023 20:41:29 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: Use Static dfs, error message, and exponent digit. Hard code min
>> and max digits instead of calculating at
> Please review this PR which updates the Scientific Notation section of
> Decimal Format. It aims to resolve
> [JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
> [JDK-6282188](https://bugs.openjdk.org/browse/JDK-6282188).
>
> **Scientific Notation** in Decimal Format
On Mon, 22 May 2023 22:29:18 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
On Mon, 22 May 2023 21:49:27 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 41 commits:
>>
>> - Adaptation for JDK-8308276.
>> - Merge remote-tracking branch 'origin' into
On Mon, 22 May 2023 21:22:50 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add comment about Register Save Area.
>
> src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 162:
>
>> 160:
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by
On Fri, 19 May 2023 23:08:00 GMT, Paul Sandoz wrote:
>>> This look much better. Can we strengthen the specification of
>>> `canonicalLayouts` in accordance with the class specification
>>
>> We can't do more in that method javadoc, think, as that has to be general
>> enough for all linkers.
On Mon, 22 May 2023 16:06:02 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
On Mon, 22 May 2023 21:36:12 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
>
On Mon, 22 May 2023 19:52:42 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into JDK-8307858
>> - Merge branch 'master' into JDK-8307858
>> -
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
>
On Mon, 22 May 2023 19:54:59 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into JDK-8307858
>> - Merge branch 'master' into JDK-8307858
>> -
On Sat, 20 May 2023 00:00:42 GMT, Justin Lu wrote:
> Please review this PR which updates the Scientific Notation section of
> Decimal Format. It aims to resolve
> [JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
>
On Mon, 22 May 2023 15:21:37 GMT, Per Minborg wrote:
> This PR adds a test that shows the documented way of calling `printf` works.
I'm not sure I get this: StdLibTest already tests variadic calls, and there's a
brand new javadoc section about this topic:
On Mon, 22 May 2023 14:46:02 GMT, Alan Bateman wrote:
>> Should the test be removed from ProblemList-generational-zgc.txt as part of
>> this?
>
>> @AlanBateman My thinking was to integrate this and make sure that the
>> problem doesn't resurface before removing it from the problem list. Does
On Mon, 22 May 2023 19:40:00 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Mon, 22 May 2023 19:28:26 GMT, Roger Riggs wrote:
> Thanks for the updates.
Thanks for all the comments (and the approval).
-
PR Comment: https://git.openjdk.org/jdk/pull/13957#issuecomment-1557863535
On Mon, 22 May 2023 19:21:52 GMT, Jiangli Zhou wrote:
>> Thanks @erikj79. Could you please help provide some more info on the build
>> failure:
>>
>> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
>> (a). It builds successfully for the `static-libs-image` target.
>>
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
>
On Thu, 18 May 2023 19:14:02 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Address reviewer
On Mon, 22 May 2023 19:10:57 GMT, Jiangli Zhou wrote:
> Thanks @erikj79. Could you please help provide some more info on the build
> failure:
>
> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
> (a). It builds successfully for the `static-libs-image` target.
>
>
On Fri, 19 May 2023 22:45:16 GMT, Erik Joelsson wrote:
>> make/common/NativeCompilation.gmk line 1208:
>>
>>> 1206: $$(call ExecuteWithLog,
>>> $$($1_OBJECT_DIR)/$$($1_SAFE_NAME)_partial_link, \
>>> 1207:$$($1_LD) $(LDFLAGS_CXX_PARTIAL_LINKING)
>>>
Hi Liang,
On Sun, May 21, 2023 at 11:29 PM - wrote:
> Thus, I suggest emitting static flags for the InnerClasses attribute
> of anonymous/local classes in static/pre-initialization contexts,
>
Related to your question on PR#13656 ... local/anonymous classes in a
pre-initialization context
On Tue, 4 Apr 2023 20:50:00 GMT, Andrey Turbanov wrote:
>> `Map.containsKey` call is sometimes unnecessary, when it's known that `Map`
>> doesn't contain `null` values.
>> Instead of pair containsKey+put we can use putIfAbsent and compare result
>> with null.
>> Result code is shorter and a
Thanks for the good response Remi.
This is part of a larger FAQ, “why are MHs hard to use?”
Part of the answer is “they model bytecode behavior”.
(Perhaps they should have been called BytecodeBehaviorHandles.)
Lifting such raw VM-level behaviors up into Java source code is
necessary, but it
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I don't like this approach at all. if github had a "reject" button I'd be
pushing it now.
On Mon, 22 May 2023 17:59:18 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with
On Mon, 22 May 2023 14:34:32 GMT, Per Minborg wrote:
> LGTM. Are there any additional types we might consider apart from the basic
> ones and `size_t`? Maybe one for an address pointing at `errno`?
I think there is a certain gravitational pull towards keeping the set of
guaranteed canonical
Please review these test changes which implement automatic testing of container
resource updates without JVM restart. Note that this merely tests container
detection code handling this case. It doesn't do anything special for the JVM
itself, though it might make sense to add some sanity checks
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by
On Mon, 22 May 2023 11:51:33 GMT, Maurizio Cimadamore
wrote:
> So, not only the new method results in more succinct code (compared to the
> alternatives), but it also combines symbol lookups in the "right way", so
> that the chain of lookups is defined, once and for all, when the composite
>
This PR adds a test that shows the documented way of calling `printf` works.
-
Commit messages:
- Add test for issue
Changes: https://git.openjdk.org/jdk/pull/14088/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14088=00
Issue: https://bugs.openjdk.org/browse/JDK-8307205
On Tue, 16 May 2023 13:53:32 GMT, Maurizio Cimadamore
wrote:
> As explained in [1], memory layouts and memory segments describe sizes using
> different units. Memory layouts use bits, whereas memory segments use bytes.
> This is historical: memory layouts were designed after the Minimal LDL
On Fri, 12 May 2023 12:11:23 GMT, Maurizio Cimadamore
wrote:
> This patch adds a simpler method for composing symbol lookups. It is common
> for clients to chain multiple symbol lookups together, e.g. to find a symbol
> in multiple libraries.
>
> A new instance method, namely
On Mon, 22 May 2023 13:28:24 GMT, Alan Bateman wrote:
>> Doubling the max heap size since not all GCs might have compressed OOPs, so
>> this change should make this test more robust.
>>
>> Cleared with @DougLea
>
> Should the test be removed from ProblemList-generational-zgc.txt as part of
>
On Mon, 22 May 2023 09:34:53 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Mon, 22 May 2023 10:27:04 GMT, Maurizio Cimadamore
wrote:
>> As explained in [1], memory layouts and memory segments describe sizes using
>> different units. Memory layouts use bits, whereas memory segments use bytes.
>> This is historical: memory layouts were designed after the Minimal
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I would suggest either disable warnings on per file basis or rewrite
problematic code.
On Sat, 20 May 2023 17:26:53 GMT, Naoto Sato wrote:
>> Hello @naotoj .
>> I'd like to confirm about DoubleByte-X.java.template and
>> EUC_JP.java.template.
>> I think the values are package-private.
>> Even if class is changed to `public`, the classes in`sun.nio.cs.ext` package
>> could not
On Mon, 22 May 2023 14:09:22 GMT, Martin Doerr wrote:
>> Yes, good idea.
>
> Please take a look at
> https://github.com/openjdk/jdk/pull/12708/commits/70736be631e4f1bf3fd3c0d45ddfc076b74ef9dd
It looks good.
-
PR Review Comment:
On Mon, 22 May 2023 13:59:05 GMT, Richard Reingruber wrote:
>> Or better `final boolean useABIv2 = (this instanceof ABIv2CallArranger);`
>
> Yes, good idea.
Please take a look at
https://github.com/openjdk/jdk/pull/12708/commits/70736be631e4f1bf3fd3c0d45ddfc076b74ef9dd
-
PR
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by
On Mon, 22 May 2023 13:42:27 GMT, Martin Doerr wrote:
>> Probably, yes. I didn't find time for figuring out what would be useful
>> tests. We could still add some in the future or with the big endian port.
>> Another idea: Would the following be better?
>> `final boolean useABIv2 =
On Mon, 22 May 2023 13:34:49 GMT, Martin Doerr wrote:
>>> That would be better to read, but would make the PPC64 CallArranger
>>> dependent on the current CABI. Note that there are tests which use
>>>
>>> ```
>>> import jdk.internal.foreign.abi.aarch64.CallArranger;
>>> ...
>>>
On Mon, 22 May 2023 13:29:14 GMT, Richard Reingruber wrote:
>> That would be better to read, but would make the PPC64 CallArranger
>> dependent on the current CABI.
>> Note that there are tests which use
>>
>> import jdk.internal.foreign.abi.aarch64.CallArranger;
>> ...
>>
On Mon, 22 May 2023 13:28:24 GMT, Alan Bateman wrote:
>> Doubling the max heap size since not all GCs might have compressed OOPs, so
>> this change should make this test more robust.
>>
>> Cleared with @DougLea
>
> Should the test be removed from ProblemList-generational-zgc.txt as part of
>
On Mon, 22 May 2023 13:12:02 GMT, Viktor Klang wrote:
> Doubling the max heap size since not all GCs might have compressed OOPs, so
> this change should make this test more robust.
>
> Cleared with @DougLea
Should the test be removed from ProblemList-generational-zgc.txt as part of
this?
On Mon, 22 May 2023 12:38:23 GMT, Martin Doerr wrote:
> That would be better to read, but would make the PPC64 CallArranger dependent
> on the current CABI. Note that there are tests which use
>
> ```
> import jdk.internal.foreign.abi.aarch64.CallArranger;
> ...
>
Doubling the max heap size since not all GCs might have compressed OOPs, so
this change should make this test more robust.
Cleared with @DougLea
-
Commit messages:
- JDK-8298066: Increasing max heap size for OOMEinAQS since not all GCs might
have compressed oops
Changes:
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of
> As the API has improved over the recent releases, not all `{@snippet ..}`
> sections have been kept in sync.
>
> This PR suggests all snippets used should be verified against real code that
> is placed in a new `snippet-files` folder and erroneous snippets are updated.
>
> In this PR, it is
On Mon, 22 May 2023 12:14:48 GMT, Richard Reingruber wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
>> line 65:
>>
>>> 63: */
>>> 64: public abstract class CallArranger {
>>> 65: protected abstract boolean useABIv2();
>>
>> This could also be
On Mon, 22 May 2023 08:53:21 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup imports, improve comments, updates from other platforms.
>
>
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of
On Thu, 18 May 2023 09:50:13 GMT, Chang Peng wrote:
>> In Vector API Java level, vector mask is represented as a boolean array with
>> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
>> is loaded into vector register, e.g. Neon, the in-memory format will be
>>
On Mon, 22 May 2023 10:30:27 GMT, Jaikiran Pai wrote:
>> I don't mind moving this but it would require changing them everywhere (as
>> you point out).
>
> I think it's fine to leave it in the current form then. If/when any of these
> tests fail due to unexpected exception type in these
On Mon, 22 May 2023 10:09:27 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
>> line 578:
>>
>>> 576: try {
>>> 577:
>>> scheduleInterruptAt("java.util.concurrent.ThreadPerTaskExecutor.invokeAny");
>>>
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote:
> This is a test only change to the unit test for the ExecutorService returned
> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll
> assume the threads started to execute the tasks do actually execute the task
>
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote:
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
> files to specify `Locale.ROOT` to ensure that case conversion issues don't
> occur,
>
> I didn't add any new tests but ran tier 1-3 with no issues
This pull
On Wed, 17 May 2023 20:03:37 GMT, Joe Darcy wrote:
> > > Should this issue have a CSR for any behavioral changes?
> >
> >
> > Well, you can certainly argue that every bug fix is a behavioral changes,
> > right :)
> > But seriously, I don't see how this PR could require a CSR. The only
> >
On Mon, 22 May 2023 10:11:25 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
>> line 269:
>>
>>> 267: assertTrue(executor.awaitTermination(10,
>>> TimeUnit.MILLISECONDS));
>>> 268: Throwable e =
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote:
> This is a test only change to the unit test for the ExecutorService returned
> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll
> assume the threads started to execute the tasks do actually execute the task
>
On Mon, 3 Apr 2023 16:58:15 GMT, Andrey Turbanov wrote:
> `Pattern.namedGroups` and `Matcher.namedGroups` contains only non-null
> values. It means instead of separate `containsKey`+`get` calls, we can use
> single `HashMap.get` call and then compare result with null.
> Result code is a bit
On Mon, 3 Apr 2023 16:58:15 GMT, Andrey Turbanov wrote:
> `Pattern.namedGroups` and `Matcher.namedGroups` contains only non-null
> values. It means instead of separate `containsKey`+`get` calls, we can use
> single `HashMap.get` call and then compare result with null.
> Result code is a bit
> As explained in [1], memory layouts and memory segments describe sizes using
> different units. Memory layouts use bits, whereas memory segments use bytes.
> This is historical: memory layouts were designed after the Minimal LDL [2],
> which allowed layout strings to be used to describe both
On Fri, 19 May 2023 11:24:30 GMT, Michael McMahon wrote:
> Seems like a useful change and I can see how issues could arise if strings
> were stored somewhere after being upper/lower cased and then reused in a
> different locale.
>
> Is it correct to say that the assumption is these strings
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a tiny helper program called
> `jspawnhelper` in a
On Thu, 18 May 2023 05:58:26 GMT, Thomas Stuefe wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> REALLY adding the test :)
>
> src/java.base/unix/native/libjava/childproc.c line 413:
>
>> 411: const char*
> According to "JDK 20 Internationalization Guide"
> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html
> Following Solaris related charsets are in "contained in jdk.charsets module"
> list.
>
> - PCK (x-PCK)
> - EUC_JP_Solaris (x-eucJP-Open)
> - Big5_Solaris
On Mon, 22 May 2023 09:48:15 GMT, Daniel Fuchs wrote:
> Seems strange to test invokeAny when there is only one task?
There are several tests further up that exercise invokeAny with more than one
task. This one is testing interrupt of invokeAny, we could expect it to test
interrupting with
On Mon, 22 May 2023 10:05:49 GMT, Jaikiran Pai wrote:
>> This is a test only change to the unit test for the ExecutorService returned
>> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll
>> assume the threads started to execute the tasks do actually execute the task
This patch disables temporary use of language preview features in JDK.
Temporary enabled language preview features (to allow Pattern Matching for
switch use in the Classfile API library) are no more necessary.
All redundant use of --enable-preview in the Classfile API tests are also
removed.
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote:
> This is a test only change to the unit test for the ExecutorService returned
> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll
> assume the threads started to execute the tasks do actually execute the task
>
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote:
> This is a test only change to the unit test for the ExecutorService returned
> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll
> assume the threads started to execute the tasks do actually execute the task
>
On 17/05/2023 02:33, John Hendrikx wrote:
SymbolLookup lookUp = name -> library1.find(name)
.or(() -> library2.find(name))
.or(() -> loader.find(name));
What you say is true - e.g. the fact that a lookup returns an optional
can be used to chain multiple lookups as you
> This patch adds an instance method on `Linker`, namely
> `Linker::canonicalLayouts` which returns all the layouts known by the linker
> as implementing some ABI type. For instance, if I call this on my machine
> (Linux/x64) I get this:
>
>
> jshell> import java.lang.foreign.*;
>
> jshell>
On Fri, 19 May 2023 18:54:19 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
This is a test only change to the unit test for the ExecutorService returned by
Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll assume
the threads started to execute the tasks do actually execute the task code. The
refresh in JEP 444 changed the implementation to use
On Fri, 19 May 2023 18:47:49 GMT, Martin Doerr wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
>> line 158:
>>
>>> 156: class StorageCalculator {
>>> 157: private final boolean forArguments;
>>> 158: private boolean forVarArgs = false;
On Fri, 19 May 2023 15:43:30 GMT, Roger Riggs wrote:
> Given the purpose and implementation of the readFully function, I don't see
> how it can return anything other than an error or the full requested read
> length.
@RogerRiggs it will return < requested read length if it encounters EOF -
On Wed, 17 May 2023 17:07:13 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> REALLY adding the test :)
>
> test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 106:
>
>> 104:
On Wed, 17 May 2023 17:05:54 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> REALLY adding the test :)
>
> test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 78:
>
>> 76:
On Wed, 17 May 2023 17:01:53 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> REALLY adding the test :)
>
> test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 63:
>
>> 61:
On Thu, 9 Feb 2023 13:46:14 GMT, Per Minborg wrote:
>> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for
>> values in the range [-18h, 18h] for each second that is on an even quarter
>> of an hour (i.e. at most 2*18*4+1 = 145 values).
>>
>> Instead of using a
On Mon, 22 May 2023 07:04:41 GMT, Alan Bateman wrote:
>> I think following two paragraphs belongs to `Implementation Note` too,
>> because of UNC pathname and SecurityException.
>> Is it wrong?
>
> The paragraph about that the result is filtered when checkRead is denied by
> the
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Nagata-Haruhito has updated the pull request incrementally with one additional
commit since the last revision:
Move
On Wed, 17 May 2023 17:08:34 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> REALLY adding the test :)
>
> test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java line 116:
>
>> 114:
On Mon, 22 May 2023 07:00:27 GMT, Nagata-Haruhito wrote:
>> src/java.base/share/classes/java/io/File.java line 1828:
>>
>>> 1826: * namely {@code "/"}. The set of filesystem roots is affected
>>> 1827: * by various system-level operations such as the disconnecting or
>>> 1828: *
On Fri, 19 May 2023 09:32:03 GMT, Alan Bateman wrote:
>> Nagata-Haruhito has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge branch 'File_javadoc' of https://github.com/Nagata-Haruhito/jdk
>> into File_javadoc
>> - Drop exist to
1 - 100 of 102 matches
Mail list logo
