Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing wrote: > I think it's useful if trying to trace the calls (i.e. set to 0ms). > Apparently the security manager was being used for that by some. The SM isn't called once connected so I don't think anyone could have every done that. Yes, you could se

Re: Question on why sun.management MBeans are not exported?

2023-09-06 Thread Kirk Pepperdine
Hi, It would be a shame to lose these metrics because many of them have been very useful over time and some would be even more useful with some modifications. For example, the CPU breakouts found in GC logs has been incredibly useful as a proxy measure in helping sort out other issues in system

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-06 Thread Joe Wang
On Tue, 5 Sep 2023 22:47:01 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-06 Thread 温绍锦
On Wed, 6 Sep 2023 22:22:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-06 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-06 Thread Naoto Sato
On Fri, 1 Sep 2023 22:17:00 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the >> `java.text.ChoiceFormat` specification regarding its pattern. >> >> `j.text.ChoiceFormat` provides an example pattern in the c

Re: RFR: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 [v2]

2023-09-06 Thread Alexey Semenyuk
On Wed, 6 Sep 2023 07:29:20 GMT, Matthias Baesken wrote: >> on some RHEL Linux 8.X machines , we run into errors in test >> tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below. >> It looks like these errors occur when running the jtreg tests with higher >> concurrency, I

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Mandy Chung
On Wed, 6 Sep 2023 21:35:49 GMT, Brent Christian wrote: >> Some benchmarks need the Class reference but some do not. For simplicity, >> use only walkers that retain Class reference so that all benchmarks can run >> with the default walker. > > In my mind, a "default" StackWalker (obtained fro

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Mandy Chung
On Wed, 6 Sep 2023 22:05:47 GMT, Chen Liang wrote: >> This reimplements >> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method >> handles. >> >> This API currently generates the bytecode which fails the verification >> because `new C; invokespecial A()` where the given

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-06 Thread 温绍锦
> Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toString*"

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v4]

2023-09-06 Thread Naoto Sato
On Wed, 6 Sep 2023 20:52:10 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) >> which refines the spec of `equals()` and `hashCode()` in `java.text.Format` >> related classes. >> >> The current spec for most of these methods is either "_Ove

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Chen Liang
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote: > This reimplements > `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method > handles. > > This API currently generates the bytecode which fails the verification > because `new C; invokespecial A()` where the given clas

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths

2023-09-06 Thread Brian Burkhalter
On Wed, 6 Sep 2023 21:40:14 GMT, Brian Burkhalter wrote: > No `File` methods aside from `getCanonicalPath` are affected. That is to say, other than `GetCanonicalFile`, of course. - PR Comment: https://git.openjdk.org/jdk/pull/15603#issuecomment-1709178997

RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths

2023-09-06 Thread Brian Burkhalter
In the Windows implementation of java.io.File.getCanonicalPath, strip any long path or UNC prefix before canonicalizing the remainder of the pathname. - Commit messages: - 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths Changes: https://git.ope

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths

2023-09-06 Thread Brian Burkhalter
On Wed, 6 Sep 2023 21:38:39 GMT, Brian Burkhalter wrote: > In the Windows implementation of java.io.File.getCanonicalPath, strip any > long path or UNC prefix before canonicalizing the remainder of the pathname. No `File` methods aside from `getCanonicalPath` are affected. The existing `GetCan

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Brent Christian
On Tue, 5 Sep 2023 17:52:44 GMT, Mandy Chung wrote: >> test/micro/org/openjdk/bench/java/lang/StackWalkBench.java line 64: >> >>> 62: default -> throw new IllegalArgumentException(name); >>> 63: }; >>> 64: } >> >> The previous `WALKER_DEFAULT` would not have retained the

Re: RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v4]

2023-09-06 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720) > which refines the spec of `equals()` and `hashCode()` in `java.text.Format` > related classes. > > The current spec for most of these methods is either "_Overrides > _" or are incomplete/wrong (i.e. see `ChoiceFor

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v8]

2023-09-06 Thread Mandy Chung
On Wed, 30 Aug 2023 22:01:28 GMT, Brent Christian wrote: >> Mandy Chung has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - update mode to be int rather than long >> - update tests >> - Review feedback on javadoc > > src/java.base/shar

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Mandy Chung
On Wed, 6 Sep 2023 19:51:07 GMT, ExE Boss wrote: >> What are you referring to "to implement serialization"? It's only used by >> ReflectionFactory. > > It’s called from the implementation of  > `JavaLangInvokeAccess::serializableConstructor`, which is called by  > `jdk.internal.reflect.Reflect

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread ExE Boss
On Wed, 6 Sep 2023 19:47:19 GMT, Mandy Chung wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 3534: >> >>> 3532: * This method is only used to implement the unsupported >>> 3533: * >>> sun.reflect.ReflectionFactory::newConstructorForSerialization

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-06 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Mandy Chung
On Wed, 6 Sep 2023 19:31:22 GMT, ExE Boss wrote: >> This reimplements >> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method >> handles. >> >> This API currently generates the bytecode which fails the verification >> because `new C; invokespecial A()` where the given c

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread ExE Boss
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote: > This reimplements > `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method > handles. > > This API currently generates the bytecode which fails the verification > because `new C; invokespecial A()` where the given clas

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread ExE Boss
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote: > This reimplements > `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method > handles. > > This API currently generates the bytecode which fails the verification > because `new C; invokespecial A()` where the given clas

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Claes Redestad
On Wed, 6 Sep 2023 16:10:23 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/util/HexFormat.java line 644: >> >>> 642: return (char)('a' - 10 + value); >>> 643: } >>> 644: return (char)('A' - 10 + value); >> >> Not sure if this would adversely impact pe

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Claes Redestad
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

RFR: 8315810: Reimplement ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Mandy Chung
This reimplements `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method handles. This API currently generates the bytecode which fails the verification because `new C; invokespecial A()` where the given class `C` and invoke a no-arg constructor of `C`'s first non-`Seriali

Integrated: 8314604: j.text.DecimalFormat behavior regarding patterns is not clear

2023-09-06 Thread Justin Lu
On Fri, 18 Aug 2023 21:28:34 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607) > which clarifies the behavior of patterns in regards to the max integer > digits in j.text.DecimalFormat. > > The current specification (of `applyPattern`) states

Re: RFR: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-06 Thread Martin Doerr
On Wed, 6 Sep 2023 14:47:20 GMT, Matthias Baesken wrote: > The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even > when it succeeds the test takes a lot of time and is close to timing out. > Probably we should increase the timeout value for this test. LGTM. -

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Roger Riggs
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: Question on why sun.management MBeans are not exported?

2023-09-06 Thread Alan Bateman
On 06/09/2023 16:17, Volker Simonis wrote: : I'm familiar with JEP 260. But wouldn't you agree that an "encapsulated" monitoring API is an oxymoron? A monitoring API is by design intended for external usage and completely useless to the platform itself. There's no single usage of the "sun.managem

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 16:49:39 GMT, Chris Plummer wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should re

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread 温绍锦
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: Question on why sun.management MBeans are not exported?

2023-09-06 Thread mandy . chung
On 9/6/23 8:17 AM, Volker Simonis wrote: Anyway, if you classify the MBeans in "sun.management" as non-critical internal APIs (with respect to JEP 260) but without any "internal" usage, than we should really remove them, right, because an internal API without any internal usage doesn't make any

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Quan Anh Mai
On Wed, 6 Sep 2023 16:51:51 GMT, 温绍锦 wrote: >> I'd be more comfortable replacing the use of Unsafe with either the >> ByteArray functions or VarHandles. >> Using VarHandles will enable future optimizations, whereas Unsafe is a >> primitive tool and is brittle. > >> I'd be more comfortable repla

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-09-06 Thread Srinivas Vamsi Parasa
On Wed, 30 Aug 2023 15:10:45 GMT, Srinivas Vamsi Parasa wrote: >>> Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java >>> is triggering the intrinsic without additional flags >> >> Just to add that Sorting.java has short and long run modes. The default when >> running

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v9]

2023-09-06 Thread Mandy Chung
On Thu, 31 Aug 2023 23:17:02 GMT, Brent Christian wrote: >> Mandy Chung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - Merge >> - Remove the new getInstance method taking varargs >> - update mode to be int

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread 温绍锦
On Wed, 6 Sep 2023 16:10:27 GMT, Roger Riggs wrote: > I'd be more comfortable replacing the use of Unsafe with either the ByteArray > functions or VarHandles. Using VarHandles will enable future optimizations, > whereas Unsafe is a primitive tool and is brittle. I also agree that using VarHand

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v10]

2023-09-06 Thread Mandy Chung
> 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some > frameworks > like logging may only interest in

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Chris Plummer
On Wed, 6 Sep 2023 16:06:29 GMT, Erik Joelsson wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should re

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v3]

2023-09-06 Thread Qing Xiao
> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in > `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, > `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use on > com.sun.tools.classfile and should be converted to Classfile API. Qing Xiao has updated the pul

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-06 Thread Leo Korinth
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Roger Riggs
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Claes Redestad
On Wed, 6 Sep 2023 15:29:45 GMT, Raffaello Giulietti wrote: >> This PR seeks to improve formatting of hex digits using >> `java.util.HexFormat` somewhat. >> >> This is achieved getting rid of a couple of lookup tables, caching the >> result of `HexFormat.of().withUpperCase()`, and removing ti

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Erik Joelsson
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote: > I wonder if this is the right thing to do for the hprof files. I believe they > originated from some hprof tools that we no longer ship. 3rd parties might > choose to integrate them into their own tools. Do you think I should revert them?

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Claes Redestad
On Wed, 6 Sep 2023 15:34:54 GMT, Roger Riggs wrote: >> This PR seeks to improve formatting of hex digits using >> `java.util.HexFormat` somewhat. >> >> This is achieved getting rid of a couple of lookup tables, caching the >> result of `HexFormat.of().withUpperCase()`, and removing tiny alloca

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Paul Sandoz
On Wed, 6 Sep 2023 10:50:59 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/foreign/Linker.java line 152: >> >>> 150: * >>> 151: * The following table shows some examples of how C types are modelled >>> in Linux/x64 (all the examples provided >>> 152: * here will assume the

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Iris Clark
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-06 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:31:36 GMT, Alan Bateman wrote: > > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling > > https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event > > generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, > > event

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Claes Redestad
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Roger Riggs
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny allocati

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Raffaello Giulietti
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny allocati

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread 温绍锦
On Wed, 6 Sep 2023 10:20:17 GMT, Quan Anh Mai wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> update copyright date info > > We can consolidate the implementation of `Integer::toString` and > `Integer::toUnsignedString` by

Re: Question on why sun.management MBeans are not exported?

2023-09-06 Thread Volker Simonis
On Wed, Sep 6, 2023 at 3:47 PM Alan Bateman wrote: > > On 06/09/2023 14:02, Volker Simonis wrote: > > : > > > > I wonder why "sun.management" was encapsulated in the first place? I > > understand that it is not an "officially supported" API, but I find it > > still quite useful. > sun.management.*

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing [v3]

2023-09-06 Thread Alan Bateman
> In the virtual thread implementation, thread identity switches to the carrier > before freezing and switches back to the virtual thread after thawing. This > was a forced move due to issues getting JVMTI to work with virtual threads. > JVMTI can now hide events during transitions so we can inv

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-06 Thread Adam Sotona
> This PR improved Classfile API attributes handling safety by introduction of > attribute stability indicator > and by extension of UnknownAttributesOption to more general > AttributesProcessingOption. Adam Sotona has updated the pull request incrementally with one additional commit since the

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-06 Thread Adam Sotona
On Wed, 6 Sep 2023 13:54:28 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> magic moved to Util::isAttributeAllowed and fixed possible NPE > > src/java.base/share/classes/jdk/internal/classfile/impl/Ab

RFR: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-06 Thread Matthias Baesken
The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even when it succeeds the test takes a lot of time and is close to timing out. Probably we should increase the timeout value for this test. - Commit messages: - JDK-8315751 Changes: https://git.openjdk.org/jdk/

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread 温绍锦
On Wed, 6 Sep 2023 10:20:17 GMT, Quan Anh Mai wrote: > We can consolidate the implementation of `Integer::toString` and > `Integer::toUnsignedString` by taking the absolute value of the signed > integer and move the later operation to unsigned domain. This helps remove > the need of relying on

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v2]

2023-09-06 Thread Adam Sotona
On Wed, 6 Sep 2023 08:10:12 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed tests > > src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPool.java > line 76: > >> 74:

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v2]

2023-09-06 Thread ExE Boss
On Wed, 6 Sep 2023 12:28:05 GMT, Adam Sotona wrote: >> This PR improved Classfile API attributes handling safety by introduction of >> attribute stability indicator >> and by extension of UnknownAttributesOption to more general >> AttributesProcessingOption. > > Adam Sotona has updated the pull

Re: Question on why sun.management MBeans are not exported?

2023-09-06 Thread Alan Bateman
On 06/09/2023 14:02, Volker Simonis wrote: : I wonder why "sun.management" was encapsulated in the first place? I understand that it is not an "officially supported" API, but I find it still quite useful. sun.management.* is JDK internal so not something for code outside the JDK to use directly

RFR: 8315789: Minor HexFormat performance improvements

2023-09-06 Thread Claes Redestad
This PR seeks to improve formatting of hex digits using `java.util.HexFormat` somewhat. This is achieved getting rid of a couple of lookup tables, caching the result of `HexFormat.of().withUpperCase()`, and removing tiny allocation that happens in the `formatHex(A, byte)` method. Improvements r

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v2]

2023-09-06 Thread ExE Boss
On Tue, 5 Sep 2023 15:25:04 GMT, Adam Sotona wrote: >> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` >> methods are confusing and unsafe to use without knowledge of constant pool >> specification. >> This patch renames `ConstantPool::entryCount` to `ConstantPool::siz

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alexey Ivanov
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v25]

2023-09-06 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Question on why sun.management MBeans are not exported?

2023-09-06 Thread Volker Simonis
Hi, I recently looked for an easy way to get the CPU time spent by JIT-compiler and GC threads in Java (e.g exported by IBM J9's JvmCpuMonitorMXBean [0]). An easy way to achieve this is in OpenJDK is by using the "sun.management.HotspotInternal" MBean which exports the "sun.management:type=Hotspot

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v2]

2023-09-06 Thread Adam Sotona
> This PR improved Classfile API attributes handling safety by introduction of > attribute stability indicator > and by extension of UnknownAttributesOption to more general > AttributesProcessingOption. Adam Sotona has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v14]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Daniel Fuchs
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

RFR: 8315696: SignedLoggerFinderTest.java test failed

2023-09-06 Thread Sean Coffey
Update the recently added LoggerFinder tests to cater for a possible condition where the test finishes before the boot logger executor service has flushed its pending data. By simulating a slow thread in the ExecutorService used in BootstrapLogger, I was able to reproduce the issue described. A

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v13]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:01:00 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8315096: Allowed access modes in memory segment should depend on layout >> alignment >> >>Reviewed-by: psandoz

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
On Wed, 6 Sep 2023 10:46:33 GMT, Martin Doerr wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in doc >> >> Co-authored-by: Paul Sandoz > > Please adapt the new `LinuxPPC64Linker` when merging: > > di

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Martin Doerr
On Wed, 6 Sep 2023 10:04:35 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign). T

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v12]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8310929: Optimization for Integer.toString [v20]

2023-09-06 Thread Quan Anh Mai
On Tue, 5 Sep 2023 00:10:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Re: RFR: 8315585: Optimization for decimal to string [v4]

2023-09-06 Thread 温绍锦
On Wed, 6 Sep 2023 03:34:04 GMT, 温绍锦 wrote: >> BigDecimal is a commonly used class in business development, It is often >> necessary to perform toString or toPlainString operations on BigDecimal. >> >> The current version uses StringBuilder resulting in multiple memory >> allocations, I made a

Re: RFR: 8315585: Optimization for decimal to string [v5]

2023-09-06 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:10:47 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8315096: Allowed access modes in memory segment should depend on layout >> alignment >> >>Reviewed-by: psandoz

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v11]

2023-09-06 Thread Jorn Vernee
On Tue, 5 Sep 2023 21:56:54 GMT, Paul Sandoz wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in doc >> >> Co-authored-by: Paul Sandoz > > src/java.base/share/classes/java/lang/invoke/MethodHandles.jav

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v2]

2023-09-06 Thread Adam Sotona
On Tue, 5 Sep 2023 23:33:05 GMT, Chen Liang wrote: >> Qing Xiao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> migrate >> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java use >> Classfile API > > test/jdk/tools/lib/

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 08:18:45 GMT, JoKern65 wrote: > After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bugs.op

Integrated: 8315579: SPARC64 builds are broken after JDK-8304913

2023-09-06 Thread Aleksey Shipilev
On Mon, 4 Sep 2023 07:28:03 GMT, Aleksey Shipilev wrote: > Similar to other issues in the same area. I have no SPARC machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after t

Re: RFR: 8315579: SPARC64 builds are broken after JDK-8304913

2023-09-06 Thread Aleksey Shipilev
On Mon, 4 Sep 2023 07:28:03 GMT, Aleksey Shipilev wrote: > Similar to other issues in the same area. I have no SPARC machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after t

Integrated: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API

2023-09-06 Thread Martin Doerr
On Thu, 24 Aug 2023 13:56:12 GMT, Martin Doerr wrote: > I've found a way to solve the remaining FFI problem on linux PPC64 Big > Endian. Large structs (>8 Bytes) which are passed in registers or on stack > require shifting the Bytes in the last slot if the size is not a multiple of > 8. This P

RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX

2023-09-06 Thread JoKern65
After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , the following test started to fail on AIX : com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; The problem was described in [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try of a fix. A s

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Tue, 5 Sep 2023 23:15:53 GMT, Jonathan Gibbons wrote: > One has to wonder about the `**/*_OLD.java` files, but that would be a > different cleanup The IBM double byte charsets were re-implemented in JDK 7. I think the old implementations moved to the test tree so it could be used to test th

Re: RFR: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 [v2]

2023-09-06 Thread Matthias Baesken
On Fri, 1 Sep 2023 15:40:00 GMT, Alexey Semenyuk wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove output from PackageTest.java > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 7

Re: RFR: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 [v2]

2023-09-06 Thread Matthias Baesken
> on some RHEL Linux 8.X machines , we run into errors in test > tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below. > It looks like these errors occur when running the jtreg tests with higher > concurrency, I did not see them when running just the single test. > > When a