On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
Shaojin Wen has updated the pull request incrementally
On Mon, 16 Oct 2023 22:27:34 GMT, Shaojin Wen wrote:
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote:
>> CLDR provides very few short names for time zones, such as PST/PDT. This
>> will typically end up substituting names from the COMPAT provider. Once the
>> COMPAT is removed, they will be displayed in the GMT format, i.e.,
>> GMT+XX:YY.
On Mon, 16 Oct 2023 17:01:20 GMT, Matthew Donovan wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote:
> The open nroff manpage files are out of sync with their closed markdown
> sources and need to be refreshed.
>
> The changes to apply are coming from:
>
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> to
> CLDR provides very few short names for time zones, such as PST/PDT. This will
> typically end up substituting names from the COMPAT provider. Once the COMPAT
> is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY.
> Although some of the short names in the COMPAT provider are
On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev wrote:
> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
> CLI options to jpackage to provide signing identity directly to `codesign`
> and `productbuild` tools as per CSR
>
On Mon, 16 Oct 2023 16:20:49 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has updated the pull request
When calling String::newStringNoRepl and String::getBytesNoRepl, we need to use
try...catch to handle CharacterCodingException and throw
IllegalArgumentException instead of CharacterCodingException to make the
calling code cleaner.
-
Commit messages:
- Make the NoRepl methods
On Tue, 19 Sep 2023 21:55:24 GMT, Brian Burkhalter wrote:
>> Windows 11 does not reserve as many names as prior versions of Windows so do
>> not expect exceptions for COM7 and LPT1.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last
On Mon, 16 Oct 2023 19:24:51 GMT, Jorn Vernee wrote:
> Ok. I'm assuming there are currently some failing tests due to the mismatch
> in ABI? (assuming the test libraries are compiled for the packed ABI)
We should be careful with the names:
- "#pragma align (power)" is the default which is
On Mon, 16 Oct 2023 06:02:02 GMT, Alan Bateman wrote:
>> The open nroff manpage files are out of sync with their closed markdown
>> sources and need to be refreshed.
>>
>> The changes to apply are coming from:
>>
>> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN,
On Mon, 16 Oct 2023 20:36:42 GMT, Naoto Sato wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> No longer localize printed numbers
>
> test/jdk/java/util/Formatter/BasicDateTime.java line 473:
>
>> 471:
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix typo
-
Changes:
- all:
> Please review this PR as a fix of
> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
> bug with after @ignore annotation.
Agnibho Hom Chowdhury has updated the pull request incrementally with one
additional commit since the last revision:
Update full name
On Mon, 9 Oct 2023 23:21:57 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 16 Oct 2023 16:19:41 GMT, Maurizio Cimadamore
wrote:
> This PR fixes a wrong reference to the JLS memory model section.
Marked as reviewed by jvernee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16204#pullrequestreview-1680886449
On Mon, 16 Oct 2023 16:57:04 GMT, Maurizio Cimadamore
wrote:
> We could, if desired, also keep the old references (and text!) too - but IMHO
> it is a bit confusing to be talking about access control when mentioning
> access to off-heap memory, so maybe it would be better to leave those out?
CLDR provides very few short names for time zones, such as PST/PDT. This will
typically end up substituting names from the COMPAT provider. Once the COMPAT
is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. Although
some of the short names in the COMPAT provider are somewhat
On Mon, 16 Oct 2023 15:54:12 GMT, Martin Doerr wrote:
> I have filed a subtask to handle the tests:
> https://bugs.openjdk.org/browse/JDK-8318175 This PR is now compatible with
> "#pragma align (natural)", but permits layouts according to the default
> setting. This allows writing Java code
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
On Fri, 13 Oct 2023 12:18:53 GMT, Agnibho Hom Chowdhury
wrote:
>> Please review this PR as a fix of
>> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
>> bug with after @ignore annotation.
>
> Agnibho Hom Chowdhury has updated the pull request incrementally with
> This PR finalizes the feature of unnamed variables and patterns.
Aggelos Biboudis has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additional
On Mon, 16 Oct 2023 14:41:40 GMT, Maurizio Cimadamore
wrote:
>> Please take a look at commit number 4. I think we need to support both,
>> 4-byte and 8-byte aligned doubles in structures. IBM recommends to use
>> "#pragma align (natural)": "The power suboption is the default to ensure
>>
On Wed, 20 Sep 2023 03:32:55 GMT, yaqsun wrote:
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
> tools/jpackage/linux/LinuxResourceTest.java.
> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
> But after 8314121,
On Fri, 13 Oct 2023 09:33:28 GMT, Raffaello Giulietti
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix duplicate method name and add a new test in
>> PrimitivePatternsSwitchErrors
>
>
On Thu, 12 Oct 2023 20:42:50 GMT, Vicente Romero wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix duplicate method name and add a new test in
>> PrimitivePatternsSwitchErrors
>
>
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request with a new target base due to a
> This PR refactors the SSLSocketParametersTest by removing
> redundant/unnecessary classes and cleans up the logic around expected
> exceptions.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
retained a reference to the RMI
On Mon, 16 Oct 2023 16:19:41 GMT, Maurizio Cimadamore
wrote:
> This PR fixes a wrong reference to the JLS memory model section.
The broken reference seems to have originated from a bogus
On Mon, 16 Oct 2023 15:17:10 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert source
>> - Revert @since 22
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1691:
>
On Sun, 15 Oct 2023 23:46:45 GMT, Chen Liang wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Blessed order
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 227:
>
>> 225: for
This PR fixes a wrong reference to the JLS memory model section.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk/pull/16204/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16204=00
Issue: https://bugs.openjdk.org/browse/JDK-8318180
Stats: 2 lines in
On Wed, 4 Oct 2023 20:35:25 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Mon, 16 Oct 2023 14:06:09 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has updated the pull request
On Mon, 18 Sep 2023 00:48:26 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/util/Formatter.java line 3420:
>>
>>> 3418: && fmt.a instanceof StringBuilder sb
>>> 3419: ) {
>>> 3420: sb.append(value);
>>
>> There's a lot of `if`s here,
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
There's a lot of duplication exposed here
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since the last
On Mon, 18 Sep 2023 02:59:06 GMT, Shaojin Wen wrote:
>> The change code of print fast-path has been deleted, and parse fast-path has
>> added support for the pattern "%8.3f".
>>
>> Where to draw the line of parse fast-path? I have seen patterns that cause
>> performance problems, and they can
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Tue, 19 Sep 2023 16:15:12 GMT, Roger Riggs wrote:
> There's a lot of duplication exposed here between the `digits` method and the
> `getCharsLatin1` method that should be resolved. Can the callers of
> `getCharsLatin1` be converted to use `digits`?
>
> We also should keep HexDigits and
On Mon, 16 Oct 2023 15:23:25 GMT, Jim Laskey wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are
On Wed, 27 Sep 2023 19:51:25 GMT, Raffaello Giulietti
wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>>
On Fri, 22 Sep 2023 11:37:18 GMT, Chen Liang wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
>
On Fri, 22 Sep 2023 12:09:48 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/FormatItem.java line 148:
>>
>>> 146: int length = DecimalDigits.stringSize(value);
>>> 147: this.digits = new byte[length];
>>> 148:
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
@cl4es can you help me to review this PR?
On Fri, 22 Sep 2023 13:50:37 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 115:
>>
>>> 113: }
>>> 114: return 10 + d;
>>> 115: }
>>
>> @wenshao How about of using
>>
On Fri, 22 Sep 2023 04:46:36 GMT, Chen Liang wrote:
> Do Octal and Hex digits need int versions of getChars and stringSize?
Since DecimalDigits made this change, for consistency, Octal and Hex digits
also do the same thing.
-
PR Comment:
On Mon, 25 Sep 2023 12:20:36 GMT, Shaojin Wen wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify
On Mon, 25 Sep 2023 12:20:36 GMT, Shaojin Wen wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify
On Mon, 25 Sep 2023 11:36:10 GMT, Shaojin Wen wrote:
> The reason why I split it into multiple small methods is to avoid a single
> method codeSize > 325. After merging small methods, the performance will
> decrease.
Yes, I can refactor to keep the same structure and verify performance is
> Update String Templates for a second preview. With the addition of
>
> - Expression type and throws are determined from the `process` method of the
> processor type and not the processor type.
>
> - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and
> `RAW` .
>
> - Raw
On Mon, 25 Sep 2023 12:28:06 GMT, Claes Redestad wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
On Fri, 22 Sep 2023 11:53:18 GMT, Andriy Plokhotnyuk wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
>
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
The `throws Throwable` declarations are no
On Mon, 25 Sep 2023 11:46:36 GMT, Claes Redestad wrote:
> > The reason why I split it into multiple small methods is to avoid a single
> > method codeSize > 325. After merging small methods, the performance will
> > decrease.
>
> Yes, I can refactor to keep the same structure and verify
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
Changes requested by jlaskey (Reviewer).
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
Changes requested by wick...@github.com
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
Changes requested by liach (Author).
On Fri, 22 Sep 2023 15:27:51 GMT, Raffaello Giulietti
wrote:
>> A new paper
>>
>> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
>> Quadruple Precision"
>> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
>>
@cl4es made performance optimizations for the simple specifiers of
String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the same
idea, I continued to make improvements. I made patterns like %2d %02d also be
optimized.
The following are the test results based on MacBookPro M1
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
>
1. Reduce duplicate stringSize code
2. Move java.lang.StringLatin1.getChars to
jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
packages also need to use this method
-
Commit messages:
- Revert FormatItem related changes
- restore
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
>
A new paper
"Accuracy of Mathematical Functions in Single, Double, Double Extended, and
Quadruple Precision"
by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
https://members.loria.fr/PZimmermann/papers/accuracy.pdf
details the inputs with generate the worst-case observed errors in
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't
On Mon, 16 Oct 2023 13:57:11 GMT, Martin Doerr wrote:
>> Err, actually using `member.equals(C_DOUBLE)` in the above doesn't work
>> since it still checks alignment. What you have with checking for
>> `ValueLayout` and `carrier() == double.class` is better, but the byte order
>> should also be
On Mon, 16 Oct 2023 14:27:05 GMT, Alan Bateman wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are
On Mon, 16 Oct 2023 13:41:55 GMT, Jim Laskey wrote:
> Update String Templates for a second preview. With the addition of
>
> - Expression type and throws are determined from the `process` method of the
> processor type and not the processor type.
>
> - Qualified `STR` and `RAW` are treated
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since the last
On Sat, 14 Oct 2023 18:01:00 GMT, Jorn Vernee wrote:
>> I was thinking something like this:
>>
>>
>> diff --git
>> a/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> b/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> index
Update String Templates for a second preview. With the addition of
- Expression type and throws are determined from the `process` method of the
processor type and not the processor type.
- Qualified `STR` and `RAW` are treated the same as unqualified `STR` and `RAW`
.
- Raw (generic) process
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Fri, 29 Sep 2023 16:42:37 GMT, Severin Gehwolf wrote:
> The command line options to override and change the error to a warning or
> silently ignore seems to be "-run-time-ignore-single-hop" and
> "--run-image-only-warnings". Maybe it should be reduced to just one option
> and maybe it
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor according to rgiulietti's suggestion and add testcases
>
> Meaningful external reviews take a _lot_ of
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Wed, 11 Oct 2023 13:53:58 GMT, Matthew Donovan wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request with a new target base due to a
>
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
> Hi,
>
> Could I have a review of an enhancement that replaces the use of ASM with the
> new Class-File API. This change only deals with bytecode that writes event
> data into buffers. Bytecode transformations carried out by classes in
> jdk.jfr.internal.intrument package are kept as is. Plan
On Wed, 11 Oct 2023 13:53:58 GMT, Matthew Donovan wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request with a new target base due to a
>
On Thu, 12 Oct 2023 06:01:41 GMT, Shaojin Wen wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> No longer localize printed numbers
>
> # Summary
> Keep the behavior of String.format('%tF') when printing LocalDate
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote:
> The open nroff manpage files are out of sync with their closed markdown
> sources and need to be refreshed.
>
> The changes to apply are coming from:
>
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> to
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
1 - 100 of 109 matches
Mail list logo
