On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote:
> The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since
> JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to
> throw UnsupportedOperationException unconditionally in Java 19/20. Early in
> Java
On Mon, 20 Nov 2023 19:48:20 GMT, Alan Bateman wrote:
> This API is sitting out JDK 22, meaning no API/implementation changes in this
> PR. We expect this API to do a third preview in JDK 23 with some API changes.
>
> So for now, we just need to bump JEP number/title that shows up in the
>
On Fri, 24 Nov 2023 17:13:30 GMT, Jaikiran Pai wrote:
>> Tests using ProcessTools.executeProcess gets the following output written to
>> stdout:
>> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
>> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process
> 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently
> on Windows in verifyDescription
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
fix utf8 representation
-
Changes:
- all:
8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently on
Windows in verifyDescription
-
Commit messages:
- 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently
on Windows in verifyDescription
Changes:
On Mon, 20 Nov 2023 19:48:20 GMT, Alan Bateman wrote:
> This API is sitting out JDK 22, meaning no API/implementation changes in this
> PR. We expect this API to do a third preview in JDK 23 with some API changes.
>
> So for now, we just need to bump JEP number/title that shows up in the
>
Thanks for the feedback, Svein -- it is much appreciated!
In my mind, the default expectation on Java interfaces is that there is no
specified order of invocation around the exposed methods, and unless explicitly
stated otherwise it has to be presumed that any order is fine.
Given that, and
Tested the Gatherer implementation, and it is a very nice work.
I have always wanted a way of writing my own stream operations and also have
incomplete composable pipelines which could be combined in different ways. Very
interesting.
The four Gatherer functions -
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> accesses as long as the memory is alive. They can both create
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Wed, 22 Nov 2023 18:28:30 GMT, Eirik Bjorsnos wrote:
> Reviewer time is a scarce resource. It would be wasteful to spend review
> cycles on getting a fix of this `.sh` test integrated now and then
> immediately follow up with a delete in the rewrite PR.
>
> I think we should handle this
On Fri, 24 Nov 2023 13:22:07 GMT, Kevin Walls wrote:
>> OK - sounds good. Meanwhile I had a look at the custom RMI Socket Factories
>> used by the JMX Agent, and these are actually RMIServerSocketFactories, so
>> having a timeout for connect there probably makes no sense.
>
> Thanks, yes so
On Fri, 24 Nov 2023 13:06:05 GMT, David Holmes wrote:
> I can't help but feel that if you disable this output then you are going to
> be missing it in the cases that you need it! Something will go wrong and
> there won't be enough info in the log to know what it was.
My experience is that I
8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
-
Commit messages:
- 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
Changes: https://git.openjdk.org/jdk/pull/16810/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16810=00
Issue:
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> *
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote:
>> The recent cdb versions do not support `.dump /f`:
>>
>> *
>> * .dump /f is not supported on a user mode process. *
>> *
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> accesses as long as the memory is alive. They can both create
On Fri, 24 Nov 2023 13:01:59 GMT, Daniel Fuchs wrote:
>> OK yes, we also have:
>> java.rmi/share/classes/javax/rmi/ssl/SslRMIClientSocketFactory.java
>> with its own createSocket(String host, int port) method. This is used if we
>> use JMX over SSL.
>>
>> So SslRMIClientSocketFactory could
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote:
>> The recent cdb versions do not support `.dump /f`:
>>
>> *
>> * .dump /f is not supported on a user mode process. *
>> *
On Fri, 24 Nov 2023 12:04:01 GMT, Daniel Jeliński wrote:
> Yes, with `/mA` the command exits as soon as the dump is completed. I
> couldn't find a way to make `cdb` not enter interactive mode on unrecognized
> parameter, so I left that part as is.
Okay, maybe it can be figured out another
On Fri, 24 Nov 2023 12:58:50 GMT, David Holmes wrote:
> Looks good to me. I'm okay with removing the suspend/resume text from the
> deprecation page - no point trying to explain a 25+ year history.
Thanks, would you mind reviewing the CSR too? (The fixVersion is set to 23 so
the skara bots
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Fri, 24 Nov 2023 12:55:26 GMT, David Holmes wrote:
> You didn't really need to rename the test even though there is now only one
> degraded method left.
True but it's wasn't good name for a test that only exercises one method.
> test/jdk/java/nio/channels/SocketChannel/SendUrgentData.java
On Fri, 24 Nov 2023 12:13:56 GMT, Kevin Walls wrote:
>> (Look for socket factories in the module `jdk.management.agent`)
>
> OK yes, we also have:
> java.rmi/share/classes/javax/rmi/ssl/SslRMIClientSocketFactory.java
> with its own createSocket(String host, int port) method. This is used if we
On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote:
> The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since
> JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to
> throw UnsupportedOperationException unconditionally in Java 19/20. Early in
> Java
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Fri, 24 Nov 2023 11:00:18 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove Test
>
> src/java.base/share/classes/java/lang/Class.java line 4797:
>
>> 4795: PublicMethods.MethodList
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote:
>> The recent cdb versions do not support `.dump /f`:
>>
>> *
>> * .dump /f is not supported on a user mode process. *
>> *
On Thu, 23 Nov 2023 17:21:02 GMT, Daniel Fuchs wrote:
>>> This is a stack from a test I was experimenting with, when it did see the
>>> timeout:
>>
>> Ah - that's for testing with a particular test. So the question now is:
>>
>> Should the RMISocketFactories provided / implemented in the JMX
On Fri, 24 Nov 2023 11:36:27 GMT, Alan Bateman wrote:
>> It's ignoring the rest of the command line after `/f`, which means it
>> ignores the `;qd` (quit and detach) part and enters the interactive mode.
>
>> It's ignoring the rest of the command line after `/f`, which means it
>> ignores the
On Fri, 24 Nov 2023 11:33:57 GMT, Daniel Jeliński wrote:
> It's ignoring the rest of the command line after `/f`, which means it ignores
> the `;qd` (quit and detach) part and enters the interactive mode.
Wonderful :-)Does switching to `/mA` change that?
-
PR Review Comment:
On Fri, 24 Nov 2023 10:28:30 GMT, Alan Bateman wrote:
>> good point, 10 minutes should be more than enough. I'll update.
>
> Out of curiosity, do we know why it takes more than an hour? Is it attempting
> to connect to the Microsoft symbol server?
It's ignoring the rest of the command line
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote:
>> The recent cdb versions do not support `.dump /f`:
>>
>> *
>> * .dump /f is not supported on a user mode process. *
>> *
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Fri, 24 Nov 2023 07:57:41 GMT, Alan Bateman wrote:
> I use the jdk_core test group. I know the split doesn't impact users of this
> test group but it's not clear why the change is being done. Would it be
> possible to explain why you are doing this? There is nothing in the JBS issue
> or
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote:
> @bwhuang-us @mahendrachhipa
Marked as reviewed by msheppar (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16796#pullrequestreview-1747718538
The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since JDK
1.2, deprecated for removal in Java 14, and re-specified/degraded to throw
UnsupportedOperationException unconditionally in Java 19/20. Early in Java 23
seems a fine time to finally remove these methods.
Corpus
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
Tests using ProcessTools.executeProcess gets the following output written to
stdout:
[2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
[2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
[2023-11-24T09:58:23.071045055Z] Waiting for completion finished
This API is sitting out JDK 22, meaning no API/implementation changes in this
PR. We expect this API to do a third preview in JDK 23 with some API changes.
So for now, we just need to bump JEP number/title that shows up in the preview
section of the javadoc.
-
Commit messages:
-
On Fri, 24 Nov 2023 09:40:16 GMT, Daniel Jeliński wrote:
>>> Notice the absence of "params" part in that key. I wonder if that is
>>> playing a role here and whether we should fix this key.
>>
>> Actually ignore that part. I had a look at the internal logs that you
>> referenced. It appears
On Fri, 24 Nov 2023 09:09:03 GMT, Alan Bateman wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/failure_handler/src/share/conf/windows.properties line 60:
>
>> 58:
>> 59:
On Fri, 24 Nov 2023 09:51:07 GMT, Daniel Jeliński wrote:
>> test/failure_handler/src/share/conf/windows.properties line 60:
>>
>>> 58:
>>> 59: native.core.app=cdb
>>> 60: native.core.args=-c ".dump /ma core.%p;qd" -p %p
>>
>> Just to double check that this is the right option. `/ma`
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> * *
>
On Fri, 24 Nov 2023 09:17:47 GMT, Jaikiran Pai wrote:
>> test/failure_handler/src/share/conf/windows.properties line 61:
>>
>>> 59: native.core.app=cdb
>>> 60: native.core.args=-c ".dump /ma core.%p;qd" -p %p
>>> 61: native.core.params.timeout=360
>>
>> Hello Daniel, I found it surprising
On Fri, 24 Nov 2023 09:05:15 GMT, Jaikiran Pai wrote:
> Notice the absence of "params" part in that key. I wonder if that is playing
> a role here and whether we should fix this key.
Actually ignore that part. I had a look at the internal logs that you
referenced. It appears that this form of
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> *
On Fri, 3 Nov 2023 08:41:12 GMT, Jan Lahoda wrote:
> Consider code like:
>
> void test(Object o) {
> switch (o) {
> case X1 -> {}
> case X2 -> {}
> ...(about 100 cases)
> ```
>
> javac will compile the switch into a switch whose selector is an indy
> invocation to
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> *
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> *
The recent cdb versions do not support `.dump /f`:
*
* .dump /f is not supported on a user mode process. *
* *
* .dump /ma
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote:
> @bwhuang-us @mahendrachhipa
As a user of the jdk_core test group, would it be possible to explain why you
are doing this? There is nothing in the JBS issue or PR to explain.
-
PR Comment:
56 matches
Mail list logo
