On Wed, 22 Nov 2023 09:05:31 GMT, Andrew Haley wrote:
>>> Have you considered the possibility of copying the sleef source to the
>>> OpenJDK repository and thereby it becomes part of the build process? I
>>> don't know how straightforward that is technically and IANAL but I think
>>> it's wort
On Mon, 27 Nov 2023 19:09:40 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that migh
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Thu, 30 Nov 2023 04:31:41 GMT, jmehrens wrote:
> You have to know that it is in the java.io package and it doesn't wrap
> another stream.
That is a good point. In the previous work on this override, we converged on
the current implementation to not leak the internal byte[] to the target. It
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 30 Nov 2023 08:58:18 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1b
On Thu, 16 Nov 2023 07:04:52 GMT, David Holmes wrote:
>> Hi Magnus, the new x86-simd-sort 4.0 needs C++17 to compile. Will look into
>> the changes needed for this library to compile without the C++17 standard
>> and get back to you.
>>
>> Thanks,
>> Vamsi
>
> Seems a bit odd to me too as the
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 30 Nov 2023 08:58:18 GMT, Alan Bateman wrote:
>> I don't think checking if the package is java.io is secure:
>>
>> ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
>> BufferedInputStream bis = new BufferedInputStream(bais);
>> UntrustedOutputStream uos = new UntrustedOutputSt
On Wed, 29 Nov 2023 22:26:37 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions p
On Wed, 29 Nov 2023 22:21:58 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions p
On Mon, 13 Nov 2023 10:08:20 GMT, Tagir F. Valeev wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor improvements to Gatherer Javadoc
>
> Marked as reviewed by tvaleev (Committer).
@amaembo, @AlanBateman, @dfuc
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Wed, 29 Nov 2023 22:01:57 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions p
On Mon, 13 Nov 2023 10:08:20 GMT, Tagir F. Valeev wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor improvements to Gatherer Javadoc
>
> Marked as reviewed by tvaleev (Committer).
> @amaembo, @AlanBateman, @df
On Thu, 30 Nov 2023 09:35:04 GMT, Magnus Ihse Bursie wrote:
> This version looks much better, thank you! I guess cflags/SVE_CFLAGS is an
> okay-ish solution.
>
> I'm still not 100% happy though, but it might be due to my limited
> understanding. Let me write down a few numbered statements and t
On Wed, 29 Nov 2023 01:10:29 GMT, Bernd wrote:
>> Hi Alan,
>>
>> Thanks for taking a look. I updated the toString() value to the one you
>> suggested, and also dropped the specific aspects of the specification.
>>
>> I am not sure if you have a preference one way or another regarding
>> prov
On Fri, 17 Nov 2023 18:46:57 GMT, Andrey Turbanov wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing trailing whitespace complaint
>
> src/java.base/share/classes/java/util/stream/GathererOp.java line 297:
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
src/java.base/share/classes/sun/nio/
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Given that the default `JdkConsole`
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Tue, 28 Nov 2023 12:18:23 GMT, Ryan Wallace wrote:
>> Hi all,
>>
>> Please review this fix for jar tool not producing an archive if there is a
>> missing file supplied.
>> The current behaviour will recognise missing files as an error but continue
>> processing,
>> creating a temporary arch
On Thu, 30 Nov 2023 11:10:44 GMT, Jaikiran Pai wrote:
> Given that the default `JdkConsole` provider implementation is the one that
> uses jline (in `jdk.internal.le` module), should we also do something to zero
> out this data in its implementation too. A brief glance suggests that it too
> u
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote:
> @bwhuang-us @mahendrachhipa
This pull request has now been integrated.
Changeset: da7cf258
Author:Ivan Šipka
Committer: Mark Sheppard
URL:
https://git.openjdk.org/jdk/commit/da7cf258bb5b24788409dde084ad012bd64a032a
Stats: 4
On Mon, 27 Nov 2023 08:27:25 GMT, Stefan Karlsson wrote:
> So, I think you have found a separate issue.
I'll open a separate issue for that and propose a change.
-
PR Comment: https://git.openjdk.org/jdk/pull/16807#issuecomment-1833661517
On Thu, 30 Nov 2023 00:03:21 GMT, Brian Burkhalter wrote:
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
src/java.base/share/classes/java/io/ByteArrayInputStream.java line 211:
> 209:
On Fri, 24 Nov 2023 10:34:02 GMT, Stefan Karlsson wrote:
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
On Wed, 29 Nov 2023 20:07:50 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update test/jdk/tools/launcher/InstanceMainTest.java
>>
>>Co-authored-by: Jan Lahoda <51319204+laho...@users.norep
On Thu, 30 Nov 2023 09:36:01 GMT, Bernd wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Trust any OutputStream from java.*
>
> Did you review if all Java.* streams are safe?
>
> There are a few stream
On Wed, 1 Nov 2023 18:56:13 GMT, Jim Laskey wrote:
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify ma
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Mon, 6 Nov 2023 20:19:25 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/native/libjava/canonicalize_md.c line 142:
>>
>>> 140: || (errval == ERROR_NETWORK_UNREACHABLE)
>>> 141: || (errval == ERROR_NETWORK_ACCESS_DENIED)
>>> 142: || (errval == ERROR_NO_MORE_FILES
On Sun, 5 Nov 2023 09:40:00 GMT, Alan Bateman wrote:
>> File.mkdirs() occasionally fails to create folders on Windows shared
>> folders. It turned out that Windows API FindFirstFileW created the error
>> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
>> still retu
On Thu, 30 Nov 2023 14:14:56 GMT, Alexey Semenyuk wrote:
> Add tests to make sure jpackage emits meaningful error messages when used
> with invalid app images.
>
> Added `JPackageCommand.nullableOutputBundle()` function that returns an empty
> `Optional` instance if it fails to deduce a path t
File.mkdirs() occasionally fails to create folders on Windows shared folders.
It turned out that Windows API FindFirstFileW created the error
ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
still returns this error code, which supposedly should not.
Adding this erro
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
Add tests to make sure jpackage emits meaningful error messages when used with
invalid app images.
Added `JPackageCommand.nullableOutputBundle()` function that returns an empty
`Optional` instance if it fails to deduce a path to the output bundle from
jpackage command line. This is the case whe
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
On Thu, 30 Nov 2023 14:30:25 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 32 commits:
>
> - Lowering upper bounda
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 32 commits:
- Lowering upper boundary of gatherer composition testing to 512
- Javadoc clarification
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
This pull request has now been integrated.
Changeset: 33b26f79
Author:Viktor Klang
Committer: Alan Bateman
URL:
https://git.openjdk.org/jdk/commit/33b26f79a9
On Thu, 30 Nov 2023 11:46:58 GMT, Andrew Haley wrote:
> [vect_math.S.txt](https://github.com/openjdk/jdk/files/13512306/vect_math.S.txt)
I guess this will live only in os_linux and os_bsd because the Windows compiler
won't like it AFAIK.
-
PR Comment: https://git.openjdk.org/jdk/p
On Thu, 2 Nov 2023 23:19:24 GMT, Jorn Vernee wrote:
>> Explicitly handle UpcallStub allocation failures by terminating. We
>> currently might try to use the returned `nullptr` which would fail sooner or
>> later. This patch just makes the termination explicit.
>
> Jorn Vernee has updated the pu
Please review this PR to correctly rename "Unnamed Class" to "Implicitly
Declared Class", not "Implicit Class".
Renaming is fixed where it affects documentation or the end-user. Renaming is
not fixed where it only affects code: it's perfectly okay to derive an internal
element name from "Implic
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Wed, 22 Nov 2023 07:05:21 GMT, Eric Liu wrote:
>> Vector API defines zero-extend operations [1], which are going to be
>> intrinsified and generated to `VectorUCastNode` by C2. This patch adds
>> backend implementation for `VectorUCastNode` on AArch64.
>>
>> The micro benchmark shows signif
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct behavio
On Thu, 30 Nov 2023 15:00:00 GMT, Pavel Rappo wrote:
> Please review this PR to correctly rename "Unnamed Class" to "Implicitly
> Declared Class", not "Implicit Class".
>
> Renaming is fixed where it affects documentation or the end-user. Renaming is
> not fixed where it only affects code: it'
This test is problematic on Zero due to
https://bugs.openjdk.org/browse/JDK-8321064
Disable it for now on that platform, until a Zero maintainer has a chance to
look into it.
Testing: running TestHandshake on zero to see that it is skipped.
-
Commit messages:
- disable TestHandsh
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
A trivial fix to ProblemList java/util/stream/GatherersTest.java.
-
Commit messages:
- 8321127: ProblemList java/util/stream/GatherersTest.java
Changes: https://git.openjdk.org/jdk/pull/16909/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16909&range=00
Issue: https://bug
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16909#pullrequestreview-1757847283
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
All right! Hope it would be fixed soon. Trivial.
-
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16909#pullreques
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev wrote:
>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.
@shipilev and @AlanBateman - Thanks for the fast reviews.
-
PR Comment: https://git.openjdk.org/jdk/pu
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
This pull request has now been integrated.
Changeset: c6a82783
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/c6a827836277f753652815c
On Thu, 30 Nov 2023 16:18:42 GMT, Jorn Vernee wrote:
> > Hold on, can we figure out if Zero can actually be fixed before we go and
> > disable the test? I think we only disable the tests like this if there is
> > an intrinsic reason why the test does not apply to a platform.
>
> I would proble
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
> [2023-11-24T09:58:23.071045055Z] Waiting for completion f
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 16:14:37 GMT, Aleksey Shipilev wrote:
> Hold on, can we figure out if Zero can actually be fixed before we go and
> disable the test? I think we only disable the tests like this if there is an
> intrinsic reason why the test does not apply to a platform.
I would problem lis
On Thu, 30 Nov 2023 12:19:33 GMT, Jaikiran Pai wrote:
> Hello Stefan,
>
> > The test were I want to use this is a long-running stress test that is
> > known to be good at shaking out JVM hangs. It has been written to provide
> > its own output about spawned processes and what they are doing, a
> Explicitly handle UpcallStub allocation failures by terminating. We currently
> might try to use the returned `nullptr` which would fail sooner or later.
> This patch just makes the termination explicit.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebas
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa, d
On Thu, 30 Nov 2023 09:57:33 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 621:
>>
>>> 619: String resName = String.format(OTHER_RESOURCES_FILE, modName);
>>> 620: try {
>>> 621: InputStream inStream =
>>> jdk
On Mon, 27 Nov 2023 18:53:24 GMT, Phil Race wrote:
> I can .. but I am not aware of even a convention to do that ordering.
It's not written anywhere as far as I know. There's [an ongoing
discussion](https://github.com/openjdk/jdk/pull/16674#discussion_r1402082665)
about it in #16674.
https://
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race wrote:
>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added
>> `@key printer`.
>>
>> Since both files contain all the tags except for `@test` in the .java file,
>> you should not remove the `@run` tag from the .java file and add
On Thu, 30 Nov 2023 10:00:48 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 88:
>>
>>> 86:
>>> 87: // Run time based link internal resources files
>>> 88: private static final String OTHER_RESOURCES_FILE =
>>> "jdk/tools/jlink/in
On Thu, 30 Nov 2023 09:47:05 GMT, Vladimir Sitnikov
wrote:
>>> You have to know that it is in the java.io package and it doesn't wrap
>>> another stream.
>>
>> That is a good point. In the previous work on this override, we converged on
>> the current implementation to not leak the internal b
On Thu, 30 Nov 2023 10:13:39 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 286:
>>
>>> 284: }
>>> 285:
>>> 286: boolean useModulePath = !options.modulePath.isEmpty();
>>
>> Is there any reason why the run-time im
On Thu, 30 Nov 2023 04:26:44 GMT, jmehrens wrote:
>> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
>> `BAIS.transferTo` only if the target stream is in the `java.io` package.
>
> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 211:
>
>> 209:
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
remove ensureOpen()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: https://git.o
On Thu, 30 Nov 2023 10:58:13 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 293:
>
>> 291:
>> 292: priva
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Created an equivalent issue for addr
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x improvement
On Thu, 30 Nov 2023 15:59:29 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PageFormat/SmallPaperPrinting.java line 73:
>
>> 71: job.print();
>> 72:
On Thu, 30 Nov 2023 15:41:28 GMT, Alexey Ivanov wrote:
>> "Should not" is strong. Why ? There's no requirement do to this even though
>> you can.
>> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files
>
> That's the reason why I prefer you keep the `@run` tag in
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa, d
On Thu, 30 Nov 2023 17:08:21 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PrinterJob/EmptyFill.java line 72:
>
>> 70:return;
>> 71:}
>> 72
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
since the last rev
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev wrote:
>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.
@shipilev @AlanBateman @dcubed-ojdk I'm on it.
-
PR Comment: https://git.openjdk.org/jdk/pull/16909#is
On Thu, 30 Nov 2023 17:25:26 GMT, Mandy Chung wrote:
>> I haven't looked into the details, but the common case is for jlink users to
>> use the default module path (`jmods` folder of the JDK install) and the
>> prime use-case for this is to get away with performing a link without the
>> packag
On Mon, 23 Oct 2023 13:58:27 GMT, Jorn Vernee wrote:
> Explicitly handle UpcallStub allocation failures by terminating. We currently
> might try to use the returned `nullptr` which would fail sooner or later.
> This patch just makes the termination explicit.
This pull request has now been inte
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
> This is update to the specification of the j.l.module.ResolvedModule.reads
> method to clarify that the set of resolved modules returned does not include
> itself. There is a small implementation change to align with the
> specification and fix an anomaly that arises with configurations that c
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x improvement
On Thu, 30 Nov 2023 18:19:51 GMT, Srinivas Vamsi Parasa
wrote:
>> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
>> just CXXFLAGS?
>>
>> Also @vamsi-parasa, did you check into if this really was needed and why? To
>> be clear, I basically consider this an integratio
On Thu, 30 Nov 2023 14:50:24 GMT, Andrew Haley wrote:
>> Do this, but with the name vect_math.S. Don't use SLEEF headers in the
>> build. I think you can do this with no build-time dependency on SLEEF at all
>> if you load the library lazily at runtime.
>>
>> [vect_math.S.txt](https://github.c
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 30 Nov 2023 20:07:19 GMT, Magnus Ihse Bursie wrote:
> But you are saying that you want to skip building this library unless you
> have a gcc version that supports c++17?
>
Yes, the request is to skip building the simdsort library if GCC version is < 8
as only GCC >= 8 supports C++17 fe
On Thu, 30 Nov 2023 19:50:00 GMT, Sergey Bylokhov wrote:
> probably we can link this from our wiki page where we describe the usage of
> keywords?:
> https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements
Good idea, once this is pushed, I'll add th
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug to
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
1 - 100 of 141 matches
Mail list logo
