On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Korov has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin functionaliti
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Korov has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin functionaliti
Can I please get a review of this test-only change which proposes to address
https://bugs.openjdk.org/browse/JDK-8328066?
The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, the
failure was observed on linux-86 instance on a GitHub jobs run.
The commit in this PR propos
On Wed, 13 Mar 2024 16:02:29 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> bug fix for CharArraySequence
>
> src/java.base/share/classes/java/math/BigDecimal.java line 561:
>
>> 559: i
> The current BigDecimal(String) constructor calls String#toCharArray, which
> has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is greater than 18, create a char[]
>
>
> boolean isCompa
On Tue, 12 Mar 2024 18:47:37 GMT, Naoto Sato wrote:
> Will let the doc people know. It is at least good that the latest doc for
> JDK21 is correct.
Now the previous releases' supported locales docs have been updated.
-
PR Comment: https://git.openjdk.org/jdk/pull/18243#issuecomme
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combinations for the test are stored
> in one array, nothing can b
On Wed, 13 Mar 2024 14:23:01 GMT, Raffaello Giulietti
wrote:
> Can you please add the bug id to `@bug` and correct the typo, as suggested
> [here](https://github.com/openjdk/jdk/pull/18264#issuecomment-1994382507)?
Done.
I kept the tenMillion... handling.
-
PR Comment: https://g
On Wed, 13 Mar 2024 20:10:25 GMT, Roger Riggs wrote:
>> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
>> assumption about GC behavior and a race condition.
>>
>> Removed test based on incorrect assumptions about simultaneous clearing of
>> WeakReferences.
>> Added
On Wed, 13 Mar 2024 20:10:25 GMT, Roger Riggs wrote:
>> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
>> assumption about GC behavior and a race condition.
>>
>> Removed test based on incorrect assumptions about simultaneous clearing of
>> WeakReferences.
>> Added
On Tue, 12 Mar 2024 16:26:48 GMT, Naoto Sato wrote:
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
This pull request has now been integrated.
Changeset: 7f6b7ebb
Author:Naoto Sato
URL:
https://git.openjdk
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>> replacing
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
> assumption about GC behavior and a race condition.
>
> Removed test based on incorrect assumptions about simultaneous clearing of
> WeakReferences.
> Added a run of the test using ZGC, (previously omitted)
Roger Rig
On Tue, 5 Mar 2024 19:56:58 GMT, Weijun Wang wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject di
On Wed, 13 Mar 2024 19:41:25 GMT, Roger Riggs wrote:
>> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
>> assumption about GC behavior and a race condition.
>>
>> Removed test based on incorrect assumptions about simultaneous clearing of
>> WeakReferences.
>> Added
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>> replacing
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
> assumption about GC behavior and a race condition.
>
> Removed test based on incorrect assumptions about simultaneous clearing of
> WeakReferences.
> Added a run of the test using ZGC, (previously omitted)
Roger Rig
On Wed, 13 Mar 2024 18:01:21 GMT, Roger Riggs wrote:
> The intermittent failure of ObjectStreamClassCaching is due to an incorrect
> assumption about GC behavior and a race condition.
>
> Removed test based on incorrect assumptions about simultaneous clearing of
> WeakReferences.
> Added a run
The intermittent failure of ObjectStreamClassCaching is due to an incorrect
assumption about GC behavior and a race condition.
Removed test based on incorrect assumptions about simultaneous clearing of
WeakReferences.
Added a run of the test using ZGC, (previously omitted)
-
Commit
On Wed, 13 Mar 2024 16:06:26 GMT, Naoto Sato wrote:
>> Adding a table that maps JDK versions and corresponding CLDR releases as an
>> implNote. A draft CSR has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>> replacing
> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>
> Updates jspawnhelper to check that JDK version and jspawnhelper version are
> the same. Updates test to include check for version. Also tested manually by
> replacing jspawnhelper with incorrect version to confirm that check wo
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Further refinement
-
Changes:
- all: https://g
On Wed, 13 Mar 2024 15:46:30 GMT, Shaojin Wen wrote:
>> The current BigDecimal(String) constructor calls String#toCharArray, which
>> has a memory allocation.
>>
>>
>> public BigDecimal(String val) {
>> this(val.toCharArray(), 0, val.length()); // allocate char[]
>> }
>>
>>
>> When the l
On Wed, 13 Mar 2024 13:51:27 GMT, Claes Redestad wrote:
> Relying on the upper bounds check of `charAt` doesn't work well with the
> `CharArraySequence` whose `charAt` deliberately does not throw an IIOBE if
> the array is longer than the provided length, ie, it'll look at chars beyond
> the p
> The current BigDecimal(String) constructor calls String#toCharArray, which
> has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is greater than 18, create a char[]
>
>
> boolean isCompa
On Wed, 13 Mar 2024 14:10:29 GMT, Christoph Langer wrote:
>> 4f336085d1098e7fba7b58f0a73c028179a2a13d
>> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
>> cases to test java/util/Formatter/Padding.java with huge Strings as
>> arguments. Since all possible argument com
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combinations for the test are stored
> in one array, nothing can b
On Wed, 13 Mar 2024 09:42:34 GMT, Raffaello Giulietti
wrote:
> What about factoring out the 4 invocations of `tenMillionBlanks()` in each
> source method in a local var?
OK, I inlined the generation of the ten million character strings into the
parameter generator methods. I looked a bit at t
On Wed, 13 Mar 2024 13:12:54 GMT, Shaojin Wen wrote:
>> If the input is "+" or "-" an exception will be thrown on line 583
>>
>> boolean isneg = c == '-'; // leading minus means negative
>> if (isneg || c == '+') {
>> c = val.charAt(++offset);
>>
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote:
>> As part of the ongoing effort to enable jcheck whitespace checking to all
>> text files, it is now time to address assembly (.S) files. The hotspot
>> assembly files were fixed as part of the hotspot mapfile removal, so only a
>> s
On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan wrote:
> This change enables to run JspawnhelperProtocol.java on MacOS.
>
> In addition to GHA , the test has been run on macos and linux.
>
>
> Test report is stored in
> build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_P
On Wed, 13 Mar 2024 07:53:30 GMT, Christoph Langer wrote:
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combina
On Wed, 13 Mar 2024 12:12:20 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix benchmark
>
> src/java.base/share/classes/java/math/BigDecimal.java line 596:
>
>> 594: // First
On Wed, 13 Mar 2024 13:11:48 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 596:
>>
>>> 594: // First compact case, we need not to preserve the
>>> character
>>> 595: // and we can just compute the value in place.
>>> 596:
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>
Update the code gen code in CallGeneratorHelper to reflect the latest state of
the libTest(Downcall/Upcall)(Stack).c and shared.h files.
- The previous code wanted users to pipe stdout into a file. But, since we have
5 files that need to be created, and the names of those files is important too,
On Wed, 13 Mar 2024 09:52:45 GMT, Shaojin Wen wrote:
>> The current BigDecimal(String) constructor calls String#toCharArray, which
>> has a memory allocation.
>>
>>
>> public BigDecimal(String val) {
>> this(val.toCharArray(), 0, val.length()); // allocate char[]
>> }
>>
>>
>> When the l
On Wed, 13 Mar 2024 11:45:33 GMT, Magnus Ihse Bursie wrote:
>> As part of the ongoing effort to enable jcheck whitespace checking to all
>> text files, it is now time to address assembly (.S) files. The hotspot
>> assembly files were fixed as part of the hotspot mapfile removal, so only a
>> s
On Wed, 13 Mar 2024 11:26:14 GMT, Julian Waters wrote:
>> Magnus Ihse Bursie has refreshed the contents of this pull request, and
>> previous commits have been removed. Incremental views are not available. The
>> pull request now contains two commits:
>>
>> - Enable jcheck whitespace checks f
> As part of the ongoing effort to enable jcheck whitespace checking to all
> text files, it is now time to address assembly (.S) files. The hotspot
> assembly files were fixed as part of the hotspot mapfile removal, so only a
> single incorrect jdk library remains.
>
> The main issue with `lib
On Wed, 13 Mar 2024 09:49:13 GMT, Aleksey Shipilev wrote:
>> make/modules/java.base/Launcher.gmk line 81:
>>
>>> 79: SRC := $(TOPDIR)/src/$(MODULE)/unix/native/jspawnhelper, \
>>> 80: OPTIMIZATION := LOW, \
>>> 81: CFLAGS := $(CFLAGS_JDKEXE) \
>>
>> There is no need to introdu
On Tue, 12 Mar 2024 19:22:25 GMT, Chad Rakoczy wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are
>> the same. Updates test to include check for version. Also tested manually by
>> replacing
On Wed, 13 Mar 2024 09:50:20 GMT, Joachim Kern wrote:
> e.g. We should change the HOTSPOT_TOOLCHAIN_TYPE=xlc to aix, because it is
> not toolchain, but OS related. As a consequence the globalDefinitions_xlc.hpp
> will become globalDefinitions_aix.hpp
No, it's not that simple. First, the `globa
On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>>
> The current BigDecimal(String) constructor calls String#toCharArray, which
> has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is greater than 18, create a char[]
>
>
> boolean isCompa
On Tue, 12 Mar 2024 23:44:45 GMT, Magnus Ihse Bursie wrote:
>> Chad Rakoczy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Print to stdout instead of stderr
>> - Compare version using VERSION_STRING
>
> make/modules/java.base/Launche
On Wed, 13 Mar 2024 07:53:30 GMT, Christoph Langer wrote:
> 4f336085d1098e7fba7b58f0a73c028179a2a13d
> ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few
> cases to test java/util/Formatter/Padding.java with huge Strings as
> arguments. Since all possible argument combina
On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan wrote:
> This change enables to run JspawnhelperProtocol.java on MacOS.
>
> In addition to GHA , the test has been run on macos and linux.
>
>
> Test report is stored in
> build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_P
On Wed, 13 Mar 2024 08:50:10 GMT, Matthias Baesken wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
>> - We need CC_VERSION_OUTPUT before we can check it
>
>
On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>>
On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
>
On Tue, 12 Mar 2024 16:02:41 GMT, Matthias Baesken wrote:
> > Please re-test.
>
> Hi Magnus, thanks for the adjustments. I reenabled your patch in our
> build/test queue .
Builds and test results on AIX (product and fastdebug) are fine with the latest
version of the PR .
-
PR Co
On Wed, 6 Mar 2024 11:33:30 GMT, Magnus Ihse Bursie wrote:
> Currently, our symbol visibility handling for tests are sloppy; we only
> handle it properly on Windows. We need to bring it up to the same levels as
> product code. This is a prerequisite for
> [JDK-8327045](https://bugs.openjdk.org
4f336085d1098e7fba7b58f0a73c028179a2a13d
([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few cases
to test java/util/Formatter/Padding.java with huge Strings as arguments. Since
all possible argument combinations for the test are stored in one array,
nothing can be garbage
On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan wrote:
> This change enables to run JspawnhelperProtocol.java on MacOS.
>
> In addition to GHA , the test has been run on macos and linux.
>
>
> Test report is stored in
> build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_P
On Tue, 12 Mar 2024 13:55:11 GMT, Magnus Ihse Bursie wrote:
>> test/hotspot/jtreg/runtime/ErrorHandling/libTestDwarfHelper.h line 24:
>>
>>> 22: */
>>> 23:
>>> 24: #include
>>
>> Seems unneeded.
>
> So what I did here was change:
>
> #include "jni.h"
> #include
>
>
> into
>
> #include
57 matches
Mail list logo
