Re: RFR: 8294982: Implementation of Classfile API [v54]

2023-03-07 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: f

Re: RFR: 8294982: Implementation of Classfile API [v49]

2023-03-07 Thread Adam Sotona
On Tue, 7 Mar 2023 15:48:22 GMT, Maurizio Cimadamore wrote: >> Here I'm also not sure I understand, the long line has bee wrapped. > > I mean here (and in the other) there seems to be a missing newline at the end > of the file OK, I'll fix it, thanks. - PR:

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Tue, 7 Mar 2023 08:35:34 GMT, Adam Sotona wrote: >> I am unsure how you might use `BlockCodeBuilder`. If the current signature >> is not changed then `transformFromHandler` seems reasonable (since its the >> handler that pushes elements into its given builder). >>

Re: RFR: 8294982: Implementation of Classfile API [v53]

2023-03-07 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8294982: Implementation of Classfile API [v52]

2023-03-07 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixed CodeRelabe

Re: RFR: 8294982: Implementation of Classfile API [v49]

2023-03-07 Thread Adam Sotona
On Tue, 7 Mar 2023 11:14:17 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> snippets and tests synced with jdk.jfr class instrumentation source code > > s

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Fri, 3 Mar 2023 15:51:25 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/NewObjectInstruction.java >> line 38: >> >>> 36: * of a {@link CodeModel}. >>> 37: */ >>> 38: public sealed interface NewObject

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-03-07 Thread Adam Sotona
On Wed, 15 Feb 2023 14:24:18 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/CharacterRange.java >> line 47: >> >>> 45: * {@return the start of the instruction range} >>> 46: */ >>>

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-07 Thread Adam Sotona
On Fri, 3 Mar 2023 22:48:23 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to Unreso

Re: RFR: 8294982: Implementation of Classfile API [v12]

2023-03-07 Thread Adam Sotona
On Mon, 6 Feb 2023 14:25:54 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line >> 1371: >> >>> 1369: } >>> 1370: >>> 1371: default CodeBuilder tableswitch(Label defaultTarget, >>> L

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Thu, 2 Mar 2023 22:05:24 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v51]

2023-03-07 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Shared `toStrin

Re: RFR: 8294982: Implementation of Classfile API [v50]

2023-03-07 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: generic implem

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Thu, 2 Mar 2023 23:49:24 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Fri, 3 Mar 2023 16:33:49 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/TransformImpl.java >> line 63: >> >>> 61: private static final Runnable NOTHING = () -> { }; >>> 62: >>> 63: int

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-07 Thread Adam Sotona
On Mon, 6 Mar 2023 17:45:27 GMT, Paul Sandoz wrote: >> I see what you mean. `transforming` was selected to represent the >> continuation of the code building process, similar to `trying` and >> `catching`. While `transform` may imply that the actual code builder gets >> transformed into

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 6 Mar 2023 17:15:25 GMT, Paul Sandoz

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
On Thu, 2 Mar 2023 19:56:08 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v49]

2023-03-06 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: sni

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
On Thu, 2 Mar 2023 23:28:23 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-06 Thread Adam Sotona
On Wed, 1 Mar 2023 10:05:27 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/ChainedFieldBuilder.java >> line 48: >> >>> 46: this.consumer = consumer; >>> 47: FieldBuilder b = downstream; >>> 48:

Re: RFR: 8294982: Implementation of Classfile API [v48]

2023-03-06 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 22:35:48 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to Unreso

Re: RFR: 8294982: Implementation of Classfile API [v47]

2023-03-06 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - simplified Code

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed obsolete generic

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:44:24 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to Unreso

Re: RFR: 8294982: Implementation of Classfile API [v46]

2023-03-06 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: removed un

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:56:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to Unreso

Re: RFR: 8294982: Implementation of Classfile API [v45]

2023-03-06 Thread Adam Sotona
is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/jdk/internal

Re: RFR: 8294982: Implementation of Classfile API [v44]

2023-03-06 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with four additional commits since the last revision: - Update src/ja

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 00:57:35 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:14:55 GMT, Jaikiran Pai wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Signature.TypeArg does not inherit from Signature > > src/java.base/share/

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:54:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 20:37:37 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Fri, 3 Mar 2023 14:53:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/instruction/CharacterRange.java >> line 42: >> >>> 40: * the setting of the {@link Classfile.Option#processDebug(boolean)} >>> option. >>

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:31:50 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v42]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - factory method

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-03 Thread Adam Sotona
On Thu, 2 Mar 2023 19:27:58 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > > src/java.b

Re: RFR: 8294982: Implementation of Classfile API [v41]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Signature.Typ

Re: RFR: 8294982: Implementation of Classfile API [v40]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Update src

Re: RFR: 8294982: Implementation of Classfile API [v39]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: 8294982: Implementation of Classfile API [v37]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - U

Re: RFR: 8294982: Implementation of Classfile API [v38]

2023-03-03 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - Updat

Re: RFR: 8294982: Implementation of Classfile API [v13]

2023-03-02 Thread Adam Sotona
On Wed, 1 Mar 2023 23:57:52 GMT, Paul Sandoz wrote: >> Every case has been considered individually, evaluated on use cases and pros >> and cons have been weighted. Unified approach across the whole API would be >> nice, however not so simple and not the highest priority. > > I had the same

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-02 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v35]

2023-03-02 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - added comm

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-02 Thread Adam Sotona
On Wed, 1 Mar 2023 23:07:38 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl >> - abstract implemen

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-02 Thread Adam Sotona
On Wed, 1 Mar 2023 23:43:55 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl >> - abstract implemen

Re: RFR: 8294982: Implementation of Classfile API [v34]

2023-03-02 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: -

Re: RFR: 8294982: Implementation of Classfile API [v33]

2023-03-02 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - Updat

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-02 Thread Adam Sotona
On Wed, 1 Mar 2023 22:38:32 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl >> - abstract implemen

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-02 Thread Adam Sotona
On Wed, 1 Mar 2023 21:36:41 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl >> - abstract implemen

Re: RFR: 8294982: Implementation of Classfile API [v32]

2023-03-02 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with five additional commits since the last revision: - Consta

Re: RFR: 8294982: Implementation of Classfile API [v31]

2023-03-01 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with four additional commits since the last revision: - renamed all r

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:19:12 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:58:21 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 11:34:28 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v30]

2023-03-01 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: javadoc fix --

Re: RFR: 8294982: Implementation of Classfile API [v29]

2023-03-01 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - LabelImpl ge

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:47:52 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:41:16 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:43:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v28]

2023-02-28 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - BytecodeHelpers

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:47:04 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:40:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/i

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 12:55:06 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:29:51 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java >> line 43: >> >>> 41: >>> 42: /** >>> 43: * CodeStackTracker is a {@link jdk.internal.classfile.CodeTransform} >>> synchronously tracking >>

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:21:29 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v27]

2023-02-27 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: javadoc fixes --

Re: RFR: 8294982: Implementation of Classfile API [v26]

2023-02-27 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: -

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Mon, 27 Feb 2023 11:54:53 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java >> line 168: >> >>> 166: public void accept(ClassBuilder clb, ClassElement cle) { >>> 167: switch (

Re: RFR: 8294982: Implementation of Classfile API [v25]

2023-02-27 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: ClassRemapper fix

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:09:30 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v24]

2023-02-27 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with three additional commits since the last revision: - added

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:54:00 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:51:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Fri, 17 Feb 2023 17:09:51 GMT, Maurizio Cimadamore wrote: >> Yes, the print structure does not exactly correspond to the Classfile API >> architecture, but rather to the classfile physical structure and it is >> partly similar to `javap` output. >> The common tree structure has been

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-17 Thread Adam Sotona
On Thu, 9 Feb 2023 14:07:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/i

Re: RFR: 8294982: Implementation of Classfile API [v23]

2023-02-17 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - javadoc fix

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 10:48:49 GMT, Adam Sotona wrote: >> The main difference is that if the given entry is not directly applicable >> (when it comes from 3rd constant pool or when the pool is not shared during >> transformation) - a new or matching entry to the targe

Re: RFR: 8294982: Implementation of Classfile API [v22]

2023-02-17 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 12:11:06 GMT, Jens Lidestrom wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/i

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 14:24:21 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 11:00:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/class

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 10:56:57 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk

Re: RFR: 8294982: Implementation of Classfile API [v21]

2023-02-17 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-16 Thread Adam Sotona
On Thu, 16 Feb 2023 10:25:04 GMT, Maurizio Cimadamore wrote: >> I'm not quite sure what exactly do you propose. >> `ConstantPool` should not accept anything as it is read-only, so "accept" >> would be confusing. >> `ConstantPoolBuilder::maybeClone` is rather a `Function`, where the name >>

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-16 Thread Adam Sotona
On Thu, 16 Feb 2023 10:46:23 GMT, Adam Sotona wrote: >> As I read the javadoc (I have not looked at impl yet), this method can >> effectively be used to add an entry to the constant pool (if the entry does >> not yet exist - in which case existing entry is returned). >>

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added 4-byte

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-16 Thread Adam Sotona
On Fri, 10 Feb 2023 11:16:22 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/constantpool/Utf8Entry.java >> line 47: >> >>> 45: * @param s the string to compare to >>> 46: */ >>> 47: boolean equalsString

Re: RFR: 8294982: Implementation of Classfile API [v19]

2023-02-15 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: removal of Member

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Thu, 9 Feb 2023 14:05:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/i

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Wed, 15 Feb 2023 14:45:32 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/constantpool/MemberRefEntry.java >> line 62: >> >>> 60: * {@return whether this member is a method} >>> 61: */ >>> 62: boo

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Thu, 9 Feb 2023 14:04:22 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/i

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Thu, 9 Feb 2023 14:18:56 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Thu, 9 Feb 2023 14:24:58 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/

Re: RFR: 8294982: Implementation of Classfile API [v15]

2023-02-15 Thread Adam Sotona
On Thu, 9 Feb 2023 15:07:01 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AttributeElement.Kind removal (#48) > > src/java.base/share/classes/jdk/

Re: RFR: 8294982: Implementation of Classfile API [v18]

2023-02-15 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294982: Implementation of Classfile API [v17]

2023-02-15 Thread Adam Sotona
internal/classfile/package-summary.html) > is also available. > > Please take you time to review this non-trivial JDK addition. > > Thank you, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - removed ge

<    4   5   6   7   8   9   10   11   >