On Thu, 9 Feb 2023 13:17:30 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal
On Thu, 9 Feb 2023 13:10:43 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/i
On Thu, 9 Feb 2023 14:01:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/i
On Thu, 9 Feb 2023 13:01:57 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/classfile/constantpool/ClassEntry.java
>> line 80:
>>
>>> 78: * Return a List composed by appending the additions to the base
>>> list.
>>> 79: * @param base The base elements
On Thu, 9 Feb 2023 12:54:42 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/i
On Thu, 9 Feb 2023 15:01:03 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/
On Thu, 9 Feb 2023 14:11:36 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/i
On Thu, 9 Feb 2023 13:03:46 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/i
On Thu, 9 Feb 2023 12:45:27 GMT, Maurizio Cimadamore
wrote:
>> During the fix I found the definition that `ThrowableSig` (as a super-set of
>> `ClassTypeSig` and `TypeVarSig`) IS `Signature` - that fact is critical for
>> processing.
>> For example when `MethodSignature` is serialized
>>
On Tue, 7 Feb 2023 16:04:07 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Wed, 8 Feb 2023 11:19:32 GMT, Maurizio Cimadamore
wrote:
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated.
>> Thanks.
>
>> Any reference to an official specification of CharacterRangeInfo is
>> appreciated. Thanks.
>
> There's this - which points back
On Mon, 6 Feb 2023 14:13:36 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/BufWriter.java line 40:
>>
>>> 38: * to the end of the buffer, as well as to create constant pool entries.
>>> 39: */
>>> 40: public
On Wed, 8 Feb 2023 00:37:57 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
se review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains six additional commits since the
last revi
On Wed, 8 Feb 2023 00:38:23 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Proprie
On Tue, 7 Feb 2023 11:48:52 GMT, Maurizio Cimadamore
wrote:
>> Yes, performance is the main reason.
>> I'll note to do a fresh differential performance benchmarks with a HashMap.
>
> thanks
I tried HashMap with String keys and it cause performance regressions, however
with Utf8Entry
On Wed, 8 Feb 2023 11:16:14 GMT, Maurizio Cimadamore
wrote:
>> `ofSymbols` is an alternative to `of` when conflicting method parameters.
>> In such case `of` refers to CP entries and `ofSymbols` refer to independent
>> symbols describing the objects, like for example `ClassDesc`,
>>
On Wed, 8 Feb 2023 12:19:35 GMT, Adam Sotona wrote:
>>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>>> `ClassTypeSig` and `TypeVarSig`.
>>
>> I really don't follow here. ThrowableSig is a piece of a method signature,
>> w
On Wed, 8 Feb 2023 11:07:08 GMT, Maurizio Cimadamore
wrote:
>> `TypeParam` is not a signature, because it simply is not a signature.
>> Per spec:
>>
>> TypeParameter:
>> Identifier ClassBound {InterfaceBound}
>
>> `Signature.ThrowableSig` is a `Signature` and it is a common super of
>>
On Tue, 7 Feb 2023 16:07:00 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Tue, 7 Feb 2023 16:09:56 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Tue, 7 Feb 2023 15:59:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
javadoc fixes
--
On Tue, 7 Feb 2023 15:26:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Fri, 3 Feb 2023 18:33:46 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Tue, 7 Feb 2023 15:18:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Tue, 7 Feb 2023 11:53:46 GMT, Maurizio Cimadamore
wrote:
>> `BootstrapMethodEntry` is not a constant pool entry, but
>> `BootstrapMethodsAttribute` entry.
>> It might be rather moved under `attribute` package and renamed to
>> `BootstrapMethodInfo` to follow the same pattern as other
On Tue, 7 Feb 2023 15:20:15 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>> Signatures](https://docs.oracle.com/javase/s
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>> Signatures](https://docs.oracle.com/javase/s
On Tue, 7 Feb 2023 15:47:25 GMT, Maurizio Cimadamore
wrote:
>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>> 4.7.9.1
>>
On Tue, 7 Feb 2023 12:10:43 GMT, Maurizio Cimadamore
wrote:
>> The confusion come from simplified name. Signature probably should be called
>> JavaTypeSignature according to the spec. ClassSignature and MethodSignature
>> could not extend it, as it would not respect the reality. Each of them
On Tue, 7 Feb 2023 14:14:50 GMT, Maurizio Cimadamore
wrote:
>> The relation is that each `Attribute` is applicable in N
>> `AttributedElements` and not vice versa.
>> For example `ClassModel::attributedElementKind` returns `CLASS` and for
>> example
>>
On Tue, 7 Feb 2023 12:34:50 GMT, Maurizio Cimadamore
wrote:
>> `AttributedElement::attributedElementKind` identifies the one kind of the
>> attributes holder.
>> The "places where an attribute can appear" is available through
>> `AttributeMapper::whereApplicable` and matched against
>>
On Tue, 7 Feb 2023 12:14:40 GMT, Maurizio Cimadamore
wrote:
>> On the contrary, it has been deduplicated. Opcode is referencing numeric
>> constants stored in Classfile.
>
> sure, but my question is - once you have a nice enum that is 1-1 with the
> opcodes - why would a client want to use
On Tue, 7 Feb 2023 11:48:28 GMT, Maurizio Cimadamore
wrote:
>> There are at least 72 usages of AttributedElement.Kind across the Classfile
>> API.
>> Do you suggest to rename it to something else (for example Location)?
>
> Uhm - I can't see these usages... something seems to be off with my
On Fri, 3 Feb 2023 18:25:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:37:43 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:11:41 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:59:53 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:58:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:56:45 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:52:49 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:07:27 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 346:
>>
>>> 344: public static final int MAGIC_NUMBER = 0xCAFEBABE;
>>> 345:
>>> 346: public static final int NOP = 0;
>>
>> Not sure how
On Fri, 3 Feb 2023 17:43:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:37:55 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with three additional
commits since the last revision:
On Fri, 3 Feb 2023 17:32:37 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:20:19 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:23:51 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:22:32 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
se review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits since
the last revision
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Classfile API moved
On Tue, 24 Jan 2023 13:35:14 GMT, Adam Sotona wrote:
> ClassDesc::ofInternalName was added in JDK 20, however @since tag is missing.
> This patch fixes the javadoc.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: b22e5216
A
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 106 commits:
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
update of Java version co
On Thu, 26 Jan 2023 14:10:47 GMT, Hannes Greule wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> merged JAVAC_FLAGS and EXCLUDES in Java.gmk
>
> (not a reviewer) From a quick look at it
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
unification of
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
merged JAVAC_F
On Thu, 12 Jan 2023 12:47:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - removal of Preview.java and TransPatterns.java patch
>>and enabled preview fo
ClassDesc::ofInternalName was added in JDK 20, however @since tag is missing.
This patch fixes the javadoc.
Please review.
Thanks,
Adam
-
Commit messages:
- 8300953: ClassDesc::ofInternalName missing @since tag
Changes: https://git.openjdk.org/jdk20/pull/115/files
Webrev:
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote:
>> **This pull request is not intended for immediate integration to JDK
>> mainline.**
>>
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote:
>> **This pull request is not intended for immediate integration to JDK
>> mainline.**
>>
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
On Mon, 7 Nov 2022 16:28:19 GMT, Adam Sotona wrote:
>> So this will be removed later on in one of the follow up "chicken" PRs?
>
> It will be removed in this PR later, this specific workaround is not intended
> to fall into JDK.
> The CompileInterimLangtools patch
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the p
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull re
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull re
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request increme
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request
On Sun, 27 Nov 2022 01:38:01 GMT, Erik Gahlin wrote:
>> Is the practice of naming the directory `snippets` well-established or
>> mandated? Otherwise I think a name like `snippet-files` (akin to
>> `doc-files`) would be much better, since it indicates that is not a java
>> package name.
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request increme
On Mon, 7 Nov 2022 13:01:41 GMT, Adam Sotona wrote:
>> make/modules/java.base/Java.gmk line 37:
>>
>>> 35:
>>> 36: EXCLUDES += java/lang/doc-files
>>> 37: EXCLUDES += jdk/classfile/snippets
>>
>> I don't like hard-coded excludes like this. I
On Mon, 21 Nov 2022 01:11:55 GMT, David Holmes wrote:
> > tools/launcher/ArgsFileTest.java was working because it didn't contain any
> > test with --disable-@files option verifying VM really starts
>
> What about the killswitch test ??
KillSwitch test did not construct valid command line, it
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 3a15e848
Author
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is passed to VM option causing it to fail.
> Proposed patch skips --disable-@files option in
> src/java.base/share/native/libjli/java.c ParseArguments processing, so it is
> not passed to the VM.
>
There is a typo in `java -help` referencing -disable-@files instead of
--disable-@files option.
Please review.
Thanks,
Adam
-
Commit messages:
- 8297258: Typo in `java -help` referencing -disable-@files instead of
--disable-@files
Changes:
On Thu, 17 Nov 2022 01:26:51 GMT, David Holmes wrote:
>> Option --disable-@files is not recognised as valid JVM option, however it is
>> already implemented in the launcher.
>> Proposed patch skips --disable-@files option in
>> src/hotspot/share/runtime/arguments.cpp processing, so it does not
ns.
> The patch also corrects typo in the launcher.properties and adds simple
> DisableFilesOptionTest.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
handling of
On Wed, 16 Nov 2022 14:38:18 GMT, Alan Bateman wrote:
> Are you sure this is right place to do this? There are other "launcher
> options" that aren't passed through to CreateJavaVM and I'm surprised this
> one is.
I've found this place as a single spot handling (or skipping) tons of options
Option --disable-@files is not recognised as valid JVM option, however it is
already implemented in the launcher.
Proposed patch skips --disable-@files option in
src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into
the category of unknown options.
The patch also corrects
On Wed, 9 Nov 2022 10:14:45 GMT, Adam Sotona wrote:
> When `Class.getEnumConstants()` is called on a bad enum class where
> `values()` is an instance method, or returns a non‑array, then it throws
> `NullPointerException` or `ClassCastException` respectively.
>
> T
When `Class.getEnumConstants()` is called on a bad enum class where `values()`
is an instance method, or returns a non‑array, then it throws
`NullPointerException` or `ClassCastException` respectively.
This patch fixes `Class.getEnumConstants()` method to handle above mentioned
bad enums and
On Mon, 7 Nov 2022 16:21:48 GMT, Magnus Ihse Bursie wrote:
>> Patched interim Preview and TransPatterns is a temporary workaround to allow
>> internal use of pattern switch in the JDK sources.
>
> So this will be removed later on in one of the follow up "chicken" PRs?
It will be removed in
On Mon, 7 Nov 2022 12:13:08 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>>
On Mon, 7 Nov 2022 12:15:35 GMT, Magnus Ihse Bursie wrote:
>> make/CompileInterimLangtools.gmk line 78:
>>
>>> 76: $(call LogInfo, Generating Preview.java for
>>> jdk.compiler.interim)
>>> 77: $(call MakeDir, $(@D))
>>> 78: $(GREP) -v 'case PATTERN_SWITCH ->' $< > $@
>>
On Mon, 7 Nov 2022 12:16:29 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>>
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK
java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
and this patch converts it to use Classfile API.
This pull request suppose to chain on the 8294982: Implementation of Classfile
API https://github.com/openjdk/jdk/pull/10982
Please review.
Thank you,
Adam
This is root pull request with Classfile API implementation, tests and
benchmarks initial drop into JDK.
Following pull requests consolidating JDK class files parsing, generating, and
transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will
chain to this one.
Classfile
On Tue, 20 Sep 2022 13:08:20 GMT, Adam Sotona wrote:
> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
> significantly improved and add performance boost to intensive users.
>
> Two main reasons have been identified and fixed in this patch:
>
> Fi
On Wed, 21 Sep 2022 15:09:21 GMT, Paul Sandoz wrote:
>> `legal` is initially set to false, so leading `/` is also rejected
>
> Doh! Could you add a comment with the case block, something like?
> // Rejects a leading `/`, any "//", and a trailing '/' (by exit from the loop)
I've added the
, so it is removed.
>
> Please review proposed performance improving patch.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added comments to j.l.ConstantUtils::skipOverFieldSignature parser loop
-
On Tue, 20 Sep 2022 16:54:27 GMT, Paul Sandoz wrote:
>> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
>> significantly improved and add performance boost to intensive users.
>>
>> Two main reasons have been identified and fixed in this patch:
>>
>> First glitch is
On Tue, 20 Sep 2022 13:08:20 GMT, Adam Sotona wrote:
> Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
> significantly improved and add performance boost to intensive users.
>
> Two main reasons have been identified and fixed in this patch:
>
> Fi
Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be
significantly improved and add performance boost to intensive users.
Two main reasons have been identified and fixed in this patch:
First glitch is late insertion of return type to the first position of
`j.u.ArrayList`,
On Fri, 17 Jun 2022 14:19:11 GMT, Adam Sotona wrote:
> The symbolic constants API (`java.lang.constant`) was designed, in part, to
> provide bytecode parsing and generation APIs with a validated, common,
> symbolic form for constants in Java class files.
>
> There is an eas
On Mon, 22 Aug 2022 07:24:14 GMT, Adam Sotona wrote:
>> test/jdk/java/lang/constant/ClassDescTest.java line 268:
>>
>>> 266: }
>>> 267:
>>> 268: List badInternalNames = List.of("I;", "[]",
>>
>> is `[]` a g
from class internal name.
> Class internal name validation and extended ClassDescTest are also parts of
> this patch.
>
> CSR is linked with the issue.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one
901 - 1000 of 1034 matches
Mail list logo
